On 13/11/2020 08.21, Peter Krempa wrote:
> On Thu, Nov 12, 2020 at 23:48:02 +0100, Thomas Huth wrote:
>> While fixing domfsinfo for non-PCI (i.e. CCW) devices on s390x,
>> I accidentally used the whole device path for the devAlias field.
>> However, it should only contain the base target name.
>>
On Fri, Nov 13, 2020 at 09:53:28 +0300, Nikolay Shirokovskiy wrote:
> This is successor to [1] but I changed the subject as in the review the patch
> 'qemu: sync backing chain update in virDomainGetBlockJobInfo' was not
> considered good one from design POV. However I think the basic patch is
>
On Thu, Nov 12, 2020 at 23:48:02 +0100, Thomas Huth wrote:
> While fixing domfsinfo for non-PCI (i.e. CCW) devices on s390x,
> I accidentally used the whole device path for the devAlias field.
> However, it should only contain the base target name.
>
> Currently we have the wrong output:
>
> $
yajl_tree_parse is declared in yajl/yajl_tree.h
autoconf is more forgiving, the error did not trigger because
yajl_tree_parse is not actually used.
Fixes commit 44b8df4cb4b3f0c143e0330f543812e6bcd5c9f0
Fixes commit 88ab32a4e555f67dae3204fbc3bcf63d3da8ad2b
Signed-off-by: Olaf Hering
---
While fixing domfsinfo for non-PCI (i.e. CCW) devices on s390x,
I accidentally used the whole device path for the devAlias field.
However, it should only contain the base target name.
Currently we have the wrong output:
$ virsh domfsinfo guestname
Mountpoint Name Type Target
On Thu, 12 Nov 2020 18:48:30 -0300
Daniel Henrique Barboza wrote:
> I intended to clean up the virDomainDefFree() calls that I
> kept seeing in qemu_driver.c, ended up doing a bit more than
> that.
>
> Daniel Henrique Barboza (10):
> qemu_driver.c: use g_autoptr() with virDomainDef pointers
>
On 11/12/20 8:33 AM, Ján Tomko wrote:
s/rs/rst/
Ops! Thanks for catching that. Fixed in my local branch.
DHB
Jano
On a Wednesday in 2020, Daniel Henrique Barboza wrote:
Document that we're not reflecting the aligned value in the
live domain XML, and that we fixed a bug that
On 11/12/20 8:28 AM, Michal Privoznik wrote:
On 11/11/20 11:07 PM, Daniel Henrique Barboza wrote:
Hi,
This is a work that I intended to do after pSeries NVDIMM changes
I made in commit v6.7.0-302-gd3f3c2c97f. The reasoning is that
if ppc64 NVDIMM alignment can be done in PostParse time,
Use g_autoptr() to deprecate the 'cleanup' label.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_domain.c | 16 +---
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 2fe8d06fdf..67d11aca92 100644
---
Remove obsolete 'cleanup' labels after the changes from the
previous patch.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_domain.c | 42 +++---
1 file changed, 15 insertions(+), 27 deletions(-)
diff --git a/src/qemu/qemu_domain.c
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_snapshot.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c
index 8e3540bbc1..a31a62b7ec 100644
--- a/src/qemu/qemu_snapshot.c
+++ b/src/qemu/qemu_snapshot.c
@@
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_driver.c | 54 ++
1 file changed, 18 insertions(+), 36 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 05f8eb2cb7..fdbac9d21d 100644
--- a/src/qemu/qemu_driver.c
+++
Use g_autoptr() and remove the 'cleanup' label.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_domain.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index f28178af61..aea0a6bd93 100644
---
Some labels became deprecated after the previous patches.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_driver.c | 132 +
1 file changed, 55 insertions(+), 77 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index
Use VIR_AUTOCLOSE with 'fd' and delete the 'cleanup' label.
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_domain.c | 16 +---
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 67d11aca92..f28178af61 100644
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_domain.c | 15 +--
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index 70896ad80e..3c17e6e4b4 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_driver.c | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index fdbac9d21d..2198e7f1e9 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
Signed-off-by: Daniel Henrique Barboza
---
src/qemu/qemu_driver.c | 15 ++-
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 2198e7f1e9..6ff7289fd1 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@
I intended to clean up the virDomainDefFree() calls that I
kept seeing in qemu_driver.c, ended up doing a bit more than
that.
Daniel Henrique Barboza (10):
qemu_driver.c: use g_autoptr() with virDomainDef pointers
qemu_driver.c: use g_autoptr() with qemuMigrationParams pointers
autoconf allows to specify the path to a runtime binary that is not required
during build via an environment variable:
AC_PATH_PROG([PARTED], [parted], [], [$LIBVIRT_SBIN_PATH])
meson lacks such essential feature. As a result the package build environment
needs to have more packages than
On 11/12/20 6:04 PM, Michal Privoznik wrote:
Using virtiofs without NUMA was implemented in v6.9.0-rc1~161 but
our kbase document only mentions QEMU version which may confuse
users.
Signed-off-by: Michal Privoznik
---
This is related to the IRC question just now? I've read it and wondered
Co-authored-by: Sri Ramanujam
Signed-off-by: Matt Coleman
---
src/hyperv/hyperv_driver.c | 52 ++
1 file changed, 52 insertions(+)
diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c
index 56d6da80e0..3c436d9465 100644
---
Changes since v1:
* use an enum for the real CPU constants
* remove the forward declaration
Here's a GitLab merge request, if you'd prefer to review it there:
https://gitlab.com/iammattcoleman/libvirt/-/merge_requests/11
Matt Coleman (6):
domain: introduce constants for virVcpuInfo->cpu state
Signed-off-by: Matt Coleman
---
NEWS.rst | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/NEWS.rst b/NEWS.rst
index 8b60a5da11..3fd3ce4cb9 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -16,9 +16,11 @@ v6.10.0 (unreleased)
* hyperv: implement new APIs
The
Co-authored-by: Sri Ramanujam
Signed-off-by: Matt Coleman
---
src/hyperv/hyperv_driver.c | 56 ++
1 file changed, 56 insertions(+)
diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c
index 44ef4c53e0..40739595ac 100644
---
Signed-off-by: Matt Coleman
---
include/libvirt/libvirt-domain.h | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h
index b3310729bf..e1095a193d 100644
--- a/include/libvirt/libvirt-domain.h
+++
Co-authored-by: Sri Ramanujam
Signed-off-by: Matt Coleman
---
src/hyperv/hyperv_driver.c | 56 ++
1 file changed, 56 insertions(+)
diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c
index 9fda0d6047..56d6da80e0 100644
---
Co-authored-by: Sri Ramanujam
Signed-off-by: Matt Coleman
---
src/hyperv/hyperv_driver.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c
index 3c436d9465..44ef4c53e0 100644
--- a/src/hyperv/hyperv_driver.c
+++
On Thu, 12 Nov 2020 13:15:19 +0100
Shalini Chellathurai Saroja wrote:
> From: Boris Fiuczynski
>
> Add detection of mdev_types capability to Adjunct Processor Matrix
> device.
>
> Signed-off-by: Boris Fiuczynski
> Signed-off-by: Shalini Chellathurai Saroja
> ---
> docs/formatnode.html.in
Using virtiofs without NUMA was implemented in v6.9.0-rc1~161 but
our kbase document only mentions QEMU version which may confuse
users.
Signed-off-by: Michal Privoznik
---
docs/kbase/virtiofs.rst | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/docs/kbase/virtiofs.rst
On Thu, 12 Nov 2020 13:15:18 +0100
Shalini Chellathurai Saroja wrote:
> Allow mdev devices to be created on the matrix device.
>
> Signed-off-by: Shalini Chellathurai Saroja
> Reviewed-by: Bjoern Walk
> Reviewed-by: Boris Fiuczynski
> ---
> src/node_device/node_device_driver.c | 5 -
>
> On Nov 12, 2020, at 11:34 AM, Michal Privoznik wrote:
>
> Well, I think I can live with this one since there is an (esthetic) reason to
> it.
Since I wrote that email, I've looked at other drivers in the codebase
and decided it's not worth it. I've eliminated the forward declaration
(as
On Thu, 12 Nov 2020 13:15:14 +0100
Shalini Chellathurai Saroja wrote:
> Add support for AP matrix device in libvirt node device driver.
>
> Signed-off-by: Shalini Chellathurai Saroja
> Reviewed-by: Bjoern Walk
> Reviewed-by: Boris Fiuczynski
> ---
> docs/schemas/nodedev.rng | 7
On 11/12/20 7:51 PM, Andrea Bolognani wrote:
While it's certainly good to log events like "failed to close fd"
and "tried to close invalid fd", which are likely to be the
consequence of some bug in libvirt, logging a message every single
time a file descriptor is closed successfully is perhaps
On 11/12/20 3:07 PM, Jin Yan wrote:
When migration fails, qemuMigrationDstPrepareAny will call qemuProcessStop
to restore labels only after all labels are successfully set. If some labels
fail to set, the labels that have been set will not be restored.
Signed-off-by: Jin Yan
---
While it's certainly good to log events like "failed to close fd"
and "tried to close invalid fd", which are likely to be the
consequence of some bug in libvirt, logging a message every single
time a file descriptor is closed successfully is perhaps excessive
and can lead to useful information
When the host is shutting down then we get PrepareForShutdown
signal on DBus to which we react by creating a thread which
runs virStateStop() and thus qemuStateStop(). But if scheduling
the thread is delayed just a but it may happen that we receive
SIGTERM (sent by systemd) to which we respond by
This is to help reproduce the race. Build and attach gdb and:
handle SIGUSR1 nostop pass
handle SIGINT nostop pass
and then:
kill -SIGUSR1 $(pgrep libvirtd); sleep 1; kill -SIGINT $(pgrep libvirtd)
Signed-off-by: Michal Privoznik
---
src/remote/remote_daemon.c | 64
The second patch is the interesting one.
Michal Prívozník (2):
DO NOT MERGE
qemu: Check if driver is still available in qemuStateStop()
src/qemu/qemu_driver.c | 7 -
src/remote/remote_daemon.c | 64 +-
2 files changed, 42 insertions(+), 29
> On Nov 12, 2020, at 8:46 AM, Michal Privoznik wrote:
>
> On 11/12/20 12:51 PM, Matt Coleman wrote:
>> +/**
>> + * VIR_VCPU_INFO_CPU_OFFLINE:
>> + *
>> + * The VCPU is offline.
>> + */
>> +# define VIR_VCPU_INFO_CPU_OFFLINE -1
>> +
>> +/**
>> + * VIR_VCPU_INFO_CPU_UNAVAILABLE:
>> + *
>> + * The
> On Nov 12, 2020, at 8:46 AM, Michal Privoznik wrote:
>
> On 11/12/20 12:51 PM, Matt Coleman wrote:
>> Co-authored-by: Sri Ramanujam
>> Signed-off-by: Matt Coleman
>> ---
>> src/hyperv/hyperv_driver.c | 16
>> 1 file changed, 16 insertions(+)
>> diff --git
Since Xen 4.2 libxl expects device_model_override="/path" instead of
device_model="/path". Adjust the code to parse this as .
While libxl also recognizes device_model_version="", this knob is not
supported by libvirt. A runtime detection exists to select either
"qemu-xen" or
On 11/12/20 6:10 PM, Matt Coleman wrote:
Changes since v1:
* use an enum for the real CPU constants
* remove the forward declaration
Here's a GitLab merge request, if you'd prefer to review it there:
https://gitlab.com/iammattcoleman/libvirt/-/merge_requests/11
Matt Coleman (6):
domain:
On 4/27/20 5:54 PM, Daniel P. Berrangé wrote:
We got a new BZ filed about a libvirtd crash in shutdown
https://bugzilla.redhat.com/show_bug.cgi?id=1828207
And there is another one:
https://bugzilla.redhat.com/show_bug.cgi?id=1895359
The problem is that when host is shutting down we get
On Thu, 12 Nov 2020 13:15:11 +0100
Shalini Chellathurai Saroja wrote:
> Each AP card device can support upto 256 AP queues. AP queues are
> also detected by udev, so add support for libvirt nodedev driver.
>
> Signed-off-by: Farhan Ali
> Signed-off-by: Shalini Chellathurai Saroja
>
On Thu, Nov 12, 2020 at 16:27:02 +, Daniel Berrange wrote:
> On Thu, Nov 12, 2020 at 05:18:06PM +0100, Michal Privoznik wrote:
> > On 11/12/20 3:46 PM, Peter Krempa wrote:
> >
> > > Saying that virDomainQemuAgentCommand is fully supported to be used
> > > would free us from having to add
On 11/12/20 3:17 PM, Matt Coleman wrote:
On Nov 12, 2020, at 8:46 AM, Michal Privoznik wrote:
On 11/12/20 12:51 PM, Matt Coleman wrote:
+/**
+ * VIR_VCPU_INFO_CPU_OFFLINE:
+ *
+ * The VCPU is offline.
+ */
+# define VIR_VCPU_INFO_CPU_OFFLINE -1
+
+/**
+ * VIR_VCPU_INFO_CPU_UNAVAILABLE:
+ *
+
On 11/12/20 3:15 PM, Matt Coleman wrote:
On Nov 12, 2020, at 8:46 AM, Michal Privoznik wrote:
On 11/12/20 12:51 PM, Matt Coleman wrote:
Co-authored-by: Sri Ramanujam
Signed-off-by: Matt Coleman
---
src/hyperv/hyperv_driver.c | 16
1 file changed, 16 insertions(+)
diff
On Thu, 12 Nov 2020 13:15:09 +0100
Shalini Chellathurai Saroja wrote:
> Introduce support for the Adjunct Processor (AP) crypto card device.
> Udev already detects the device, so add support for libvirt nodedev
> driver.
>
> Signed-off-by: Farhan Ali
> Signed-off-by: Shalini Chellathurai
On Thu, Nov 12, 2020 at 05:18:06PM +0100, Michal Privoznik wrote:
> On 11/12/20 3:46 PM, Peter Krempa wrote:
>
> > Saying that virDomainQemuAgentCommand is fully supported to be used
> > would free us from having to add arbitrary unextendable APIs for every
> > single guest agent API, but would
On 11/12/20 3:46 PM, Peter Krempa wrote:
Saying that virDomainQemuAgentCommand is fully supported to be used
would free us from having to add arbitrary unextendable APIs for every
single guest agent API, but would still allow libvirt to use APIs we
need.
By saying that mgmt apps will need to
On Thu, Nov 12, 2020 at 16:17:22 +0100, Ján Tomko wrote:
> On a Thursday in 2020, Peter Krempa wrote:
> > We try to enable keepalive oportunistically. If it's not supported by
>
> *opportunistically
>
> > the connection driver and it was not explicitly requested we keep the
> > error object set
Signed-off-by: Matt Coleman
---
NEWS.rst | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/NEWS.rst b/NEWS.rst
index 8b60a5da11..3fd3ce4cb9 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -16,9 +16,11 @@ v6.10.0 (unreleased)
* hyperv: implement new APIs
The
Co-authored-by: Sri Ramanujam
Signed-off-by: Matt Coleman
---
src/hyperv/hyperv_driver.c | 56 ++
1 file changed, 56 insertions(+)
diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c
index 0e35f18430..3ee2705592 100644
---
Co-authored-by: Sri Ramanujam
Signed-off-by: Matt Coleman
---
src/hyperv/hyperv_driver.c | 16
1 file changed, 16 insertions(+)
diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c
index 3c436d9465..0e35f18430 100644
--- a/src/hyperv/hyperv_driver.c
+++
Co-authored-by: Sri Ramanujam
Signed-off-by: Matt Coleman
---
src/hyperv/hyperv_driver.c | 52 ++
1 file changed, 52 insertions(+)
diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c
index 56d6da80e0..3c436d9465 100644
---
Co-authored-by: Sri Ramanujam
Signed-off-by: Matt Coleman
---
src/hyperv/hyperv_driver.c | 56 ++
1 file changed, 56 insertions(+)
diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c
index 9fda0d6047..56d6da80e0 100644
---
Signed-off-by: Matt Coleman
---
include/libvirt/libvirt-domain.h | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h
index b3310729bf..d52733190f 100644
--- a/include/libvirt/libvirt-domain.h
+++
Here's a GitLab merge request, if you'd prefer to review it there:
https://gitlab.com/iammattcoleman/libvirt/-/merge_requests/10
Matt Coleman (6):
domain: introduce constants for virVcpuInfo->cpu state values
hyperv: implement domainGetVcpus
hyperv: implement domainGetVcpusFlags
hyperv:
On a Thursday in 2020, Matt Coleman wrote:
Signed-off-by: Matt Coleman
---
src/conf/domain_conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
On a Thursday in 2020, Matt Coleman wrote:
Signed-off-by: Matt Coleman
---
src/conf/domain_conf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 25baa44a92..d71bd68682 100644
--- a/src/conf/domain_conf.c
+++
On a Thursday in 2020, Peter Krempa wrote:
Recent patch:
https://www.redhat.com/archives/libvir-list/2020-November/msg00555.html
passes build check but then virsh complains when started that the
command list is wrong.
Fix it by moving the check to the appropriate place.
You can use the above
On a Thursday in 2020, Peter Krempa wrote:
We try to enable keepalive oportunistically. If it's not supported by
*opportunistically
the connection driver and it was not explicitly requested we keep the
error object set and can report it in some cases accidentally:
I was going to complain
On a Wednesday in 2020, Peter Krempa wrote:
Synchronize with the latest release candidate.
Signed-off-by: Peter Krempa
---
.../caps_5.2.0.x86_64.replies | 684 +-
.../caps_5.2.0.x86_64.xml | 6 +-
2 files changed, 349 insertions(+), 341
On a Tuesday in 2020, Masayoshi Mizuma wrote:
On Tue, Nov 10, 2020 at 10:10:16AM -0300, Daniel Henrique Barboza wrote:
On 11/10/20 2:04 AM, Masayoshi Mizuma wrote:
> From: Masayoshi Mizuma
>
> A qemu guest which has virtiofs config fails to start if the previous
> starting failed because of
On Thu, Nov 12, 2020 at 12:55:23 +0100, Michal Privoznik wrote:
> On 11/11/20 1:04 PM, Michal Privoznik wrote:
> > On 11/11/20 11:32 AM, Peter Krempa wrote:
> > > On Tue, Nov 10, 2020 at 16:11:40 +0100, Michal Privoznik wrote:
> > > > Marc-André posted a patch that implements agent handling. I've
When migration fails, qemuMigrationDstPrepareAny will call qemuProcessStop
to restore labels only after all labels are successfully set. If some labels
fail to set, the labels that have been set will not be restored.
Signed-off-by: Jin Yan
---
src/qemu/qemu_security.c | 12 ++--
1 file
Signed-off-by: Andrea Bolognani
---
Pushed as trivial.
config.h | 2 +-
docs/programming-languages.rst | 2 +-
meson.build| 4 ++--
tests/qemusecuritymock.c | 2 +-
4 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/config.h b/config.h
'vshCmddefCheckInternals' is the go-to place for all checks related to
the definition of parameters for commands, but the check that all
mandatory parameters must be ordered before optional parameters was
still only in vshCmddefOptParse.
Adding a non-compliant option would not be caught by our
Signed-off-by: Peter Krempa
---
tools/vsh.c | 2 +-
tools/vsh.h | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/tools/vsh.c b/tools/vsh.c
index ca92bcd78c..e5ecc38f73 100644
--- a/tools/vsh.c
+++ b/tools/vsh.c
@@ -600,7 +600,7 @@ vshCmdGrpHelp(vshControl *ctl, const
We no longer print help for every command to validate the args.
Signed-off-by: Peter Krempa
---
tools/vsh.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/tools/vsh.c b/tools/vsh.c
index 28c7533a25..cf4ddc1c2c 100644
--- a/tools/vsh.c
+++ b/tools/vsh.c
@@ -3324,9 +3324,6 @@ const
On 11/12/20 12:51 PM, Matt Coleman wrote:
Co-authored-by: Sri Ramanujam
Signed-off-by: Matt Coleman
---
src/hyperv/hyperv_driver.c | 16
1 file changed, 16 insertions(+)
diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c
index 3c436d9465..0e35f18430
On 11/12/20 12:51 PM, Matt Coleman wrote:
Signed-off-by: Matt Coleman
---
include/libvirt/libvirt-domain.h | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h
index b3310729bf..d52733190f
Please don't CC individual developers when posting patches: we're all
subscribed to the mailing list.
On Mon, 2020-11-09 at 15:33 +0800, jgao wrote:
> From: jgao
>
> Add news about apparmor about the improvements.
>
> Signed-off-by: jgao
Please make sure both the Signed-off-by tag and git
On Thu, Nov 12, 2020 at 12:48:21PM +, Daniel P. Berrangé wrote:
On Thu, Nov 12, 2020 at 01:42:32PM +0100, Martin Kletzander wrote:
On Thu, Nov 12, 2020 at 09:41:39AM +, Daniel P. Berrangé wrote:
> With CLang we're getting failures from cats in GLib macros
>
>
Recent patch:
https://www.redhat.com/archives/libvir-list/2020-November/msg00555.html
passes build check but then virsh complains when started that the
command list is wrong.
Fix it by moving the check to the appropriate place.
You can use the above patch as reproducer.
Peter Krempa (8):
Since vshCmddefCheckInternals now has this check we no longer need it in
vshCmddefOptParse.
Signed-off-by: Peter Krempa
---
tools/vsh.c | 24 +---
1 file changed, 5 insertions(+), 19 deletions(-)
diff --git a/tools/vsh.c b/tools/vsh.c
index cf4ddc1c2c..f92759f219 100644
---
The help formatter called vshCmddefOptParse just for validation
purposes. Since vshCmddefOptParse no longer validates the command itself
and we don't need the bitmaps returned by it we can drop the call
entirely.
Signed-off-by: Peter Krempa
---
tools/vsh.c | 12 ++--
1 file changed, 2
The function can't fail so there's no need to return a value or check it
in the callers.
Signed-off-by: Peter Krempa
---
tools/vsh.c | 24 +++-
1 file changed, 7 insertions(+), 17 deletions(-)
diff --git a/tools/vsh.c b/tools/vsh.c
index 2de940277e..badd37c08e 100644
---
If a parameter definition is invalid we can include the name of the
parameter for simpler debugging.
Signed-off-by: Peter Krempa
---
tools/vsh.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/tools/vsh.c b/tools/vsh.c
index e5ecc38f73..d1e795bbc1
We try to enable keepalive oportunistically. If it's not supported by
the connection driver and it was not explicitly requested we keep the
error object set and can report it in some cases accidentally:
--- stdout ---
TEST: /home/pipo/libvirt/tests/virsh-self-test
!
On Thu, Nov 12, 2020 at 01:42:32PM +0100, Martin Kletzander wrote:
> On Thu, Nov 12, 2020 at 09:41:39AM +, Daniel P. Berrangé wrote:
> > With CLang we're getting failures from cats in GLib macros
> >
> > ../dist-unpack/libvirt-6.10.0/src/util/vireventthread.c:35:1:
> > error: passing 'typeof
On Thu, Nov 12, 2020 at 09:41:39AM +, Daniel P. Berrangé wrote:
With CLang we're getting failures from cats in GLib macros
../dist-unpack/libvirt-6.10.0/src/util/vireventthread.c:35:1:
error: passing 'typeof (*(_define_type_id__volatile)) *'
(aka 'volatile unsigned long *') to parameter
On 11/12/20 1:16 PM, Vasiliy Tolstov wrote:
Useful things. As i understand it qemu-ga eventually can replace
cloud-init stuff. As for now it already have high level api and low
level api (like read/write files)
Yeah, the low level file manipulation APIs are terrible because they
have to rely
Useful things. As i understand it qemu-ga eventually can replace
cloud-init stuff. As for now it already have high level api and low
level api (like read/write files)
вт, 10 нояб. 2020 г. в 18:49, Michal Privoznik :
>
> Marc-André posted a patch that implements agent handling. I've written
> the
From: Boris Fiuczynski
Add detection of mdev_types capability to Adjunct Processor Matrix device.
Signed-off-by: Boris Fiuczynski
Signed-off-by: Shalini Chellathurai Saroja
---
docs/formatnode.html.in | 24 +++-
docs/schemas/nodedev.rng | 4 +
Add support to filter by 'ap_matrix' capability.
Signed-off-by: Shalini Chellathurai Saroja
Reviewed-by: Bjoern Walk
Reviewed-by: Boris Fiuczynski
---
docs/formatnode.html.in | 3 +++
docs/manpages/virsh.rst | 2 +-
include/libvirt/libvirt-nodedev.h | 1 +
Add tests to verify libvirt node device driver support for AP queues
Signed-off-by: Farhan Ali
Signed-off-by: Shalini Chellathurai Saroja
Reviewed-by: Bjoern Walk
Reviewed-by: Boris Fiuczynski
---
tests/nodedevschemadata/ap_07_0038.xml | 9 +
tests/nodedevxml2xmltest.c |
Add tests to verify libvirt node device driver support for AP matrix
device.
Signed-off-by: Shalini Chellathurai Saroja
Reviewed-by: Bjoern Walk
Reviewed-by: Boris Fiuczynski
---
tests/nodedevschemadata/ap_matrix.xml| 7 +++
Add support for AP matrix device in libvirt node device driver.
Signed-off-by: Shalini Chellathurai Saroja
Reviewed-by: Bjoern Walk
Reviewed-by: Boris Fiuczynski
---
docs/schemas/nodedev.rng | 7 +++
src/conf/node_device_conf.c| 11 ++-
Use switch statements instead of if-else condition in the method
nodeDeviceFindAddressByName to retrieve address of a node device.
Signed-off-by: Shalini Chellathurai Saroja
Reviewed-by: Bjoern Walk
Reviewed-by: Boris Fiuczynski
---
src/node_device/node_device_driver.c | 30
Add tests to verify libvirt node device driver support for AP card
device.
Signed-off-by: Farhan Ali
Signed-off-by: Shalini Chellathurai Saroja
Reviewed-by: Bjoern Walk
Reviewed-by: Boris Fiuczynski
---
tests/nodedevschemadata/ap_card07.xml | 8
tests/nodedevxml2xmltest.c
From: Farhan Ali
Add support to filter by 'ap_card' and 'ap_queue' capabilities.
Signed-off-by: Farhan Ali
Reviewed-by: Boris Fiuczynski
Reviewed-by: Bjoern Walk
Signed-off-by: Shalini Chellathurai Saroja
---
docs/manpages/virsh.rst | 2 +-
include/libvirt/libvirt-nodedev.h | 2
Allow mdev devices to be created on the matrix device.
Signed-off-by: Shalini Chellathurai Saroja
Reviewed-by: Bjoern Walk
Reviewed-by: Boris Fiuczynski
---
src/node_device/node_device_driver.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git
Add support for AP card devices, AP queues and AP matrix devices in
libvirt node device driver.
---
v2:
- The tests included in the patches to detect the node devices (AP
card, AP queues and AP matrix) are moved to separate patches.
These patches are not divided further due to the following
Each AP card device can support upto 256 AP queues. AP queues are
also detected by udev, so add support for libvirt nodedev driver.
Signed-off-by: Farhan Ali
Signed-off-by: Shalini Chellathurai Saroja
Reviewed-by: Bjoern Walk
Reviewed-by: Boris Fiuczynski
---
docs/formatnode.html.in
Introduce support for the Adjunct Processor (AP) crypto card device.
Udev already detects the device, so add support for libvirt nodedev
driver.
Signed-off-by: Farhan Ali
Signed-off-by: Shalini Chellathurai Saroja
Reviewed-by: Bjoern Walk
Reviewed-by: Boris Fiuczynski
---
On 11/11/20 1:04 PM, Michal Privoznik wrote:
On 11/11/20 11:32 AM, Peter Krempa wrote:
On Tue, Nov 10, 2020 at 16:11:40 +0100, Michal Privoznik wrote:
Marc-André posted a patch that implements agent handling. I've written
the rest.
Marc-André Lureau (1):
qemu_agent: add
s/rs/rst/
Jano
On a Wednesday in 2020, Daniel Henrique Barboza wrote:
Document that we're not reflecting the aligned value in the
live domain XML, and that we fixed a bug that occurred in
pSeries guests where a guest might start with an extra 256MiB
of memory.
Signed-off-by: Daniel Henrique
On 11/11/20 11:07 PM, Daniel Henrique Barboza wrote:
Hi,
This is a work that I intended to do after pSeries NVDIMM changes
I made in commit v6.7.0-302-gd3f3c2c97f. The reasoning is that
if ppc64 NVDIMM alignment can be done in PostParse time, regular
ppc64 DIMMs alignment can also be done the
1 - 100 of 108 matches
Mail list logo