Re: [PATCH 1/2] util:netlink: Enable virNetlinkNewLink to support veth

On 11/17/20 1:48 AM, Shi Lei wrote: Signed-off-by: Shi Lei --- src/util/virnetlink.c | 25 + src/util/virnetlink.h | 1 + 2 files changed, 26 insertions(+) diff --git a/src/util/virnetlink.c b/src/util/virnetlink.c index fdd3a6a4..e191f63b 100644 ---

Re: [PATCH 2/2] util:veth: Create veth device pair by netlink

On 11/17/20 1:48 AM, Shi Lei wrote: When netlink is supported, use netlink to create veth device pair rather than 'ip link' command. Signed-off-by: Shi Lei --- src/util/virnetdevveth.c | 39 ++- 1 file changed, 30 insertions(+), 9 deletions(-) diff --git

Re: Issue 90 Further Clarifications

On 11/20/20 1:07 PM, Dustan B Helm wrote: On Fri, Nov 20, 2020 at 5:33 AM Peter Krempa > wrote: On Fri, Nov 20, 2020 at 09:41:44 +, Daniel Berrange wrote: > On Thu, Nov 19, 2020 at 03:48:48PM -0600, Dustan B Helm wrote: > > [image: Dustan Helm]

Re: [PATCH] util: convert char pointers to use g_autofree

On 11/20/20 11:43 AM, Barrett J Schonefeld wrote: I appreciate the feedback on this patch! I will work on splitting this into multiple patches. I believe this will involve redoing much of the work because I will need to split this patch (a single commit) into many commits. One suggestion on

Re: [libvirt PATCH v2 0/3] network: Drop UUID handling for default network

On 11/20/20 5:53 AM, Andrea Bolognani wrote: On Thu, 2020-11-19 at 11:03 -0500, Laine Stump wrote: We should change the other drivers that have uuids so that they also save if the uuid was added during parse. If that sounds boring to you, then I can put it on a list somewhere. I can't

Re: regression in meson build, AC_PATH_PROG lost

On Fri, Nov 20, 2020 at 07:32:44PM +0100, Pavel Hrdina wrote: On Fri, Nov 20, 2020 at 06:49:15PM +0100, Andrea Bolognani wrote: On Fri, 2020-11-20 at 17:31 +0100, Pavel Hrdina wrote: > On Fri, Nov 20, 2020 at 04:38:20PM +0100, Andrea Bolognani wrote: > > If you did that, then you wouldn't have

[libvirt PATCH 7/8] cpu_x86: Make sure removed features are always mentioned in CPU def

For backward compatibility with older versions of libvirt CPU models in our CPU map are mostly immutable. We only changed them in a few specific cases after showing it was safe. Sometimes QEMU developers realize a specific feature should not be part of a particular (or any) CPU model because it

[libvirt PATCH 6/8] cpu_x86: Add support for marking features as removed from a CPU model

The patch adds a new attribute for the 'feature' element in CPU model specification to indicate that a given feature was removed from a CPU model. In other words, older versions of libvirt would consider such feature to be included in the CPU model. Signed-off-by: Jiri Denemark ---

[libvirt PATCH 2/8] conf: Use enum in virCPUDefAddFeatureInternal

Replace the 'update' bool parameter with an enum so that we can have more than two possible values. Signed-off-by: Jiri Denemark --- src/conf/cpu_conf.c | 30 -- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/src/conf/cpu_conf.c b/src/conf/cpu_conf.c

[libvirt PATCH 3/8] conf: Add virCPUDefAddFeatureIfMissing

This new function adds a feature to a CPU definition only if it is not present there yet. Signed-off-by: Jiri Denemark --- src/conf/cpu_conf.c | 14 ++ src/conf/cpu_conf.h | 5 + src/libvirt_private.syms | 1 + 3 files changed, 20 insertions(+) diff --git

[libvirt PATCH 8/8] cpu_map: Drop 'monitor' from modern x86 CPU models

The feature is never enabled by default on KVM and QEMU dropped it from the models long ago. https://bugzilla.redhat.com/show_bug.cgi?id=1798004 Signed-off-by: Jiri Denemark --- src/cpu_map/x86_Dhyana.xml | 2 +- src/cpu_map/x86_EPYC-IBPB.xml

[libvirt PATCH 5/8] cpu_x86: Change the flow in virCPUx86Update

This is just a preparation for adding new functionality to virCPUx86Update. Signed-off-by: Jiri Denemark --- src/cpu/cpu_x86.c | 49 --- 1 file changed, 25 insertions(+), 24 deletions(-) diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index

[libvirt PATCH 0/8] Drop 'monitor' from modern x86 CPU models

Doing so would normally break migration to older libvirt, but most of the patches in this series prepare an infrastructure for removing features from existing CPU models while maintaining backward compatibility during migration. See patch 7 for more details.

[libvirt PATCH 4/8] cpu: Run arch specific code for virCPUUpdate for all custom CPUs

Until now, the function returned immediately when the guest CPU definition did not use optional features or minimum match. Clearly, there's nothing to be updated according to the host CPU in this case, but the arch specific code may still want to do some compatibility updates based on the model

[libvirt PATCH 1/8] conf: Rename virCPUDefUpdateFeatureInternal

The function is supposed to add a feature to a CPU definition, let's name it virCPUDefAddFeatureInternal. The behavior in case the feature is already present in the CPU def is configurable and we will soon add a new option to not do anything in that case, which wouldn't really work well with the

Re: [PATCH-for-5.2 3/4] docs/system/arm: Document OpenPOWER Witherspoon BMC model Front LEDs

On 11/20/20 4:21 PM, Philippe Mathieu-Daudé wrote: > Document the 3 front LEDs modeled on the OpenPOWER Witherspoon BMC > (see commit 7cfbde5ea1c "hw/arm/aspeed: Add the 3 front LEDs drived > by the PCA9552 #1"). > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks,

Re: regression in meson build, AC_PATH_PROG lost

On Fri, Nov 20, 2020 at 06:49:15PM +0100, Andrea Bolognani wrote: > On Fri, 2020-11-20 at 17:31 +0100, Pavel Hrdina wrote: > > On Fri, Nov 20, 2020 at 04:38:20PM +0100, Andrea Bolognani wrote: > > > If you did that, then you wouldn't have simplified meson.build much > > > while at the same time

[libvirt PATCH 6/9] qemu_agent: add qemuAgentGetDisks

From: Marc-André Lureau guest-get-disks is available since QEMU 5.2: https://wiki.qemu.org/ChangeLog/5.2#Guest_agent Note that the test response was manually edited based on a reply on my bare-metal computer. It shows partial results due to pcieport driver not being currently supported by QGA.

[libvirt PATCH 2/9] qemu_agent: export qemuAgentDiskAddressFree & add g_auto

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- src/qemu/qemu_agent.c | 2 +- src/qemu/qemu_agent.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c index beb42449ce..ba07d6bfdf 100644 --- a/src/qemu/qemu_agent.c

[libvirt PATCH 5/9] qemu: use virJSONValueObjectGetStringArray

From: Marc-André Lureau There might be more potential users around, I haven't looked thoroughly. Signed-off-by: Marc-André Lureau --- src/qemu/qemu_monitor_json.c | 34 ++ 1 file changed, 6 insertions(+), 28 deletions(-) diff --git

[libvirt PATCH 0/9] qemu: report guest disks informations

From: Marc-André Lureau Hi, The following series extends virDomainGetGuestInfo to report disk informations provided by the new QGA "guest-get-disks" command in QEMU 5.2. Please review, Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1899527 Marc-André Lureau (9): qemu_agent: rename

[libvirt PATCH 1/9] qemu_agent: rename qemuAgentDiskInfo->qemuAgentDiskAddress

From: Marc-André Lureau To match the QGA schema name (we are introducing a qemuAgentDiskInfo struct again for different purpose). Signed-off-by: Marc-André Lureau --- src/qemu/qemu_agent.c | 10 +- src/qemu/qemu_agent.h | 8 src/qemu/qemu_driver.c | 4 ++-- 3 files

[libvirt PATCH 9/9] virsh: add --disk informations to guestinfo command

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- tools/virsh-domain.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index c999458d72..070b8d21fd 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -14219,6

[libvirt PATCH 8/9] qemu_driver: report guest disk informations

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- src/qemu/qemu_driver.c | 99 -- 1 file changed, 96 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index a8760f82b1..8d3e09da69 100644 ---

[libvirt PATCH 7/9] domain: add disk informations to virDomainGetGuestInfo

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- include/libvirt/libvirt-domain.h | 1 + src/libvirt-domain.c | 17 + 2 files changed, 18 insertions(+) diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h index

[libvirt PATCH 4/9] util: json: add virJSONValueObjectGetStringArray convenience

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- src/libvirt_private.syms | 1 + src/util/virjson.c | 30 ++ src/util/virjson.h | 1 + 3 files changed, 32 insertions(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index

[libvirt PATCH 3/9] qemu_agent: factor out qemuAgentGetDiskAddress

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- src/qemu/qemu_agent.c | 83 ++- 1 file changed, 43 insertions(+), 40 deletions(-) diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c index ba07d6bfdf..31f26eedd1 100644 ---

Re: Issue 90 Further Clarifications

On Fri, Nov 20, 2020 at 5:33 AM Peter Krempa wrote: > On Fri, Nov 20, 2020 at 09:41:44 +, Daniel Berrange wrote: > > On Thu, Nov 19, 2020 at 03:48:48PM -0600, Dustan B Helm wrote: > > > [image: Dustan Helm] > > > Dustan Helm

Re: regression in meson build, AC_PATH_PROG lost

On Fri, 2020-11-20 at 17:31 +0100, Pavel Hrdina wrote: > On Fri, Nov 20, 2020 at 04:38:20PM +0100, Andrea Bolognani wrote: > > If you did that, then you wouldn't have simplified meson.build much > > while at the same time you'd have ended up with a far less nuanced > > check that does not catch

[PATCH-for-5.2 v2 1/4] docs/system: Deprecate raspi2/raspi3 machine aliases

Since commit aa35ec2213b ("hw/arm/raspi: Use more specific machine names") the raspi2/raspi3 machines have been renamed as raspi2b/raspi3b. Note, rather than the raspi3b, the raspi3ap introduced in commit 5be94252d34 ("hw/arm/raspi: Add the Raspberry Pi 3 model A+") is a closer match to what QEMU

[PATCH-for-5.2 v2 2/4] docs/system/arm: Document the various raspi boards

Document the following Raspberry Pi models: - raspi0 Raspberry Pi Zero (revision 1.2) - raspi1ap Raspberry Pi A+ (revision 1.1) - raspi2b Raspberry Pi 2B (revision 1.1) - raspi3ap Raspberry Pi 3A+ (revision 1.0) - raspi3b

[PATCH-for-5.2 v2 0/4] docs/system/arm: Document raspi/tosa boards

- Deprecate raspi2/raspi3 machine aliases - Document the Raspberry Pi boards - Document LED on OpenPOWER Witherspoon - Document Sharp Zaurus SL-6000 Tosa Since v1: - cover docs/system/arm/raspi.rst in MAINTAINERS - Addressed Peter review comments - Added R-b tags Philippe Mathieu-Daudé (4):

[RFC PATCH-for-5.2 v2 4/4] docs/system/arm: Document the Sharp Zaurus SL-6000

List the 'tosa' machine with the XScale-based PDAs models. Signed-off-by: Philippe Mathieu-Daudé --- docs/system/arm/xscale.rst | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/docs/system/arm/xscale.rst b/docs/system/arm/xscale.rst index

[PATCH-for-5.2 v2 3/4] docs/system/arm: Document OpenPOWER Witherspoon BMC model Front LEDs

Document the 3 front LEDs modeled on the OpenPOWER Witherspoon BMC (see commit 7cfbde5ea1c "hw/arm/aspeed: Add the 3 front LEDs drived by the PCA9552 #1"). Reviewed-by: Cédric Le Goater Signed-off-by: Philippe Mathieu-Daudé --- docs/system/arm/aspeed.rst | 1 + 1 file changed, 1 insertion(+)

Re: [libvirt PATCH] qemu: fix setting of scsi-id for ESP SCSI controllers

On 11/20/20 11:08 AM, Daniel P. Berrangé wrote: The ESP SCSI controllers have same requirement as the LSI Logic controller for each disk to be set via the scsi-id=NNN property, not the lun=NNN property. Maybe you could list the 3 controllers that are "ESP controllers" in the commit log

Re: [PATCH-for-5.2 2/4] docs/system/arm: Document the various raspi boards

On 11/20/20 5:48 PM, Peter Maydell wrote: > On Fri, 20 Nov 2020 at 15:21, Philippe Mathieu-Daudé wrote: >> >> Document the following Raspberry Pi models: >> >> - raspi0 Raspberry Pi Zero (revision 1.2) >> - raspi1ap Raspberry Pi A+ (revision 1.1) >> - raspi2b

Re: [RFC PATCH-for-5.2 4/4] docs/system/arm: Document the Sharp Zaurus SL-6000

On 11/20/20 5:52 PM, Peter Maydell wrote: > On Fri, 20 Nov 2020 at 15:22, Philippe Mathieu-Daudé wrote: >> >> List the 'tosa' machine with the XScale-based PDAs models. >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> docs/system/arm/xscale.rst | 13 - >> 1 file changed, 8

Re: [RFC PATCH-for-5.2 4/4] docs/system/arm: Document the Sharp Zaurus SL-6000

On Fri, 20 Nov 2020 at 15:22, Philippe Mathieu-Daudé wrote: > > List the 'tosa' machine with the XScale-based PDAs models. > > Signed-off-by: Philippe Mathieu-Daudé > --- > docs/system/arm/xscale.rst | 13 - > 1 file changed, 8 insertions(+), 5 deletions(-) > > diff --git

Re: [PATCH-for-5.2 2/4] docs/system/arm: Document the various raspi boards

On Fri, 20 Nov 2020 at 15:21, Philippe Mathieu-Daudé wrote: > > Document the following Raspberry Pi models: > > - raspi0 Raspberry Pi Zero (revision 1.2) > - raspi1ap Raspberry Pi A+ (revision 1.1) > - raspi2b Raspberry Pi 2B (revision 1.1) > - raspi3ap

Re: [PATCH-for-5.2 1/4] docs/system: Deprecate raspi2/raspi3 machine aliases

On Fri, 20 Nov 2020 at 15:21, Philippe Mathieu-Daudé wrote: > > Since commit aa35ec2213b ("hw/arm/raspi: Use more specific > machine names") the raspi2/raspi3 machines have been renamed > as raspi2b/raspi3b. > > Note, rather than the raspi3b, the raspi3ap introduced in > commit 5be94252d34

Re: [PATCH] util: convert char pointers to use g_autofree

I appreciate the feedback on this patch! I will work on splitting this into multiple patches. I believe this will involve redoing much of the work because I will need to split this patch (a single commit) into many commits. Hence, I'd like to get some confirmation on how I should approach the

Re: regression in meson build, AC_PATH_PROG lost

On Fri, Nov 20, 2020 at 04:38:20PM +0100, Andrea Bolognani wrote: > On Fri, 2020-11-20 at 14:36 +, Daniel P. Berrangé wrote: > > On Fri, Nov 20, 2020 at 03:31:39PM +0100, Andrea Bolognani wrote: > > > Lastly, if we stopped looking for commands at build time we would be > > > enabling features

[libvirt PATCH] qemu: fix setting of scsi-id for ESP SCSI controllers

The ESP SCSI controllers have same requirement as the LSI Logic controller for each disk to be set via the scsi-id=NNN property, not the lun=NNN property. Switching the code to use an enum will force authors to pay attention to this difference when adding future SCSI controllers. Signed-off-by:

Re: [libvirt PATCH 1/2] src: rework static analysis detection

On Fri, Nov 20, 2020 at 10:31:54AM -0500, John Ferlan wrote: > > > On 11/20/20 8:39 AM, Pavel Hrdina wrote: > > On Fri, Nov 20, 2020 at 06:57:10AM -0500, John Ferlan wrote: > >> > >> > >> On 11/16/20 10:36 AM, Pavel Hrdina wrote: > >>> Inspired by QEMU code. > >>> > >>> Signed-off-by: Pavel

Re: regression in meson build, AC_PATH_PROG lost

On Fri, 2020-11-20 at 14:36 +, Daniel P. Berrangé wrote: > On Fri, Nov 20, 2020 at 03:31:39PM +0100, Andrea Bolognani wrote: > > Lastly, if we stopped looking for commands at build time we would be > > enabling features that can, in reality, never work: iscsiadm, for > > example, is

Re: [libvirt PATCH 1/2] src: rework static analysis detection

On 11/20/20 8:39 AM, Pavel Hrdina wrote: > On Fri, Nov 20, 2020 at 06:57:10AM -0500, John Ferlan wrote: >> >> >> On 11/16/20 10:36 AM, Pavel Hrdina wrote: >>> Inspired by QEMU code. >>> >>> Signed-off-by: Pavel Hrdina >>> --- >>> meson.build| 14 -- >>> src/internal.h | 4

Re: [libvirt PATCH v2 2/2] ci: Drop env variables related to autotools and make

On Mon, 2020-11-09 at 12:20 +0100, Erik Skultety wrote: > Previous patch switched the build to meson which supports only > out-of-tree builds, runs by default in parallel on all available CPUs, > and we don't use configure anymore - the corresponding variables are > thus longer needed. > >

Re: [libvirt PATCH v2 1/2] ci: Switch to meson build system

On Mon, 2020-11-09 at 12:20 +0100, Erik Skultety wrote: > First add the meson required bits to be able to run the build. > NOTE: inspired by our gitlab-ci.yml This note seems unnecessary. > +++ b/ci/Makefile > @@ -227,6 +230,8 @@ ci-run-command@%: ci-prepare-tree >

Re: [PATCH-for-5.2 2/4] docs/system/arm: Document the various raspi boards

On 11/20/20 4:21 PM, Philippe Mathieu-Daudé wrote: > Document the following Raspberry Pi models: > > - raspi0 Raspberry Pi Zero (revision 1.2) > - raspi1ap Raspberry Pi A+ (revision 1.1) > - raspi2b Raspberry Pi 2B (revision 1.1) > - raspi3ap

[PATCH-for-5.2 0/4] docs/system/arm: Document raspi/tosa boards

- Deprecate raspi2/raspi3 machine aliases - Document the Raspberry Pi boards - Document LED on OpenPOWER Witherspoon - Document Sharp Zaurus SL-6000 Tosa Philippe Mathieu-Daudé (4): docs/system: Deprecate raspi2/raspi3 machine aliases docs/system/arm: Document the various raspi boards

[PATCH-for-5.2 3/4] docs/system/arm: Document OpenPOWER Witherspoon BMC model Front LEDs

Document the 3 front LEDs modeled on the OpenPOWER Witherspoon BMC (see commit 7cfbde5ea1c "hw/arm/aspeed: Add the 3 front LEDs drived by the PCA9552 #1"). Signed-off-by: Philippe Mathieu-Daudé --- docs/system/arm/aspeed.rst | 1 + 1 file changed, 1 insertion(+) diff --git

[RFC PATCH-for-5.2 4/4] docs/system/arm: Document the Sharp Zaurus SL-6000

List the 'tosa' machine with the XScale-based PDAs models. Signed-off-by: Philippe Mathieu-Daudé --- docs/system/arm/xscale.rst | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/docs/system/arm/xscale.rst b/docs/system/arm/xscale.rst index

[PATCH-for-5.2 2/4] docs/system/arm: Document the various raspi boards

Document the following Raspberry Pi models: - raspi0 Raspberry Pi Zero (revision 1.2) - raspi1ap Raspberry Pi A+ (revision 1.1) - raspi2b Raspberry Pi 2B (revision 1.1) - raspi3ap Raspberry Pi 3A+ (revision 1.0) - raspi3b

[PATCH-for-5.2 1/4] docs/system: Deprecate raspi2/raspi3 machine aliases

Since commit aa35ec2213b ("hw/arm/raspi: Use more specific machine names") the raspi2/raspi3 machines have been renamed as raspi2b/raspi3b. Note, rather than the raspi3b, the raspi3ap introduced in commit 5be94252d34 ("hw/arm/raspi: Add the Raspberry Pi 3 model A+") is a closer match to what QEMU

Re: [libvirt PATCH 0/2] minor cleanups in udevConnectListAllInterfaces

On 11/20/20 2:13 PM, Ján Tomko wrote: Ján Tomko (2): udevConnectListAllInterfaces: initialize ret udevConnectListAllInterfaces: delete pointless cleanup code src/interface/interface_backend_udev.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) Reviewed-by: Michal

Re: [PATCH 5/6] qapi: Add support for aliases

On Fri, Nov 20, 2020 at 03:41:54PM +0100, Peter Krempa wrote: > On Fri, Nov 13, 2020 at 10:46:02 +0100, Kevin Wolf wrote: > > Am 12.11.2020 um 19:34 hat Eric Blake geschrieben: > > > On 11/12/20 11:28 AM, Kevin Wolf wrote: > > > > Introduce alias definitions for object types (structs and unions).

Re: [PATCH 5/6] qapi: Add support for aliases

On Fri, Nov 13, 2020 at 10:46:02 +0100, Kevin Wolf wrote: > Am 12.11.2020 um 19:34 hat Eric Blake geschrieben: > > On 11/12/20 11:28 AM, Kevin Wolf wrote: > > > Introduce alias definitions for object types (structs and unions). This > > > allows using the same QAPI type and visitor for many syntax

Re: regression in meson build, AC_PATH_PROG lost

On Fri, Nov 20, 2020 at 03:31:39PM +0100, Andrea Bolognani wrote: > On Fri, 2020-11-20 at 13:58 +0100, Martin Kletzander wrote: > > On Fri, Nov 20, 2020 at 12:24:38PM +0100, Andrea Bolognani wrote: > > > While I would love the simplification such an approach would yield, > > > I have to point out

Re: regression in meson build, AC_PATH_PROG lost

On Fri, 2020-11-20 at 13:58 +0100, Martin Kletzander wrote: > On Fri, Nov 20, 2020 at 12:24:38PM +0100, Andrea Bolognani wrote: > > While I would love the simplification such an approach would yield, > > I have to point out that there is at least one advantage to checking > > for the availability

Re: [libvirt PATCH 1/2] qemu: json: check return value of virJSONValueObjectGetBoolean

On Fri, Nov 20, 2020 at 15:11:19 +0100, Peter Krempa wrote: > On Fri, Nov 20, 2020 at 15:08:31 +0100, Ján Tomko wrote: > > On a Friday in 2020, Peter Krempa wrote: > > > On Fri, Nov 20, 2020 at 14:46:06 +0100, Ján Tomko wrote: > > > > Signed-off-by: Ján Tomko > > > > Fixes:

Re: [libvirt PATCH 1/2] qemu: json: check return value of virJSONValueObjectGetBoolean

On Fri, Nov 20, 2020 at 15:08:31 +0100, Ján Tomko wrote: > On a Friday in 2020, Peter Krempa wrote: > > On Fri, Nov 20, 2020 at 14:46:06 +0100, Ján Tomko wrote: > > > Signed-off-by: Ján Tomko > > > Fixes: 7555a554706e8a6d492804debbacfaae9f5d8b05 > > > --- > > > src/qemu/qemu_monitor_json.c |

Re: [libvirt PATCH 1/2] qemu: json: check return value of virJSONValueObjectGetBoolean

On a Friday in 2020, Peter Krempa wrote: On Fri, Nov 20, 2020 at 14:46:06 +0100, Ján Tomko wrote: Signed-off-by: Ján Tomko Fixes: 7555a554706e8a6d492804debbacfaae9f5d8b05 --- src/qemu/qemu_monitor_json.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) See the discussion at:

Re: [PATCH RESEND v1] xen: recognize device_model_override

Am Thu, 19 Nov 2020 16:11:34 -0700 schrieb Jim Fehlig : > I suppose. Currently it is done in the downstream OBS package in %check > VIR_TEST_DEBUG=1 %meson_test -t 5 --no-suite syntax-check I had to run the build in a chroot in a dom0, not sure why it happens to work elsewhere. With v2 of the

Re: [libvirt PATCH 2/2] testsutilsqemu: check return value of virQEMUCapsNewCopy

On Fri, Nov 20, 2020 at 14:46:07 +0100, Ján Tomko wrote: > While for virQEMUCapsNew this should not be needed > (the possible failures in VIR_CLASS_NEW are only hit > on bad API usage which we don't do here), > virQEMUCapsNewCopy calls into many other functions, > some of which actually fail. >

Re: [libvirt PATCH 1/2] qemu: json: check return value of virJSONValueObjectGetBoolean

On Fri, Nov 20, 2020 at 14:46:06 +0100, Ján Tomko wrote: > Signed-off-by: Ján Tomko > Fixes: 7555a554706e8a6d492804debbacfaae9f5d8b05 > --- > src/qemu/qemu_monitor_json.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) See the discussion at:

Re: regression in meson build, AC_PATH_PROG lost

On Fri, Nov 20, 2020 at 6:25 AM Andrea Bolognani wrote: > > On Thu, 2020-11-19 at 16:56 -0500, Neal Gompa wrote: > > On Fri, Nov 13, 2020 at 8:14 AM Andrea Bolognani > > wrote: > > > As another data point, Debian currently carries a patch[1] which > > > allows us to enable the ZFS driver

[libvirt PATCH 2/2] testsutilsqemu: check return value of virQEMUCapsNewCopy

While for virQEMUCapsNew this should not be needed (the possible failures in VIR_CLASS_NEW are only hit on bad API usage which we don't do here), virQEMUCapsNewCopy calls into many other functions, some of which actually fail. Check the return value of both. Signed-off-by: Ján Tomko ---

[libvirt PATCH 1/2] qemu: json: check return value of virJSONValueObjectGetBoolean

Signed-off-by: Ján Tomko Fixes: 7555a554706e8a6d492804debbacfaae9f5d8b05 --- src/qemu/qemu_monitor_json.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 723bdb4426..0428ed0b6f 100644 ---

[libvirt PATCH 0/2] coverity unchecked returns

For #2, eventually we'd convert QEMUCaps to g_object and fix all the copy functions, but that's too big of a yak to shave now. Ján Tomko (2): qemu: json: check return value of virJSONValueObjectGetBoolean testsutilsqemu: check return value of virQEMUCapsNewCopy src/qemu/qemu_monitor_json.c

Re: [libvirt PATCH 1/2] src: rework static analysis detection

On Fri, Nov 20, 2020 at 06:57:10AM -0500, John Ferlan wrote: > > > On 11/16/20 10:36 AM, Pavel Hrdina wrote: > > Inspired by QEMU code. > > > > Signed-off-by: Pavel Hrdina > > --- > > meson.build| 14 -- > > src/internal.h | 4 > > 2 files changed, 4 insertions(+), 14

[libvirt PATCH 2/2] udevConnectListAllInterfaces: delete pointless cleanup code

We only jump to cleanup before allocating any lists. Drop the dead code. Signed-off-by: Ján Tomko --- src/interface/interface_backend_udev.c | 8 1 file changed, 8 deletions(-) diff --git a/src/interface/interface_backend_udev.c b/src/interface/interface_backend_udev.c index

[libvirt PATCH 1/2] udevConnectListAllInterfaces: initialize ret

Currently, ret is only used in the 'cleanup' section and initialized right before the jump. Switch to the customary initialization to -1 and only leave in the 'ret = 0' statement on an empty list. Signed-off-by: Ján Tomko --- src/interface/interface_backend_udev.c | 3 +-- 1 file changed, 1

[libvirt PATCH 0/2] minor cleanups in udevConnectListAllInterfaces

Ján Tomko (2): udevConnectListAllInterfaces: initialize ret udevConnectListAllInterfaces: delete pointless cleanup code src/interface/interface_backend_udev.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) -- 2.26.2

Re: regression in meson build, AC_PATH_PROG lost

On Fri, Nov 20, 2020 at 12:24:38PM +0100, Andrea Bolognani wrote: On Fri, 2020-11-20 at 01:19 +0100, Pavel Hrdina wrote: On Thu, Nov 19, 2020 at 11:38:28PM +0100, Martin Kletzander wrote: > Right now, IMHO, all meson checks for binaries that are not needed at build time > should be removed.

Re: Availability of physical devices and migration (was: Re: [RFC PATCH 2/2] vfio-ccw: Connect the device request notifier)

On Fri, 20 Nov 2020 12:38:37 +0100 Cornelia Huck wrote: > On Fri, 20 Nov 2020 03:51:07 +0100 > Halil Pasic wrote: > > > On Tue, 17 Nov 2020 04:26:05 +0100 > > Eric Farman wrote: > > > > > Now that the vfio-ccw code has a notifier interface to request that > > > a device be unplugged, let's

[PATCH v2] xen: recognize device_model_override

Since Xen 4.2 libxl expects device_model_override="/path" instead of device_model="/path". Adjust the code to parse this as . While libxl also recognizes device_model_version="", this knob is not required for libvirt. A runtime detection exists in libvirt to select either "qemu-xen" or

Re: regression in meson build, AC_PATH_PROG lost

On Fri, Nov 20, 2020 at 01:19:33AM +0100, Pavel Hrdina wrote: On Thu, Nov 19, 2020 at 11:38:28PM +0100, Martin Kletzander wrote: On Thu, Nov 19, 2020 at 10:31:00PM +0100, Olaf Hering wrote: > Am Thu, 19 Nov 2020 22:15:27 +0100 > schrieb Martin Kletzander : > > > Libvirt needs to be able to

Re: [PATCH 00/16] virsh: Add support for network disks to --attach-disk

On 11/19/20 1:26 PM, Peter Krempa wrote: This version refactors cmdAttachDisk first so that we can use a much simpler logic to format the XML. With the simpler logic and tests the code now doesn't misformat the XML in certain situations as it was with the previous posting: virsh attach-disk

Re: [libvirt PATCH 1/2] src: rework static analysis detection

On 11/16/20 10:36 AM, Pavel Hrdina wrote: > Inspired by QEMU code. > > Signed-off-by: Pavel Hrdina > --- > meson.build| 14 -- > src/internal.h | 4 > 2 files changed, 4 insertions(+), 14 deletions(-) > > diff --git a/meson.build b/meson.build > index

Re: [PATCH 01/16] tests: virsh: Add simple testsuite for using --print-xml of various commands

On 11/19/20 1:26 PM, Peter Krempa wrote: The test uses a script and compares the output against a template file VIR_TEST_REGENREATE_OUTPUT can be used on test failures. This test will A typo and ... a missing period perhaps? "... against a template file. VIR_TEST_REGENERATE_OUTPUT can be

Availability of physical devices and migration (was: Re: [RFC PATCH 2/2] vfio-ccw: Connect the device request notifier)

On Fri, 20 Nov 2020 03:51:07 +0100 Halil Pasic wrote: > On Tue, 17 Nov 2020 04:26:05 +0100 > Eric Farman wrote: > > > Now that the vfio-ccw code has a notifier interface to request that > > a device be unplugged, let's wire that together. > > I'm aware of the fact that performing an unplug

Re: Issue 90 Further Clarifications

On Fri, Nov 20, 2020 at 09:41:44 +, Daniel Berrange wrote: > On Thu, Nov 19, 2020 at 03:48:48PM -0600, Dustan B Helm wrote: > > [image: Dustan Helm] > > Dustan Helm @dustan.helm > > · just now >

Re: regression in meson build, AC_PATH_PROG lost

On Thu, 2020-11-19 at 16:56 -0500, Neal Gompa wrote: > On Fri, Nov 13, 2020 at 8:14 AM Andrea Bolognani wrote: > > As another data point, Debian currently carries a patch[1] which > > allows us to enable the ZFS driver without installing the ZFS > > packages in the build environment: this is

Re: regression in meson build, AC_PATH_PROG lost

On Fri, 2020-11-20 at 01:19 +0100, Pavel Hrdina wrote: > On Thu, Nov 19, 2020 at 11:38:28PM +0100, Martin Kletzander wrote: > > Right now, IMHO, all meson checks for binaries that are not needed at build > > time > > should be removed. During runtime we can just use the name of the binary. > >

Re: [libvirt PATCH v2 0/3] network: Drop UUID handling for default network

On Thu, 2020-11-19 at 11:03 -0500, Laine Stump wrote: > On 11/19/20 10:36 AM, Andrea Bolognani wrote: > > Andrea Bolognani (3): > >conf: Write network config to disk after generating UUID > >network: Drop UUID handling for default network > >spec: Drop UUID handling for default network

Plans for the next release

We are getting close to the last release of libvirt in 2020. To aim for the release on Dec 01 I suggest entering the freeze on Wednesday Nov 25 and tagging RC2 on Friday Nov 27. I hope this works for everyone. Jirka

Re: [libvirt][RFC PATCH] add a new 'default' option for attribute mode in numatune

On Fri, Nov 20, 2020 at 01:17:29PM +0800, Zhong, Luyao wrote: On 11/18/2020 8:42 PM, Martin Kletzander wrote: So let's finish this sooner rather than later.  Let's remove the "migratable/movable" attribute and add another mode for the way memory allocations are going to be treated.  But let's

Re: Issue 90 Further Clarifications

On Thu, Nov 19, 2020 at 03:48:48PM -0600, Dustan B Helm wrote: > [image: Dustan Helm] > Dustan Helm @dustan.helm > · just now > >

Re: [PATCH v2] selinux label: restore all labels when some labels fail to set

On 2020/11/20 15:49, Michal Privoznik wrote: On 11/19/20 3:54 PM, Jin Yan wrote: On 2020/11/13 22:33, Michal Privoznik wrote: On 11/13/20 10:47 AM, Jin Yan wrote: Hi Michal, I found this problem while performing migration, based on       libvirt version: 6.2.0       SELinux mode:

Re: [libvirt PATCH v2 0/2] Switch our build repo CI recipes in the ci subdirectory to meson

On Mon, Nov 09, 2020 at 12:20:51PM +0100, Erik Skultety wrote: > Since v1: > - honor MESON_OPTS from our cross containers > - remove several more variables > - shuffle the patches a bit > > Erik Skultety (2): > ci: Switch to meson build system > ci: Drop env variables related to autotools and