Re: Issue 90 Further Clarifications

On Mon, Nov 23, 2020 at 17:17:15 -0600, Dustan B Helm wrote: > On Mon, Nov 23, 2020 at 2:33 AM Peter Krempa wrote: > > > On Sat, Nov 21, 2020 at 11:20:57 -0600, Dustan B Helm wrote: > > > We plan to support NFS protocol according to the example XML from Issue > > 90 > > >

[PATCH 6/8] util: always check for ebtables/iptables binaries, even when using firewalld

Even though *we* don't call ebtables/iptables/ip6tables (yet) when the firewalld backend is selected, firewalld does, so these binaries need to be there; let's check for them. (Also, the patch after this one is going to start execing those binaries directly rather than via firewalld).

[PATCH 4/8] tests: fix iptables test case commandline options in virfirewalltest.c

This test was created with all the commandlines erroneously having "--source-host", which is not a valid iptables option. The correct name for the option is "--source". However, since the test is just checking that the generated commandline matches what we told it to generate (and never actually

[PATCH 3/8] util/tests: enable locking on iptables/ebtables commandlines by default

iptables and ip6tables have had a "-w" commandline option to grab a systemwide lock that prevents two iptables invocations from modifying the iptables chains since 2013 (upstream commit 93587a04 in iptables-1.4.20). Similarly, ebtables has had a "--concurrent" commandline option for the same

[PATCH 7/8] util: synchronize with firewalld before we start calling iptables directly

When it is starting up, firewalld will delete all existing iptables rules and chains before adding its own rules. If libvirtd were to try to directly add iptables rules during the time before firewalld has finished initializing, firewalld would end up deleting the rules that libvirtd has just

[PATCH 1/8] util: fix typo in VIR_MOCK_WRAP_RET_ARGS()

(This is the most inconsequential of inconsequential typos, but the incongruity was bugging me.) When virfirewalltest.c was first written in commit 3a0ca7de51 (March 2013), a conditional accidentally tested for "ipv4" instead of "ipv6". Since the file ended up only testing ipv4 rules, this has

[PATCH 8/8] util: call iptables directly rather than via firewalld

When libvirt added support for firewalld, we were unable to use firewalld's higher level rules, because they weren't detailed enough and could not be applied to the iptables FORWARD or OUTPUT chains (only to the INPUT chain). Instead we changed our code so that rather than running the

[PATCH 5/8] network: be more verbose about the reason for a firewall reload

Signed-off-by: Laine Stump --- src/network/bridge_driver.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 5d9b9eaa4f..fdad2191e6 100644 --- a/src/network/bridge_driver.c +++

[PATCH 0/8] run iptables directly rather than via firewalld

The reasoning for this is explained in Patch 8/8 Laine Stump (8): util: fix typo in VIR_MOCK_WRAP_RET_ARGS() util/tests: enable locking on iptables/ebtables commandlines in unit tests util/tests: enable locking on iptables/ebtables commandlines by default tests: fix iptables test

Re: Issue 90 Further Clarifications

On Mon, Nov 23, 2020 at 2:33 AM Peter Krempa wrote: > On Sat, Nov 21, 2020 at 11:20:57 -0600, Dustan B Helm wrote: > > We plan to support NFS protocol according to the example XML from Issue > 90 > > . Since there is already > > support for network

Re: [PATCH] util: convert char pointers to use g_autofree

Updated the patch with the suggested changes. The last commit for the new patch is https://www.redhat.com/archives/libvir-list/2020-November/msg01324.html. On Fri, Nov 20, 2020 at 2:55 PM Laine Stump wrote: > On 11/20/20 11:43 AM, Barrett J Schonefeld wrote: > > I appreciate the feedback on

[PATCH v2 4/6] ci: Run test suite on macOS

There's no need to have different CI process between macOS and FreeBSD as test suite has been fixed on macOS. Signed-off-by: Roman Bolshakov --- ci/cirrus/build.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ci/cirrus/build.yml b/ci/cirrus/build.yml index

[PATCH v2 0/6] Final changes to fix test suite on macOS

The set of changes fixes qemuxml2argvtest and closes issue #58. Changes since v1: - Simplified lookup of symbols in main executable (Michal) - Reduced timeout to 90s for qemuxml2argvtest (Andrea) - Two new patches to fix qemucapsprobe Pipeline results:

[PATCH 25/30] util: remove cleanup labels

From: Barrett Schonefeld - src/util/virsecret.c Signed-off-by: Barrett Schonefeld --- src/util/virsecret.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/util/virsecret.c b/src/util/virsecret.c index 78a3b41bc5..9ed803d45b 100644 ---

[PATCH v2 1/6] tests: Fix opendir mocks on macOS

opendir() mocks need to search for decorated function with $INODE64 suffix, like stat mocks. Reviewed-by: Michal Privoznik Signed-off-by: Roman Bolshakov --- tests/virfilewrapper.c | 4 tests/virpcimock.c | 4 2 files changed, 8 insertions(+) diff --git a/tests/virfilewrapper.c

[PATCH 04/30] util: convert pointers to use g_autofree

From: Barrett Schonefeld - src/util/viruri.c Signed-off-by: Barrett Schonefeld --- src/util/viruri.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/util/viruri.c b/src/util/viruri.c index 11753a0aef..704e5b2132 100644 --- a/src/util/viruri.c +++ b/src/util/viruri.c

[PATCH 19/30] util: convert pointers to use g_autofree

From: Barrett Schonefeld - src/util/vircgroupv1.c Signed-off-by: Barrett Schonefeld --- src/util/vircgroupv1.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/util/vircgroupv1.c b/src/util/vircgroupv1.c index 731e9d61d4..984cd50409 100644 --- a/src/util/vircgroupv1.c

[PATCH v2 3/6] qemuxml2argvtest: Increase timeout on macOS

The test takes 40+ seconds on MBP 2012, MBA 2015. Cirrus completes the test within default timeout, just above 29 seconds but the error margin is narrow, under a second. It'd be good to provide reasonable default timeout to avoid test suite failure if "meson test" is invoked without arguments.

[PATCH v2 6/6] qemucapsprobemock: Fix lookup of qemu functions

qemucapsprobemock can't find real versions of qemuMonitorSend() and qemuMonitorJSONIOProcessLine() on macOS. That breaks qemucapsprobe. The failure can be explained by documented behaviour of dlsym(3) on macOS: If dlsym() is called with the special handle RTLD_NEXT, then dyld searches for

[PATCH 14/30] util: convert pointers to use g_autofree

From: Barrett Schonefeld - src/util/virlog.c Signed-off-by: Barrett Schonefeld --- src/util/virlog.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/util/virlog.c b/src/util/virlog.c index 6b7a4512e9..e12fd58831 100644 --- a/src/util/virlog.c +++

[PATCH 29/30] util: remove cleanup labels

From: Barrett Schonefeld - src/util/virlog.c Signed-off-by: Barrett Schonefeld --- src/util/virlog.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/util/virlog.c b/src/util/virlog.c index e12fd58831..2bf606b8c5 100644 --- a/src/util/virlog.c +++

[PATCH 24/30] util: remove cleanup labels

From: Barrett Schonefeld - src/util/virstorageencryption.c Signed-off-by: Barrett Schonefeld --- src/util/virstorageencryption.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/util/virstorageencryption.c b/src/util/virstorageencryption.c index

[PATCH 08/30] util: convert pointers to use g_autofree

From: Barrett Schonefeld - src/util/virsecret.c Signed-off-by: Barrett Schonefeld --- src/util/virsecret.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/util/virsecret.c b/src/util/virsecret.c index 54d6bbcb7c..78a3b41bc5 100644 --- a/src/util/virsecret.c +++

[PATCH 26/30] util: remove cleanup labels

From: Barrett Schonefeld - src/util/virscsihost.c Signed-off-by: Barrett Schonefeld --- src/util/virscsihost.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/util/virscsihost.c b/src/util/virscsihost.c index 2ce33e4cfb..3aecb3146f 100644 ---

[PATCH 30/30] util: remove cleanup labels

From: Barrett Schonefeld - src/util/virdnsmasq.c Signed-off-by: Barrett Schonefeld --- src/util/virdnsmasq.c | 46 +-- 1 file changed, 14 insertions(+), 32 deletions(-) diff --git a/src/util/virdnsmasq.c b/src/util/virdnsmasq.c index

[PATCH 15/30] util: convert pointers to use g_autofree

From: Barrett Schonefeld - src/util/virlockspace.c Signed-off-by: Barrett Schonefeld --- src/util/virlockspace.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/util/virlockspace.c b/src/util/virlockspace.c index b90e13f506..71d5dfb83e 100644 ---

[PATCH 27/30] util: remove cleanup labels

From: Barrett Schonefeld - src/util/virrotatingfile.c Signed-off-by: Barrett Schonefeld --- src/util/virrotatingfile.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/util/virrotatingfile.c b/src/util/virrotatingfile.c index 6d8076e7c4..45dc66e94d 100644 ---

[PATCH 01/30] util: convert pointers to use g_autofree

From: Barrett Schonefeld - src/util/virxml.c Signed-off-by: Barrett Schonefeld --- src/util/virxml.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/util/virxml.c b/src/util/virxml.c index a3b819d85c..7df50e4b4d 100644 --- a/src/util/virxml.c +++

[PATCH v2 5/6] tests: Delay mock creation

There might be mocks that need to reference qemu test driver and link with it. It's not possible now because qemu test driver is defined after mocks. While at it, add 'link_with' parameter to mock definition that allows to specify a set of libraries the mock has to be linked with. Signed-off-by:

[PATCH v2 2/6] tests: Fix mock chaining on macOS

Some tests in qemuxml2argvtest need opendir() from virpcimock, others need opendir() from virfilewrapper. But as of now, only opendir() from virpcimock has an effect. real_opendir in virpcimock has a pointer to opendir$INODE64 in libsystem_kernel.dylib instead of pointing to opendir$INODE64 in

[PATCH 06/30] util: convert pointers to use g_autofree

From: Barrett Schonefeld - src/util/virstoragefilebackend.c Signed-off-by: Barrett Schonefeld --- src/util/virstoragefilebackend.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/util/virstoragefilebackend.c b/src/util/virstoragefilebackend.c index

[PATCH 09/30] util: convert pointers to use g_autofree

From: Barrett Schonefeld - src/util/virscsihost.c Signed-off-by: Barrett Schonefeld --- src/util/virscsihost.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/src/util/virscsihost.c b/src/util/virscsihost.c index 969cdd9f79..2ce33e4cfb 100644 ---

[PATCH 17/30] util: convert pointers to use g_autofree

From: Barrett Schonefeld - src/util/virfile.c Signed-off-by: Barrett Schonefeld --- src/util/virfile.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/util/virfile.c b/src/util/virfile.c index f57272ca2f..38207f1948 100644 --- a/src/util/virfile.c +++

[PATCH 21/30] util: remove cleanup label

From: Barrett Schonefeld - src/util/virutil.c Signed-off-by: Barrett Schonefeld --- src/util/virutil.c | 45 - 1 file changed, 16 insertions(+), 29 deletions(-) diff --git a/src/util/virutil.c b/src/util/virutil.c index d4b864d5cb..52ab6c6e6d

[PATCH 23/30] util: remove error label

From: Barrett Schonefeld - src/util/virsysinfo.c Signed-off-by: Barrett Schonefeld --- src/util/virsysinfo.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/util/virsysinfo.c b/src/util/virsysinfo.c index 36317c97eb..45a950c85a 100644 --- a/src/util/virsysinfo.c

[PATCH 22/30] util: remove cleanup labels

From: Barrett Schonefeld - src/util/viruri.c Signed-off-by: Barrett Schonefeld --- src/util/viruri.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/util/viruri.c b/src/util/viruri.c index 704e5b2132..d49821451e 100644 --- a/src/util/viruri.c +++ b/src/util/viruri.c

[PATCH 12/30] util: convert pointers to use g_autofree

From: Barrett Schonefeld - src/util/virnetdevbandwidth.c Signed-off-by: Barrett Schonefeld --- src/util/virnetdevbandwidth.c | 44 --- 1 file changed, 15 insertions(+), 29 deletions(-) diff --git a/src/util/virnetdevbandwidth.c b/src/util/virnetdevbandwidth.c

[PATCH 16/30] util: convert pointers to use g_autofree

From: Barrett Schonefeld - src/util/virhostcpu.c Signed-off-by: Barrett Schonefeld --- src/util/virhostcpu.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/util/virhostcpu.c b/src/util/virhostcpu.c index c531d65f86..4f6c3390ce 100644 --- a/src/util/virhostcpu.c +++

[PATCH 13/30] util: convert pointers to use g_autofree

From: Barrett Schonefeld - src/util/virmacmap.c Signed-off-by: Barrett Schonefeld --- src/util/virmacmap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/util/virmacmap.c b/src/util/virmacmap.c index f9047d0fb1..e68742de10 100644 --- a/src/util/virmacmap.c +++

[PATCH 18/30] util: convert pointers to use g_autofree

From: Barrett Schonefeld - src/util/virdnsmasq.c Signed-off-by: Barrett Schonefeld --- src/util/virdnsmasq.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/src/util/virdnsmasq.c b/src/util/virdnsmasq.c index 9030f9218a..5f477c976d 100644 ---

[PATCH 11/30] util: convert pointers to use g_autofree

From: Barrett Schonefeld - src/util/virresctrl.c Signed-off-by: Barrett Schonefeld --- src/util/virresctrl.c | 25 - 1 file changed, 8 insertions(+), 17 deletions(-) diff --git a/src/util/virresctrl.c b/src/util/virresctrl.c index d3087b98c1..1c2d175295 100644 ---

[PATCH 20/30] util: remove cleanup label

From: Barrett Schonefeld - src/util/virvhba.c Signed-off-by: Barrett Schonefeld --- src/util/virvhba.c | 24 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/src/util/virvhba.c b/src/util/virvhba.c index a80145b8fd..e0a79344cc 100644 ---

[PATCH 28/30] util: remove cleanup labels

From: Barrett Schonefeld - src/util/virnetdevbandwidth.c Signed-off-by: Barrett Schonefeld --- src/util/virnetdevbandwidth.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/util/virnetdevbandwidth.c b/src/util/virnetdevbandwidth.c index 364b39e3c1..e222bcd6a2

[PATCH 10/30] util: convert pointers to use g_autofree

From: Barrett Schonefeld - src/util/virrotatingfile.c Signed-off-by: Barrett Schonefeld --- src/util/virrotatingfile.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/util/virrotatingfile.c b/src/util/virrotatingfile.c index 9f1ef17c3e..6d8076e7c4 100644 ---

[PATCH 07/30] util: convert pointers to use g_autofree

From: Barrett Schonefeld - src/util/virstorageencryption.c Signed-off-by: Barrett Schonefeld --- src/util/virstorageencryption.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/src/util/virstorageencryption.c b/src/util/virstorageencryption.c index

[PATCH 02/30] util: convert pointers to use g_autofree

From: Barrett Schonefeld - src/util/virvhba.c Signed-off-by: Barrett Schonefeld --- src/util/virvhba.c | 35 --- 1 file changed, 12 insertions(+), 23 deletions(-) diff --git a/src/util/virvhba.c b/src/util/virvhba.c index a4e88024d1..a80145b8fd 100644 ---

[PATCH 05/30] util: convert pointers to use g_autofree

From: Barrett Schonefeld - src/util/virsysinfo.c Signed-off-by: Barrett Schonefeld --- src/util/virsysinfo.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/src/util/virsysinfo.c b/src/util/virsysinfo.c index 217f842a37..36317c97eb 100644 ---

[PATCH 03/30] util: convert pointers to use g_autofree

From: Barrett Schonefeld - src/util/virutil.c Signed-off-by: Barrett Schonefeld --- src/util/virutil.c | 33 ++--- 1 file changed, 10 insertions(+), 23 deletions(-) diff --git a/src/util/virutil.c b/src/util/virutil.c index a0cd0f1bcd..d4b864d5cb 100644 ---

[PATCH v3 2/2] schema: add support for Windows file paths and device names

Signed-off-by: Matt Coleman --- docs/schemas/basictypes.rng | 2 +- docs/schemas/domaincommon.rng | 5 +++- .../disk-hyperv-physical.xml | 17 ++ .../disk-hyperv-virtual.xml | 17 ++

[PATCH v3 0/2] hyperv: storage volume XML changes

Changes since v2: * raise an error if the parent device cannot be located * correct the disk count and use constants instead of magic numbers Here's a GitLab MR if you'd prefer to review it there: https://gitlab.com/iammattcoleman/libvirt/-/merge_requests/12/commits This link shows a diff

[PATCH v3 1/2] hyperv: XML parsing of storage volumes

dumpxml can now serialize: * floppy drives * file-backed and device-backed disk drives * images mounted to virtual CD/DVD drives * IDE and SCSI controllers Co-authored-by: Sri Ramanujam Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c| 425 +-

Re: regression in meson build, AC_PATH_PROG lost

On Mon, Nov 23, 2020 at 11:24 AM Andrea Bolognani wrote: > > On Fri, 2020-11-20 at 08:51 -0500, Neal Gompa wrote: > > On Fri, Nov 20, 2020 at 6:25 AM Andrea Bolognani > > wrote: > > > On Thu, 2020-11-19 at 16:56 -0500, Neal Gompa wrote: > > > > The way I solved *that* specific problem was to

RE: Libvirt NVME support

> -Original Message- > From: Peter Krempa > Sent: 23 November 2020 17:47 > To: Thanos Makatos > Cc: Suraj Kasi ; libvirt-l...@redhat.com; John Levon > > Subject: Re: Libvirt NVME support > > On Mon, Nov 23, 2020 at 17:40:58 +, Thanos Makatos wrote: > > > > > > > -Original

Re: Libvirt NVME support

On Mon, Nov 23, 2020 at 17:40:58 +, Thanos Makatos wrote: > > > > -Original Message- > > From: Peter Krempa > > Sent: 23 November 2020 16:56 > > To: Thanos Makatos > > Cc: Suraj Kasi ; libvirt-l...@redhat.com; John Levon > > > > Subject: Re: Libvirt NVME support > > > > On Mon,

RE: Libvirt NVME support

> -Original Message- > From: Peter Krempa > Sent: 23 November 2020 16:56 > To: Thanos Makatos > Cc: Suraj Kasi ; libvirt-l...@redhat.com; John Levon > > Subject: Re: Libvirt NVME support > > On Mon, Nov 23, 2020 at 16:48:55 +, Thanos Makatos wrote: > > > On Mon, Nov 23, 2020 at

[libvirt PATCH v3] ci: Switch to meson build system

Add meson required bits to the ci logic in the repo to be able to run a meson build in a container. This patch also drops a few environment variables we don't need with meson anymore. Signed-off-by: Erik Skultety --- v2: https://www.redhat.com/archives/libvir-list/2020-November/msg00380.html

Re: [libvirt PATCH v2 1/2] ci: Switch to meson build system

On Fri, Nov 20, 2020 at 04:29:18PM +0100, Andrea Bolognani wrote: > On Mon, 2020-11-09 at 12:20 +0100, Erik Skultety wrote: > > First add the meson required bits to be able to run the build. > > NOTE: inspired by our gitlab-ci.yml > > This note seems unnecessary. > > > +++ b/ci/Makefile > > @@

RE: Libvirt NVME support

> -Original Message- > From: Peter Krempa > Sent: 23 November 2020 15:20 > To: Daniel P. Berrangé > Cc: Michal Prívozník ; Thanos Makatos > ; Suraj Kasi ; > libvirt-l...@redhat.com; John Levon > Subject: Re: Libvirt NVME support > > On Mon, Nov 23, 2020 at 15:01:31 +, Daniel

Re: Libvirt NVME support

On Mon, Nov 23, 2020 at 16:48:55 +, Thanos Makatos wrote: > > On Mon, Nov 23, 2020 at 13:07:51 +, Thanos Makatos wrote: > > > > > > > On Mon, Nov 23, 2020 at 09:47:23 +, Thanos Makatos wrote: > > > > > > On Thu, Nov 19, 2020 at 10:17:56 +, Thanos Makatos wrote: > > > > > > > > > >

RE: Libvirt NVME support

> On Mon, Nov 23, 2020 at 13:07:51 +, Thanos Makatos wrote: > > > > > On Mon, Nov 23, 2020 at 09:47:23 +, Thanos Makatos wrote: > > > > > On Thu, Nov 19, 2020 at 10:17:56 +, Thanos Makatos wrote: > > > > > > > As a starting point a trivial way to model this in the XML will > > > > > >

Re: regression in meson build, AC_PATH_PROG lost

On Fri, 2020-11-20 at 19:32 +0100, Pavel Hrdina wrote: > On Fri, Nov 20, 2020 at 06:49:15PM +0100, Andrea Bolognani wrote: > > In my opinion this move would place a significant burden upon > > downstreams and users while taking very little burden away from > > upstream developers because,

Re: regression in meson build, AC_PATH_PROG lost

On Fri, 2020-11-20 at 08:51 -0500, Neal Gompa wrote: > On Fri, Nov 20, 2020 at 6:25 AM Andrea Bolognani wrote: > > On Thu, 2020-11-19 at 16:56 -0500, Neal Gompa wrote: > > > The way I solved *that* specific problem was to use zfs-fuse at > > > build-time and have runtime work with either

Re: [PATCH 4/4] ci: Run test suite on macOS

On Mon, 2020-11-23 at 16:46 +0300, Roman Bolshakov wrote: > My intention with the patch was to remove the difference (skipping tests > on macOS) that is no longer needed. FreeBSD had the most concise > invocation, so I kept it. > > It's not trouble for me to update it to "meson dist" [1] if you

Re: [PATCH v2 1/2] hyperv: XML parsing of storage volumes

On Thu, Nov 19, 2020 at 07:33:29PM -0500, Matt Coleman wrote: > dumpxml can now serialize: > * floppy drives > * file-backed and device-backed disk drives > * images mounted to virtual CD/DVD drives > * IDE and SCSI controllers > > Co-authored-by: Sri Ramanujam > Signed-off-by: Matt Coleman >

Re: Libvirt NVME support

On Mon, Nov 23, 2020 at 15:01:31 +, Daniel Berrange wrote: > On Mon, Nov 23, 2020 at 03:36:42PM +0100, Peter Krempa wrote: > > On Mon, Nov 23, 2020 at 15:32:20 +0100, Michal Privoznik wrote: [...] > > No, the NVMe controller lives on PCIe. Here we are trying to emulate a > > NVMe controller

Re: [PATCH 0/2] hyperv: storage volume XML changes

On Wed, Nov 18, 2020 at 01:48:23PM -0500, Matt Coleman wrote: > Here's a GitLab MR if you'd prefer to review it there: > https://gitlab.com/iammattcoleman/libvirt/-/merge_requests/12/commits > > Matt Coleman (2): > hyperv: XML parsing of storage volumes > schema: add support for Windows file

Re: Libvirt NVME support

On Mon, Nov 23, 2020 at 03:36:42PM +0100, Peter Krempa wrote: > On Mon, Nov 23, 2020 at 15:32:20 +0100, Michal Privoznik wrote: > > On 11/23/20 3:03 PM, Daniel P. Berrangé wrote: > > > On Wed, Nov 18, 2020 at 11:24:30AM +0100, Peter Krempa wrote: > > > > On Wed, Nov 18, 2020 at 09:57:14 +,

Re: [libvirt PATCH 0/3] Add missing feature detection to sync tool in cpu_map

On Wed, 2020-11-18 at 12:19 +0100, Tim Wiederhake wrote: > sync_qemu_i386.py in src/cpu_map is a tool to sync CPU models from > qemu > with libvirt. It currently has no provisions for detecting new > features > that are not implemented in libvirt yet. This series changes that. > > See also >

Re: Libvirt NVME support

On Mon, Nov 23, 2020 at 15:32:20 +0100, Michal Privoznik wrote: > On 11/23/20 3:03 PM, Daniel P. Berrangé wrote: > > On Wed, Nov 18, 2020 at 11:24:30AM +0100, Peter Krempa wrote: > > > On Wed, Nov 18, 2020 at 09:57:14 +, Thanos Makatos wrote: > > > > > As a separate question, is there any

Re: Libvirt NVME support

On Mon, Nov 23, 2020 at 03:32:20PM +0100, Michal Prívozník wrote: > On 11/23/20 3:03 PM, Daniel P. Berrangé wrote: > > On Wed, Nov 18, 2020 at 11:24:30AM +0100, Peter Krempa wrote: > > > On Wed, Nov 18, 2020 at 09:57:14 +, Thanos Makatos wrote: > > > > > As a separate question, is there any

Re: Libvirt NVME support

On 11/23/20 3:03 PM, Daniel P. Berrangé wrote: On Wed, Nov 18, 2020 at 11:24:30AM +0100, Peter Krempa wrote: On Wed, Nov 18, 2020 at 09:57:14 +, Thanos Makatos wrote: As a separate question, is there any performance benefit of emulating a NVMe controller compared to e.g. virtio-scsi? We

[libvirt PATCH v3 09/10] cpu_map: Add support for split-lock-detect CPU feature

Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 5 + 1 file changed, 5 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index a5a987deba..4836595a8c 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -581,4

[libvirt PATCH v3 10/10] cpu_map: Define and enable Snowridge model

Signed-off-by: Tim Wiederhake --- src/cpu_map/index.xml | 1 + src/cpu_map/meson.build | 1 + src/cpu_map/x86_Snowridge.xml | 71 +++ .../domaincapsdata/qemu_4.1.0-q35.x86_64.xml | 1 +

[libvirt PATCH v3 08/10] cpu_map: Add support for core-capability CPU feature

Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index b0bf22d916..a5a987deba 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -357,6

[libvirt PATCH v3 07/10] cpu_map: Add support for fsrm CPU feature

Signed-off-by: Tim Wiederhake --- src/cpu_map/x86_features.xml | 3 +++ tests/cputestdata/x86_64-cpuid-Ice-Lake-Server-guest.xml | 1 + tests/cputestdata/x86_64-cpuid-Ice-Lake-Server-host.xml | 1 + 3 files changed, 5 insertions(+) diff --git

[libvirt PATCH v3 06/10] cpu_map: sync_qemu_cpu_i386: Detect features missing in libvirt

Signed-off-by: Tim Wiederhake --- src/cpu_map/sync_qemu_i386.py | 17 + 1 file changed, 17 insertions(+) diff --git a/src/cpu_map/sync_qemu_i386.py b/src/cpu_map/sync_qemu_i386.py index 83b21a93e5..d2a05db77c 100755 --- a/src/cpu_map/sync_qemu_i386.py +++

[libvirt PATCH v3 05/10] cpu_map: sync_qemu_cpu_i386: Add missing features to translation table

Signed-off-by: Tim Wiederhake --- src/cpu_map/sync_qemu_i386.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/cpu_map/sync_qemu_i386.py b/src/cpu_map/sync_qemu_i386.py index acf27d2bec..83b21a93e5 100755 --- a/src/cpu_map/sync_qemu_i386.py +++ b/src/cpu_map/sync_qemu_i386.py @@ -31,6

[libvirt PATCH v3 04/10] cpu_map: sync_qemu_cpu_i386: Simplify ignore features

Signed-off-by: Tim Wiederhake --- src/cpu_map/sync_qemu_i386.py | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/src/cpu_map/sync_qemu_i386.py b/src/cpu_map/sync_qemu_i386.py index 93630f1a55..acf27d2bec 100755 --- a/src/cpu_map/sync_qemu_i386.py +++

[libvirt PATCH v3 02/10] cpu_map: sync_qemu_cpu_i386: Factor out translation of features

Signed-off-by: Tim Wiederhake --- src/cpu_map/sync_qemu_i386.py | 289 +- 1 file changed, 148 insertions(+), 141 deletions(-) diff --git a/src/cpu_map/sync_qemu_i386.py b/src/cpu_map/sync_qemu_i386.py index f86cdf969f..53b27773e4 100755 ---

[libvirt PATCH v3 01/10] cpu_map: sync_qemu_cpu_i386: Factor out translation of vendors

Signed-off-by: Tim Wiederhake --- src/cpu_map/sync_qemu_i386.py | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/src/cpu_map/sync_qemu_i386.py b/src/cpu_map/sync_qemu_i386.py index 8deda869df..f86cdf969f 100755 --- a/src/cpu_map/sync_qemu_i386.py +++

[libvirt PATCH v3 03/10] cpu_map: sync_qemu_cpu_i386: Translate features in model versions

If a feature is added (or removed) in a QEMU CPU model version, we get to see the QEMU pretty name for the feature, not the name of the macro. Signed-off-by: Tim Wiederhake --- src/cpu_map/sync_qemu_i386.py | 9 + 1 file changed, 9 insertions(+) diff --git

[libvirt PATCH v3 00/10] Add missing feature detection to sync tool in cpu_map

sync_qemu_i386.py in src/cpu_map is a tool to sync CPU models from qemu with libvirt. It currently has no provisions for detecting new features that are not implemented in libvirt yet. This series changes that. Currently missing x86 CPU models: * "Denverton" * "KnightsMill" * "Snowridge"

Re: Libvirt NVME support

On Wed, Nov 18, 2020 at 11:24:30AM +0100, Peter Krempa wrote: > On Wed, Nov 18, 2020 at 09:57:14 +, Thanos Makatos wrote: > > > As a separate question, is there any performance benefit of emulating a > > > NVMe controller compared to e.g. virtio-scsi? > > > > We haven't measured that yet; I

Re: [PATCH 4/4] ci: Run test suite on macOS

On Fri, Nov 20, 2020 at 08:10:57AM +0100, Michal Privoznik wrote: > On 11/13/20 8:08 PM, Andrea Bolognani wrote: > > On Fri, 2020-11-13 at 16:58 +0100, Michal Privoznik wrote: > > > On 11/8/20 10:24 PM, Roman Bolshakov wrote: > > > > -- if test "$(uname)" = "FreeBSD"; then ninja -C build dist;

[PATCH 2/2] qemu: checkpoint: Write metadata of previously-'current' checkpoint on update

Similarly to previous commit dealing with snapshots we must rewrite the metadata of the previously-'current' checkpoint when changing which checkpoint is considered 'current'. Signed-off-by: Peter Krempa --- src/qemu/qemu_checkpoint.c | 35 +-- 1 file changed, 33

[PATCH 1/2] qemu: snapshot: Write metadata of previously-'current' snapshot on update

Whether a snapshot definition is considered 'current' or active is stored in the metadata XML libvirt writes when we create metadata. This means that if we are changing the 'current' snapshot we must re-write the metadata of the previously 'current' snapshot to update the field to prevent having

[PATCH 0/2] qemu: Fix setting of 'current' checkpoint/snapshot

See patch 1 Peter Krempa (2): qemu: snapshot: Write metadata of previously-'current' snapshot on update qemu: checkpoint: Write metadata of previously-'current' checkpoint on update src/qemu/qemu_checkpoint.c | 35 +-- src/qemu/qemu_snapshot.c | 38

Re: Libvirt NVME support

On Mon, Nov 23, 2020 at 13:07:51 +, Thanos Makatos wrote: > > > On Mon, Nov 23, 2020 at 09:47:23 +, Thanos Makatos wrote: > > > > On Thu, Nov 19, 2020 at 10:17:56 +, Thanos Makatos wrote: > > > > > > As a starting point a trivial way to model this in the XML will be: > > > > > > > > >

RE: Libvirt NVME support

> On Mon, Nov 23, 2020 at 09:47:23 +, Thanos Makatos wrote: > > > On Thu, Nov 19, 2020 at 10:17:56 +, Thanos Makatos wrote: > > > > > As a starting point a trivial way to model this in the XML will be: > > > > > > > > > > > > > > > > > > > > And then add the storage into it as: > >

Re: [libvirt PATCH 0/8] Drop 'monitor' from modern x86 CPU models

On Mon, Nov 23, 2020 at 10:15:11 +, Daniel P. Berrangé wrote: > On Fri, Nov 20, 2020 at 08:38:59PM +0100, Jiri Denemark wrote: > > Doing so would normally break migration to older libvirt, but most of > > the patches in this series prepare an infrastructure for removing > > features from

Re: [PATCH] virDomainAuthorizedSSHKeysSet: Use uint for @nkeys

On Mon, Nov 23, 2020 at 01:15:28PM +0100, Michal Privoznik wrote: > When introducing the API I've mistakenly used 'int' type for > @nkeys argument which does nothing more than tells the API how > many items there are in @keys array. Obviously, negative values > are not expected and therefore

[PATCH] virDomainAuthorizedSSHKeysSet: Use uint for @nkeys

When introducing the API I've mistakenly used 'int' type for @nkeys argument which does nothing more than tells the API how many items there are in @keys array. Obviously, negative values are not expected and therefore 'unsigned int' should have been used. Reported-by: Daniel P. Berrangé

Re: [libvirt][RFC PATCH] add a new 'default' option for attribute mode in numatune

On Mon, Nov 23, 2020 at 05:02:31PM +0800, Zhong, Luyao wrote: On 11/20/2020 6:08 PM, Martin Kletzander wrote: On Fri, Nov 20, 2020 at 01:17:29PM +0800, Zhong, Luyao wrote: On 11/18/2020 8:42 PM, Martin Kletzander wrote: So let's finish this sooner rather than later.  Let's remove the

Re: [PATCH v3 1/6] Introduce OpenSSH authorized key file mgmt APIs

On 11/23/20 12:50 PM, Daniel P. Berrangé wrote: On Wed, Nov 18, 2020 at 02:34:19PM +0100, Michal Privoznik wrote: When setting up a new guest or when a management software wants to allow access to an existing guest the virDomainSetUserPassword() API can be used, but that might be not good

Re: [PATCH v3 1/6] Introduce OpenSSH authorized key file mgmt APIs

On Wed, Nov 18, 2020 at 02:34:19PM +0100, Michal Privoznik wrote: > When setting up a new guest or when a management software wants > to allow access to an existing guest the > virDomainSetUserPassword() API can be used, but that might be not > good enough if user want to ssh into the guest. Not

[PATCH 5/5] qemuDomainSnapshotForEachQcow2: Pass in 'def' rather than selecting it internally

In some cases such as when creating an internal inactive snapshot we know that the domain definition in the snapshot is equivalent to the current definition. Additionally we set up the current definition for the snapshotting but not the one contained in the snapshot. Thus in some cases the caller

[PATCH 3/5] qemuDomainSnapshotForEachQcow2Raw: Avoid a level of indentation

'continue' the loop if the device is not a disk. Saving the level makes one of the error messages fit on a single line. Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 73 +- 1 file changed, 36 insertions(+), 37 deletions(-) diff --git

[PATCH 4/5] qemuDomainSnapshotForEachQcow2Raw: Lock out operation on unsupported storage

Don't try to manipulate snapshots on network or unresolved volume backed storage. Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index c8f721b00d..c782810839 100644 ---

[PATCH 2/5] virDomainDiskTranslateSourcePool: Don't break error message in half

Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 2393bf6a37..b1534dcc1e 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -32847,8 +32847,7 @@

[PATCH 1/5] virCommandAddArg: Don't abort on invalid input

Commit 912c6b22fc622cd7c7d29c7f8eaeb816b266daac added abort() when the 'val' parameter is NULL along with setting the error variable for the command. We don't want to abort in this case, just set the error. Signed-off-by: Peter Krempa --- src/util/vircommand.c | 2 +- 1 file changed, 1

  1   2   >