Re: [PATCH 0/3] gitlab: Add issue templates

2020-11-26 Thread Daniel P . Berrangé
On Thu, Nov 26, 2020 at 02:23:17PM +0100, Peter Krempa wrote: > Gitlab allows projects to define templates for filing issues [1]. > Libvirt didn't have them yet. We can use them to encourage users to > file better bug reports and feature requests. > > You can test-drive the proposed templates in

Re: [PATCH 0/3] gitlab: Add issue templates

2020-11-26 Thread Daniel Henrique Barboza
On 11/26/20 10:23 AM, Peter Krempa wrote: Gitlab allows projects to define templates for filing issues [1]. Libvirt didn't have them yet. We can use them to encourage users to file better bug reports and feature requests. You can test-drive the proposed templates in my test repo:

Re: [PATCH 06/11] hyperv: attach virtual disks when defining domains

2020-11-26 Thread Daniel P . Berrangé
On Tue, Nov 24, 2020 at 02:48:35PM -0500, Matt Coleman wrote: > Co-authored-by: Sri Ramanujam > Signed-off-by: Matt Coleman > --- > src/hyperv/hyperv_driver.c | 244 +++- > src/hyperv/hyperv_wmi_classes.h | 1 + > 2 files changed, 242 insertions(+), 3

Re: [PATCH 05/11] hyperv: create SCSI controllers when defining domains

2020-11-26 Thread Daniel P . Berrangé
On Tue, Nov 24, 2020 at 02:48:34PM -0500, Matt Coleman wrote: > Co-authored-by: Sri Ramanujam > Signed-off-by: Matt Coleman > --- > src/hyperv/hyperv_driver.c | 51 ++ > 1 file changed, 51 insertions(+) > > diff --git a/src/hyperv/hyperv_driver.c

Re: [PATCH 03/11] hyperv: implement domainCreateXML and domainDefineXML

2020-11-26 Thread Daniel P . Berrangé
On Tue, Nov 24, 2020 at 02:48:32PM -0500, Matt Coleman wrote: > Co-authored-by: Sri Ramanujam > Signed-off-by: Matt Coleman > --- > src/hyperv/hyperv_driver.c | 114 + > 1 file changed, 114 insertions(+) > > diff --git a/src/hyperv/hyperv_driver.c

Re: [PATCH 02/11] hyperv: implement domainUndefine and domainUndefineFlags

2020-11-26 Thread Daniel P . Berrangé
On Tue, Nov 24, 2020 at 02:48:31PM -0500, Matt Coleman wrote: > Co-authored-by: Sri Ramanujam > Signed-off-by: Matt Coleman > --- > src/hyperv/hyperv_driver.c | 60 ++ > 1 file changed, 60 insertions(+) > > diff --git a/src/hyperv/hyperv_driver.c

[PATCH v2] gitlab-ci: publish test report as an artifact

2020-11-26 Thread Paolo Bonzini
Since version 0.55, "meson test" produces JUnit XML in the meson-logs directory. The XML can be parsed by GitLab and showed as part of the CI report. However, if the build and tests are performed by "meson dist", the tests are performed in "meson dist"'s own build directory and the logs are not

Re: [PATCH 01/11] hyperv: ambiguous VM names will throw an error

2020-11-26 Thread Daniel P . Berrangé
On Tue, Nov 24, 2020 at 02:48:30PM -0500, Matt Coleman wrote: > Since Hyper-V allows multiple VMs to be created with the same name, > some commands produce unpredictable results due to > hypervDomainLookupByName's WMI query selecting the wrong domain. > > For example, this prevents `virsh

Re: [PATCH] NEWS: Mention network disk support in 'virsh attach-disk'

2020-11-26 Thread Andrea Bolognani
On Thu, 2020-11-26 at 11:48 +0100, Peter Krempa wrote: > +++ b/NEWS.rst > + * virsh: Support network disks in ``virsh attach-disk`` > + > +The ``virsh attach-disk`` helper command which simplifies attaching of > disks > +without the need for the user to formulate the disk XML manually

[PATCH 3/3] gitlab: Add issue template for filing a bug in libvirt's qemu driver

2020-11-26 Thread Peter Krempa
Add a qemu-specific version of the bug report template. The additional data section focuses on requesting VM xml, VM log file and debug logs and adds the 'driver-qemu' label. Signed-off-by: Peter Krempa --- .gitlab/issue_templates/bug-qemu.md | 56 + 1 file changed,

[PATCH 1/3] gitlab: Add issue template for reporting a generic bug

2020-11-26 Thread Peter Krempa
When reporting an issue in gitlab, the project can define a template for various scenarios which are meant to guide the users to add the relevant information the project needs to the reported issue. Add a template for a generic bug report against libvirt. The template adds sections which motivate

[PATCH 0/3] gitlab: Add issue templates

2020-11-26 Thread Peter Krempa
Gitlab allows projects to define templates for filing issues [1]. Libvirt didn't have them yet. We can use them to encourage users to file better bug reports and feature requests. You can test-drive the proposed templates in my test repo:

[PATCH 2/3] gitlab: Add issue template for a feature request

2020-11-26 Thread Peter Krempa
Try to motivate the users to describe what they want to achieve before diving down into technical specifics. Signed-off-by: Peter Krempa --- .gitlab/issue_templates/feature.md | 26 ++ 1 file changed, 26 insertions(+) create mode 100644

[PATCH] NEWS: Mention network disk support in 'virsh attach-disk'

2020-11-26 Thread Peter Krempa
Signed-off-by: Peter Krempa --- NEWS.rst | 8 1 file changed, 8 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index aa8a217eb6..8c2b5def0f 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -42,6 +42,14 @@ v6.10.0 (unreleased) * **Improvements** + * virsh: Support network disks in ``virsh

[PATCH] gitlab-ci: publish test report as an artifact

2020-11-26 Thread Paolo Bonzini
"meson test" produces JUnit XML in the meson-logs directory. The XML can be parsed by GitLab and showed as part of the CI report. However, if the build and tests are performed by "meson dist", the tests are performed in "meson dist"'s own build directory and the logs are not accessible. So

Re: [libvirt PATCH 2/2] util: avoid glib event loop workaround where possible

2020-11-26 Thread Daniel P . Berrangé
On Wed, Nov 25, 2020 at 08:37:02PM +0100, Michal Prívozník wrote: > On 11/25/20 7:04 PM, Daniel P. Berrangé wrote: > > I previously did a workaround for a glib event loop race > > that causes crashes: > > > >commit 0db4743645b7a0611a3c0687f834205c9956f7fc > >Author: Daniel P. Berrangé >

Re: [libvirt PATCH 1/2] remote: make ssh-helper massively faster

2020-11-26 Thread Daniel P . Berrangé
On Wed, Nov 25, 2020 at 08:50:07PM +0100, Michal Prívozník wrote: > On 11/25/20 7:04 PM, Daniel P. Berrangé wrote: > > It was reported that the performance of tunnelled migration and > > volume upload/download regressed in 6.9.0, when the virt-ssh-helper > > is used for remote SSH tunnelling

Re: Migration with "--p2p --tunnelled" hanging in v6.9.0

2020-11-26 Thread Christian Ehrhardt
On Wed, Nov 25, 2020 at 7:06 PM Daniel P. Berrangé wrote: > > On Wed, Nov 25, 2020 at 05:20:41PM +, Daniel P. Berrangé wrote: > > On Wed, Nov 25, 2020 at 05:00:20PM +, Daniel P. Berrangé wrote: > > > On Wed, Nov 25, 2020 at 04:36:39PM +, Daniel P. Berrangé wrote: > > > > On Wed, Nov

Re: [libvirt PATCH 0/2] fix regression in SSH tunnelling performance

2020-11-26 Thread Christian Ehrhardt
On Wed, Nov 25, 2020 at 7:04 PM Daniel P. Berrangé wrote: > > In testing the "vol-download" command in virsh, downloading a > 1G file takes a ridiculous amount of time (minutes) with the > new SSH helper. > > After the first patch is applied the time gets down to a much > more reasonable 5.5