Simplify ReserveName/GenerateName for macvlan and macvtap by using
common functions.
Signed-off-by: Shi Lei
---
src/libvirt_private.syms| 1 -
src/lxc/lxc_process.c | 2 +-
src/qemu/qemu_process.c | 2 +-
src/util/virnetdevmacvlan.c | 177 +---
Those functions that call virNetDevTapCreate don't need to adding
'vnet%d' into ifname when it is empty, since virNetDevGenerateName
which is in virNetDevTapCreate can deal with it.
Signed-off-by: Shi Lei
---
src/bhyve/bhyve_command.c | 1 -
src/qemu/qemu_interface.c | 12
2 files
Extract ReserveName/GenerateName from netdevtap and netdevmacvlan as
common helper functions.
Signed-off-by: Shi Lei
---
src/bhyve/bhyve_command.c | 4 +-
src/conf/domain_conf.c | 4 +-
src/interface/interface_backend_udev.c | 2 +-
src/libvirt_private.syms
Simplify GenerateName/ReserveName for netdevtap by using common
functions.
Signed-off-by: Shi Lei
---
src/libvirt_private.syms | 1 -
src/qemu/qemu_process.c | 2 +-
src/util/virnetdevtap.c | 100 ++-
src/util/virnetdevtap.h | 4 --
4 files changed, 5
V1 here: https://www.redhat.com/archives/libvir-list/2020-December/msg00308.html
Since V1:
(1) Remove virNetDev[Lock|Unlock]GenName.
Only *lastID* needs to be protected. Now we lock *lastID*
inside virNetDevReserveName and virNetDevGenerateName, then lock and
unlock fun
Simplify virNetDevVethCreate by using common GenerateName/ReserveName
functions.
Signed-off-by: Shi Lei
---
src/lxc/lxc_process.c| 3 +
src/util/virnetdevveth.c | 140 +--
2 files changed, 36 insertions(+), 107 deletions(-)
diff --git a/src/lxc/lxc_proc
On 12/9/20 4:18 AM, Daniel P. Berrangé wrote:
On Tue, Dec 08, 2020 at 08:37:43PM -0500, Laine Stump wrote:
Previously there was no way to differentiate between this function 1)
encountering an error while reading the pci config, and 2) determining
that the device in question is a conventional PC
On 12/9/20 2:48 PM, Peter Krempa wrote:
qemu-5.2 is out! Let's update the capabilities for the final version.
Note that the 'enable-fips' feature vanishing in this update is expected
as the removal was tied to a version check (see commit 7b1ed1cd733a0 ).
Signed-off-by: Peter Krempa
---
.../c
On 12/9/20 2:03 PM, Erik Skultety wrote:
On Fri, Dec 04, 2020 at 11:24:12AM +0100, Erik Skultety wrote:
On Thu, Dec 03, 2020 at 06:59:32PM +0100, Shalini Chellathurai Saroja wrote:
Add support for AP card devices, AP queues and AP matrix devices in
libvirt node device driver.
---
v4:
- Adde
On Wed, Dec 09, 2020 at 14:51:27 +0100, Tim Wiederhake wrote:
> On Wed, 2020-12-09 at 14:43 +0100, Jiri Denemark wrote:
> > On Mon, Nov 23, 2020 at 15:14:32 +0100, Tim Wiederhake wrote:
> > > Signed-off-by: Tim Wiederhake
> > > ---
> > > src/cpu_map/x86_features.xml | 5 +
> > > 1 file change
On Mon, Nov 23, 2020 at 15:14:23 +0100, Tim Wiederhake wrote:
> sync_qemu_i386.py in src/cpu_map is a tool to sync CPU models from qemu
> with libvirt. It currently has no provisions for detecting new features
> that are not implemented in libvirt yet. This series changes that.
>
> Currently missi
On Wed, 2020-12-09 at 14:43 +0100, Jiri Denemark wrote:
> On Mon, Nov 23, 2020 at 15:14:32 +0100, Tim Wiederhake wrote:
> > Signed-off-by: Tim Wiederhake
> > ---
> > src/cpu_map/x86_features.xml | 5 +
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/src/cpu_map/x86_features.xml
> >
qemu-5.2 is out! Let's update the capabilities for the final version.
Note that the 'enable-fips' feature vanishing in this update is expected
as the removal was tied to a version check (see commit 7b1ed1cd733a0 ).
Signed-off-by: Peter Krempa
---
.../caps_5.2.0.x86_64.replies |
On Mon, Nov 23, 2020 at 15:14:32 +0100, Tim Wiederhake wrote:
> Signed-off-by: Tim Wiederhake
> ---
> src/cpu_map/x86_features.xml | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml
> index a5a987deba..4836595a8c 100644
> ---
On Mon, Nov 23, 2020 at 15:14:31 +0100, Tim Wiederhake wrote:
> Signed-off-by: Tim Wiederhake
> ---
> src/cpu_map/x86_features.xml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml
> index b0bf22d916..a5a987deba 100644
> --- a
On Mon, Nov 23, 2020 at 15:14:30 +0100, Tim Wiederhake wrote:
> Signed-off-by: Tim Wiederhake
> ---
> src/cpu_map/x86_features.xml | 3 +++
> tests/cputestdata/x86_64-cpuid-Ice-Lake-Server-guest.xml | 1 +
> tests/cputestdata/x86_64-cpuid-Ice-Lake-Server-host.xml | 1
On a Tuesday in 2020, Peter Krempa wrote:
Peter Krempa (2):
qemuDomainCheckpointLoad: Don't align disks when restoring config from
disk
qemuDomainCheckpointLoad: Remove stale comment
src/qemu/qemu_driver.c | 22 --
1 file changed, 4 insertions(+), 18 deletions(-)
Revie
On Fri, Dec 04, 2020 at 11:24:12AM +0100, Erik Skultety wrote:
> On Thu, Dec 03, 2020 at 06:59:32PM +0100, Shalini Chellathurai Saroja wrote:
> > Add support for AP card devices, AP queues and AP matrix devices in
> > libvirt node device driver.
> > ---
> > v4:
> > - Added virNodeDevAPAdapterParse
On 12/9/20 7:52 AM, Daniel P. Berrangé wrote:
On Wed, Dec 09, 2020 at 07:35:09AM -0300, Daniel Henrique Barboza wrote:
On 12/9/20 5:13 AM, Michal Privoznik wrote:
On 12/8/20 11:20 PM, Daniel Henrique Barboza wrote:
This patch creates a new function, virDomainDefBootValidate(), to host
the
On Mon, 2020-12-07 at 11:38 +0300, Nikolay Shirokovskiy wrote:
> +++ b/libvirt.spec.in
> +restart_daemon=0
> +for dfile in %{_datadir}/libvirt/nwfilter/*.xml; do
> + sfile=%{_sysconfdir}/libvirt/nwfilter/`basename $dfile`
Please use $() instead of ``. Some additional quoting would also be
nice.
On Mon, 2020-12-07 at 16:18 -0300, Daniel Henrique Barboza wrote:
> On 12/7/20 2:07 PM, Andrea Bolognani wrote:
> > +++ b/src/qemu/qemu_domain.c
> > @@ -5363,7 +5363,7 @@
> > qemuDomainNVDimmAlignSizePseries(virDomainMemoryDefPtr mem)
> > /* Align down guest_area. 256MiB is the minimum size.
On Wed, Dec 09, 2020 at 07:35:09AM -0300, Daniel Henrique Barboza wrote:
>
>
> On 12/9/20 5:13 AM, Michal Privoznik wrote:
> > On 12/8/20 11:20 PM, Daniel Henrique Barboza wrote:
> > > This patch creates a new function, virDomainDefBootValidate(), to host
> > > the validation of boot menu timeout
On 12/9/20 5:13 AM, Michal Privoznik wrote:
On 12/8/20 11:20 PM, Daniel Henrique Barboza wrote:
This is the v3 of
https://www.redhat.com/archives/libvir-list/2020-December/msg00419.html
Michal mentioned in his v2 review that we should move these validations
out of domain_conf.c to a new file
On 12/9/20 5:13 AM, Michal Privoznik wrote:
On 12/8/20 11:20 PM, Daniel Henrique Barboza wrote:
This patch creates a new function, virDomainDefBootValidate(), to host
the validation of boot menu timeout and rebootTimeout outside of parse
time. The checks in virDomainDefParseBootXML() were cha
Some secdrivers (typically SELinux driver) generate unique
dynamic seclabel for each domain (unless a static one is
requested in domain XML). This is achieved by calling
qemuSecurityGenLabel() from qemuProcessPrepareDomain() which
allocates unique seclabel and stores it in domain def->seclabels.
Th
On Wed, Dec 09, 2020 at 10:15:54AM +0100, Peter Krempa wrote:
> Commit 926563dc3a6 which refactored the function call deleting the
> snapshot's on disk state introduced a logic bug, which skips over the
> deletion of libvirt metadata after the disk state deletion is done.
>
> To fix it we must not
On Tue, Dec 08, 2020 at 08:37:43PM -0500, Laine Stump wrote:
> Previously there was no way to differentiate between this function 1)
> encountering an error while reading the pci config, and 2) determining
> that the device in question is a conventional PCI device, and so has
> no Express Capabilit
Commit 926563dc3a6 which refactored the function call deleting the
snapshot's on disk state introduced a logic bug, which skips over the
deletion of libvirt metadata after the disk state deletion is done.
To fix it we must not return early.
Resolves: https://gitlab.com/libvirt/libvirt/-/issues/10
On 12/9/20 2:37 AM, Laine Stump wrote:
I think there's an adequate description in patch 6 (and maybe in the
bugzilla record: https://bugzilla.redhat.com/1901685). I already typed
a long description once, and git send-email failed due to network
problems and threw away everything I typed. I don't
On 12/8/20 11:20 PM, Daniel Henrique Barboza wrote:
This patch creates a new function, virDomainDefBootValidate(), to host
the validation of boot menu timeout and rebootTimeout outside of parse
time. The checks in virDomainDefParseBootXML() were changed to throw
VIR_ERR_XML_ERROR in case of parse
On 12/8/20 11:20 PM, Daniel Henrique Barboza wrote:
This is the v3 of
https://www.redhat.com/archives/libvir-list/2020-December/msg00419.html
Michal mentioned in his v2 review that we should move these validations
out of domain_conf.c to a new file. Let's create a new file called
domain_validate
31 matches
Mail list logo
