[PATCH 7/7] tests: Added tests for NFS disk protocol

2020-12-29 Thread Ryan Gahagan
Signed-off-by: Ryan Gahagan --- tests/qemuxml2argvdata/disk-network-nfs.args | 1 + .../disk-network-nfs.x86_64-latest.args | 56 +++ tests/qemuxml2argvdata/disk-network-nfs.xml | 48 tests/qemuxml2argvtest.c | 1 +

[PATCH 6/7] util: Added a backing store NFS parser

2020-12-29 Thread Ryan Gahagan
Signed-off-by: Ryan Gahagan --- src/util/virstoragefile.c | 51 +++ 1 file changed, 51 insertions(+) diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c index b5a5f267b9..ee8e31ce58 100644 --- a/src/util/virstoragefile.c +++

[PATCH 1/7] conf: Add NFS disk protocol

2020-12-29 Thread Ryan Gahagan
Per Issue 90, Libvirt does not support attaching an NFS disk even though QEMU has added support for it. This series of patches seeks to implement this support in Libvirt and begins by adding in flags for an NFS disk. Signed-off-by: Ryan Gahagan --- src/libxl/libxl_conf.c| 1 +

[PATCH 5/7] qemu: Added NFS JSON props methods

2020-12-29 Thread Ryan Gahagan
Signed-off-by: Ryan Gahagan --- src/qemu/qemu_block.c | 79 +- src/qemu/qemu_domain.c | 47 + 2 files changed, 125 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c index

[PATCH 4/7] conf: Added NFS XML format/parse methods

2020-12-29 Thread Ryan Gahagan
Signed-off-by: Ryan Gahagan --- src/conf/domain_conf.c | 33 + 1 file changed, 33 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index b301ac0a08..565ca680c9 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -6888,6

[PATCH 3/7] docs: added rng schema and formatdomain for NFS

2020-12-29 Thread Ryan Gahagan
Signed-off-by: Ryan Gahagan --- docs/formatdomain.rst | 11 +- docs/schemas/domaincommon.rng | 38 +++ 2 files changed, 48 insertions(+), 1 deletion(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 512939679b..23a7bca643 100644

[PATCH 2/7] util: Added nfs params to virStorageSource

2020-12-29 Thread Ryan Gahagan
Signed-off-by: Ryan Gahagan --- src/util/virstoragefile.c | 8 src/util/virstoragefile.h | 5 + 2 files changed, 13 insertions(+) diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c index 103dade0e7..b5a5f267b9 100644 --- a/src/util/virstoragefile.c +++

Re: [PATCH] Deprecate pmem=on with non-DAX capable backend file

2020-12-29 Thread Igor Mammedov
On Tue, 29 Dec 2020 19:04:58 +0100 Philippe Mathieu-Daudé wrote: > On 12/29/20 6:29 PM, Igor Mammedov wrote: > > It is not safe to pretend that emulated NVDIMM supports > > persistence while backend actually failed to enable it > > and used non-persistent mapping as fall back. > > Instead of

Re: [PATCH] Deprecate pmem=on with non-DAX capable backend file

2020-12-29 Thread Philippe Mathieu-Daudé
On 12/29/20 6:29 PM, Igor Mammedov wrote: > It is not safe to pretend that emulated NVDIMM supports > persistence while backend actually failed to enable it > and used non-persistent mapping as fall back. > Instead of falling-back, QEMU should be more strict and > error out with clear message that

[PATCH] Deprecate pmem=on with non-DAX capable backend file

2020-12-29 Thread Igor Mammedov
It is not safe to pretend that emulated NVDIMM supports persistence while backend actually failed to enable it and used non-persistent mapping as fall back. Instead of falling-back, QEMU should be more strict and error out with clear message that it's not supported. So if user asks for persistence

Re: RFC PATCH: Issue 90 (Test Clarification)

2020-12-29 Thread Peter Krempa
On Tue, Dec 29, 2020 at 10:17:31 -0600, Ryan Gahagan wrote: > On Tue, Dec 29, 2020 at 10:11 AM Peter Krempa wrote: > > > Please don't post screenshots of text. It's pointlessly bloating the > > mail and I can't respond inline. Please re-post all the relevant bits as > > text. I've remembered a

Re: RFC PATCH: Issue 90 (Test Clarification)

2020-12-29 Thread Ryan Gahagan
On Tue, Dec 29, 2020 at 10:11 AM Peter Krempa wrote: > Please don't post screenshots of text. It's pointlessly bloating the > mail and I can't respond inline. Please re-post all the relevant bits as > text. > Sorry about that, I didn't know what the policy on images was. Basically, we used the

Re: RFC PATCH: Issue 90 (Test Clarification)

2020-12-29 Thread Peter Krempa
On Mon, Dec 28, 2020 at 15:49:17 -0600, Ryan Gahagan wrote: > Our output file (qemuxml2xmloutdata/disk-network-nfs.x86_64-latest.xml) has > a backingStore on line 35. Test 181 generates an output where this backing > store does not have an index, but Test 182 generates an output where this >

[PATCH 3/3] storageBackendCreateRaw: remove unused created variable

2020-12-29 Thread Yi Li
refactor and remove unused created variable Signed-off-by: Yi Li --- src/storage/storage_util.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/storage/storage_util.c b/src/storage/storage_util.c index c6d0f7a97c..c02ece8253 100644 ---

[PATCH 2/3] createRawFile: remove unused return variable

2020-12-29 Thread Yi Li
remove unused return variable, The errno will throw by virReportSystemError Signed-off-by: Yi Li --- src/storage/storage_util.c | 21 - 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/src/storage/storage_util.c b/src/storage/storage_util.c index

[PATCH 1/3] virStorageBackendCopyToFD: remove unused return variable

2020-12-29 Thread Yi Li
remove unused return variable, The errno will throw by virReportSystemError Signed-off-by: Yi Li --- src/storage/storage_util.c | 22 +++--- 1 file changed, 7 insertions(+), 15 deletions(-) diff --git a/src/storage/storage_util.c b/src/storage/storage_util.c index