Re: [PATCH] apparmor: let image label setting loop over backing files

2021-01-19 Thread Christian Ehrhardt
On Tue, Jan 19, 2021 at 11:43 AM Peter Krempa wrote: > > On Tue, Jan 19, 2021 at 11:23:16 +0100, Christian Ehrhardt wrote: > > When adding a rule for an image file and that image file has a chain > > of backing files then we need to add a rule for each of those files. > > > > To get that iterate

Re: [PATCH] apparmor: let image label setting loop over backing files

2021-01-19 Thread Christian Ehrhardt
On Tue, Jan 19, 2021 at 12:28 PM Peter Krempa wrote: > > On Tue, Jan 19, 2021 at 12:15:31 +0100, Christian Ehrhardt wrote: > > On Tue, Jan 19, 2021 at 11:43 AM Peter Krempa wrote: > > > > > > On Tue, Jan 19, 2021 at 11:23:16 +0100, Christian Ehrhardt wrote: > > > > When adding a rule for an

[libvirt PATCH v2 3/3] ci: Drop openSUSE Leap 15.1

2021-01-19 Thread Erik Skultety
Leap 15.1 will reach EOL on January 31st 2021, so we should not test on it during the current development cycle ending in March 1st. Signed-off-by: Erik Skultety --- .gitlab-ci.yml | 17 +--- ci/containers/ci-opensuse-151.Dockerfile | 100 --- 2

[libvirt PATCH v2 0/3] Refresh Dockerfiles

2021-01-19 Thread Erik Skultety
Erik Skultety (3): ci: Refresh Dockerfiles ci: Add openSUSE Leap 15.2 ci: Drop openSUSE Leap 15.1 .gitlab-ci.yml | 14 +++--- ci/containers/ci-centos-7.Dockerfile | 4 ++-- ci/containers/ci-centos-8.Dockerfile | 2

[libvirt PATCH v2 1/3] ci: Refresh Dockerfiles

2021-01-19 Thread Erik Skultety
In this refresh CentOS 7 now uses docker.io registry and the PowerTools repo name regression was fixed for CentOS Stream this time. Signed-off-by: Erik Skultety --- ci/containers/ci-centos-7.Dockerfile | 4 ++-- ci/containers/ci-centos-8.Dockerfile | 2 +-

[libvirt PATCH v2 2/3] ci: Add openSUSE Leap 15.2

2021-01-19 Thread Erik Skultety
Signed-off-by: Erik Skultety --- .gitlab-ci.yml | 13 +++ ci/containers/ci-opensuse-152.Dockerfile | 100 +++ 2 files changed, 113 insertions(+) create mode 100644 ci/containers/ci-opensuse-152.Dockerfile diff --git a/.gitlab-ci.yml

Re: [libvirt PATCH 0/2] Refresh Dockerfiles

2021-01-19 Thread Erik Skultety
On Tue, Jan 19, 2021 at 04:30:19PM +, Daniel P. Berrangé wrote: > On Tue, Jan 19, 2021 at 05:22:12PM +0100, Erik Skultety wrote: > > Note that openSUSE Leap 15.1 container hasn't been removed yet as it reaches > > EOL on January 31, 2021, we'll build on both. > > We should remove it right

[PATCH v2] meson: build vstorage only on linux

2021-01-19 Thread Nikolay Shirokovskiy
This should fix CI error: ../dist-unpack/libvirt-7.1.0/src/storage/storage_backend_vstorage.c:10:10: fatal error: 'mntent.h' file not found #include ^~ on freebsd and mac. Signed-off-by: Nikolay Shirokovskiy --- meson.build | 15 +-- 1 file changed, 13

Re: [PATCH] meson: don't build vstorage where mntent.h is not present

2021-01-19 Thread Nikolay Shirokovskiy
On Tue, Jan 19, 2021 at 5:59 PM Pavel Hrdina wrote: > On Tue, Jan 19, 2021 at 04:41:35PM +0300, Nikolay Shirokovskiy wrote: > > This should fix CI error: > > > > > ../dist-unpack/libvirt-7.1.0/src/storage/storage_backend_vstorage.c:10:10: > fatal error: 'mntent.h' file not found > >

[PATCH] meson: don't build vstorage where mntent.h is not present

2021-01-19 Thread Nikolay Shirokovskiy
This should fix CI error: ../dist-unpack/libvirt-7.1.0/src/storage/storage_backend_vstorage.c:10:10: fatal error: 'mntent.h' file not found #include ^~ on freebsd and mac. Signed-off-by: Nikolay Shirokovskiy --- meson.build | 16 ++-- 1 file changed, 14

Re: [PATCH v2] meson: build vstorage only on linux

2021-01-19 Thread Daniel P . Berrangé
On Tue, Jan 19, 2021 at 07:31:42PM +0300, Nikolay Shirokovskiy wrote: > This should fix CI error: > > > ../dist-unpack/libvirt-7.1.0/src/storage/storage_backend_vstorage.c:10:10: > fatal error: 'mntent.h' file not found > #include > ^~ > > on freebsd and mac. > >

Re: [libvirt PATCH 0/2] Refresh Dockerfiles

2021-01-19 Thread Daniel P . Berrangé
On Tue, Jan 19, 2021 at 05:22:12PM +0100, Erik Skultety wrote: > Note that openSUSE Leap 15.1 container hasn't been removed yet as it reaches > EOL on January 31, 2021, we'll build on both. We should remove it right now, because it'll be EOL by the time of the next libvirt release on March 1st,

[libvirt PATCH 2/2] ci: Add openSUSE Leap 15.2

2021-01-19 Thread Erik Skultety
Flip the codestyle job to this minor version from Leap 15.1 as well. Signed-off-by: Erik Skultety --- .gitlab-ci.yml | 17 +++- ci/containers/ci-opensuse-152.Dockerfile | 100 +++ 2 files changed, 115 insertions(+), 2 deletions(-) create mode

[libvirt PATCH 1/2] ci: Refresh Dockerfiles

2021-01-19 Thread Erik Skultety
In this refresh CentOS 7 now uses docker.io registry and the PowerTools repo name regression was fixed for CentOS Stream this time. Signed-off-by: Erik Skultety --- ci/containers/ci-centos-7.Dockerfile | 4 ++-- ci/containers/ci-centos-8.Dockerfile | 2 +-

[libvirt PATCH 0/2] Refresh Dockerfiles

2021-01-19 Thread Erik Skultety
Note that openSUSE Leap 15.1 container hasn't been removed yet as it reaches EOL on January 31, 2021, we'll build on both. Erik Skultety (2): ci: Refresh Dockerfiles ci: Add openSUSE Leap 15.2 .gitlab-ci.yml| 17 ++- ci/containers/ci-centos-7.Dockerfile

Re: [libvirt PATCH v2] meson: Fix build with -Dtest_coverage=true

2021-01-19 Thread Pavel Hrdina
On Tue, Jan 19, 2021 at 03:31:56PM +0100, Jiri Denemark wrote: > As can be seen in commit 8a62a1592ae00eab4eb153c02661e56b9d8d9032 (from > autoconf era), the coverage flags have to be used also when linking > objects. However, this was not reflected when we switched to meson. > > Without this

Re: [PATCH] meson: don't build vstorage where mntent.h is not present

2021-01-19 Thread Pavel Hrdina
On Tue, Jan 19, 2021 at 04:41:35PM +0300, Nikolay Shirokovskiy wrote: > This should fix CI error: > > > ../dist-unpack/libvirt-7.1.0/src/storage/storage_backend_vstorage.c:10:10: > fatal error: 'mntent.h' file not found > #include > ^~ > > on freebsd and mac. > >

Re: [libvirt PATCH] docs: Clarify use of virtio-scsi model for SCSI controllers

2021-01-19 Thread Jiri Denemark
On Tue, Jan 19, 2021 at 15:38:40 +0100, Andrea Bolognani wrote: > The current formulation can lead people to believe SCSI > controllers only allow the virtio-scsi model, but really the > only difference is that you have to use model='virtio-scsi' > where you would use model='virtio' for another

[libvirt PATCH] docs: Clarify use of virtio-scsi model for SCSI controllers

2021-01-19 Thread Andrea Bolognani
The current formulation can lead people to believe SCSI controllers only allow the virtio-scsi model, but really the only difference is that you have to use model='virtio-scsi' where you would use model='virtio' for another device. Signed-off-by: Andrea Bolognani --- docs/formatdomain.rst | 6

[libvirt PATCH v2] meson: Fix build with -Dtest_coverage=true

2021-01-19 Thread Jiri Denemark
As can be seen in commit 8a62a1592ae00eab4eb153c02661e56b9d8d9032 (from autoconf era), the coverage flags have to be used also when linking objects. However, this was not reflected when we switched to meson. Without this patch linking fails with undefined references to various __gcov_* symbols.

Re: [libvirt PATCH] meson: Fix build with -Dtest_coverage=true

2021-01-19 Thread Jiri Denemark
On Mon, Jan 18, 2021 at 09:56:56 +0100, Pavel Hrdina wrote: > On Mon, Jan 18, 2021 at 09:23:34AM +0100, Jiri Denemark wrote: > > As can be seen in commit 8a62a1592ae00eab4eb153c02661e56b9d8d9032 (from > > autoconf era), the coverage flags have to be used also when linking > > objects. However,

Re: [PATCH] storage: Linstor support

2021-01-19 Thread Daniel P . Berrangé
On Mon, Jan 18, 2021 at 02:12:04PM +0100, Peter Krempa wrote: > On Fri, Jan 15, 2021 at 08:16:47 +0100, Rene Peinthor wrote: > > Implement a LINSTOR backend storage driver. > > The Linstor client needs to be installed and it needs to be configured > > on the nodes used by the controller. > > > >

[PATCH 3/3] storage: Add tests for the Linstor storage backend

2021-01-19 Thread Rene Peinthor
--- tests/linstorjsondata/broken.json | 1 + tests/linstorjsondata/resource-group.json | 1 + .../linstorjsondata/resource-list-test2.json | 332 .../storage-pools-ssdpool.json| 72 tests/linstorjsondata/storage-pools.json | 192

[PATCH 0/3] Storage backend Linstor V2

2021-01-19 Thread Rene Peinthor
Here is the updated PATCH with split commits, and changes from the first review. Rene Peinthor (3): storage: Linstor configuration storage: Linstor support storage: Add tests for the Linstor storage backend docs/schemas/storagepool.rng | 27 + docs/storage.html.in

[PATCH 2/3] storage: Linstor support

2021-01-19 Thread Rene Peinthor
Implement a LINSTOR backend storage driver. The Linstor client needs to be installed and it needs to be configured on the nodes used by the controller. It supports most pool/vol commands, except for pool-build/pool-delete and provides a block device in RAW file mode. Linstor supports more than

[PATCH 1/3] storage: Linstor configuration

2021-01-19 Thread Rene Peinthor
This adds Linstor storage defines and documentation for the new storage backend for Linstor. --- docs/schemas/storagepool.rng | 27 +++ include/libvirt/libvirt-storage.h | 1 + src/conf/domain_conf.c| 1 +

Re: [PATCH] storage: Linstor support

2021-01-19 Thread Rene Peinthor
Hi! Thanks for the review, I applied all of your corrections and will retest the code and send a splitted version of the changes. > Also I'd like to ask you to provide a way to setup this storage on our > CI system so that we can compile-test the new driver. Well the easiest would be to use an

Re: [PATCH] apparmor: let image label setting loop over backing files

2021-01-19 Thread Peter Krempa
On Tue, Jan 19, 2021 at 12:15:31 +0100, Christian Ehrhardt wrote: > On Tue, Jan 19, 2021 at 11:43 AM Peter Krempa wrote: > > > > On Tue, Jan 19, 2021 at 11:23:16 +0100, Christian Ehrhardt wrote: > > > When adding a rule for an image file and that image file has a chain > > > of backing files then

Re: [PATCH] apparmor: let image label setting loop over backing files

2021-01-19 Thread Christian Ehrhardt
On Tue, Jan 19, 2021 at 11:43 AM Peter Krempa wrote: > > On Tue, Jan 19, 2021 at 11:23:16 +0100, Christian Ehrhardt wrote: > > When adding a rule for an image file and that image file has a chain > > of backing files then we need to add a rule for each of those files. > > > > To get that iterate

Re: [PATCH] apparmor: let image label setting loop over backing files

2021-01-19 Thread Peter Krempa
On Tue, Jan 19, 2021 at 11:23:16 +0100, Christian Ehrhardt wrote: > When adding a rule for an image file and that image file has a chain > of backing files then we need to add a rule for each of those files. > > To get that iterate over the backing file chain the same way as > dac/selinux already

[PATCH] apparmor: let image label setting loop over backing files

2021-01-19 Thread Christian Ehrhardt
When adding a rule for an image file and that image file has a chain of backing files then we need to add a rule for each of those files. To get that iterate over the backing file chain the same way as dac/selinux already do and add a label for each. Fixes:

Re: [PATCH] meson: fix vstorage driver build

2021-01-19 Thread Nikolay Shirokovskiy
This patch is outdated by https://www.redhat.com/archives/libvir-list/2021-January/msg00778.html On Mon, Jan 18, 2021 at 3:02 PM Nikolay Shirokovskiy < nshirokovs...@virtuozzo.com> wrote: > It breaks on using - in VSTORAGE-MOUNT definition with: > > In file included from ../config.h:19:0, >

[PATCH] vstorage: remove build time checks for runtime binaries

2021-01-19 Thread Nikolay Shirokovskiy
Accoring to current agreement mentioned in list recently [1]. Now vstorage driver will be build in default devs environment and also can be included into CI. This also closes quite old abandoned thread on alternative checks for binaries in case of this same driver [2]. [1]

Re: [PATCH] vstorage: remove build time checks for runtime binaries

2021-01-19 Thread Michal Privoznik
On 1/19/21 7:34 AM, Nikolay Shirokovskiy wrote: Accoring to current agreement mentioned in list recently [1]. Now vstorage driver will be build in default devs environment and also can be included into CI. This also closes quite old abandoned thread on alternative checks for binaries in case of