On Wed, Jan 20, 2021 at 11:33:41AM -0600, Jonathon Jongsma wrote:
> Erik Skultety suggested posting a separate series removing the space-padded
> alignment of function declarations in the public headers.
This is already an improvement. We've gradually adopted a style where
function declarations
On Wed, Jan 20, 2021 at 11:33:43AM -0600, Jonathon Jongsma wrote:
> Improve consistency in headers by removing the old style space-padded
> alignment for function names and arguments.
>
> Signed-off-by: Jonathon Jongsma
> ---
...
> -int virDomainSetSchedulerParameters (virDomainPtr domain,
> Ping
Hi!
I think this series still make sense, even though the dirty ring patch
haven't been merged.
Using the -accel to specify accelerator is more graceful and more
feature such as kernel-irqchip锛宬vm-shadow-mem锛宼b-size锛宔tc, can be
specified via domain xml if we continue doing this
Again, don't use "modernize". Just "convert to use g_auto*" or something
like that.
On 1/18/21 2:53 PM, Daniel Henrique Barboza wrote:
Use g_auto* cleanup to avoid free() calls.
Signed-off-by: Daniel Henrique Barboza
---
src/security/security_dac.c | 49
Saying "modernize" in the title line is kind of odd - when I read that I
thought it must be changing something related to selinux, not just
switching to g_autoptr. How about you just say that in the first line
(use g_auto* in security_selinux.c, or something like that).
Aside from that:
On 1/18/21 2:53 PM, Daniel Henrique Barboza wrote:
Gitlab issue #72 [1] reports that removing SR-IOVs VFs before
removing the devices from the running domains can have strange
consequences.
Resolution: "Don't do that!!" :-)
Seriously, though, there are any number of things that someone with
On 1/18/21 2:53 PM, Daniel Henrique Barboza wrote:
We're going to add logic to handle the case where a previously
existing PCI device does not longer exist in the host.
The logic was copied from virPCIDeviceNew(), which verifies if a
PCI device exists in the host, returning NULL and throwing an
On 1/18/21 2:53 PM, Daniel Henrique Barboza wrote:
The current virPCIDeviceNew() signature, receiving 4 uints in sequence
(domain, bus, slot, function), is not neat.
We already have a way to represent a PCI address in virPCIDeviceAddress
that is used in the code. Aside from the test files, most
On 1/18/21 2:53 PM, Daniel Henrique Barboza wrote:
Instead of receiving 4 uints in order and write domain/bus/slot/function,
receive a virPCIDeviceAddressPtr instead and write into it.
This change will allow us to simplify the API for virPCIDeviceNew()
in the next patch.
Signed-off-by: Daniel
On 1/18/21 2:53 PM, Daniel Henrique Barboza wrote:
libxlNodeDeviceGetPCIInfo() and qemuNodeDeviceGetPCIInfo() are equal.
Let's move the logic to a new virDomainDriverNodeDeviceGetPCIInfo()
info to be used by libxl_driver.c and qemu_driver.c.
Signed-off-by: Daniel Henrique Barboza
---
On 1/18/21 2:53 PM, Daniel Henrique Barboza wrote:
There is no need to open code the PCI address string format
when we have a function that does exactly that.
Signed-off-by: Daniel Henrique Barboza
---
src/conf/domain_audit.c | 6 +-
src/util/virpci.c | 6 ++
2 files changed,
On 1/20/21 12:33 AM, Christian Ehrhardt wrote:
On Tue, Jan 19, 2021 at 11:43 AM Peter Krempa wrote:
On Tue, Jan 19, 2021 at 11:23:16 +0100, Christian Ehrhardt wrote:
When adding a rule for an image file and that image file has a chain
of backing files then we need to add a rule for each of
Cc'ing MST.
On 1/20/21 8:31 PM, Igor Mammedov wrote:
> On Mon, 11 Jan 2021 15:33:32 -0500
> Igor Mammedov wrote:
>
>> It is not safe to pretend that emulated NVDIMM supports
>> persistence while backend actually failed to enable it
>> and used non-persistent mapping as fall back.
>> Instead of
On Mon, 11 Jan 2021 15:33:32 -0500
Igor Mammedov wrote:
> It is not safe to pretend that emulated NVDIMM supports
> persistence while backend actually failed to enable it
> and used non-persistent mapping as fall back.
> Instead of falling-back, QEMU should be more strict and
> error out with
Improve consistency in headers by removing the old style space-padded
alignment for function names and arguments.
Signed-off-by: Jonathon Jongsma
---
include/libvirt/libvirt-secret.h | 72
1 file changed, 36 insertions(+), 36 deletions(-)
diff --git
Improve consistency in headers by removing the old style space-padded
alignment for function names and arguments.
Signed-off-by: Jonathon Jongsma
---
include/libvirt/libvirt-interface.h | 72 ++---
1 file changed, 36 insertions(+), 36 deletions(-)
diff --git
Improve consistency in headers by removing the old style space-padded
alignment for function names and arguments.
Signed-off-by: Jonathon Jongsma
---
include/libvirt/libvirt-storage.h | 222 +++---
1 file changed, 111 insertions(+), 111 deletions(-)
diff --git
Improve consistency in headers by removing the old style space-padded
alignment for function names and arguments.
Signed-off-by: Jonathon Jongsma
---
include/libvirt/libvirt-network.h | 92 +++
1 file changed, 46 insertions(+), 46 deletions(-)
diff --git
Improve consistency in headers by removing the old style space-padded
alignment for function names and arguments.
Signed-off-by: Jonathon Jongsma
---
include/libvirt/libvirt-nwfilter.h | 80 +++---
1 file changed, 40 insertions(+), 40 deletions(-)
diff --git
Improve consistency in headers by removing the old style space-padded
alignment for function names and arguments.
Signed-off-by: Jonathon Jongsma
---
include/libvirt/libvirt-host.h | 100 -
1 file changed, 50 insertions(+), 50 deletions(-)
diff --git
Erik Skultety suggested posting a separate series removing the space-padded
alignment of function declarations in the public headers.
Jonathon Jongsma (8):
libvirt-nodedev.h: remove space-padded alignment
libvirt-domain.h: remove space-padded alignment
libvirt-host.h: remove space-padded
Improve consistency in headers by removing the old style space-padded
alignment for function names and arguments.
Signed-off-by: Jonathon Jongsma
---
include/libvirt/libvirt-domain.h | 584 +++
1 file changed, 292 insertions(+), 292 deletions(-)
diff --git
Improve consistency in headers by removing the old style space-padded
alignment for function names and arguments.
Signed-off-by: Jonathon Jongsma
---
include/libvirt/libvirt-nodedev.h | 79 ---
1 file changed, 41 insertions(+), 38 deletions(-)
diff --git
dtrace is now also installed when cross-building.
Signed-off-by: Andrea Bolognani
---
ci/containers/ci-centos-7.Dockerfile | 2 +-
ci/containers/ci-centos-8.Dockerfile | 2 +-
ci/containers/ci-centos-stream.Dockerfile| 2 +-
From: Helmut Grohne
dtrace invokes the C compiler, so when cross-building we need
to make sure that $CC is set in the environment and that it
points to the cross-compiler rather than the native one.
Until https://github.com/mesonbuild/meson/issues/266
is addressed, the workaround is to call
We didn't spot this issue before simply because we're not
installing dtrace in the cross-building environments.
Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/244473178
libvirt-ci MR: https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/82
Andrea Bolognani (1):
ci: Refresh
Do I need attach the test results to patch and send a new version again? This
patch set is seems missed by developers.
Regards,
Luyao
From: Han Han
Sent: Thursday, January 7, 2021 5:57 PM
To: Zhong, Luyao
Cc: libvir-list@redhat.com
Subject: Re: [libvirt][PATCH v3 3/3] qemu: add parser and
On Wed, Jan 20, 2021 at 08:11:13AM +0100, Erik Skultety wrote:
>
>
> Erik Skultety (3):
> ci: Refresh Dockerfiles
> ci: Add openSUSE Leap 15.2
> ci: Drop openSUSE Leap 15.1
>
> .gitlab-ci.yml | 14 +++---
> ci/containers/ci-centos-7.Dockerfile
28 matches
Mail list logo
