Re: [PATCH 02/55] hyperv: store the Hyper-V version when connecting

On 1/21/21 1:50 PM, Matt Coleman wrote: Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 62 + src/hyperv/hyperv_private.h | 1 + 2 files changed, 37 insertions(+), 26 deletions(-) diff --git a/src/hyperv/hyperv_driver.c

Re: [PATCH] virNetworkDHCPLeaseTimeDefParseXML: Output error when 'expiry' can't be parsed

On 1/21/21 11:40 AM, Peter Krempa wrote: virStrToLong_ul doesn't report it's own error. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1918674 Signed-off-by: Peter Krempa Reviewed-by: Laine Stump --- src/conf/network_conf.c | 5 - 1 file changed, 4 insertions(+), 1

[PATCH 50/55] hyperv: use GLib auto-cleanup in hypervSerializeEprParam

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_wmi.c | 56 - 1 file changed, 21 insertions(+), 35 deletions(-) diff --git a/src/hyperv/hyperv_wmi.c b/src/hyperv/hyperv_wmi.c index ed0091ba06..c1325b2ccc 100644 --- a/src/hyperv/hyperv_wmi.c +++

[PATCH 45/55] hyperv: use GLib auto-cleanup in hypervMsvmVSMSAddResourceSettings and hypervMsvmVSMSModifyResourceSettings

Fixes a memory leak when hypervCreateInvokeParamsList() fails. Signed-off-by: Matt Coleman --- src/hyperv/hyperv_wmi.c | 43 - 1 file changed, 17 insertions(+), 26 deletions(-) diff --git a/src/hyperv/hyperv_wmi.c b/src/hyperv/hyperv_wmi.c index

[PATCH 38/55] hyperv: use g_autoptr for Msvm_ComputerSystem in hypervDomainManagedSave

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index e501a9..476c24533d 100644 --- a/src/hyperv/hyperv_driver.c +++

[PATCH 37/55] hyperv: use g_autoptr for Msvm_ComputerSystem in hypervDomainIsActive

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 6fa32d175d..e501a9 100644 --- a/src/hyperv/hyperv_driver.c +++

[PATCH 49/55] hyperv: use g_autoptr for WMI classes in hypervDomainAttachDeviceFlags

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 38 +++--- 1 file changed, 15 insertions(+), 23 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index e8296ead21..2c0e9e0614 100644 --- a/src/hyperv/hyperv_driver.c +++

[PATCH 41/55] hyperv: use g_autoptr for Msvm_ComputerSystem in hypervConnectListAllDomains

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index f134b7f137..2dfccb4802 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv/hyperv_driver.c @@

[PATCH 28/55] hyperv: use g_autoptr for Msvm_ComputerSystem in hypervDomainGetState

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 9cf074b6a7..44be9fbd2f 100644 --- a/src/hyperv/hyperv_driver.c +++

[PATCH 53/55] hyperv: use GLib auto-cleanup in hypervCreateInvokeXmlDoc

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_wmi.c | 33 +++-- 1 file changed, 11 insertions(+), 22 deletions(-) diff --git a/src/hyperv/hyperv_wmi.c b/src/hyperv/hyperv_wmi.c index 96ae9a40c8..a28bb0e815 100644 --- a/src/hyperv/hyperv_wmi.c +++

[PATCH 27/55] hyperv: use g_autoptr for WMI classes in hypervDomainGetInfo

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 27 +-- 1 file changed, 9 insertions(+), 18 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 40e4c97d35..9cf074b6a7 100644 --- a/src/hyperv/hyperv_driver.c +++

[PATCH 47/55] hyperv: use g_autoptr for Win32_OperatingSystem in hypervNodeGetFreeMemory

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 84ffb24f1a..bd3c5a7c34 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv/hyperv_driver.c @@

[PATCH 39/55] hyperv: use g_autoptr for Msvm_ComputerSystem in hypervDomainHasManagedSaveImage

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 476c24533d..d4852d55af 100644 --- a/src/hyperv/hyperv_driver.c +++

[PATCH 36/55] hyperv: use g_autoptr for WMI classes in hypervDomainGetSchedulerParametersFlags

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 28 ++-- 1 file changed, 10 insertions(+), 18 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 15770eeba8..6fa32d175d 100644 --- a/src/hyperv/hyperv_driver.c +++

[PATCH 46/55] hyperv: use g_autoptr for Win32_PerfRawData_HvStats_HyperVHypervisorVirtualProcessor in hypervDomainGetVcpus

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 4bf91cfa1a..84ffb24f1a 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv/hyperv_driver.c @@

[PATCH 43/55] hyperv: use GLib auto-cleanup in hypervInvokeMethod

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_wmi.c | 68 - 1 file changed, 27 insertions(+), 41 deletions(-) diff --git a/src/hyperv/hyperv_wmi.c b/src/hyperv/hyperv_wmi.c index 0a9d4bf4fd..459d207ee7 100644 --- a/src/hyperv/hyperv_wmi.c +++

[PATCH 42/55] hyperv: use GLib auto-cleanup in hypervDomainSendKey

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 36 ++-- 1 file changed, 14 insertions(+), 22 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 2dfccb4802..4bf91cfa1a 100644 --- a/src/hyperv/hyperv_driver.c +++

[PATCH 31/55] hyperv: use g_autoptr for Msvm_ComputerSystem in hypervConnectListDefinedDomains

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 0642e42b35..f1e6efd343 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv/hyperv_driver.c @@

[PATCH 55/55] hyperv: use g_auto for WsXmlDocH in hypervDomainAttachCDROM

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index b81cedf426..bdc084790a 100644 --- a/src/hyperv/hyperv_driver.c +++

[PATCH 54/55] hyperv: use g_auto for WsXmlDocH in hypervDomainAttachVirtualDisk

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 2c0e9e0614..b81cedf426 100644 --- a/src/hyperv/hyperv_driver.c +++

[PATCH 51/55] hyperv: use GLib auto-cleanup in hypervEnumAndPull

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_wmi.c | 42 ++--- 1 file changed, 14 insertions(+), 28 deletions(-) diff --git a/src/hyperv/hyperv_wmi.c b/src/hyperv/hyperv_wmi.c index c1325b2ccc..b68b555a3b 100644 --- a/src/hyperv/hyperv_wmi.c +++

[PATCH 52/55] hyperv: use GLib auto-cleanup in hypervSerializeEmbeddedParam

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_wmi.c | 44 + 1 file changed, 18 insertions(+), 26 deletions(-) diff --git a/src/hyperv/hyperv_wmi.c b/src/hyperv/hyperv_wmi.c index b68b555a3b..96ae9a40c8 100644 --- a/src/hyperv/hyperv_wmi.c +++

[PATCH 33/55] hyperv: use g_autoptr for Msvm_ComputerSystem in hypervDomainCreateWithFlags

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index a73b463260..535bd34733 100644 --- a/src/hyperv/hyperv_driver.c +++

[PATCH 34/55] hyperv: use g_autoptr for Msvm_VirtualSystemSettingData in hypervDomainGetAutostart

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 535bd34733..c63599c09e 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv/hyperv_driver.c

[PATCH 32/55] hyperv: use g_autoptr for Msvm_ComputerSystem in hypervConnectNumOfDefinedDomains

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index f1e6efd343..a73b463260 100644 --- a/src/hyperv/hyperv_driver.c +++

[PATCH 44/55] hyperv: use GLib auto-cleanup in hypervInvokeMsvmComputerSystemRequestStateChange

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_wmi.c | 50 +++-- 1 file changed, 18 insertions(+), 32 deletions(-) diff --git a/src/hyperv/hyperv_wmi.c b/src/hyperv/hyperv_wmi.c index 459d207ee7..bd62174739 100644 --- a/src/hyperv/hyperv_wmi.c +++

[PATCH 21/55] hyperv: use g_autoptr for WMI classes in hypervDomainSetMemoryProperty

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 25 + 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 2ec0415f62..f3fe88926e 100644 --- a/src/hyperv/hyperv_driver.c +++

[PATCH 30/55] hyperv: use g_autoptr for WMI classes in hypervDomainGetVcpusFlags

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 30 ++ 1 file changed, 10 insertions(+), 20 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index f056761338..0642e42b35 100644 --- a/src/hyperv/hyperv_driver.c +++

[PATCH 48/55] hyperv: use GLib auto-cleanup in hypervDomainGetXMLDesc

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 49 ++ 1 file changed, 18 insertions(+), 31 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index bd3c5a7c34..e8296ead21 100644 --- a/src/hyperv/hyperv_driver.c +++

[PATCH 25/55] hyperv: use g_autoptr for WMI classes in hypervDomainAttachStorage

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 25 + 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 07e8d376e0..06eee379a1 100644 --- a/src/hyperv/hyperv_driver.c +++

[PATCH 35/55] hyperv: use g_autoptr for Msvm_VirtualSystemSettingData in hypervDomainSetAutostart

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 22 -- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index c63599c09e..15770eeba8 100644 --- a/src/hyperv/hyperv_driver.c +++

[PATCH 40/55] hyperv: use g_autoptr for Msvm_ComputerSystem in hypervDomainManagedSaveRemove

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index d4852d55af..f134b7f137 100644 --- a/src/hyperv/hyperv_driver.c +++

[PATCH 04/55] hyperv: store hypervPrivate in hypervObject

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 131 + src/hyperv/hyperv_wmi.c| 19 +++--- src/hyperv/hyperv_wmi.h| 3 +- 3 files changed, 74 insertions(+), 79 deletions(-) diff --git a/src/hyperv/hyperv_driver.c

[PATCH 16/55] hyperv: use g_autoptr for Msvm_ComputerSystem in hypervDomainLookupByName

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index fe1ab1c52c..dd5c42c45b 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv/hyperv_driver.c @@

[PATCH 24/55] hyperv: use g_autoptr for Msvm_ResourceAllocationSettingData in hypervDomainAttachPhysicalDisk

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 26 ++ 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 3c4ef5f33f..07e8d376e0 100644 --- a/src/hyperv/hyperv_driver.c +++

[PATCH 29/55] hyperv: use g_autoptr for WMI classes in hypervDomainSetVcpusFlags

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 25 + 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 44be9fbd2f..f056761338 100644 --- a/src/hyperv/hyperv_driver.c +++

[PATCH 13/55] hyperv: use g_autoptr for Msvm_ComputerSystem in hypervConnectListDomains

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index efafe9ece2..45463d120d 100644 --- a/src/hyperv/hyperv_driver.c +++

[PATCH 06/55] hyperv: enable use of g_autoptr for the rest of the CIM/WMI classes

Signed-off-by: Matt Coleman --- scripts/hyperv_wmi_generator.py | 4 src/hyperv/hyperv_wmi.c | 12 ++-- src/hyperv/hyperv_wmi.h | 2 +- 3 files changed, 11 insertions(+), 7 deletions(-) diff --git a/scripts/hyperv_wmi_generator.py b/scripts/hyperv_wmi_generator.py

[PATCH 17/55] hyperv: use g_autoptr for Msvm_ComputerSystem in hypervDomainResume

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index dd5c42c45b..1eb3dbd48e 100644 --- a/src/hyperv/hyperv_driver.c +++

[PATCH 10/55] hyperv: use g_autoptr for Msvm_ProcessorSettingData in hypervConnectGetMaxVcpus

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 8b59dd05f7..6375f6b011 100644 --- a/src/hyperv/hyperv_driver.c +++

[PATCH 20/55] hyperv: use g_autoptr for WMI classes in hypervDomainGetMaxMemory

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 7da4c216b1..2ec0415f62 100644 --- a/src/hyperv/hyperv_driver.c +++

[PATCH 05/55] hyperv: enable use of g_autoptr for hypervObject

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_wmi.c | 3 +-- src/hyperv/hyperv_wmi.h | 1 + 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/hyperv/hyperv_wmi.c b/src/hyperv/hyperv_wmi.c index 241993f2be..2a4377a12f 100644 --- a/src/hyperv/hyperv_wmi.c +++

[PATCH 03/55] hyperv: add inheritance to the WMI generator

This enables casting subtypes to their parent. Signed-off-by: Matt Coleman --- scripts/hyperv_wmi_generator.py | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/scripts/hyperv_wmi_generator.py b/scripts/hyperv_wmi_generator.py index d72e5d8ca1..e5e961d2db 100755

[PATCH 18/55] hyperv: use g_autoptr for WMI classes in hypervDomainShutdownFlags

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 23 --- 1 file changed, 8 insertions(+), 15 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 1eb3dbd48e..fcb764c0f7 100644 --- a/src/hyperv/hyperv_driver.c +++

[PATCH 26/55] hyperv: use g_autoptr for Msvm_DiskDrive in hypervDomainDefParsePhysicalDisk

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 06eee379a1..40e4c97d35 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv/hyperv_driver.c @@

[PATCH 22/55] hyperv: use g_autoptr for Msvm_ComputerSystem in hypervRequestStateChange

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index f3fe88926e..ef3ae54f7d 100644 --- a/src/hyperv/hyperv_driver.c +++

[PATCH 07/55] hyperv: enable automatic cleanup for OpenWSMAN types

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_private.h | 3 +-- src/hyperv/hyperv_wsman.h | 28 2 files changed, 29 insertions(+), 2 deletions(-) create mode 100644 src/hyperv/hyperv_wsman.h diff --git a/src/hyperv/hyperv_private.h

[PATCH 09/55] hyperv: use g_autoptr for Win32_ComputerSystem in hypervConnectGetHostname

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 830a3414c5..8b59dd05f7 100644 --- a/src/hyperv/hyperv_driver.c +++

[PATCH 19/55] hyperv: use g_autoptr for Msvm_ComputerSystem in hypervDomainDestroyFlags

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index fcb764c0f7..7da4c216b1 100644 --- a/src/hyperv/hyperv_driver.c +++

[PATCH 23/55] hyperv: use g_autoptr for Win32_ComputerSystemProduct in hypervLookupHostSystemBiosUuid

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index ef3ae54f7d..3c4ef5f33f 100644 --- a/src/hyperv/hyperv_driver.c +++

[PATCH 12/55] hyperv: use g_autoptr for Msvm_ComputerSystem in hypervConnectNumOfDomains

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index e2773d0d2f..efafe9ece2 100644 --- a/src/hyperv/hyperv_driver.c +++

[PATCH 14/55] hyperv: use g_autoptr for Msvm_ComputerSystem in hypervDomainLookupByID

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 45463d120d..e5a62c728b 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv/hyperv_driver.c @@

[PATCH 15/55] hyperv: use g_autoptr for Msvm_ComputerSystem in hypervDomainLookupByUUID

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index e5a62c728b..fe1ab1c52c 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv/hyperv_driver.c @@

[PATCH 08/55] hyperv: use g_autoptr for Win32_OperatingSystem in hypervConnectOpen

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 680d8b762b..830a3414c5 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv/hyperv_driver.c @@

[PATCH 11/55] hyperv: use g_autoptr for WMI classes in hypervNodeGetInfo

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 6375f6b011..e2773d0d2f 100644 --- a/src/hyperv/hyperv_driver.c +++

[PATCH 02/55] hyperv: store the Hyper-V version when connecting

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_driver.c | 62 + src/hyperv/hyperv_private.h | 1 + 2 files changed, 37 insertions(+), 26 deletions(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 2399b5df7d..1ac379c14f 100644

[PATCH 00/55] Hyper-V: code cleanup & prep for future changes

This series of patches simplifies the code in several ways and makes a few changes required by the next round of patches that I'll submit. Simplifications: * add a macro to cut down on repetitive SettingData code * enable GLib auto-cleanup for hypervObject and several OpenWSMAN types Changes:

[PATCH 01/55] hyperv: add a macro for retrieving setting data

Signed-off-by: Matt Coleman --- src/hyperv/hyperv_wmi.c | 52 + 1 file changed, 16 insertions(+), 36 deletions(-) diff --git a/src/hyperv/hyperv_wmi.c b/src/hyperv/hyperv_wmi.c index 4bace10874..d89aeb1874 100644 --- a/src/hyperv/hyperv_wmi.c +++

[PATCH] spec: Increase meson test timeout 10x

Tests time out when building in slow environments, like emulated s390x in Fedora copr. Bump up the test timeout Signed-off-by: Cole Robinson --- libvirt.spec.in | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 0a8b0ebad4..1731aa8bd9

[libvirt PATCH v2 13/13] storage_source: use virStorageSource prefix for all functions

Signed-off-by: Pavel Hrdina --- src/libvirt_private.syms | 42 ++--- src/qemu/qemu_backup.c| 8 +- src/qemu/qemu_block.c | 6 +- src/qemu/qemu_domain.c| 16 +- src/qemu/qemu_driver.c| 66 +++

[libvirt PATCH v2 12/13] virstoragefile: use virStorageFile prefix for all functions

Signed-off-by: Pavel Hrdina --- src/libvirt_private.syms | 4 ++-- src/qemu/qemu_block.c | 2 +- src/qemu/qemu_snapshot.c | 2 +- src/storage_file/storage_source.c | 6 +++--- src/util/virstoragefile.c | 6 +++--- src/util/virstoragefile.h | 4 ++--

[libvirt PATCH v2 11/13] util: move virStorageEncryption code into conf

The code handles XML bits and internal definition and should be in conf directory. Signed-off-by: Pavel Hrdina --- po/POTFILES.in | 2 +- src/conf/domain_conf.h | 2 +- src/conf/meson.build |

[libvirt PATCH v2 09/13] util: move virStorageFileProbe code into storage_file

Same as virStorageFileBackend, it doesn't belong into util directory. Signed-off-by: Pavel Hrdina --- po/POTFILES.in | 2 +- src/libvirt_private.syms | 10 +- src/qemu/qemu_driver.c |

[libvirt PATCH v2 10/13] util: move virStorageSource code into conf

The code handles XML bits and internal definition and should be in conf directory. Signed-off-by: Pavel Hrdina --- po/POTFILES.in |1 + src/conf/backup_conf.c |2 +- src/conf/checkpoint_conf.c |2 +- src/conf/domain_conf.c

[libvirt PATCH v2 06/13] util: extract storage file probe code into virtstoragefileprobe.c

This code is not directly relevant to virStorageSource so move it to separate file. Signed-off-by: Pavel Hrdina --- po/POTFILES.in| 1 + src/libvirt_private.syms | 6 +- src/qemu/qemu_driver.c| 1 + src/storage/storage_backend_gluster.c

[libvirt PATCH v2 02/13] virstoragefile: properly include virstoragefile.h header

It was indirectly included by virstoragefilebackend.h. Signed-off-by: Pavel Hrdina --- src/util/virstoragefile.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c index 0d3c2af94f..17579126b0 100644 ---

[libvirt PATCH v2 08/13] util: move virStorageFileBackend code into storage_file

It's used only by storage file code so it doesn't make sense to have it in util directory. Signed-off-by: Pavel Hrdina --- po/POTFILES.in| 2 +- src/libvirt_private.syms | 8 src/storage_file/meson.build

[libvirt PATCH v2 05/13] util: move virStorageSourceFindByNodeName into qemu_domain

It's only relevant for QEMU driver. Signed-off-by: Pavel Hrdina --- src/libvirt_private.syms | 1 - src/qemu/qemu_domain.c| 38 -- src/util/virstoragefile.c | 25 - src/util/virstoragefile.h | 5 - 4 files changed, 32

[libvirt PATCH v2 01/13] src: add missing virstoragefile.h includes

These files are using functions from virstoragefile.h but are missing explicit include. Signed-off-by: Pavel Hrdina --- src/locking/lock_driver_lockd.c| 1 + src/qemu/qemu_block.c | 1 + src/qemu/qemu_snapshot.c | 1 + src/security/virt-aa-helper.c | 1 +

[libvirt PATCH v2 03/13] virstoragefile: change virStorageSource->drv to void pointer

This will allow following patches to move virStorageSource into conf directory and virStorageDriverData into a new storage_file directory. Signed-off-by: Pavel Hrdina Reviewed-by: Peter Krempa --- src/storage/storage_file_fs.c | 21 +++-- src/storage/storage_file_gluster.c | 31 +---

[libvirt PATCH v2 04/13] storage: move storage file sources to separate directory

Introduce a new storage_file directory where we will keep storage file related code. Signed-off-by: Pavel Hrdina --- po/POTFILES.in| 4 +- src/meson.build | 1 + src/storage/meson.build | 30 +--

[libvirt PATCH v2 00/13] second part of cleanup storage source related code

Pavel Hrdina (13): src: add missing virstoragefile.h includes virstoragefile: properly include virstoragefile.h header virstoragefile: change virStorageSource->drv to void pointer storage: move storage file sources to separate directory util: move virStorageSourceFindByNodeName into

Re: [PATCH 00/55] Hyper-V: code cleanup & prep for future changes

On Thu, Jan 21, 2021 at 1:53 PM Matt Coleman wrote: > > This series of patches simplifies the code in several ways and makes a > few changes required by the next round of patches that I'll submit. > > Simplifications: > > * add a macro to cut down on repetitive SettingData code > * enable GLib

[PATCH] virNetworkDHCPLeaseTimeDefParseXML: Output error when 'expiry' can't be parsed

virStrToLong_ul doesn't report it's own error. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1918674 Signed-off-by: Peter Krempa --- src/conf/network_conf.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index

Re: [libvirt PATCH 0/8] Remove space-padded alignment from public headers

On Thu, 21 Jan 2021 08:38:06 +0100 Erik Skultety wrote: > On Wed, Jan 20, 2021 at 11:33:41AM -0600, Jonathon Jongsma wrote: > > Erik Skultety suggested posting a separate series removing the > > space-padded alignment of function declarations in the public > > headers. > > This is already an

Re: [PATCH] NEWS: Document virtio-pmem model

On Thu, 2021-01-21 at 13:23 +0100, Michal Privoznik wrote: > A few commits ago I've implemented virtio-pmem memory model. > Mention it in the news file. > > Signed-off-by: Michal Privoznik > --- > NEWS.rst | 5 + > 1 file changed, 5 insertions(+) Reviewed-by: Andrea Bolognani -- Andrea

[PATCH] NEWS: Document virtio-pmem model

A few commits ago I've implemented virtio-pmem memory model. Mention it in the news file. Signed-off-by: Michal Privoznik --- NEWS.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 64e6847673..7a2d6649b4 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -13,6 +13,11

[PATCH v2 0/2] Support Link non uplink representors to PCI device

Kernel 5.8 link VF representors to their parent PCI device similar to existing uplink representor netdevice [1]. This patch update the virPCIGetNetName to support kernel describe above. Updates in V2 per of Laine's comments 1. split v1 patch to 2 patches. first patch for the new util method 2.

[PATCH v2 2/2] util: Add phys_port_name support on virPCIGetNetName

From: Dmytro Linkin Current virPCIGetNetName() logic is to get net device name by checking it's phys_port_id, if caller provide it, or by it's index (eg, by it's position at sysfs net directory). This approach worked fine up until linux kernel version 5.8, where NVIDIA Mellanox driver

[PATCH v2 1/2] util: add virNetDevGetPhysPortName

This commit add virNetDevGetPhysPortName to read netdevice phys_port_name from sysfs. It also refactor the code so virNetDevGetPhysPortName and virNetDevGetPhysPortID will use same method to read the netdevice sysfs. --- src/util/virnetdev.c | 74 +++-

Re: [PATCH v2 00/10] hyperv: implement defining/undefining domains

On 1/14/21 2:03 PM, Matt Coleman wrote: This series starts by fixing a some dangerous behavior due to ambiguous VM names, since Hyper-V allows multiple VMs to be defined with the same name. That meant that `virsh dumpxml` could return XML for the wrong domain. Additionally, when I implemented