On Thu, Jan 28, 2021 at 15:21:28 +0100, Tim Wiederhake wrote:
> On Thu, 2021-01-28 at 11:54 +0100, Peter Krempa wrote:
> > On Thu, Jan 28, 2021 at 11:24:40 +0100, Tim Wiederhake wrote:
> > > `val` is declared `ATTRIBUTE_NONNULL`.
> >
> > Please see:
> >
> > https://gitlab.com/libvirt/libvirt/-/bl
On Thu, Jan 28, 2021 at 12:20:13PM -0700, Jim Fehlig wrote:
> Further testing revealed commit f035f53baa regresses Debian bug 955216
>
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=955216
>
> Restarting libvirt-guests on libvirtd restart is worse than the original
> dependency issue, so rev
The channel subsystem elements describe a channel in the I/O subsystem
of a s390x machine, and not a normal device (like a disk or network card).
Reword the documentation here to make it this a little bit clearer.
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1898074
Signed-off-by: Thomas H
On 1/28/21 1:42 PM, Michal Privoznik wrote:
On 1/27/21 7:46 PM, Boris Fiuczynski wrote:
Add virtio related options iommu, ats and packed as driver element
attributes
to vsock devices. Ex:
Signed-off-by: Boris Fiuczynski
---
docs/formatdomain.rst | 2
On Fri, 29 Jan 2021 11:04:44 +0100
Thomas Huth wrote:
> The channel subsystem elements describe a channel in the I/O subsystem
> of a s390x machine, and not a normal device (like a disk or network card).
> Reword the documentation here to make it this a little bit clearer.
>
> Buglink: https://b
On 1/29/21 11:08 AM, Boris Fiuczynski wrote:
On 1/28/21 1:42 PM, Michal Privoznik wrote:
On 1/27/21 7:46 PM, Boris Fiuczynski wrote:
Add virtio related options iommu, ats and packed as driver element
attributes
to vsock devices. Ex:
Signed-off-by: Boris Fiuczynski
---
docs
On a Thursday in 2021, Michal Privoznik wrote:
I've noticed these while reviewing Boris' patch:
https://www.redhat.com/archives/libvir-list/2021-January/msg01149.html
Michal Prívozník (3):
conf: Move virDomainCheckVirtioOptions() into domain_validate.c
conf: Drop empty virDomainNetDefPostPars
On 1/27/21 7:46 PM, Boris Fiuczynski wrote:
Add virtio related options iommu, ats and packed as driver element attributes
to vsock devices. Ex:
Signed-off-by: Boris Fiuczynski
---
docs/formatdomain.rst | 2 +
docs/schemas/domaincommon.rng
Rename virDomainCheckVirtioOptions into
virDomainCheckVirtioOptionsAreAbent since it checks if all virtio
options are absent. The old name was very misleading.
Signed-off-by: Boris Fiuczynski
---
src/conf/domain_validate.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
On 1/29/21 12:27 PM, Michal Privoznik wrote:
On 1/27/21 7:46 PM, Boris Fiuczynski wrote:
Add virtio related options iommu, ats and packed as driver element
attributes
to vsock devices. Ex:
Signed-off-by: Boris Fiuczynski
---
docs/formatdomain.rst |
On 1/29/21 8:39 AM, Boris Fiuczynski wrote:
Rename virDomainCheckVirtioOptions into
virDomainCheckVirtioOptionsAreAbent since it checks if all virtio
s/virDomainCheckVirtioOptionsAreAbent/virDomainCheckVirtioOptionsAreAbsent
options are absent. The old name was very misleading.
Signed-off
On 1/29/21 11:04 AM, Thomas Huth wrote:
The channel subsystem elements describe a channel in the I/O subsystem
of a s390x machine, and not a normal device (like a disk or network card).
Reword the documentation here to make it this a little bit clearer.
Buglink: https://bugzilla.redhat.com/show_
On 1/27/21 2:59 PM, Michal Privoznik wrote:
Since we've switched to meson our tests run with a timeout (meson
uses 30 seconds as the default). However, not every machine that
builds libvirt is fast enough to run every test under 30 seconds
(each test binary has its own timeout, but still). For
On Fri, Jan 29, 2021 at 12:39:22 +0100, Boris Fiuczynski wrote:
> Rename virDomainCheckVirtioOptions into
> virDomainCheckVirtioOptionsAreAbent since it checks if all virtio
> options are absent. The old name was very misleading.
We usually have functions which check presence using the 'Has' verb,
On Fri, Jan 29, 2021 at 12:39:22PM +0100, Boris Fiuczynski wrote:
> Rename virDomainCheckVirtioOptions into
> virDomainCheckVirtioOptionsAreAbent since it checks if all virtio
> options are absent. The old name was very misleading.
>
> Signed-off-by: Boris Fiuczynski
> ---
> src/conf/domain_vali
On 1/29/21 12:48 PM, Daniel Henrique Barboza wrote:
On 1/29/21 8:39 AM, Boris Fiuczynski wrote:
Rename virDomainCheckVirtioOptions into
virDomainCheckVirtioOptionsAreAbent since it checks if all virtio
s/virDomainCheckVirtioOptionsAreAbent/virDomainCheckVirtioOptionsAreAbsent
options are a
On 1/29/21 1:35 PM, Pavel Hrdina wrote:
On Fri, Jan 29, 2021 at 12:39:22PM +0100, Boris Fiuczynski wrote:
Rename virDomainCheckVirtioOptions into
virDomainCheckVirtioOptionsAreAbent since it checks if all virtio
options are absent. The old name was very misleading.
Signed-off-by: Boris Fiuczyns
On Fri, Jan 29, 2021 at 09:30:24AM -0300, Daniel Henrique Barboza wrote:
>
>
> On 1/27/21 2:59 PM, Michal Privoznik wrote:
> > Since we've switched to meson our tests run with a timeout (meson
> > uses 30 seconds as the default). However, not every machine that
> > builds libvirt is fast enough t
On Wed, Jan 27, 2021 at 06:59:58PM +0100, Michal Privoznik wrote:
> Since we've switched to meson our tests run with a timeout (meson
> uses 30 seconds as the default). However, not every machine that
> builds libvirt is fast enough to run every test under 30 seconds
> (each test binary has its own
On Fri, Jan 29, 2021 at 09:30:24AM -0300, Daniel Henrique Barboza wrote:
>
>
> On 1/27/21 2:59 PM, Michal Privoznik wrote:
> > Since we've switched to meson our tests run with a timeout (meson
> > uses 30 seconds as the default). However, not every machine that
> > builds libvirt is fast enough t
Parameter 'known_hosts_verify' is supported for some time now,
but it is not yet documented.
Ref.:
https://gitlab.com/libvirt/libvirt/-/blob/master/src/rpc/virnetsocket.c#L941
https://gitlab.com/libvirt/libvirt/-/blob/master/src/rpc/virnetsocket.c#L1073
---
docs/uri.html.in | 17 +
On 1/29/21 1:30 PM, Daniel Henrique Barboza wrote:
On 1/27/21 2:59 PM, Michal Privoznik wrote:
Since we've switched to meson our tests run with a timeout (meson
uses 30 seconds as the default). However, not every machine that
builds libvirt is fast enough to run every test under 30 seconds
(ea
On 1/29/21 1:45 PM, Pavel Hrdina wrote:
On Fri, Jan 29, 2021 at 09:30:24AM -0300, Daniel Henrique Barboza wrote:
On 1/27/21 2:59 PM, Michal Privoznik wrote:
Since we've switched to meson our tests run with a timeout (meson
uses 30 seconds as the default). However, not every machine that
build
On Fri, Jan 29, 2021 at 02:07:31PM +0100, Michal Privoznik wrote:
> On 1/29/21 1:45 PM, Pavel Hrdina wrote:
> > On Fri, Jan 29, 2021 at 09:30:24AM -0300, Daniel Henrique Barboza wrote:
> > >
> > >
> > > On 1/27/21 2:59 PM, Michal Privoznik wrote:
> > > > Since we've switched to meson our tests ru
Our docs have not been fully updated to reflect the separate
build directory.
Suggested-by: Laszlo Ersek
Signed-off-by: Ján Tomko
---
docs/compiling.html.in | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/docs/compiling.html.in b/docs/compiling.html.in
index c2c9d9f0ed
On a Thursday in 2021, Laszlo Ersek wrote:
On 01/28/21 16:15, Ján Tomko wrote:
Sadly, the replies changes for older QEMUs are synthetic.
Separated for easier review.
Also available on gitlab:
git fetch https://gitlab.com/janotomko/libvirt/ virtiofs-bootindex
https://gitlab.com/janotomko/libvirt
On 1/29/21 10:04 AM, Michal Privoznik wrote:
On 1/29/21 1:30 PM, Daniel Henrique Barboza wrote:
On 1/27/21 2:59 PM, Michal Privoznik wrote:
Since we've switched to meson our tests run with a timeout (meson
uses 30 seconds as the default). However, not every machine that
builds libvirt is f
Signed-off-by: Ján Tomko
---
NEWS.rst | 5 +
1 file changed, 5 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index 7a2d6649b4..8b8a132e41 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -18,6 +18,11 @@ v7.1.0 (unreleased)
The virtio-pmem is a virtio variant of NVDIMM and just like NVDIMM
On 1/29/21 2:25 PM, Pavel Hrdina wrote:
On Fri, Jan 29, 2021 at 02:07:31PM +0100, Michal Privoznik wrote:
On 1/29/21 1:45 PM, Pavel Hrdina wrote:
On Fri, Jan 29, 2021 at 09:30:24AM -0300, Daniel Henrique Barboza wrote:
So we agree that timeouts are evil :-) Back in the autotools days we di
The channel subsystem elements describe a channel in the I/O subsystem
of a s390x machine, and not a normal device (like a disk or network card).
Reword the documentation here to make it this a little bit clearer.
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1898074
Reviewed-by: Boris Fiuc
On 1/29/21 2:39 PM, Ján Tomko wrote:
Signed-off-by: Ján Tomko
---
NEWS.rst | 5 +
1 file changed, 5 insertions(+)
Reviewed-by: Michal Privoznik
Michal
On 1/29/21 2:29 PM, Ján Tomko wrote:
Our docs have not been fully updated to reflect the separate
build directory.
Suggested-by: Laszlo Ersek
Signed-off-by: Ján Tomko
---
docs/compiling.html.in | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Michal Privoznik
Mic
On Fri, 2021-01-29 at 12:48 +, Daniel P. Berrangé wrote:
> On Wed, Jan 27, 2021 at 06:59:58PM +0100, Michal Privoznik wrote:
> > Since we've switched to meson our tests run with a timeout (meson
> > uses 30 seconds as the default). However, not every machine that
> > builds libvirt is fast enou
On Fri, Jan 29, 2021 at 03:46:18PM +0100, Andrea Bolognani wrote:
> On Fri, 2021-01-29 at 12:48 +, Daniel P. Berrangé wrote:
> > On Wed, Jan 27, 2021 at 06:59:58PM +0100, Michal Privoznik wrote:
> > > Since we've switched to meson our tests run with a timeout (meson
> > > uses 30 seconds as the
On Fri, 29 Jan 2021 15:37:26 +0100
Thomas Huth wrote:
> The channel subsystem elements describe a channel in the I/O subsystem
> of a s390x machine, and not a normal device (like a disk or network card).
> Reword the documentation here to make it this a little bit clearer.
>
> Buglink: https://b
On 1/29/21 3:53 PM, Daniel P. Berrangé wrote:
On Fri, Jan 29, 2021 at 03:46:18PM +0100, Andrea Bolognani wrote:
On Fri, 2021-01-29 at 12:48 +, Daniel P. Berrangé wrote:
On Wed, Jan 27, 2021 at 06:59:58PM +0100, Michal Privoznik wrote:
Since we've switched to meson our tests run with a time
On Fri, 2021-01-29 at 14:53 +, Daniel P. Berrangé wrote:
> On Fri, Jan 29, 2021 at 03:46:18PM +0100, Andrea Bolognani wrote:
> > On Fri, 2021-01-29 at 12:48 +, Daniel P. Berrangé wrote:
> > > I'm not convinced we want to optimize for the slowest hardware
> > > we can find, especially when t
On Fri, Jan 29, 2021 at 04:14:30PM +0100, Michal Privoznik wrote:
> On 1/29/21 3:53 PM, Daniel P. Berrangé wrote:
> > On Fri, Jan 29, 2021 at 03:46:18PM +0100, Andrea Bolognani wrote:
> > > On Fri, 2021-01-29 at 12:48 +, Daniel P. Berrangé wrote:
> > > > On Wed, Jan 27, 2021 at 06:59:58PM +0100
On Fri, Jan 29, 2021 at 17:34:02 +0300, Aleksei Zakharov wrote:
> This commit adds delay time (steal time inside guest) to libvirt
> domain CPU stats. It's more convenient to work with this statistic
> in a context of libvirt domain. Any monitoring software may use
> this information.
Please prima
On Fri, Jan 29, 2021 at 04:20:53PM +0100, Andrea Bolognani wrote:
> On Fri, 2021-01-29 at 14:53 +, Daniel P. Berrangé wrote:
> > On Fri, Jan 29, 2021 at 03:46:18PM +0100, Andrea Bolognani wrote:
> > > On Fri, 2021-01-29 at 12:48 +, Daniel P. Berrangé wrote:
> > > > I'm not convinced we want
On 1/22/21 6:40 PM, Daniel Henrique Barboza wrote:
Michal,
I see that this patch was sent standalone in the ML, and the cover-letter
of the series doesn't mention it. Is this an ooopsie? Should I review this
patch together with the rest of the series?
Yeah, that's what I get for not removing
Peter, thanks a lot for the review! I'll come back with fixes.
пт, 29 янв. 2021 г. в 18:25, Peter Krempa :
>
> On Fri, Jan 29, 2021 at 17:34:02 +0300, Aleksei Zakharov wrote:
> > This commit adds delay time (steal time inside guest) to libvirt
> > domain CPU stats. It's more convenient to work wit
On Fri, 2021-01-29 at 15:28 +, Daniel P. Berrangé wrote:
> On Fri, Jan 29, 2021 at 04:20:53PM +0100, Andrea Bolognani wrote:
> > the timeout multiplier has been added to the upstream spec file,
> > which the Fedora spec file is based on, so while you're correct that
> > Fedora is not yet using
On Fri, Jan 29, 2021 at 04:56:07PM +0100, Andrea Bolognani wrote:
> On Fri, 2021-01-29 at 15:28 +, Daniel P. Berrangé wrote:
> > On Fri, Jan 29, 2021 at 04:20:53PM +0100, Andrea Bolognani wrote:
> > > the timeout multiplier has been added to the upstream spec file,
> > > which the Fedora spec f
I stumbled upon a buffer overflow / stack smash present in
"test/commandhelper.c" that could be triggered by e.g.
$ ./tests/commandhelper --readfd 0 --readfd 0 --readfd 0 --readfd x
Could not parse fd x
*** stack smashing detected ***: terminated
Aborted (core dumped)
This series cleans u
Signed-off-by: Tim Wiederhake
---
tests/commandhelper.c | 16
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/tests/commandhelper.c b/tests/commandhelper.c
index ba5681b715..c2040b76f0 100644
--- a/tests/commandhelper.c
+++ b/tests/commandhelper.c
@@ -60,7 +60,6 @@
Signed-off-by: Tim Wiederhake
---
tests/commandhelper.c | 83 +--
1 file changed, 57 insertions(+), 26 deletions(-)
diff --git a/tests/commandhelper.c b/tests/commandhelper.c
index a77bee931f..c44322502f 100644
--- a/tests/commandhelper.c
+++ b/tests/comma
Comparing only the keys produces the same result as comparing keys and
value. The latter saves two invocations of each `strndup` and `free`.
Signed-off-by: Tim Wiederhake
---
tests/commandhelper.c | 17 +
1 file changed, 1 insertion(+), 16 deletions(-)
diff --git a/tests/command
Signed-off-by: Tim Wiederhake
---
tests/commandhelper.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tests/commandhelper.c b/tests/commandhelper.c
index 2be121ce2c..a964420d81 100644
--- a/tests/commandhelper.c
+++ b/tests/commandhelper.c
@@ -56,6 +56,7 @@ int main(int
Preparation for later conversion to g_auto* memory handling.
Signed-off-by: Tim Wiederhake
---
tests/commandhelper.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/tests/commandhelper.c b/tests/commandhelper.c
index 05e3879688..2be121ce2c 100644
--- a/tests/comman
Signed-off-by: Tim Wiederhake
---
tests/commandhelper.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/commandhelper.c b/tests/commandhelper.c
index a964420d81..a77bee931f 100644
--- a/tests/commandhelper.c
+++ b/tests/commandhelper.c
@@ -65,8 +65,6 @@ int main(in
Signed-off-by: Tim Wiederhake
---
tests/commandhelper.c | 57 +++
1 file changed, 36 insertions(+), 21 deletions(-)
diff --git a/tests/commandhelper.c b/tests/commandhelper.c
index aa346f1dfd..14c7302633 100644
--- a/tests/commandhelper.c
+++ b/tests/comma
Signed-off-by: Tim Wiederhake
---
tests/commandhelper.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/tests/commandhelper.c b/tests/commandhelper.c
index c44322502f..aa346f1dfd 100644
--- a/tests/commandhelper.c
+++ b/tests/commandhelper.c
@@ -80,6 +80,15 @@ s
Signed-off-by: Tim Wiederhake
---
tests/commandhelper.c | 16 +++-
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/tests/commandhelper.c b/tests/commandhelper.c
index c2040b76f0..2b937979c0 100644
--- a/tests/commandhelper.c
+++ b/tests/commandhelper.c
@@ -67,7 +67,6 @@
Signed-off-by: Tim Wiederhake
---
tests/commandhelper.c | 37 -
1 file changed, 24 insertions(+), 13 deletions(-)
diff --git a/tests/commandhelper.c b/tests/commandhelper.c
index 14c7302633..fa32f6a435 100644
--- a/tests/commandhelper.c
+++ b/tests/commandhelp
Signed-off-by: Tim Wiederhake
---
tests/commandhelper.c | 26 ++
1 file changed, 14 insertions(+), 12 deletions(-)
diff --git a/tests/commandhelper.c b/tests/commandhelper.c
index fa32f6a435..01dd6f9e45 100644
--- a/tests/commandhelper.c
+++ b/tests/commandhelper.c
@@ -15
Signed-off-by: Tim Wiederhake
---
tests/commandhelper.c | 42 ++
1 file changed, 26 insertions(+), 16 deletions(-)
diff --git a/tests/commandhelper.c b/tests/commandhelper.c
index 01dd6f9e45..929de7a05d 100644
--- a/tests/commandhelper.c
+++ b/tests/comman
Signed-off-by: Tim Wiederhake
---
tests/commandhelper.c | 65 ++-
1 file changed, 39 insertions(+), 26 deletions(-)
diff --git a/tests/commandhelper.c b/tests/commandhelper.c
index 929de7a05d..d501e33e88 100644
--- a/tests/commandhelper.c
+++ b/tests/comma
Fixes a buffer overflow triggered when more than three "--readfd"
arguments were given on the command line.
Signed-off-by: Tim Wiederhake
---
tests/commandhelper.c | 25 -
1 file changed, 20 insertions(+), 5 deletions(-)
diff --git a/tests/commandhelper.c b/tests/command
Signed-off-by: Tim Wiederhake
---
tests/commandhelper.c | 38 +-
1 file changed, 17 insertions(+), 21 deletions(-)
diff --git a/tests/commandhelper.c b/tests/commandhelper.c
index 6d5fe04042..e616f92987 100644
--- a/tests/commandhelper.c
+++ b/tests/commandhel
Fixes a buffer overflow triggered when more than three "--readfd"
arguments were given on the command line.
Signed-off-by: Tim Wiederhake
---
tests/commandhelper.c | 18 --
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/tests/commandhelper.c b/tests/commandhelper.
Signed-off-by: Tim Wiederhake
---
tests/commandhelper.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/tests/commandhelper.c b/tests/commandhelper.c
index e616f92987..26a7de5149 100644
--- a/tests/commandhelper.c
+++ b/tests/commandhelper.c
@@ -108,16 +108,15 @@
Signed-off-by: Tim Wiederhake
---
tests/commandhelper.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tests/commandhelper.c b/tests/commandhelper.c
index 26a7de5149..3bd7d2b28d 100644
--- a/tests/commandhelper.c
+++ b/tests/commandhelper.c
@@ -172,7 +172,7 @@ static void p
Signed-off-by: Tim Wiederhake
---
tests/commandhelper.c | 24
1 file changed, 8 insertions(+), 16 deletions(-)
diff --git a/tests/commandhelper.c b/tests/commandhelper.c
index 3bd7d2b28d..940a979a3f 100644
--- a/tests/commandhelper.c
+++ b/tests/commandhelper.c
@@ -306,3
Unless there are any objections to it, I'm planning to push these two
patches later today or tomorrow. (Dan - I've Cc'ed you since you were
the only one to respond to V1)
After that, I'm wondering if it would be okay to backport it into Fedora
Rawhide so that it makes it into Fedora 34 (since
On Fri, Jan 29, 2021 at 17:16:13 +0100, Tim Wiederhake wrote:
> Comparing only the keys produces the same result as comparing keys and
> value. The latter saves two invocations of each `strndup` and `free`.
env variable names allow also ascii chars with lower index than '=' such
as numbers:
$ TES
On 1/24/21 7:44 AM, Laine Stump wrote:
V1 here: https://www.redhat.com/archives/libvir-list/2021-January/msg00922.html
A short version of the cover letter from V1: this is a followup to my
proposal to stop using netcf for the interface driver backend in
Fedora/RHEL/CentOS builds and use the udev
On Sun, Jan 24, 2021 at 01:44:26AM -0500, Laine Stump wrote:
> libvirt.spec currently adds a hardcoded -Dnetcf=enabled to the meson
> commandline, so just setting the default in the meson.build file won't
> have any effect for rpm builds - it will be overridden.
>
> This patch changes the meson co
The following changes since commit 5101d00d2f1138a73344dc4833587f76d7a5fa5c:
Merge remote-tracking branch 'remotes/vivier2/tags/trivial-branch-for-6.0-p=
ull-request' into staging (2021-01-29 10:10:43 +)
are available in the Git repository at:
https://gitlab.com/berrange/qemu tags/misc-f
From: shiliyang
This patch fixes error style problems found by checkpatch.pl:
ERROR: spaces required around that '*'
ERROR: space required after that ','
ERROR: spaces required around that '|'
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Liyang Shi
Signed-off-by: Daniel P. Berrangé
---
From: Kevin Wolf
Instead of duplicating the code for user creatable objects in secret and
secret_keyring, move it to the common base clase secret_common. As the
base class is abstract, it won't become user creatable itself.
Signed-off-by: Kevin Wolf
Signed-off-by: Daniel P. Berrangé
---
crypt
From: Kevin Wolf
qcrypto_secret_prop_set_loaded() forgets to reset secret->rawdata after
unloading a secret, which will lead to a double free at some point.
Because there is no use case for unloading an already loaded secret
(apart from deleting the whole secret object) and we know that nobody
c
From: Kevin Wolf
If you set the loaded property to true when it was already true, the
state is overwritten without freeing the old state first. Change the
set_loaded callback so that it always frees the old state (which is a
no-op if nothing was loaded) and only then load if requestsd.
Signed-of
The -enable-fips option was added a long time ago to prevent the use of
single DES when VNC when FIPS mode is enabled. It should never have been
added, because apps are supposed to unconditionally honour FIPS mode
based on the '/proc/sys/crypto/fips_enabled' file contents.
In addition there is mor
Update some docs and test cases to use 'on' | 'off' as the preferred
value for bool options.
Reviewed-by: Thomas Huth
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Daniel P. Berrangé
---
docs/system/vnc-security.rst | 10 +-
include/authz/listfile.h | 2 +-
qemu-options.hx
The distinction between short life and long life Linux distributions
turned out to be redundant. They can both be covered in a simple way
by noting support will target the current release, and the previous
release for a period of two years or until its EOL. This rule can also
apply to the other UNI
On 1/29/21 12:06 PM, Daniel P. Berrangé wrote:
On Sun, Jan 24, 2021 at 01:44:26AM -0500, Laine Stump wrote:
libvirt.spec currently adds a hardcoded -Dnetcf=enabled to the meson
commandline, so just setting the default in the meson.build file won't
have any effect for rpm builds - it will be over
Reviewed-by: Peter Maydell
Signed-off-by: Daniel P. Berrangé
---
docs/system/tls.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/system/tls.rst b/docs/system/tls.rst
index dc2b94257f..b0973afe1b 100644
--- a/docs/system/tls.rst
+++ b/docs/system/tls.rst
@@ -64,7 +64,
From: Dan Streetman
Replace the --enable-git-update and --disable-git-update configure params
with the param --with-git-submodules=(update|validate|ignore) to
allow 3 options for building from a git repo.
This is needed because downstream packagers, e.g. Debian, Ubuntu, etc,
also keep the source
From: shiliyang
I am reading crypto related code, find some code style problems while
using checkpatch.pl to check crypto folder. Fix the error style
problems.
Signed-off-by: Liyang Shi
Signed-off-by: Daniel P. Berrangé
---
crypto/aes.c| 4 ++--
crypto/desrfb.c | 2 +-
2 files changed, 3
Primarily this is to pull in a fix for Win32 keycodes. The other useful
change is the removal of build timestamp from generated files which is
desirable for reproducable builds.
The make rules need updating due to slightly changed CLI syntax - more
args must now come after the command name.
6119e
From: Stefan Weil
A test with sanitizers on macOS shows this error:
authz/pamacct.c:50:25: runtime error: null pointer passed as argument 1,
which is declared to never be null
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sec
From: Stefan Weil
This fixes several compiler warnings on MacOS with Homebrew. The
git development branch for forthcoming libtasn1 4.17.0 has introduced
deprecation warnings for several macros/types that we use.
Signed-off-by: Stefan Weil
Signed-off-by: Daniel P. Berrangé
---
tests/crypto-tls
On Fri, Jan 29, 2021 at 17:16:14 +0100, Tim Wiederhake wrote:
> Preparation for later conversion to g_auto* memory handling.
>
> Signed-off-by: Tim Wiederhake
> ---
> tests/commandhelper.c | 10 ++
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/tests/commandhelper.c
Patchew URL:
https://patchew.org/QEMU/20210129171102.4109641-1-berra...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210129171102.4109641-1-berra...@redhat.com
Subject: [PULL 00/13] Misc patches
=== TE
On Fri, Jan 29, 2021 at 18:17:36 +0100, Peter Krempa wrote:
> On Fri, Jan 29, 2021 at 17:16:14 +0100, Tim Wiederhake wrote:
> > Preparation for later conversion to g_auto* memory handling.
> >
> > Signed-off-by: Tim Wiederhake
> > ---
> > tests/commandhelper.c | 10 ++
> > 1 file changed
On Fri, Jan 29, 2021 at 06:17:36PM +0100, Peter Krempa wrote:
> On Fri, Jan 29, 2021 at 17:16:14 +0100, Tim Wiederhake wrote:
> > Preparation for later conversion to g_auto* memory handling.
> >
> > Signed-off-by: Tim Wiederhake
> > ---
> > tests/commandhelper.c | 10 ++
> > 1 file chang
On Fri, Jan 29, 2021 at 17:52:35 +, Daniel Berrange wrote:
> On Fri, Jan 29, 2021 at 06:17:36PM +0100, Peter Krempa wrote:
> > On Fri, Jan 29, 2021 at 17:16:14 +0100, Tim Wiederhake wrote:
> > > Preparation for later conversion to g_auto* memory handling.
> > >
> > > Signed-off-by: Tim Wiederh
On Fri, Jan 29, 2021 at 17:16:27 +0100, Tim Wiederhake wrote:
> Signed-off-by: Tim Wiederhake
> ---
> tests/commandhelper.c | 12 +++-
> 1 file changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/tests/commandhelper.c b/tests/commandhelper.c
> index e616f92987..26a7de5149 100644
>
On Fri, Jan 29, 2021 at 17:16:10 +0100, Tim Wiederhake wrote:
> I stumbled upon a buffer overflow / stack smash present in
> "test/commandhelper.c" that could be triggered by e.g.
>
> $ ./tests/commandhelper --readfd 0 --readfd 0 --readfd 0 --readfd x
> Could not parse fd x
> *** stack smash
On Fri, Jan 29, 2021 at 07:08:27PM +0100, Peter Krempa wrote:
> On Fri, Jan 29, 2021 at 17:16:27 +0100, Tim Wiederhake wrote:
> > Signed-off-by: Tim Wiederhake
> > ---
> > tests/commandhelper.c | 12 +++-
> > 1 file changed, 3 insertions(+), 9 deletions(-)
> >
> > diff --git a/tests/comm
On Fri, Jan 29, 2021 at 17:52:35 +, Daniel Berrange wrote:
> On Fri, Jan 29, 2021 at 06:17:36PM +0100, Peter Krempa wrote:
> > On Fri, Jan 29, 2021 at 17:16:14 +0100, Tim Wiederhake wrote:
> > > Preparation for later conversion to g_auto* memory handling.
> > >
> > > Signed-off-by: Tim Wiederh
On Tue, Jan 26, 2021 at 6:04 PM Peter Krempa wrote:
> On Tue, Jan 26, 2021 at 11:55:25 +0800, Han Han wrote:
> > Since the commit ccd3b3b811 of QEMU, the short-form boolean options in
> > qemu cmdline like "server", "nowait", "disable-ticketing" are deprecated:
> >
> > qemu-system-x86_64: -charde
On Fri, 29 Jan 2021 at 17:27, Daniel P. Berrangé wrote:
>
> The following changes since commit 5101d00d2f1138a73344dc4833587f76d7a5fa5c:
>
> Merge remote-tracking branch 'remotes/vivier2/tags/trivial-branch-for-6.0-p=
> ull-request' into staging (2021-01-29 10:10:43 +)
>
> are available in t
On Thu, 7 Jan 2021 17:43:54 +0100
Erik Skultety wrote:
> > Tested with v6.10.0-283-g1948d4e61e.
> >
> > 1.Can define/start/destroy mdev device successfully;
> >
> > 2.'virsh nodedev-list' has no '--active' option, which is
> > inconsistent with the description in the patch：
> > # virsh nodedev-
95 matches
Mail list logo
