tpm-tis device for ARM virt

2021-02-08 Thread Jim Fehlig
Hi All, I received a private bug report that starting a VM with swtpm device fails with qemu-system-aarch64. The VM config has QEMU reports the following error error: internal error: process exited while connecting to monitor: 2021-02-07T05:15:35.378927Z qemu-system-aarch6

generation of virtproxd socket files

2021-02-08 Thread Jim Fehlig
Hi All, I received a report [1] and verified that virtproxyd*.socket files have broken syntax. E.g. from virtproxyd.socket [Unit] Description=Libvirt proxy local socket Before=virtproxyd.service libvirtd.socket libvirtd-ro.socket libvirtd-admin.socket libvirtd-tcp.socket libvirtd-tls.socket

Re: [PATCH] rpc: avoid crash when system time jump back

2021-02-08 Thread Daniel P . Berrangé
On Mon, Feb 08, 2021 at 07:50:11PM +0100, Ján Tomko wrote: > On a Monday in 2021, BiaoxiangYe wrote: > > From: BiaoXiang Ye > > > > Setting the system time backward would lead to a > > multiplication overflow in function virKeepAliveStart. > > FunctionvirKeepAliveTimerInternal got the same bug to

Re: [PATCH] rpc: avoid crash when system time jump back

2021-02-08 Thread Ján Tomko
On a Monday in 2021, BiaoxiangYe wrote: From: BiaoXiang Ye Setting the system time backward would lead to a multiplication overflow in function virKeepAliveStart. FunctionvirKeepAliveTimerInternal got the same bug too. Backtrace below: #0 0xae898470 in raise () from /usr/lib64/libc.so

Re: [PATCH] qemu: Release device address on failed hotplug

2021-02-08 Thread Jiri Denemark
On Mon, Feb 08, 2021 at 16:14:54 +0100, Michal Privoznik wrote: > A few commits back I've introduced new 'virtio-pmem' > device. Since it's virtio it goes onto PCI bus. Therefore, on > hotplug new PCI address is generated (or provided one is > reserved). However, if hotplug fails (for whatever rea

[PATCH] qemu: Release device address on failed hotplug

2021-02-08 Thread Michal Privoznik
A few commits back I've introduced new 'virtio-pmem' device. Since it's virtio it goes onto PCI bus. Therefore, on hotplug new PCI address is generated (or provided one is reserved). However, if hotplug fails (for whatever reason) the address needs to be released. This is different to 'dimm' type

Re: [libvirt PATCH] conf: allow virtio driver attributes for vhostuser disk

2021-02-08 Thread Pavel Hrdina
On Sun, Feb 07, 2021 at 01:42:33PM +0800, Han Han wrote: > On Fri, Feb 5, 2021 at 8:08 PM Pavel Hrdina wrote: > > > All of these options are actually supported by vhostuser disk so > > we should allow them to be usable. > > > > Signed-off-by: Pavel Hrdina > > --- > > src/conf/domain_validate.c

Re: [PATCH] bhyve: auto allocate nmdm console paths

2021-02-08 Thread Ján Tomko
On a Sunday in 2021, Roman Bogorodskiy wrote: Currently, nmdm console device requires user to specify master and slave path attributes (such as /dev/nmdm0A and /dev/nmdm0B respectively). However, making user find a non-occupied device name might be not convenient, especially for the remote connec

Re: [libvirt PATCH] conf: allow virtio driver attributes for vhostuser disk

2021-02-08 Thread Peter Krempa
On Fri, Feb 05, 2021 at 13:07:41 +0100, Pavel Hrdina wrote: > All of these options are actually supported by vhostuser disk so > we should allow them to be usable. > > Signed-off-by: Pavel Hrdina > --- > src/conf/domain_validate.c| 20 --- > .../disk-vhostuser

[PATCH] rpc: avoid crash when system time jump back

2021-02-08 Thread BiaoxiangYe
From: BiaoXiang Ye Setting the system time backward would lead to a multiplication overflow in function virKeepAliveStart. FunctionvirKeepAliveTimerInternal got the same bug too. Backtrace below: #0 0xae898470 in raise () from /usr/lib64/libc.so.6 #1 0xae89981c in abort () fr

Re: [libvirt PATCH 0/3] cpu: Fix build on some aarch64 platforms

2021-02-08 Thread Pavel Hrdina
On Sun, Feb 07, 2021 at 02:45:56PM +0100, Andrea Bolognani wrote: > The current code was written under the assumption that any > platform that supports aarch64 will have either getauxval() > or elf_aux_info(), but that's not always true. > > Andrea Bolognani (3): > cpu: Only include if availabl

Re: [libvirt PATCH 1/3] cpu: Only include if available

2021-02-08 Thread Pavel Hrdina
On Sun, Feb 07, 2021 at 02:45:57PM +0100, Andrea Bolognani wrote: > It's glibc-specific, so it's not present on many non-Linux > targets that nonetheless support aarch64. Not true that it's glibc specific, it is available on FreeBSD as well but it provides elf_aux_info instead of getauxval. > >