Signed-off-by: Jim Fehlig
---
NEWS.rst | 17 +
1 file changed, 17 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index 6ca539b1cd..8cb26d4d4c 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -88,6 +88,23 @@ v7.1.0 (unreleased)
For more details why this is necessary see
`systemd
Some SRIOV PFs don't have a netdev associated with them (the spec
apparently doesn't require it). In most cases when libvirt is dealing
with an SRIOV VF, that VF must have a PF, and the PF *must* have an
associated netdev (the only way to set the MAC address of a VF is by
sending a netlink message
I hadn't caught the code omission because my migration tester system
was out of commission, and I stupidly assumed migration would
work. The docs typo was pure lack of attention.
This (sub) feature will be new for this release, and there is an open
BZ for it downstream, so it would be nice to get
When the parser and docs were enhanced to support a element
in a generic , the example XML for formatdomain.rst was
cut/pasted from the example for . In my haste I
neglected to remove the element (which is unused/ignored
for generic and change the closing tag from to
Commit 010ed0856b and commit db64acfbda introduced the ability to use
the element in a generic (previously it could only
be used with ). However, the patch omitted
one crucial detail - along with parsing the element in
, and adding the necessary info to the qemu commandline, we
also need to
In files: src/lxc/lxc_native: in lxcAddNetworkRouteDefinition(),
src/conf/networkcommon_conf: in virNetDevIPRouteCreate() and
virNetDevIPRouteParseXML()
Signed-off-by: Kristina Hanicova
---
src/conf/networkcommon_conf.c | 55 +++
src/lxc/lxc_native.c |
In files: src/conf/domain_conf: in virDomainNetIPInfoParseXML(),
src/lxc/lxc_native: in lxcAddNetworkRouteDefinition(),
src/vz/vz_sdk: in prlsdkGetRoutes(), src/conf/networkcommon_conf:
in virNetDevIPRouteCreate()
Signed-off-by: Kristina Hanicova
---
src/conf/domain_conf.c| 3 +--
Signed-off-by: Kristina Hanicova
---
src/conf/networkcommon_conf.c | 14 +-
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/src/conf/networkcommon_conf.c b/src/conf/networkcommon_conf.c
index 26eeb6dbda..e82dbc3d3d 100644
--- a/src/conf/networkcommon_conf.c
+++
This uses g_autofree (if possible) in file networkcommon_conf and
g_autoptr instead of virNetDevIPRouteFree where possible.
Kristina Hanicova (3):
networkcommon_conf: Use g_autofree where possible
Use g_autoptr instead of virNetDevIPRouteFree if possible
Remove redundant variables/labels
On Thu, Feb 11, 2021 at 02:44:38PM -0600, Eric Blake wrote:
> The value '1.1k' is inexact; 1126.4 bytes is not possible, so we
> happen to truncate it to 1126. Our use of fractional sizes is
> intended for convenience, but when a user specifies a fraction that is
> not a clean translation to
On 2/18/21 8:04 AM, Peng Liang wrote:
qemuMonitorUnregister will be called in multiple threads (e.g. threads
in rpc worker pool and the vm event thread). In some cases, it isn't
protected by the monitor lock, which may lead to call g_source_unref
more than one time and a use-after-free problem
On Thu, Feb 11, 2021 at 02:44:37PM -0600, Eric Blake wrote:
> Supporting '0x20M' looks odd, particularly since we have a 'B' suffix
> that is ambiguous for bytes, as well as a less-frequently-used 'E'
> suffix for extremely large exibytes. In practice, people using hex
> inputs are specifying
On 2/23/21 5:27 AM, Jim Fehlig wrote:
The libvirt libxl driver has no access to FDs associated with VM disks.
The disks are opened by libxl.so and any related FDs are not exposed to
applications. The prevents using virtlockd's auto-release feature to
release locks when the FD is closed.
On Wed, Feb 17, 2021 at 10:24:51AM +0100, Andrea Bolognani wrote:
> This is intended to be the perform a number of CI-related
> operations that currently are implemented in various different
> scripts written in various different programming languages; in
> this first iteration it does two things:
On a Tuesday in 2021, Kristina Hanicova wrote:
Via coccinelle (not the hanbag!)
s/hanbag/handbag/
spatches used:
@ rule1 @
identifier a, b;
symbol NULL;
@@
- b = a;
... when != a
- a = NULL;
+ b = g_steal_pointer();
@@
- *b = a;
... when != a
- a = NULL;
+ *b = g_steal_pointer();
Via coccinelle (not the hanbag!)
spatches used:
@ rule1 @
identifier a, b;
symbol NULL;
@@
- b = a;
... when != a
- a = NULL;
+ b = g_steal_pointer();
@@
- *b = a;
... when != a
- a = NULL;
+ *b = g_steal_pointer();
Signed-off-by: Kristina Hanicova
---
src/admin/admin_server.c
Signed-off-by: Kristina Hanicova
---
src/conf/netdev_bandwidth_conf.c | 16 +---
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/src/conf/netdev_bandwidth_conf.c b/src/conf/netdev_bandwidth_conf.c
index 4fb7aa4e3d..1ff3785677 100644
---
In functions: virNetDevBandwidthParseRate(),
virNetDevBandwidthParse()
Signed-off-by: Kristina Hanicova
---
src/conf/netdev_bandwidth_conf.c | 42 +---
1 file changed, 17 insertions(+), 25 deletions(-)
diff --git a/src/conf/netdev_bandwidth_conf.c
In: vshTableRowNew(), vshTablePrint(), vshTablePrintToStdout().
Signed-off-by: Kristina Hanicova
---
tools/vsh-table.c | 16 +---
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/tools/vsh-table.c b/tools/vsh-table.c
index d09cc9e14e..2e10abfc90 100644
---
In files: netdev_bandwidth_conf: in virNetDevBandwidthParse(),
bridge_driver: in networkPortSetParameters(), qemu_driver: in
qemuDomainSetInterfaceParameters(), test_driver: in
testDomainSetInterfaceParameters(), virnetdevbandwidthtest: in
testVirNetDevBandwidthSet()
Signed-off-by: Kristina
This uses g_autofree (if possible) in files: vsh-table,
netdev_bandwidth_conf and g_autoptr instead of
virNetDevBandwidthFree where possible.
Kristina Hanicova (4):
vsh-table: Use g_autofree where possible
netdev_bandwidth_conf: Use g_autofree where possible
Use g_autoptr instead
Peter Maydell writes:
> On Tue, 23 Feb 2021 at 09:33, Markus Armbruster wrote:
>> Misunderstanding: our JSON interpolation feature is *not* string
>> interpolation! It interpolates *objects* into the QObject built by the
>> parser.
>
> Given that it's basically undocumented except in a
Paolo Bonzini writes:
> On 23/02/21 10:06, Markus Armbruster wrote:
>>> Markus, did you rebuild the qtests after disabling single-quoted
>>> strings? "make check-qtest-x86_64" would have rebuilt them, but I'm
>>> confused by the results.
>> I ran "make check" and looked at the failures:
>>
On Tue, 23 Feb 2021 at 09:33, Markus Armbruster wrote:
> Misunderstanding: our JSON interpolation feature is *not* string
> interpolation! It interpolates *objects* into the QObject built by the
> parser.
Given that it's basically undocumented except in a scattered
handful of comments inside
On 23/02/21 10:06, Markus Armbruster wrote:
Markus, did you rebuild the qtests after disabling single-quoted
strings? "make check-qtest-x86_64" would have rebuilt them, but I'm
confused by the results.
I ran "make check" and looked at the failures:
Still confused?
Yes. What's the patch
Markus Armbruster writes:
[...]
> A bigger stumbling block for replacement is our need for a streaming
> interface: we feed the parser characters, and expect to be called back
> when an expression is complete.
Another stumbling block: check-qjson.c test case "/literals/string/utf8"
and
On Mon, 2021-02-22 at 16:09 +0100, Pavel Hrdina wrote:
> +To fix the issue libvirt now uses DBus calls for some of the cgroup
> +attributes that distributes the resources proportionally to the cgroup
I think this should be s/distributes/distribute/
> +siblings and for the rest we
On Tue, Feb 23, 2021 at 11:23:18AM +0800, Hogan Wang wrote:
> From: suruifeng
>
> When the 'pcpu' is larger then the last 'iothr->cpumap' bits,
> set the list element to False to avoid out of bounds access
> 'iothr->cpumap'.
>
> Signed-off-by: suruifeng
> Reviewed-by: Hogan Wang
Changes for
Daniel P. Berrangé writes:
> On Mon, Feb 22, 2021 at 06:47:30PM +0100, Paolo Bonzini wrote:
>> On 22/02/21 16:24, Daniel P. Berrangé wrote:
>> > This problem isn't unique to QEMU. Any app using JSON from the
>> > shell will have the tedium of quote escaping. JSON is incredibly
>> > widespread
From: suruifeng
When the 'pcpu' is larger then the last 'iothr->cpumap' bits,
set the list element to False to avoid out of bounds access
'iothr->cpumap'.
Signed-off-by: suruifeng
Reviewed-by: Hogan Wang
---
libvirt-override.c | 12
1 file changed, 8 insertions(+), 4
Paolo Bonzini writes:
> On 22/02/21 16:24, Daniel P. Berrangé wrote:
>> This problem isn't unique to QEMU. Any app using JSON from the
>> shell will have the tedium of quote escaping. JSON is incredibly
>> widespread and no other apps felt it neccessary to introduce single
>> quoting support,
The libvirt libxl driver has no access to FDs associated with VM disks.
The disks are opened by libxl.so and any related FDs are not exposed to
applications. The prevents using virtlockd's auto-release feature to
release locks when the FD is closed. Acquiring and releasing locks is
explicitly
32 matches
Mail list logo
