On Thu, Mar 04, 2021 at 06:10:11PM +, Daniel P. Berrangé wrote:
> GSSAPI and SCRAM-SHA-256 are the only two SASL mechanisms we
> especially want people to be using. Even the latter is a little
> questionable due to storing passwords in cleartext on the server.
At what point of the SCRAM-SHA-25
Peter Krempa writes:
> On Thu, Mar 04, 2021 at 17:23:05 +0100, Markus Armbruster wrote:
>> Daniel P. Berrangé writes:
>>
>> > On Thu, Mar 04, 2021 at 03:26:55PM +0100, Markus Armbruster wrote:
>> >> Daniel P. Berrangé writes:
>> >>
>> >> > On Thu, Mar 04, 2021 at 11:00:57AM +0100, Markus Armb
Great thanks for your reviewing!
I will update 5/5 and possibly 4/5 according to expected more suggestion in the
next version.
BR,
Hao
On 2021/3/3 19:31, Michal Privoznik wrote:
> On 2/26/21 9:35 AM, Hao Wang wrote:
>>
>> Hao Wang (5):
>> migration/dirtyrate: Introduce virDomainStartDirtyRate
From: Zhuang Shengen
When a vm is doing migration phase confirm, and then start it concurrently,
it will lead to the vm out of libvirtd control.
Cause Analysis:
1. thread1 migrate vm out.
2. thread2 start the migrating vm.
3. thread1 remove vm from domain list after migrate success.
4. thread2 a
Surprisingly, we never documented the relationship between
connection URI and the location of qemu.conf. Users might wonder
what qemu.conf is loaded when they are connecting to the session
daemon or embed URI. And what to do if the file doesn't exist for
the URI they're using.
Signed-off-by: Micha
On 3/4/21 6:08 PM, Ján Tomko wrote:
On a Monday in 2021, Michal Privoznik wrote:
While reading through glib manual I've noticed there's
g_mkdir_with_parents() which does the same as our virFileMakePath() and
virFileMakePathWithMode().
Michal Prívozník (4):
virfile: Replace virFileMakePathHelpe
On a Tuesday in 2021, Peter Krempa wrote:
Use glib functions to do the relative name lookup instead of manual
assembly.
Signed-off-by: Peter Krempa
---
src/test/test_driver.c | 35 ++-
1 file changed, 6 insertions(+), 29 deletions(-)
Reviewed-by: Ján Tomko
Ja
On a Tuesday in 2021, Peter Krempa wrote:
Signed-off-by: Peter Krempa
---
src/libxl/xen_xm.c | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
On a Tuesday in 2021, Peter Krempa wrote:
Passing 'strlen(src)' for length makes it equivalent to virStrcpy.
Signed-off-by: Peter Krempa
---
src/util/virfile.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
On a Tuesday in 2021, Peter Krempa wrote:
virStrncpy was called with -1 for lenght of the copied source which is
length
equivalent to virStrcpy.
Signed-off-by: Peter Krempa
---
src/util/virdevmapper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Ján Tomko
Jano
si
On a Tuesday in 2021, Peter Krempa wrote:
We want a (possibly truncated) copy of the full source string so
virStrcpy is a better fit.
Signed-off-by: Peter Krempa
---
src/locking/lock_driver_sanlock.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
Reviewed-by: Ján Tomko
Jano
sign
On a Tuesday in 2021, Peter Krempa wrote:
Signed-off-by: Peter Krempa
---
src/util/virprocess.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
On a Tuesday in 2021, Peter Krempa wrote:
15 out of 72 invocations of virStrcpy(Static)
That's almost 21%
ignore the return value as
it's either impossible to fail or in certain cases a truncated copy is
still good enough.Unfortunately virStrcpy doesn't copy anything in
such case as the check
On a Wednesday in 2021, Peter Krempa wrote:
There's nothing that would set the 'err' field of virFirewallPtr to
ENOMEM so we can remove the checks.
Signed-off-by: Peter Krempa
---
src/util/virfirewall.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/src/util/virfir
We don't need to go to the trouble of telling users about existance of
insecure SASL mechanisms only to then say that they shouldn't be used.
We should only tell people about the GSSAPI mechanism for TCP sockets.
For the SCRAM mechanism we should be telling people about the SHA256
variant only, an
Signed-off-by: Daniel P. Berrangé
---
docs/auth.html.in | 368 --
docs/auth.rst | 350 +++
docs/meson.build | 2 +-
3 files changed, 351 insertions(+), 369 deletions(-)
delete mode 100644 docs/auth.html.in
GSSAPI and SCRAM-SHA-256 are the only two SASL mechanisms we
especially want people to be using. Even the latter is a little
questionable due to storing passwords in cleartext on the server.
Daniel P. Berrangé (2):
docs: convert auth page into RST format
docs: stop mentioning insecure / broken
On a Thursday in 2021, Peter Krempa wrote:
In cases we use -1 for failure internally we still must return
EXIT_FAILURE.
Signed-off-by: Peter Krempa
---
tests/qemucommandutiltest.c| 3 +--
tests/virnetdevbandwidthtest.c | 2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
Reviewed-by: J
On a Thursday in 2021, Peter Krempa wrote:
Simplify the logic picking which element form to format by using
virBuffers for the partial properties and virXMLFormatElement for
combining them.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 93 --
1
On a Thursday in 2021, Peter Krempa wrote:
There's an optimization in virBufferAdd which returns early when the
length of the added string is 0 (given that auto-indent is disabled).
The optimization causes inconsistent behaviour between these two cases:
virBufferAdd(buf, "", 0); // this doesn'
In cases we use -1 for failure internally we still must return
EXIT_FAILURE.
Signed-off-by: Peter Krempa
---
tests/qemucommandutiltest.c| 3 +--
tests/virnetdevbandwidthtest.c | 2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/tests/qemucommandutiltest.c b/tests/qemucomma
Simplify the logic picking which element form to format by using
virBuffers for the partial properties and virXMLFormatElement for
combining them.
Signed-off-by: Peter Krempa
---
src/conf/domain_conf.c | 93 --
1 file changed, 35 insertions(+), 58 deletion
There's an optimization in virBufferAdd which returns early when the
length of the added string is 0 (given that auto-indent is disabled).
The optimization causes inconsistent behaviour between these two cases:
virBufferAdd(buf, "", 0); // this doesn't initialize the buffer
and
virBufferAdd(
On a Monday in 2021, Michal Privoznik wrote:
While reading through glib manual I've noticed there's
g_mkdir_with_parents() which does the same as our virFileMakePath() and
virFileMakePathWithMode().
Michal Prívozník (4):
virfile: Replace virFileMakePathHelper() with g_mkdir_with_parents()
Thi
On a Monday in 2021, Michal Privoznik wrote:
Generated using the following spatch:
@@
expression path;
@@
- virFileMakePath(path)
+ g_mkdir_with_parents(path, 0777)
However, 14 occurrences were not replaced, e.g. in
virHostdevManagerNew(). I don't really understand why.
d/I don't really
On Thu, Mar 04, 2021 at 05:52:50PM +0100, Peter Krempa wrote:
> On Thu, Mar 04, 2021 at 17:23:05 +0100, Markus Armbruster wrote:
> > Daniel P. Berrangé writes:
> >
> > > On Thu, Mar 04, 2021 at 03:26:55PM +0100, Markus Armbruster wrote:
> > >> Daniel P. Berrangé writes:
> > >>
> > >> > On Thu,
On a Tuesday in 2021, Peter Krempa wrote:
We don't need OOM resiliency nowadays.
Peter Krempa (6):
util: virerror: Don't use stack'd buffers in error report helpers
util: virerror: Avoid a copy of the error messages
util: virprocess: Use local maximum error message size
qemuProcessReportLogE
On Thu, Mar 04, 2021 at 17:23:05 +0100, Markus Armbruster wrote:
> Daniel P. Berrangé writes:
>
> > On Thu, Mar 04, 2021 at 03:26:55PM +0100, Markus Armbruster wrote:
> >> Daniel P. Berrangé writes:
> >>
> >> > On Thu, Mar 04, 2021 at 11:00:57AM +0100, Markus Armbruster wrote:
> >> >> Drop the
On a Wednesday in 2021, Roman Bogorodskiy wrote:
Tools depend on keycode generated sources, so declare that as an
explicit dependency, otherwise it might fail with:
../tools/virsh-completer-domain.c:35:10: fatal error: 'virkeynametable_linux.h'
file not found
^
On a Wednesday in 2021, Kristina Hanicova wrote:
This is v2 from
https://listman.redhat.com/archives/libvir-list/2021-February/msg01117.html
I split commit 3/4 into more commits and left out autofreeing outer
array as suggested by Jan Tomko.
Patches 2/6 and 6/6 (previously 2/4 and 4/4) have alre
On Wed, Mar 03, 2021 at 10:37:13AM +0100, Andrea Bolognani wrote:
> We've already applied this policy on multiple occasions, but it's
> good to have it written down so that there can be no confusion.
>
> Signed-off-by: Andrea Bolognani
> ---
Reviewed-by: Erik Skultety
On a Wednesday in 2021, Kristina Hanicova wrote:
Refractoring includes:
* removal of VIR_FREE
* inversion of the condition
* use of g_steal_pointer
The conversion to g_steal_pointer was in your patch:
Use g_steal_pointer where possible
and is already merged as
commit 155151a3d061e3641709
Daniel P. Berrangé writes:
> On Thu, Mar 04, 2021 at 03:26:55PM +0100, Markus Armbruster wrote:
>> Daniel P. Berrangé writes:
>>
>> > On Thu, Mar 04, 2021 at 11:00:57AM +0100, Markus Armbruster wrote:
>> >> Drop the crap deprecated in commit 4a27a638e7 "fdc: Deprecate
>> >> configuring floppies
On Wed, Mar 03, 2021 at 06:18:28PM +, Daniel P. Berrangé wrote:
> Currently the QEMU driver secretly sets the QEMU_AUDIO_DRV env variable
>
> - VNC - set to "none", unless passthrough of host env variable is set
> - SPICE - always set to "spice"
> - SDL - always passthrough host env
> - No
On Thu, Mar 04, 2021 at 03:26:55PM +0100, Markus Armbruster wrote:
> Daniel P. Berrangé writes:
>
> > On Thu, Mar 04, 2021 at 11:00:57AM +0100, Markus Armbruster wrote:
> >> Drop the crap deprecated in commit 4a27a638e7 "fdc: Deprecate
> >> configuring floppies with -global isa-fdc" (v5.1.0).
> >
Daniel P. Berrangé writes:
> On Thu, Mar 04, 2021 at 11:00:57AM +0100, Markus Armbruster wrote:
>> Drop the crap deprecated in commit 4a27a638e7 "fdc: Deprecate
>> configuring floppies with -global isa-fdc" (v5.1.0).
>>
>> Signed-off-by: Markus Armbruster
>> ---
>> docs/system/deprecated.rst
With this, incomplete XML without for in coalesce
won't raise error as before. It will leave the coalesce parameter
empty, thanks to passing it as a parameter and return an integer
to indicate error state - previously it returned pointer (or NULL
for both error and incomplete XML).
The code went
On 2/19/21 5:08 PM, Aleksei Zakharov wrote:
This patch adds delay time (steal time inside guest) to libvirt
domain per-vcpu stats. Delay time is an important performance metric.
It is a consequence of the overloaded CPU. Knowledge of the delay
time of a virtual machine helps to understand if i
On 2/25/21 10:23 AM, Tim Wiederhake wrote:
See https://bugzilla.redhat.com/show_bug.cgi?id=1840770
Signed-off-by: Tim Wiederhake
---
Reviewed-by: Daniel Henrique Barboza
src/qemu/qemu_process.c | 27 +++
1 file changed, 27 insertions(+)
diff --git a/src/qemu/
On 2/26/21 4:11 PM, Chris Mayo wrote:
Allow the directory to be chosen at installation time, to support local
conventions e.g. versioning.
Signed-off-by: Chris Mayo
---
Reviewed-by: Daniel Henrique Barboza
meson.build | 6 +-
meson_options.txt | 1 +
2 files changed, 6 ins
On Thu, Mar 04, 2021 at 10:20:14AM +, Daniel P. Berrangé wrote:
> On Thu, Mar 04, 2021 at 10:48:10AM +0100, Martin Kletzander wrote:
> > This way it can be used from other places as well.
> >
> > Signed-off-by: Martin Kletzander
> > ---
> > src/util/glibcompat.c | 35 ++
On 3/3/21 5:17 PM, Kristina Hanicova wrote:
This refactors file node_device_conf in order to remove VIR_FREE
(if possible) and removes redundant variables and labels.
Kristina Hanicova (4):
node_device_conf: Use g_autofree where possible
node_device_conf: Refactoring functions in order to
On 3/3/21 5:17 PM, Kristina Hanicova wrote:
Signed-off-by: Kristina Hanicova
---
src/conf/node_device_conf.c | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c
index cfc72299de..a64be74011 100644
--- a/s
On Thu, Mar 04, 2021 at 11:00:57AM +0100, Markus Armbruster wrote:
> Drop the crap deprecated in commit 4a27a638e7 "fdc: Deprecate
> configuring floppies with -global isa-fdc" (v5.1.0).
>
> Signed-off-by: Markus Armbruster
> ---
> docs/system/deprecated.rst | 26 --
> docs/system/remove
On 3/4/21 9:35 AM, Tim Wiederhake wrote:
VIR_DOMAIN_HYPERV_STIMER happens to have the same numerical value as
VIR_DOMAIN_FEATURE_HYPERV, resulting in the if-block to always being
executed when a "" tag is found, whether or not it actually
contained a "" tag. This had no ill effects, as virXPathNo
On 3/4/21 9:35 AM, Tim Wiederhake wrote:
Patches 1-4 are minor cleanups, patch 5 is the actual one that I want out
of the way before continuing down my rabbit hole of the week.
Tim Wiederhake (5):
domain_conf: Reduce scope of tmp in virDomainFeaturesDefParse
domain_conf: Reduce scope of gi
On Thu, Mar 04, 2021 at 10:48:10AM +0100, Martin Kletzander wrote:
> This way it can be used from other places as well.
>
> Signed-off-by: Martin Kletzander
> ---
> src/util/glibcompat.c | 35 +++
> src/util/glibcompat.h | 11 +++
> src/util/vireventgl
On Thu, Mar 04, 2021 at 10:48:11AM +0100, Martin Kletzander wrote:
> Similarly to the crash workaround:
>
> commit 0db4743645b7a0611a3c0687f834205c9956f7fc
> Author: Daniel P. Berrangé
> Date: Tue Jul 28 16:52:47 2020 +0100
>
> util: avoid crash due to race in glib event loop code
>
Drop the crap deprecated in commit a1b40bda08 "blockdev: Deprecate
-drive with bogus interface type" (v5.1.0).
Signed-off-by: Markus Armbruster
---
docs/system/deprecated.rst | 7 --
docs/system/removed-features.rst | 7 ++
include/sysemu/blockdev.h| 1 -
blockdev.c
v2:
* Rebased, straightforward conflict with commit f5d33dd51f
"hw/block/fdc: Remove the check_media_rate property" resolved
* PATCH 2: Commit message fixed [Kevin]
Markus Armbruster (3):
fdc: Drop deprecated floppy configuration
fdc: Inline fdctrl_connect_drives() into fdctrl_realize_common
Drop the crap deprecated in commit 4a27a638e7 "fdc: Deprecate
configuring floppies with -global isa-fdc" (v5.1.0).
Signed-off-by: Markus Armbruster
---
docs/system/deprecated.rst | 26 --
docs/system/removed-features.rst | 26 ++
hw/block/fdc.c | 54 +--
tests/qemu-iot
The previous commit rendered the name fdctrl_connect_drives() somewhat
misleading. Get rid of it by inlining the (now pretty simple)
function into its only caller.
Signed-off-by: Markus Armbruster
---
hw/block/fdc.c | 23 ---
1 file changed, 8 insertions(+), 15 deletions(-)
This way it can be used from other places as well.
Signed-off-by: Martin Kletzander
---
src/util/glibcompat.c | 35 +++
src/util/glibcompat.h | 11 +++
src/util/vireventglib.c | 30 --
3 files changed, 46 insertions(+), 30 d
Similarly to the crash workaround:
commit 0db4743645b7a0611a3c0687f834205c9956f7fc
Author: Daniel P. Berrangé
Date: Tue Jul 28 16:52:47 2020 +0100
util: avoid crash due to race in glib event loop code
we need to do this in the other event loop as crash in that one was also
reported:
Similarly to commit 0db4743645b7 we need to fix the other event loop as well.
To be completely honest I do not completely understand all the details in the
original workaround, so I just hope this is the best way to fix the issue.
Hopefully-resolves: https://bugzilla.redhat.com/show_bug.cgi?id=193
Signed-off-by: Tim Wiederhake
---
src/conf/domain_conf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 4bc82b69fc..48fd078b90 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -18449,6 +18449,7 @@ virDomainFeaturesDefPa
Signed-off-by: Tim Wiederhake
---
src/conf/domain_conf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index f73814f3c7..4bc82b69fc 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -18156,7 +18156,6 @@ vi
VIR_DOMAIN_HYPERV_STIMER happens to have the same numerical value as
VIR_DOMAIN_FEATURE_HYPERV, resulting in the if-block to always being
executed when a "" tag is found, whether or not it actually
contained a "" tag. This had no ill effects, as virXPathNodeSet()
would simply return 0 if that tag d
Signed-off-by: Tim Wiederhake
---
src/conf/domain_conf.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 1d0ef17318..f73814f3c7 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -18157,7 +18157,6 @@ virD
Variables using `g_autofree` should not be manually VIR_FREE'd and reused.
Signed-off-by: Tim Wiederhake
---
src/conf/domain_conf.c | 26 +-
1 file changed, 9 insertions(+), 17 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index f194909b13..1d
Patches 1-4 are minor cleanups, patch 5 is the actual one that I want out
of the way before continuing down my rabbit hole of the week.
Tim Wiederhake (5):
domain_conf: Reduce scope of tmp in virDomainFeaturesDefParse
domain_conf: Reduce scope of gic_version in virDomainFeaturesDefParse
doma
On Thu, 2021-03-04 at 08:44 +0100, Jiri Denemark wrote:
> Commit a208176ca1d9eedf8aa6bf12fde6a7a9579ab549 introduced this
> feature
> with an incorrect "svme-addr-check" spelling.
>
> Signed-off-by: Jiri Denemark
My bad.
Reviewed-by: Tim Wiederhake
> ---
> src/cpu_map/sync_qemu_i386.py | 2
62 matches
Mail list logo
