On Tue, Mar 23, 2021 at 05:40:36PM +, Daniel P. Berrangé wrote:
> On Tue, Mar 23, 2021 at 05:54:47PM +0100, Igor Mammedov wrote:
> > Let me hijack this thread for beyond this case scope.
> >
> > I agree that for this particular bug we've done all we could, but
> > there is broader issue to dis
Just like VFIO devices, vDPA devices may need to have all guest memory
pages locked/pinned in order to operate properly. In the case of VFIO
devices (including mdev and NVME, which also use VFIO) libvirt
automatically increases the locked memory limit when one of those
devices is present. This patc
This function is a specialized version of
qemuDomainGetMemLockLimitBytes() for PPC64. Simplifying it in the same
manner as the previous patch has the nice side effect of accounting
for the possibility of an mdev device in the config.
(I don't know if mdev devices are supported on PPC, but even if
We recently learned that vDPA devices may/will need to pin/lock all of
guest memory, and so just as we do for VFIO devices, we need to
increase the locked memory limit when a vDPA device is present.
https://bugzilla.redhat.com/1939776
Laine Stump (4):
conf: new function virDomainDefHasVDPANet()
This function goes through a loop checking if each hostdev is a VFIO
or mdev device, and then later it calls virDomainDefHasNVMEDisk(). The
function qemuDomainNeedsVFIO() does exactly the same thing, so let's
just call that instead.
Signed-off-by: Laine Stump
---
src/qemu/qemu_domain.c | 17 +---
This function returns true if the domain has any interfaces that are
type='vdpa'.
Signed-off-by: Laine Stump
---
src/conf/domain_conf.c | 14 ++
src/conf/domain_conf.h | 3 +++
src/libvirt_private.syms | 1 +
3 files changed, 18 insertions(+)
diff --git a/src/conf/domain_conf.
On Tue, Mar 23, 2021 at 05:54:47PM +0100, Igor Mammedov wrote:
> Let me hijack this thread for beyond this case scope.
>
> I agree that for this particular bug we've done all we could, but
> there is broader issue to discuss here.
>
> We have machine versions to deal with hw compatibility issues
On Tue, Mar 23, 2021 at 05:23:38PM +0100, Tim Wiederhake wrote:
> On Tue, 2021-03-23 at 15:28 +0100, Peter Krempa wrote:
> > On Tue, Mar 23, 2021 at 15:19:44 +0100, Michal Privoznik wrote:
> > > On 3/23/21 3:04 PM, Peter Krempa wrote:
> > > > On Tue, Mar 23, 2021 at 14:50:09 +0100, Michal Privoznik
On Tue, 23 Mar 2021 16:04:11 +0100
Thomas Lamprecht wrote:
> On 23.03.21 15:55, Vitaly Cheptsov wrote:
> >> 23 марта 2021 г., в 17:48, Michael S. Tsirkin написал(а):
> >>
> >> The issue is with people who installed a VM using 5.1 qemu,
> >> migrated to 5.2, booted there and set a config on a dev
On Tue, 2021-03-23 at 15:28 +0100, Peter Krempa wrote:
> On Tue, Mar 23, 2021 at 15:19:44 +0100, Michal Privoznik wrote:
> > On 3/23/21 3:04 PM, Peter Krempa wrote:
> > > On Tue, Mar 23, 2021 at 14:50:09 +0100, Michal Privoznik wrote:
> > > > On 3/23/21 2:42 PM, Daniel P. Berrangé wrote:
> > > > >
On Mon, Mar 15, 2021 at 06:39:43PM +0100, Erik Skultety wrote:
> since v1:
> - fixed a broken heading reference from a kbase article caused by RST convers=
> ion
> - dropped architecture.html.in along with images
>
> v1: https://listman.redhat.com/archives/libvir-list/2021-March/msg00584.html
>
>
On Wed, Mar 10, 2021 at 06:01:17PM +0100, Kristina Hanicova wrote:
With this, incomplete XML without for in coalesce
won't raise error as before. It will leave the coalesce parameter
empty, thanks to passing it as a parameter and return an integer
to indicate error state - previously it returne
Notable changes:
* HAL is no longer installed on FreeBSD;
* the native version of libwsman is no longer installed in
containers intended for cross-compilation;
* Meson 0.55 is used instead of 0.54 when installing from
PyPI.
Signed-off-by: Andrea Bolognani
---
Test pipeline:
ht
On Tue, Mar 23, 2021 at 15:19:44 +0100, Michal Privoznik wrote:
> On 3/23/21 3:04 PM, Peter Krempa wrote:
> > On Tue, Mar 23, 2021 at 14:50:09 +0100, Michal Privoznik wrote:
> > > On 3/23/21 2:42 PM, Daniel P. Berrangé wrote:
> > > > On Tue, Mar 23, 2021 at 02:36:19PM +0100, Michal Privoznik wrote:
On 3/23/21 3:04 PM, Peter Krempa wrote:
On Tue, Mar 23, 2021 at 14:50:09 +0100, Michal Privoznik wrote:
On 3/23/21 2:42 PM, Daniel P. Berrangé wrote:
On Tue, Mar 23, 2021 at 02:36:19PM +0100, Michal Privoznik wrote:
On 3/22/21 5:09 PM, Tim Wiederhake wrote:
virsh has several arguments that ar
On 3/23/21 8:44 AM, Michal Privoznik wrote:
Honestly, this is not the most beautiful patch I've seen, but also I
don't have any idea how to make it look better,
I didn't like writing it either.
Anyway, I like Dan's idea better - "that's not a regression, it's a
bonus bugfix for a bug that s
On Tue, Mar 23, 2021 at 14:50:09 +0100, Michal Privoznik wrote:
> On 3/23/21 2:42 PM, Daniel P. Berrangé wrote:
> > On Tue, Mar 23, 2021 at 02:36:19PM +0100, Michal Privoznik wrote:
> > > On 3/22/21 5:09 PM, Tim Wiederhake wrote:
> > > > virsh has several arguments that are better not used. This se
On Tue, Mar 23, 2021 at 02:50:09PM +0100, Michal Privoznik wrote:
> On 3/23/21 2:42 PM, Daniel P. Berrangé wrote:
> > On Tue, Mar 23, 2021 at 02:36:19PM +0100, Michal Privoznik wrote:
> > > On 3/22/21 5:09 PM, Tim Wiederhake wrote:
> > > > virsh has several arguments that are better not used. This
On Tue, Mar 23, 2021 at 14:36:19 +0100, Michal Privoznik wrote:
> On 3/22/21 5:09 PM, Tim Wiederhake wrote:
> > virsh has several arguments that are better not used. This series introduces
> > a formal way of marking them as deprecated.
>
> Commit messages are rather sparse. What we currently have
On 3/23/21 2:42 PM, Daniel P. Berrangé wrote:
On Tue, Mar 23, 2021 at 02:36:19PM +0100, Michal Privoznik wrote:
On 3/22/21 5:09 PM, Tim Wiederhake wrote:
virsh has several arguments that are better not used. This series introduces
a formal way of marking them as deprecated.
Commit messages ar
On Tue, Mar 23, 2021 at 02:36:19PM +0100, Michal Privoznik wrote:
> On 3/22/21 5:09 PM, Tim Wiederhake wrote:
> > virsh has several arguments that are better not used. This series introduces
> > a formal way of marking them as deprecated.
>
> Commit messages are rather sparse. What we currently ha
On 3/22/21 5:09 PM, Tim Wiederhake wrote:
virsh has several arguments that are better not used. This series introduces
a formal way of marking them as deprecated.
Commit messages are rather sparse. What we currently have is hiding
options we deem obsolete from users and replacing them with bet
On 3/22/21 10:30 PM, Laine Stump wrote:
Commit 114e3b42 modified virDomainNetFindIdx() to compare the alias
name of the being matched (in addition to already-existing
match of MAC address and PCI/CCW address). This was done in response
to https://bugzilla.redhat.com/1926190 which complained that
On 3/23/21 5:37 AM, Daniel P. Berrangé wrote:
On Mon, Mar 22, 2021 at 05:30:34PM -0400, Laine Stump wrote:
Commit 114e3b42 modified virDomainNetFindIdx() to compare the alias
name of the being matched (in addition to already-existing
match of MAC address and PCI/CCW address). This was done in r
On Tue, Mar 23, 2021 at 11:49:48AM +0100, Andrea Bolognani wrote:
> FreeBSD 12 was released in December 2018, so according to our
> platform support policy we can now drop support for the previous
> major release. It would be going EOL in September anyway.
>
> Signed-off-by: Andrea Bolognani
> --
On Tue, Mar 23, 2021 at 11:58:47AM +0100, Michal Privoznik wrote:
> See 2/2.
>
> Michal Prívozník (2):
> domain_conf: Separate virDomainOS clear into a function
> domain_conf: Don't leak def->os.firmwareFeatures
>
> src/conf/domain_conf.c | 55 --
> 1
The firmwareFeatures member of virDomainOSDef struct is allocated
in virDomainDefParseBootFirmwareOptions() but never freed.
Signed-off-by: Michal Privoznik
---
src/conf/domain_conf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 3aefa8
The virDomainDefFree() function frees individual members of
virDomainDef struct. The function is already long enough, move
code that handles def->os member into a separate function.
Signed-off-by: Michal Privoznik
---
src/conf/domain_conf.c | 54 --
1 file
See 2/2.
Michal Prívozník (2):
domain_conf: Separate virDomainOS clear into a function
domain_conf: Don't leak def->os.firmwareFeatures
src/conf/domain_conf.c | 55 --
1 file changed, 32 insertions(+), 23 deletions(-)
--
2.26.2
FreeBSD 12 was released in December 2018, so according to our
platform support policy we can now drop support for the previous
major release. It would be going EOL in September anyway.
Signed-off-by: Andrea Bolognani
---
.gitlab-ci.yml| 10 --
ci/cirrus/freebsd-11.vars | 8 -
On 3/23/21 7:03 AM, Ján Tomko wrote:
On a Monday in 2021, Daniel Henrique Barboza wrote:
Commit ac87d3520ad5 consolidated common cgroup code between the QEMU and
lxc drivers in domain_cgroup.c. In this process, in
virDomainCgroupSetupDomainBlkioParameters(), a call to
virCgroupGetBlkioWeight(
On a Monday in 2021, Peter Krempa wrote:
Peter Krempa (2):
qemuCheckpointDiscardBitmaps: Refuse to delete checkpoint with NULL
bitmap name
virDomainCheckpointRedefinePrep: Assign default bitmap names when
domain XML is missing
src/conf/checkpoint_conf.c | 3 +++
src/qemu/qemu_checkpoint.c
On a Monday in 2021, Daniel Henrique Barboza wrote:
Commit ac87d3520ad5 consolidated common cgroup code between the QEMU and
lxc drivers in domain_cgroup.c. In this process, in
virDomainCgroupSetupDomainBlkioParameters(), a call to
virCgroupGetBlkioWeight() went missing.
The result is that 'virs
See https://bugzilla.redhat.com/show_bug.cgi?id=1840770
Signed-off-by: Tim Wiederhake
---
src/qemu/qemu_process.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index fedd1f56b1..b74afedd07 100644
--- a/src/qemu/qemu_process.c
++
V1: https://listman.redhat.com/archives/libvir-list/2021-February/msg01275.ht=
ml
V2: https://listman.redhat.com/archives/libvir-list/2021-February/msg01289.ht=
ml
Changes since V2:
* Factored out into seperate function in src/cpu/cpu.c
* Made virCPUDefFindFeature work on const pointers
Tim Wiede
Signed-off-by: Tim Wiederhake
---
src/conf/cpu_conf.c | 2 +-
src/conf/cpu_conf.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/conf/cpu_conf.c b/src/conf/cpu_conf.c
index 380a74691d..43629068c3 100644
--- a/src/conf/cpu_conf.c
+++ b/src/conf/cpu_conf.c
@@ -933,7 +933
Signed-off-by: Tim Wiederhake
---
src/cpu/cpu.c| 37 +
src/cpu/cpu.h| 6 ++
src/libvirt_private.syms | 1 +
3 files changed, 44 insertions(+)
diff --git a/src/cpu/cpu.c b/src/cpu/cpu.c
index dfedf5bbf0..3fd7035f7a 100644
--- a/src
On Tue, Mar 23, 2021 at 10:59:02AM +0800, Luyao Zhong wrote:
> Before this patch set, numatune only has three memory modes:
> static, interleave and prefered. These memory policies are
> ultimately set by mbind() system call.
>
> Memory policy could be 'hard coded' into the kernel, but none of
> a
On 3/19/21 3:33 PM, Peter Krempa wrote:
The qemu changes are merged upstream now, so this series is now required
to ensure qemu compatibility with 'object_add' (support for 'props'
sub-object is now dropped from qemu, but libvirt would still use it) and
also to allow further updates of capability
On 3/19/21 3:33 PM, Peter Krempa wrote:
Signed-off-by: Peter Krempa
---
.../disk-network-tlsx509.x86_64-latest.args | 90 ---
1 file changed, 90 deletions(-)
delete mode 100644
tests/qemuxml2argvdata/disk-network-tlsx509.x86_64-latest.args
Maybe put a reason why, so tha
On Mon, Mar 22, 2021 at 05:30:34PM -0400, Laine Stump wrote:
> Commit 114e3b42 modified virDomainNetFindIdx() to compare the alias
> name of the being matched (in addition to already-existing
> match of MAC address and PCI/CCW address). This was done in response
> to https://bugzilla.redhat.com/19
On Fri, Mar 19, 2021 at 10:29:44 +0100, Jiri Denemark wrote:
> We are getting close to the next release of libvirt. To aim for the
> release on Apr 01 I suggest entering the freeze on Froday Mar 26 and
> tagging RC2 on Tuesday Mar 30.
Since this is the last libvirt release before qemu-6.0 gets rel
42 matches
Mail list logo
