[PATCH] docs: formatnetworkport: Fix typos

2021-03-31 Thread Han Han
Signed-off-by: Han Han --- docs/formatnetworkport.html.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/formatnetworkport.html.in b/docs/formatnetworkport.html.in index 199a05f929..2d41552618 100644 --- a/docs/formatnetworkport.html.in +++

RE: [libvirt][PATCH v4 0/3] introduce 'restrictive' mode in numatune

2021-03-31 Thread Zhong, Luyao
>-Original Message- >From: Martin Kletzander >Sent: Wednesday, March 31, 2021 5:37 PM >To: Zhong, Luyao >Cc: Daniel P. Berrangé ; libvir-list@redhat.com >Subject: Re: [libvirt][PATCH v4 0/3] introduce 'restrictive' mode in numatune > >On Wed, Mar 31, 2021 at 06:33:28AM +, Zhong,

Re: [libvirt PATCH 1/2] conf: add support for disk "rotation_rate" property

2021-03-31 Thread Han Han
On Wed, Mar 31, 2021 at 5:51 PM Daniel P. Berrangé wrote: > This lets the app expose the virtual SCSI or IDE disks as solid state > devices by setting a rate of '1', or rotational media by setting a > rate between 1025 and 65534. > > Signed-off-by: Daniel P. Berrangé > --- >

Re: [libvirt PATCH 2/2] qemu: implement setting of rotation rate for SCSI/IDE disks

2021-03-31 Thread Han Han
On Wed, Mar 31, 2021 at 5:51 PM Daniel P. Berrangé wrote: > Signed-off-by: Daniel P. Berrangé > --- > src/qemu/qemu_capabilities.c | 2 + > src/qemu/qemu_capabilities.h | 1 + > src/qemu/qemu_command.c | 3 + > src/qemu/qemu_validate.c

Re: [PATCH 0/6] qemu: Allow control of deprecation behaviour

2021-03-31 Thread Martin Kletzander
On Fri, Mar 19, 2021 at 07:33:48PM +0100, Peter Krempa wrote: For debugging purposes it's very useful to disable all deprecated commands and fields in qemu. This series implements a qemu.conf knob and a qemu namespace element to control this. The implementation tries to be very conservative to

Re: [PATCH 6/6] qemu: command: Handle formatting of '-compat' options

2021-03-31 Thread Martin Kletzander
On Fri, Mar 19, 2021 at 07:33:54PM +0100, Peter Krempa wrote: Enable '-compat' if requested in qemu.conf and supported by qemu to instruct qemu to crash when a deprecated command is used and stop returning deprecated fields. This setting is meant for libvirt developers and such. ---

Re: [PATCH 5/6] qemu: Add per-VM control of deprecation behavior

2021-03-31 Thread Martin Kletzander
On Fri, Mar 19, 2021 at 07:33:53PM +0100, Peter Krempa wrote: Similar to the qemu.conf knob 'deprecation_behavior' add a per-VM knob in the QEMU namespace: Signed-off-by: Peter Krempa --- docs/drvqemu.rst | 48 +++ docs/schemas/domaincommon.rng

Re: [PATCH 3/6] qemu: conf: Add 'deprecation_behavior' setting to qemu.conf

2021-03-31 Thread Martin Kletzander
On Fri, Mar 19, 2021 at 07:33:51PM +0100, Peter Krempa wrote: New QEMU supports an harsh, but hard to ignore way to notify that the "a harsh" or just "harsh" QMP user used an deprecated command. This is useful e.g. for developers "a deprecated" to see that something needs to be fixed.

Re: [PATCH 2/6] qemu: capabilities: Introduce QEMU_CAPS_COMPAT_DEPRECATED

2021-03-31 Thread Martin Kletzander
On Fri, Mar 19, 2021 at 07:33:50PM +0100, Peter Krempa wrote: The capability is asserted if qemu supports the -compat deprecated-input= and deprecated-output= settings to control what should happen if deprecated fields are used in QMP. This will be used for a developer/tester-oriented setting

Re: [PATCH RFC 0/3] Add checkpoint/restore support to LXC using CRIU

2021-03-31 Thread Martin Kletzander
On Sat, Feb 27, 2021 at 01:14:29AM -0300, Julio Faracco wrote: Hi guys, Hi and sorry for not replying earlier. I marked this series as RFC to discuss some points. I'm interested in enhancing this specific part of LXC. So, some questions that I would like to hear as a feedback from

Re: [libvirt PATCH 2/2] ci: Call meson consistently

2021-03-31 Thread Martin Kletzander
On Fri, Mar 26, 2021 at 11:35:02AM +0100, Andrea Bolognani wrote: We should always pass --werror and display the contents of the log file in case of failure. Any reason why the lines are not in one place? What I did in libnbd (first draft, still up for review) is that I just took all the

Re: [libvirt PATCH 2/2] ci: Call meson consistently

2021-03-31 Thread Martin Kletzander
On Mon, Mar 29, 2021 at 10:17:51AM +0200, Andrea Bolognani wrote: On Fri, 2021-03-26 at 18:55 +0100, Pavel Hrdina wrote: On Fri, Mar 26, 2021 at 05:11:04PM +0100, Andrea Bolognani wrote: > Even though you didn't spell that out explicitly, I assume you're > okay with me pushing this series

Gsoc2021

2021-03-31 Thread Aaryan Singh
Hello, This is Aaryan, a 2nd-year undergraduate student at Kalinga institute of industrial technology. I have a keen interest in the " test driver API coverage " project. since I have worked in cloud computing and DevOps that's why I am this interested in this project and would love to share my

[libvirt PATCHv1 4/4] qemu: add socket for virtiofs filesystems

2021-03-31 Thread Ján Tomko
Copy the socket path in qemuExtDevicesStart, because for libvirt-managed virtiofsd daemons the path is filled there in qemuVirtioFSStart. Signed-off-by: Ján Tomko --- src/qemu/qemu_extdevice.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git

[libvirt PATCHv1 2/4] conf: fs: allow missing accessmode in the formatter

2021-03-31 Thread Ján Tomko
So far VIR_DOMAIN_FS_ACCESSMODE_PASSTHROUGH is always set in virDomainFSDefPostParse, but future commits aim to change that. Signed-off-by: Ján Tomko --- src/conf/domain_conf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c

[libvirt PATCHv1 1/4] conf: fs: fill out accessmode in post-parse

2021-03-31 Thread Ján Tomko
Move the default setting of accessmode to the post-parse phase. Signed-off-by: Ján Tomko --- src/conf/domain_conf.c | 18 -- src/conf/domain_conf.h | 1 + 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index

[libvirt PATCHv1 3/4] conf: add socket for virtiofs filesystems

2021-03-31 Thread Ján Tomko
Allow passing a socket of an externally launched virtiofsd to the vhost-user-fs device. https://bugzilla.redhat.com/show_bug.cgi?id=1855789 Signed-off-by: Ján Tomko --- docs/schemas/domaincommon.rng | 11 ++ src/conf/domain_conf.c| 21

[libvirt PATCHv1 0/4] qemu: support unmanaged virtiofsd

2021-03-31 Thread Ján Tomko
Connect the vhost-user-fs device to a socket path configured in the XML. Starting and stopping the virtiofsd daemon on that socket is the user's responsibility. Ján Tomko (4): conf: fs: fill out accessmode in post-parse conf: fs: allow missing accessmode in the formatter conf: add socket

Re: [libvirt PATCH v6 16/30] api: add virNodeDeviceDefineXML()

2021-03-31 Thread Jonathon Jongsma
On Wed, 31 Mar 2021 08:31:11 +0200 Erik Skultety wrote: > On Fri, Mar 26, 2021 at 11:48:12AM -0500, Jonathon Jongsma wrote: > > With mediated devices, we can now define persistent node devices > > that can be started and stopped. In order to take advantage of > > this, we need an API to define

Re: [PATCH] docs: Fix broken link in migrationinternals

2021-03-31 Thread Ján Tomko
On a Thursday in 2021, Han Han wrote: Signed-off-by: Han Han --- docs/kbase/migrationinternals.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Ján Tomko and pushed Jano signature.asc Description: PGP signature

Re: [PATCH] XML update in

2021-03-31 Thread Ján Tomko
On a Wednesday in 2021, Kristina Hanicova wrote: Previously, we accepted empty bridge name, because some old versions of VMWare Workstation did not put it into the config. But this doesn't make much sense - to have an interface type bridge with no name. We circumvented this problem by generating

[PATCH] NEWS: Fix typo swtmp -> swtpm

2021-03-31 Thread Andrea Bolognani
Signed-off-by: Andrea Bolognani --- Pushed as trivial. NEWS.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NEWS.rst b/NEWS.rst index 9eb771cd0b..3f4380ff23 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -91,7 +91,7 @@ v7.2.0 (unreleased) * Restore security context of

RE: [Libvirt] Attach qemu commands to an running xml domain

2021-03-31 Thread Moshe Levi
> -Original Message- > From: Michal Privoznik > Sent: Wednesday, March 31, 2021 5:49 PM > To: Moshe Levi ; Daniel P. Berrangé > > Cc: Waleed Musa ; libvir-list@redhat.com; Adrian > Chiris > Subject: Re: [Libvirt] Attach qemu commands to an running xml domain > > External email: Use

Re: [Libvirt] Attach qemu commands to an running xml domain

2021-03-31 Thread Michal Privoznik
On 3/31/21 4:01 PM, Moshe Levi wrote: -Original Message- From: Daniel P. Berrangé Sent: Wednesday, March 31, 2021 3:23 PM To: Michal Privoznik Cc: Waleed Musa ; libvir-list@redhat.com; Moshe Levi ; Adrian Chiris Subject: Re: [Libvirt] Attach qemu commands to an running xml domain

Re: [PATCH] news: Update for upcoming release

2021-03-31 Thread Andrea Bolognani
On Wed, 2021-03-31 at 16:20 +0200, Michal Privoznik wrote: > + * Add support for audio backend specific settings > + > +With this release new element is introduced that allows > users > +to configure audio output for their guests. s/new/ a new/ > + * Various improvements for

Re: [PATCH] news: Update for upcoming release

2021-03-31 Thread Ján Tomko
On a Wednesday in 2021, Michal Privoznik wrote: Mention some of the stuff we dealt with in this release. Signed-off-by: Michal Privoznik --- NEWS.rst | 51 +++ 1 file changed, 51 insertions(+) Reviewed-by: Ján Tomko Jano signature.asc

[PATCH] news: Update for upcoming release

2021-03-31 Thread Michal Privoznik
Mention some of the stuff we dealt with in this release. Signed-off-by: Michal Privoznik --- NEWS.rst | 51 +++ 1 file changed, 51 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 71f357e39f..f823fc8575 100644 --- a/NEWS.rst +++ b/NEWS.rst @@

RE: [Libvirt] Attach qemu commands to an running xml domain

2021-03-31 Thread Moshe Levi
> -Original Message- > From: Daniel P. Berrangé > Sent: Wednesday, March 31, 2021 3:23 PM > To: Michal Privoznik > Cc: Waleed Musa ; libvir-list@redhat.com; Moshe > Levi ; Adrian Chiris > Subject: Re: [Libvirt] Attach qemu commands to an running xml domain > > External email: Use

Re: [libvirt PATCH v6 00/30] Add support for persistent mediated devices

2021-03-31 Thread Erik Skultety
On Fri, Mar 26, 2021 at 11:47:56AM -0500, Jonathon Jongsma wrote: > This patch series follows the previously-merged series which added support for > transient mediated devices. This series expands mdev support to include > persistent device definitions. Again, it relies on mdevctl as the backend.

Re: [libvirt PATCH v6 15/30] nodedev: add function to generate mdevctl define command

2021-03-31 Thread Erik Skultety
On Fri, Mar 26, 2021 at 11:48:11AM -0500, Jonathon Jongsma wrote: > Abstract out the function used to generate the commandline for 'mdevctl > start' since they take the same arguments. Add tests to ensure that > we're generating the command properly. > > Signed-off-by: Jonathon Jongsma > ---

Re: [Libvirt] Attach qemu commands to an running xml domain

2021-03-31 Thread Daniel P . Berrangé
On Wed, Mar 31, 2021 at 02:11:40PM +0200, Michal Privoznik wrote: > On 3/31/21 1:36 PM, Daniel P. Berrangé wrote: > > On Wed, Mar 31, 2021 at 01:09:32PM +0200, Michal Privoznik wrote: > > > On 3/30/21 11:35 AM, Waleed Musa wrote: > > > > Hi all, > > > > > > > > I see in libvirt you are supporting

Re: [Libvirt] Attach qemu commands to an running xml domain

2021-03-31 Thread Michal Privoznik
On 3/31/21 1:36 PM, Daniel P. Berrangé wrote: On Wed, Mar 31, 2021 at 01:09:32PM +0200, Michal Privoznik wrote: On 3/30/21 11:35 AM, Waleed Musa wrote: Hi all, I see in libvirt you are supporting attach/detach devices to existing xml domain using *attachDeviceFlags *and *detachDeviceFlags

Re: [libvirt PATCH 2/2] qemu: implement setting of rotation rate for SCSI/IDE disks

2021-03-31 Thread Daniel P . Berrangé
On Wed, Mar 31, 2021 at 01:49:04PM +0200, Ján Tomko wrote: > On a Wednesday in 2021, Daniel P. Berrangé wrote: > > Signed-off-by: Daniel P. Berrangé > > --- > > src/qemu/qemu_capabilities.c | 2 + > > src/qemu/qemu_capabilities.h | 1 + > >

Re: [PATCH 0/6] Remove few useless syntax-checks

2021-03-31 Thread Ján Tomko
On a Wednesday in 2021, Peter Krempa wrote: Peter Krempa (6): syntax-check: Remove check for proper spelling of 'Red Hat' syntax-check: Clean up check for g_auto* syntax-check: Remove used header checks for gnulib modules syntax-check: Remove check for prohibited 'WITH_MBRTOWC'

Re: [libvirt PATCH 2/2] qemu: implement setting of rotation rate for SCSI/IDE disks

2021-03-31 Thread Ján Tomko
On a Wednesday in 2021, Daniel P. Berrangé wrote: Signed-off-by: Daniel P. Berrangé --- src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 3 + src/qemu/qemu_validate.c |

Re: [libvirt PATCH 1/2] conf: add support for disk "rotation_rate" property

2021-03-31 Thread Ján Tomko
On a Wednesday in 2021, Daniel P. Berrangé wrote: This lets the app expose the virtual SCSI or IDE disks as solid state devices by setting a rate of '1', or rotational media by setting a rate between 1025 and 65534. Signed-off-by: Daniel P. Berrangé --- docs/formatdomain.rst | 13

Re: [Libvirt] Attach qemu commands to an running xml domain

2021-03-31 Thread Daniel P . Berrangé
On Wed, Mar 31, 2021 at 01:09:32PM +0200, Michal Privoznik wrote: > On 3/30/21 11:35 AM, Waleed Musa wrote: > > Hi all, > > > > I see in libvirt you are supporting attach/detach devices to existing > > xml domain using *attachDeviceFlags *and *detachDeviceFlags *APIs. > > Now we are adding some

Re: [Libvirt] Attach qemu commands to an running xml domain

2021-03-31 Thread Michal Privoznik
On 3/30/21 11:35 AM, Waleed Musa wrote: Hi all, I see in libvirt you are supporting attach/detach devices to existing xml domain using *attachDeviceFlags *and *detachDeviceFlags *APIs. Now we are adding some qemu command to the xml domain related to some interfaces using alias names before 

[libvirt PATCH 1/2] conf: add support for disk "rotation_rate" property

2021-03-31 Thread Daniel P . Berrangé
This lets the app expose the virtual SCSI or IDE disks as solid state devices by setting a rate of '1', or rotational media by setting a rate between 1025 and 65534. Signed-off-by: Daniel P. Berrangé --- docs/formatdomain.rst | 13 ++--- docs/schemas/domaincommon.rng | 5 +

[libvirt PATCH 0/2] qemu: wire up support for rotation rate for disks

2021-03-31 Thread Daniel P . Berrangé
By default QEMU doesn't report any rotation information to guests, so guests assume rotational media. This lets the user specify an explicit speed in RPM, or 1 for SSD. This may allow the user to achieve better performance for their virtual disks. Note, however, this doesn't mean that the guest

[libvirt PATCH 2/2] qemu: implement setting of rotation rate for SCSI/IDE disks

2021-03-31 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 3 + src/qemu/qemu_validate.c | 22 .../caps_2.12.0.aarch64.xml

Re: [libvirt][PATCH v4 0/3] introduce 'restrictive' mode in numatune

2021-03-31 Thread Martin Kletzander
On Wed, Mar 31, 2021 at 06:33:28AM +, Zhong, Luyao wrote: -Original Message- From: Martin Kletzander Sent: Wednesday, March 31, 2021 12:21 AM To: Zhong, Luyao Cc: Daniel P. Berrangé ; libvir-list@redhat.com Subject: Re: [libvirt][PATCH v4 0/3] introduce 'restrictive' mode in

[PATCH 5/6] syntax-check: Remove unused header check for 'strings.h'

2021-03-31 Thread Peter Krempa
Libvirt doesn't use it and we also require use of wrappers for such string operations. Remove the pointless check. Signed-off-by: Peter Krempa --- build-aux/syntax-check.mk | 8 1 file changed, 8 deletions(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index

[PATCH 4/6] syntax-check: Remove check for prohibited 'WITH_MBRTOWC'

2021-03-31 Thread Peter Krempa
While our code uses mbrtowc, we don't do any detection of it. Additionally it was recently changed from HAVE_MBRTOWC to WITH_MBRTOWC so even if it came from an included file it would no longer work. Signed-off-by: Peter Krempa --- build-aux/syntax-check.mk | 5 - 1 file changed, 5

[PATCH 6/6] syntax-check: Remove GFDL format check

2021-03-31 Thread Peter Krempa
Our docs don't use the GFDL so checking its format is pointless. Signed-off-by: Peter Krempa --- build-aux/syntax-check.mk | 8 1 file changed, 8 deletions(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index dbc0338ac0..6d934c4de1 100644 ---

[PATCH 3/6] syntax-check: Remove used header checks for gnulib modules

2021-03-31 Thread Peter Krempa
We removed gnulib support, so all the checks whether a header is included only when it's used are pointless now. Signed-off-by: Peter Krempa --- build-aux/syntax-check.mk | 96 --- 1 file changed, 96 deletions(-) diff --git a/build-aux/syntax-check.mk

[PATCH 1/6] syntax-check: Remove check for proper spelling of 'Red Hat'

2021-03-31 Thread Peter Krempa
Don't single out this one, and also don't waste computational resources on it. Signed-off-by: Peter Krempa --- build-aux/syntax-check.mk | 15 --- 1 file changed, 15 deletions(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index 51a498a897..1dac418008 100644

[PATCH 0/6] Remove few useless syntax-checks

2021-03-31 Thread Peter Krempa
Peter Krempa (6): syntax-check: Remove check for proper spelling of 'Red Hat' syntax-check: Clean up check for g_auto* syntax-check: Remove used header checks for gnulib modules syntax-check: Remove check for prohibited 'WITH_MBRTOWC' syntax-check: Remove unused header check for

[PATCH 2/6] syntax-check: Clean up check for g_auto*

2021-03-31 Thread Peter Krempa
Remove the old libvirt variants that are no longer in use and include g_autostringlist. Signed-off-by: Peter Krempa --- build-aux/syntax-check.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index

Re: [libvirt PATCH v6 11/30] nodedev: add mdevctl devices to node device list

2021-03-31 Thread Erik Skultety
On Fri, Mar 26, 2021 at 11:48:07AM -0500, Jonathon Jongsma wrote: > At startup, query devices that are defined by 'mdevctl' and add them to > the node device list. > > This adds a complication: we now have two potential sources of > information for a node device: > - udev for all devices and for

Re: [libvirt PATCH v6 26/30] nodedev: add ability to specify UUID for new mdevs

2021-03-31 Thread Erik Skultety
On Fri, Mar 26, 2021 at 11:48:22AM -0500, Jonathon Jongsma wrote: > Use the new element in the mdev caps to define and start devices > with a specific UUID. > > Signed-off-by: Jonathon Jongsma > --- Reviewed-by: Erik Skultety

RE: [libvirt][PATCH v4 0/3] introduce 'restrictive' mode in numatune

2021-03-31 Thread Zhong, Luyao
>-Original Message- >From: Martin Kletzander >Sent: Wednesday, March 31, 2021 12:21 AM >To: Zhong, Luyao >Cc: Daniel P. Berrangé ; libvir-list@redhat.com >Subject: Re: [libvirt][PATCH v4 0/3] introduce 'restrictive' mode in numatune > >On Tue, Mar 30, 2021 at 08:53:19AM +, Zhong,

Re: [libvirt PATCH v6 19/30] nodedev: refactor tests to support mdev undefine

2021-03-31 Thread Erik Skultety
On Fri, Mar 26, 2021 at 11:48:15AM -0500, Jonathon Jongsma wrote: > mdevctl 'stop' and 'undefine' commands take the same uuid parameter, so > refactor the test infrastructure to share common implementation for both > of these commands. The 'undefine' command will be introduced in a > following

Re: [libvirt PATCH v6 16/30] api: add virNodeDeviceDefineXML()

2021-03-31 Thread Erik Skultety
On Fri, Mar 26, 2021 at 11:48:12AM -0500, Jonathon Jongsma wrote: > With mediated devices, we can now define persistent node devices that > can be started and stopped. In order to take advantage of this, we need > an API to define new node devices. > > Signed-off-by: Jonathon Jongsma > --- >

Re: [libvirt PATCH v6 20/30] api: add virNodeDeviceUndefine()

2021-03-31 Thread Erik Skultety
On Fri, Mar 26, 2021 at 11:48:16AM -0500, Jonathon Jongsma wrote: > This interface allows you to undefine a persistently defined (but > inactive) mediated devices. It is implemented via 'mdevctl' > > Signed-off-by: Jonathon Jongsma ... > > > +/** > + * virNodeDeviceUndefine: > + * @dev: a