Re: [PATCH] hw/arm/raspi: Remove deprecated raspi2/raspi3 aliases

2021-05-10 Thread Philippe Mathieu-Daudé
Hi Peter, Can this patch go via your qemu-arm tree (it is reviewed)? On 5/3/21 12:57 PM, Philippe Mathieu-Daudé wrote: > Remove the raspi2/raspi3 machine aliases, > deprecated since commit 155e1c82ed0. > > Signed-off-by: Philippe Mathieu-Daudé > --- > docs/system/deprecated.rst | 7

Re: [PATCH v2] libxl: set vcpu affinity during domain creation

2021-05-10 Thread Daniel Henrique Barboza
On 5/5/21 11:06 AM, Olaf Hering wrote: Since Xen 4.5 libxl allows to set affinities during domain creation. This enables Xen to allocate the domain memory on NUMA systems close to the specified pcpus. Libvirt can now handle in domU.xml correctly. Without this change, Xen will create the

[libvirt PATCH 3/4] gitlab: run "meson" directly instead of "ninja" indirection

2021-05-10 Thread Daniel P . Berrangé
The "dist" and "test" targets in ninja end up calling back into the equivalent meson commands. The meson commands support various arguments that are not accessible when invoked via ninja, so it is preferrable to use meson directly. Signed-off-by: Daniel P. Berrangé --- .gitlab-ci.yml | 20

[libvirt PATCH 4/4] gitlab: avoid building libvirt twice and running syntax-check twice

2021-05-10 Thread Daniel P . Berrangé
In the distros using RPMs, we build libvirt once as a side effect of running "ninja dist", and once via rpmbuild. In addition "ninja dist" will run all tests including the "syntax-check" suite, despite use having a separate "codestyle" job for for that. There is no way to pass "--no-suite" when

[libvirt PATCH 1/4] gitlab: only print failed tests in codestyle job

2021-05-10 Thread Daniel P . Berrangé
"meson test" will only print a list of which tests fail by default, so we were sending the full test log to stdout on failure. This makes it really hard to see the errors though as the test log has all succcesful tests too. "ninja test" will print the same as "meson test", following by details of

[libvirt PATCH 2/4] gitlab: remove ability to skip 'ninja dist'

2021-05-10 Thread Daniel P . Berrangé
The "DIST=skip" flag as used in CentOS 7 jobs to workaround a problem with older git versions. This is no longer required since commit d35003aee7d057e66d935cfd919ea86d5d450c4c Author: Andrea Bolognani Date: Tue May 4 10:45:29 2021 +0200 ci: Drop CentOS 7 Signed-off-by: Daniel P.

[libvirt PATCH 0/4] gitlab: improve CI speed

2021-05-10 Thread Daniel P . Berrangé
In several of the jobs we are running the libvirt build twice. We also uncessarily run the syntax-check job multiple times which causes more work for contributors looking at failed jobs. Daniel P. Berrangé (4): gitlab: only print failed tests in codestyle job gitlab: remove ability to skip

[libvirt PATCH v2 1/2] docs: kbase: Add a doc on live full disk backup

2021-05-10 Thread Kashyap Chamarthy
This is a rewrite of: https://wiki.libvirt.org/page/Live-disk-backup-with-active-blockcommit Once this commit merges, the above wiki should point to this kbase document. NB: I've intentionally left out the example for pull-based full backups. I'll tackle it once QMP `x-blockdev-reopen`

[libvirt PATCH v2 2/2] docs: kbase: Add a doc on merging disk image chains

2021-05-10 Thread Kashyap Chamarthy
This is a rewrite of: https://wiki.libvirt.org/page/Live-merge-an-entire-disk-image-chain-including-current-active-disk Once this commit merges, the above wiki should point to this kbase document. Signed-off-by: Kashyap Chamarthy --- docs/kbase/merging_disk_image_chains.rst | 200

[libvirt PATCH v2 0/2] rST-ify and rewrite a couple of block-layer docs

2021-05-10 Thread Kashyap Chamarthy
I don't think the Debian "sid" failure is related to my patch: https://gitlab.com/kashyapc/libvirt/-/pipelines/300380749/failures Changes in v2: - Mention backupBegin() [Peter] - Add examples of push-mode backup using backupBegin() [Peter, Kashyap] - Use existing rST conventions to make

Re: [libvirt PATCH v2 09/10] src: elevate current identity privilege when fetching secret

2021-05-10 Thread Daniel P . Berrangé
On Mon, May 10, 2021 at 01:32:20PM +0200, Michal Prívozník wrote: > On 5/7/21 6:24 PM, Daniel P. Berrangé wrote: > > When fetching the value of a private secret, we need to use an elevated > > identity otherwise the secret driver will deny access. > > > > When using the modular daemons, the

Re: [libvirt PATCH] qemu_firmware: don't error out for unknown firmware features

2021-05-10 Thread Pavel Hrdina
On Mon, May 10, 2021 at 03:24:39PM +0200, Peter Krempa wrote: > On Mon, May 10, 2021 at 15:16:11 +0200, Pavel Hrdina wrote: > > When QEMU introduces new firmware features libvirt will fail until we > > list that feature in our code as well which doesn't sound right. > > > > We should simply

Re: [libvirt PATCH] qemu_firmware: don't error out for unknown firmware features

2021-05-10 Thread Pavel Hrdina
On Mon, May 10, 2021 at 02:24:49PM +0100, Daniel P. Berrangé wrote: > On Mon, May 10, 2021 at 03:16:11PM +0200, Pavel Hrdina wrote: > > When QEMU introduces new firmware features libvirt will fail until we > > list that feature in our code as well which doesn't sound right. > > > > We should

Re: [libvirt PATCH] qemu_firmware: don't error out for unknown firmware features

2021-05-10 Thread Daniel P . Berrangé
On Mon, May 10, 2021 at 03:16:11PM +0200, Pavel Hrdina wrote: > When QEMU introduces new firmware features libvirt will fail until we > list that feature in our code as well which doesn't sound right. > > We should simply ignore the new feature until we add a proper support > for it. > >

Re: [libvirt PATCH] qemu_firmware: don't error out for unknown firmware features

2021-05-10 Thread Peter Krempa
On Mon, May 10, 2021 at 15:16:11 +0200, Pavel Hrdina wrote: > When QEMU introduces new firmware features libvirt will fail until we > list that feature in our code as well which doesn't sound right. > > We should simply ignore the new feature until we add a proper support > for it. > >

Re: [PATCH] Introduce a new virDomainReloadTlsCertificates API

2021-05-10 Thread Han Han
On Sat, May 8, 2021 at 2:43 PM Zheng Yan wrote: > The new virDomainReloadTlsCertificates API is used to notify domain reload > its certificates without restart, and avoid service interruption. > > Currently, only QEMU VNC TLS certificates are supported, but parameters and > flags are also

[libvirt PATCH] qemu_firmware: don't error out for unknown firmware features

2021-05-10 Thread Pavel Hrdina
When QEMU introduces new firmware features libvirt will fail until we list that feature in our code as well which doesn't sound right. We should simply ignore the new feature until we add a proper support for it. Reported-by: Laszlo Ersek Signed-off-by: Pavel Hrdina ---

[libvirt PATCH 10/10] virNodeDeviceDefParseXML: Use virXMLProp*

2021-05-10 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/conf/node_device_conf.c | 19 --- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c index 04014f75dc..4477a8d9d2 100644 --- a/src/conf/node_device_conf.c +++

[libvirt PATCH 07/10] virNodeDevCapsDefParseXML: Use virXMLProp*

2021-05-10 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/conf/node_device_conf.c | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c index 34c8aa988e..b3d5bc1515 100644 --- a/src/conf/node_device_conf.c +++

[libvirt PATCH 09/10] virNodeDevCapsDefParseXML: Use g_autoptr

2021-05-10 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/conf/node_device_conf.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c index b3d5bc1515..04014f75dc 100644 --- a/src/conf/node_device_conf.c +++

[libvirt PATCH 05/10] virPCIEDeviceInfoLinkParseXML: Use virXMLProp*

2021-05-10 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/conf/node_device_conf.c | 34 ++ 1 file changed, 6 insertions(+), 28 deletions(-) diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c index faa36c1944..ef09ed0a6f 100644 --- a/src/conf/node_device_conf.c

[libvirt PATCH 06/10] virPCIEDeviceInfoLinkParseXML: Remove unused parameter ctxt

2021-05-10 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/conf/node_device_conf.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c index ef09ed0a6f..34c8aa988e 100644 --- a/src/conf/node_device_conf.c +++

[libvirt PATCH 03/10] virNetworkDHCPLeaseTimeDef: Make expiry unsigned long long

2021-05-10 Thread Tim Wiederhake
The width of `unsigned long` differs on 32 bit and 64 bit architectures. There is no compelling reason why the maximum DHCP lease time should depend on the architecture. Signed-off-by: Tim Wiederhake --- src/conf/network_conf.c | 8 src/conf/network_conf.h | 2 +-

[libvirt PATCH 04/10] virNetworkDHCPLeaseTimeDefParseXML: Use virXMLProp*

2021-05-10 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/conf/network_conf.c | 26 ++ 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index c3c335135b..a9eadff29c 100644 --- a/src/conf/network_conf.c +++

[libvirt PATCH 08/10] conf: node_device: Register autoptr cleanup function for virNodeDevCapsDef

2021-05-10 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/conf/node_device_conf.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/conf/node_device_conf.h b/src/conf/node_device_conf.h index 85790ad96c..a60562e4fe 100644 --- a/src/conf/node_device_conf.h +++ b/src/conf/node_device_conf.h @@ -377,6 +377,8

[libvirt PATCH 02/10] virDomainObjParseXML: Use g_autoptr

2021-05-10 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 30 +- 1 file changed, 13 insertions(+), 17 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 0d396cbdda..7044701fac 100644 --- a/src/conf/domain_conf.c +++

[libvirt PATCH 01/10] virDomainObjParseXML: Use virXMLProp*

2021-05-10 Thread Tim Wiederhake
Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 36 +--- 1 file changed, 13 insertions(+), 23 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index e8632e4d73..0d396cbdda 100644 --- a/src/conf/domain_conf.c +++

[libvirt PATCH 00/10] Refactor more XML parsing boilerplate code, part IX

2021-05-10 Thread Tim Wiederhake
For background, see https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html Tim Wiederhake (10): virDomainObjParseXML: Use virXMLProp* virDomainObjParseXML: Use g_autoptr virNetworkDHCPLeaseTimeDef: Make expiry unsigned long long virNetworkDHCPLeaseTimeDefParseXML: Use

After blockcopy with pivot, a dirty-bitmap is added, but not been removed automatically.

2021-05-10 Thread ChangLimin
Hi Peter, Since https://libvirt.org/git/?p=libvirt.git;a=commitdiff;h=7bfff40fdfe5410c446c1cd8ec413e00530faf7d, after blockcopy with pivot, a dirty-bitmap is added, but not been removed automatically. Is that something wrong? 0. start a vm, and switch on some traces # virsh start cirros #

Re: [PATCH 0/5] Couple of virCapabilities cleanups

2021-05-10 Thread Ján Tomko
On a Wednesday in 2021, Michal Privoznik wrote: I'm working on reporting HMAT in virCapabilities and noticed couple of possible cleanups. I'm sending them upfront. Michal Prívozník (5): virCapabilitiesHostNUMAFormat: Swap order of arguments virCapabilitiesHostNUMAInitReal: Free @cpus properly

Re: [libvirt PATCH v2 09/10] src: elevate current identity privilege when fetching secret

2021-05-10 Thread Michal Prívozník
On 5/7/21 6:24 PM, Daniel P. Berrangé wrote: > When fetching the value of a private secret, we need to use an elevated > identity otherwise the secret driver will deny access. > > When using the modular daemons, the elevated identity needs to be active > before the secret driver connection is

Re: [libvirt PATCH v2 03/10] util: generate a persistent system token

2021-05-10 Thread Michal Prívozník
On 5/7/21 6:24 PM, Daniel P. Berrangé wrote: > When creating the system identity set the system token. The system > token is currently stored in a local path > >/var/run/libvirt/common/system.token > > Obviously with only traditional UNIX DAC in effect, this is largely > security through

Re: [PATCH] securityselinuxhelper: Fix retval of setcon_raw() and security_disable()

2021-05-10 Thread Ján Tomko
On a Monday in 2021, Michal Privoznik wrote: The securityselinuxhelper is a mock that's replacing libselinux APIs with our own implementation to achieve deterministic results. Our implementation uses env vars (among other things) to hold internal state. For instance, "FAKE_SELINUX_CONTEXT" and

Re: [libvirt PATCH v3 0/8] cleanup meson checks for runtime binaries

2021-05-10 Thread Pavel Hrdina
On Wed, Apr 21, 2021 at 02:37:23PM +0200, Pavel Hrdina wrote: > Recent attempt to add a lot of meson options to specify different > runtime paths motivated me enough to cleanup this from meson. > > Changes in v3: > - some patches were already pushed > - removed patch that moved

[PATCH] securityselinuxhelper: Fix retval of setcon_raw() and security_disable()

2021-05-10 Thread Michal Privoznik
The securityselinuxhelper is a mock that's replacing libselinux APIs with our own implementation to achieve deterministic results. Our implementation uses env vars (among other things) to hold internal state. For instance, "FAKE_SELINUX_CONTEXT" and "FAKE_SELINUX_DISABLED" variables are used.

Re: After blockcopy with pivot, a dirty-bitmap is added, but not been removed automatically.

2021-05-10 Thread Peter Krempa
On Mon, May 10, 2021 at 13:34:41 +0800, ChangLimin wrote: > Hi Peter, > > Since > https://libvirt.org/git/?p=libvirt.git;a=commitdiff;h=7bfff40fdfe5410c446c1cd8ec413e00530faf7d, > > after blockcopy with pivot, a dirty-bitmap is added, but not been removed > automatically. > Is that something

[PATCH v3 1/1] qemu: add support for max-ram-below-4g option

2021-05-10 Thread Zhiyong Ye
The 'below4g' attribute added in 'memory' element can be used to specify the low memory area, which allows to get a larger PCI I/O window below 4G when reduce it to a smaller value, and when raise value allows legacy non-PAE guests to have as much memory as possible in the 32bit address space

[PATCH v3 0/1] qemu: add support for max-ram-below-4g option

2021-05-10 Thread Zhiyong Ye
For background, see: https://listman.redhat.com/archives/libvir-list/2021-April/msg01196.html V3 to V2: * Fix conflicts created by git pull V2 to V1: * Change the 'below4g' attribute to not share the 'unit' argument with actual memory size, and let its unit default to KiB * Add docs and test