[PATCH] tests: Update expected output of virsh-optparse

In the previous commit I've changed what API is called from 'virsh setmem' command. However, since virsh-optparse test is ran only when expensive tests are enabled I've completely missed that the expected output for virsh-optparse test must be updated too as it contains the API. Signed-off-by: Mic

[PATCH 2/5] qemu: add 'pef-guest' capability

This capability will be used in the papr-pef launch security type. Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_capabilities.c| 2 ++ src/qemu/qemu_capabilities.h| 1 + tests/qemucapabilitiesdata/caps_6.1.0.ppc64.xml | 1 + 3 files changed, 4 i

[PATCH 5/5] docs/formatdomain.rst: add 'papr-pef' launchSecurity docs

Signed-off-by: Daniel Henrique Barboza --- docs/formatdomain.rst | 4 1 file changed, 4 insertions(+) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index ab1307910d..4102327aa8 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -8067,6 +8067,10 @@ IBM Secure Exec

[PATCH 4/5] tests: add tests for 'papr-pef' support

Signed-off-by: Daniel Henrique Barboza --- .../launch-security-papr-pef.xml | 22 ++ tests/genericxml2xmltest.c| 1 + ...y-papr-pef-ignore-policy.ppc64-latest.args | 30 +++ ...launch-security-papr-pef-ignore-policy.xml | 19 ++

[PATCH 3/5] conf, qemu: add 'papr-pef' launch security type

This patch adds the 'papr-pef' launch security type for the QEMU driver. Signed-off-by: Daniel Henrique Barboza --- docs/schemas/domaincommon.rng | 1 + src/conf/domain_conf.c| 3 +++ src/conf/domain_conf.h| 1 + src/qemu/qemu_command.c | 26 ++ s

[PATCH 0/5] Support for launchSecurity type papr-pef

Hi, This is the implementation of ppc64 secure guest execution, known as PAPR-PEF. This implementation is based on the new confidential-guest-support machine option that is available in QEMU 6.0.0. The patches were done on top of Boris s390-pv patches that were sent by review [1] given that Boris

Re: [PATCH v2 3/3] virsh-domain: Drop support for old APIs in cmdSetmem and cmdSetmaxmem

On 5/19/21 3:03 PM, Peter Krempa wrote: > On Wed, May 19, 2021 at 12:16:57 +0200, Michal Privoznik wrote: >> Some of our really old APIs are missing @flags argument. We >> introduced their variants with "Flags" suffix and wired some >> logic into virsh to call the new variant only if necessary. Thi

Re: Recommended volume permissions (being created for vagrant-libvirt via fog-libvirt)

On 5/31/21 4:42 PM, Darragh Bailey wrote: > Hi, > > On Thu, 27 May 2021 at 13:34, Michal Prívozník wrote: > >> Disks can contain various secrets (passwords, certificates, private >> keys, etc.). Historically, libvirt set seclabel on anything that QEMU >> needed access to and then returned it to

[PATCH] storage: Don't overwrite error in virISCSIDirectDisconnect()

The iscsi-direct storage pool backend works merely like this: a connection is established to the target (usually done via virStorageBackendISCSIDirectSetConnection()), intended action is executed (e.g. reporting LUNs, volume wiping), and at the end the connection is closed via virISCSIDirectDisconn

Re: Libvirt CI for running functional tests

On Thu, May 27, 2021 at 11:17:04AM -0500, Praveen K Paladugu wrote: > Hi, > > While developing cloud-hypervisor driver for libvirt, we re-fitted > cloud-hypervisor project's CI to libvirt. This CI was built on Rust and > currently supports VM boot up tests. > > https://github.com/cloud-hypervisor

Re: [PATCH 0/4] node_device_udev: Also process ID_TYPE=cd/dvd in udevProcessStorage()

On Wed, Jun 02, 2021 at 09:37:39 +0200, Michal Privoznik wrote: > See the last one which fixes a real bug. The rest is just cleanups. > > Michal Prívozník (4): > node_device_udev: Make udevGenerateDeviceName() return void > node_device_udev: Make udevGetStringProperty() return void > node_de

Re: [PATCH 2/4] node_device_udev: Make udevGetStringProperty() return void

On Wed, Jun 02, 2021 at 09:48:46 +0200, Peter Krempa wrote: > On Wed, Jun 02, 2021 at 09:37:41 +0200, Michal Privoznik wrote: > > This function can't fail really as it's returning 0 no matter > > what. This is probably a residue from old days when we cared > > about propagating OOM errors. Now we j

Re: [PATCH 2/4] node_device_udev: Make udevGetStringProperty() return void

On Wed, Jun 02, 2021 at 09:37:41 +0200, Michal Privoznik wrote: > This function can't fail really as it's returning 0 no matter > what. This is probably a residue from old days when we cared > about propagating OOM errors. Now we just abort. Make its return > type void then. > > Signed-off-by: Mic

[PATCH 4/4] node_device_udev: Also process ID_TYPE=cd/dvd in udevProcessStorage()

When processing node devices, the udevProcessStorage() will be called if the device is some form of storage. In here, ID_TYPE attribute is queried and depending on its value one of more specialized helper functions is called. For instance, for ID_TYPE=="cd" the udevProcessCDROM() is called, for ID_

[PATCH 3/4] node_device_udev: Don't overwrite @ret in udevProcessStorage()

Let's use a different variable for storing retvals of helper functions. This way the usual function pattern can be restored. Signed-off-by: Michal Privoznik --- src/node_device/node_device_udev.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/src/node_device

[PATCH 0/4] node_device_udev: Also process ID_TYPE=cd/dvd in udevProcessStorage()

See the last one which fixes a real bug. The rest is just cleanups. Michal Prívozník (4): node_device_udev: Make udevGenerateDeviceName() return void node_device_udev: Make udevGetStringProperty() return void node_device_udev: Don't overwrite @ret in udevProcessStorage() node_device_udev:

[PATCH 2/4] node_device_udev: Make udevGetStringProperty() return void

This function can't fail really as it's returning 0 no matter what. This is probably a residue from old days when we cared about propagating OOM errors. Now we just abort. Make its return type void then. Signed-off-by: Michal Privoznik --- src/node_device/node_device_udev.c | 46 ++--

[PATCH 1/4] node_device_udev: Make udevGenerateDeviceName() return void

This function can't fail really as it's returning 0 no matter what. This is probably a residue from old days when we cared about propagating OOM errors. Now we just abort. Make its return type void then. Signed-off-by: Michal Privoznik --- src/node_device/node_device_udev.c | 52 ++--