Signed-off-by: Lin Ma
---
tools/virsh-volume.c | 36 +---
1 file changed, 25 insertions(+), 11 deletions(-)
diff --git a/tools/virsh-volume.c b/tools/virsh-volume.c
index c7d5ab8c3b..41b366a833 100644
--- a/tools/virsh-volume.c
+++ b/tools/virsh-volume.c
@@ -54,14
The functions will be used by next patch.
Signed-off-by: Lin Ma
---
tools/virsh-pool.c | 10 ++
tools/virsh-pool.h | 11 +++
2 files changed, 13 insertions(+), 8 deletions(-)
diff --git a/tools/virsh-pool.c b/tools/virsh-pool.c
index 34ed86152e..18f3839a4c 100644
--- a/tools/vir
Signed-off-by: Lin Ma
---
tools/virsh-completer-domain.c | 20
tools/virsh-completer-domain.h | 6 ++
tools/virsh-domain.c | 2 ++
3 files changed, 28 insertions(+)
diff --git a/tools/virsh-completer-domain.c b/tools/virsh-completer-domain.c
index 256ac0b593.
Signed-off-by: Lin Ma
---
tools/virsh-completer-domain.c | 17 +
tools/virsh-completer-domain.h | 5 +
tools/virsh-domain.c | 1 +
3 files changed, 23 insertions(+)
diff --git a/tools/virsh-completer-domain.c b/tools/virsh-completer-domain.c
index 20d503ff09..256a
Signed-off-by: Lin Ma
---
tools/virsh-volume.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/tools/virsh-volume.c b/tools/virsh-volume.c
index daa205ea67..1da9b7217f 100644
--- a/tools/virsh-volume.c
+++ b/tools/virsh-volume.c
@@ -1643,11 +1643,7 @@ static cons
Signed-off-by: Lin Ma
---
tools/virsh-domain.c | 10 ++
tools/virsh-domain.h | 1 +
2 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 0100652e76..3fb37ea5e6 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -347
Signed-off-by: Lin Ma
---
tools/virsh-volume.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/tools/virsh-volume.c b/tools/virsh-volume.c
index 41b366a833..daa205ea67 100644
--- a/tools/virsh-volume.c
+++ b/tools/virsh-volume.c
@@ -1552,11 +1552,7 @@ static cons
Lin Ma (12):
virsh: Add comp-methods completion to migrate command
virsh: Use VIR_ENUM_* for --target argument in cmdNodeSuspend
virsh: Add target completion to nodesuspend command
virsh: Use VIR_ENUM_* for --target argument in cmdDomPMSuspend
virsh: Add target completion to dompmsuspend
Signed-off-by: Lin Ma
---
tools/virsh-domain.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 3fb37ea5e6..b3aa52b8a8 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -3453,6 +3453,7 @@ static const vshCmdOptDef opts_dom_pm_susp
Signed-off-by: Lin Ma
---
tools/virsh-completer-volume.c | 53 ++
tools/virsh-completer-volume.h | 5
2 files changed, 58 insertions(+)
diff --git a/tools/virsh-completer-volume.c b/tools/virsh-completer-volume.c
index 301ee982a5..14e9069c5a 100644
--- a/too
Signed-off-by: Lin Ma
---
tools/virsh-pool.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/virsh-pool.c b/tools/virsh-pool.c
index e8d3c33506..34ed86152e 100644
--- a/tools/virsh-pool.c
+++ b/tools/virsh-pool.c
@@ -64,6 +64,7 @@
{.name = "type", \
.type = VSH_OT_DATA, \
Signed-off-by: Lin Ma
---
tools/virsh-host.c | 17 +
tools/virsh-host.h | 3 +++
2 files changed, 12 insertions(+), 8 deletions(-)
diff --git a/tools/virsh-host.c b/tools/virsh-host.c
index 1eca0bc231..9d6d2b3645 100644
--- a/tools/virsh-host.c
+++ b/tools/virsh-host.c
@@ -950,6
Signed-off-by: Lin Ma
---
tools/virsh-completer-host.c | 20
tools/virsh-completer-host.h | 4
tools/virsh-host.c | 1 +
3 files changed, 25 insertions(+)
diff --git a/tools/virsh-completer-host.c b/tools/virsh-completer-host.c
index 213f029552..d17bc5f5ce 1
On 6/10/21 7:43 AM, Daniel P. Berrangé wrote:
This series first improves driver probing when using modular daemons.
Currently when URI is NULL, we connect to virtproxyd and it looks
at which UNIX sockets exist and what binaries exist, to decide which
modular hypervisor daemon to connect to.
Thi
On 6/10/21 7:43 AM, Daniel P. Berrangé wrote:
When virtproxyd gets a NULL URI, it needs to implement probing logic
similar to that found in virConnectOpen. The latter can't be used
directly since it relied on directly calling into the internal drivers
in libvirtd. virtproxyd approximates this beh
On Mon, Jun 14, 2021 at 12:27 PM Boris Fiuczynski wrote:
>
> On 6/3/21 10:11 PM, Jonathon Jongsma wrote:
> > Implement these new API functions in the nodedev driver.
> >
> > Signed-off-by: Jonathon Jongsma
> > ---
> > src/node_device/node_device_driver.c | 50
> >
On Thu, Jun 10, 2021 at 03:57:19PM +0200, Michal Privoznik wrote:
This test was generated on a guest with the following NUMA
configuration:
On Thu, Jun 10, 2021 at 03:57:18PM +0200, Michal Privoznik wrote:
Links between NUMA nodes can have different latencies and
bandwidths. This info is newly defined in ACPI 6.2 under
Heterogeneous Memory Attribute Table (HMAT) table. Linux kernel
learned how to report these values under sysfs and t
On 6/3/21 10:11 PM, Jonathon Jongsma wrote:
Implement these new API functions in the nodedev driver.
Signed-off-by: Jonathon Jongsma
---
src/node_device/node_device_driver.c | 50
src/node_device/node_device_driver.h | 6
src/node_device/node_device_udev.c
On 6/3/21 10:11 PM, Jonathon Jongsma wrote:
This is currently the only way to view the 'autostart' property for a
node device.
Signed-off-by: Jonathon Jongsma
---
docs/manpages/virsh.rst | 12
tools/virsh-nodedev.c | 68 +
2 files changed,
On Mon, Jun 14, 2021 at 04:57:47PM +0200, Peter Krempa wrote:
> On Mon, Jun 14, 2021 at 16:13:40 +0200, Pavel Hrdina wrote:
> > On Fri, Jun 11, 2021 at 04:18:24PM +0200, Peter Krempa wrote:
> > > On Fri, Jun 11, 2021 at 15:24:09 +0200, Pavel Hrdina wrote:
> > > > In libvirt we already use `query-co
The pc-1.0 machine type was deprecated in QEMU 6.0.0. In our tests we
use 2.12.0 and 6.0.0 replies so switch to pc type.
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
tests/qemuxml2argvdata/launch-security-sev.x86_64-2.12.0.args | 2 +-
tests/qemuxml2argvdata/launch-security-sev.xml
Currently we only have AMD SEV bits in qemu-2.12.0 replies which is way
too old to test new features that require AMD SEV as well.
Signed-off-by: Pavel Hrdina
---
tests/domaincapsdata/qemu_6.0.0-q35.x86_64.xml | 5 -
tests/domaincapsdata/qemu_6.0.0-tcg.x86_64.xml | 5 -
tes
Signed-off-by: Pavel Hrdina
Reviewed-by: Peter Krempa
---
src/qemu/qemu_command.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 14b1ac8e37..10cf5c255f 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_c
QEMU 6.0.0 introduced `confidential-guest-support` -machine option as
a replacement for `memory-encryption`. In order to test it use 6.0.0
capabilities as well.
Signed-off-by: Pavel Hrdina
---
.../launch-security-sev.x86_64-6.0.0.args | 36 +++
tests/qemuxml2argvtest.c
In libvirt we already use `query-command-line-options` QMP command but
that is useless as it doesn't provide correct data for `-machine`
option. So we need a new and better way to get that data.
We already use `qom-list-properties` to get options for specific machine
types so we can reuse it to ge
Changes in v2:
- patch 1 split into two separate patches
- AMD SEV bits added into 6.0.0 caps instead of 6.1.0
- launch-security-sev qemuxml2argv will use 'pc' machine type
Pavel Hrdi
On Mon, Jun 14, 2021 at 16:13:40 +0200, Pavel Hrdina wrote:
> On Fri, Jun 11, 2021 at 04:18:24PM +0200, Peter Krempa wrote:
> > On Fri, Jun 11, 2021 at 15:24:09 +0200, Pavel Hrdina wrote:
> > > In libvirt we already use `query-command-line-options` QMP command but
> > > that is useless as it doesn'
On 6/14/21 2:35 PM, Peter Krempa wrote:
> On Mon, Jun 14, 2021 at 14:30:26 +0200, Michal Prívozník wrote:
>> On 6/14/21 2:26 PM, Peter Krempa wrote:
>>> On Mon, Jun 14, 2021 at 14:14:47 +0200, Michal Prívozník wrote:
On 6/14/21 1:31 PM, Tim Wiederhake wrote:
> On Mon, 2021-06-14 at 13:06 +
On Fri, Jun 11, 2021 at 04:18:24PM +0200, Peter Krempa wrote:
> On Fri, Jun 11, 2021 at 15:24:09 +0200, Pavel Hrdina wrote:
> > In libvirt we already use `query-command-line-options` QMP command but
> > that is useless as it doesn't provide correct data for `-machine`
> > option. So we need a new a
On Mon, Jun 14, 2021 at 03:24:03PM +0200, Olaf Hering wrote:
> Am Mon, 14 Jun 2021 11:06:51 +0100
> schrieb Daniel P. Berrangé :
>
> > Repology reports the following
>
> Is it expected that people replace just "libvirt" on a system, and leave
> everything as it is?
>
> If I would build a Xen se
Am Mon, 14 Jun 2021 11:06:51 +0100
schrieb Daniel P. Berrangé :
> Repology reports the following
Is it expected that people replace just "libvirt" on a system, and leave
everything as it is?
If I would build a Xen server, the obvious change is to also replace Xen with
the variant I want or nee
Signed-off-by: Luke Yue
---
src/test/test_driver.c | 53 ++
1 file changed, 53 insertions(+)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index ae1b8ebc23..a7ea05464d 100644
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
@@ -9331
Signed-off-by: Luke Yue
---
src/test/test_driver.c | 41 +
1 file changed, 41 insertions(+)
diff --git a/src/test/test_driver.c b/src/test/test_driver.c
index 611ec6d7ec..ae1b8ebc23 100644
--- a/src/test/test_driver.c
+++ b/src/test/test_driver.c
@@ -136,6
On Mon, Jun 14, 2021 at 14:30:26 +0200, Michal Prívozník wrote:
> On 6/14/21 2:26 PM, Peter Krempa wrote:
> > On Mon, Jun 14, 2021 at 14:14:47 +0200, Michal Prívozník wrote:
> >> On 6/14/21 1:31 PM, Tim Wiederhake wrote:
> >>> On Mon, 2021-06-14 at 13:06 +0200, Michal Privoznik wrote:
> In a f
On Mon, Jun 14, 2021 at 02:26:48PM +0200, Peter Krempa wrote:
> On Mon, Jun 14, 2021 at 14:14:47 +0200, Michal Prívozník wrote:
> > On 6/14/21 1:31 PM, Tim Wiederhake wrote:
> > > On Mon, 2021-06-14 at 13:06 +0200, Michal Privoznik wrote:
> > >> In a few occasions in tests we pass INT_MAX to
> > >>
On 6/14/21 2:26 PM, Peter Krempa wrote:
> On Mon, Jun 14, 2021 at 14:14:47 +0200, Michal Prívozník wrote:
>> On 6/14/21 1:31 PM, Tim Wiederhake wrote:
>>> On Mon, 2021-06-14 at 13:06 +0200, Michal Privoznik wrote:
In a few occasions in tests we pass INT_MAX to
virFileReadLimFD(). This is
On Mon, Jun 14, 2021 at 14:14:47 +0200, Michal Prívozník wrote:
> On 6/14/21 1:31 PM, Tim Wiederhake wrote:
> > On Mon, 2021-06-14 at 13:06 +0200, Michal Privoznik wrote:
> >> In a few occasions in tests we pass INT_MAX to
> >> virFileReadLimFD(). This is not safe because virFileReadAll()
> >> will
On Mon, Jun 14, 2021 at 11:15:07AM +0200, Michal Prívozník wrote:
> On 6/11/21 2:27 PM, Pavel Hrdina wrote:
> > When using firmware auto-selection and user enables AMD SEV-ES we need
> > to pick correct firmware that actually supports it. This can be detected
> > by having `amd-sev-es` in the firmw
On 6/14/21 1:31 PM, Tim Wiederhake wrote:
> On Mon, 2021-06-14 at 13:06 +0200, Michal Privoznik wrote:
>> In a few occasions in tests we pass INT_MAX to
>> virFileReadLimFD(). This is not safe because virFileReadAll()
>> will call virFileReadLimFD() under the hood which takes the limit
>> and adds
On Mon, Jun 14, 2021 at 13:06:13 +0200, Michal Privoznik wrote:
> In a few occasions in tests we pass INT_MAX to
> virFileReadLimFD(). This is not safe because virFileReadAll()
> will call virFileReadLimFD() under the hood which takes the limit
> and adds 1 to it. And since we use signed integer fo
On Mon, 2021-06-14 at 13:06 +0200, Michal Privoznik wrote:
> In a few occasions in tests we pass INT_MAX to
> virFileReadLimFD(). This is not safe because virFileReadAll()
> will call virFileReadLimFD() under the hood which takes the limit
> and adds 1 to it.
Calling virFileReadAll with "INT_MAX -
On Mon, 2021-06-14 at 13:06 +0200, Michal Privoznik wrote:
> In a few places we take 1 and shift it left repeatedly. So much
> that it won't longer fit into signed integer. The problem is that
> this is undefined behaviour. Switching to 1U makes us stay within
> boundaries.
>
> Signed-off-by: Mich
On Mon, 2021-06-14 at 13:06 +0200, Michal Privoznik wrote:
> In a few places it may happen that the array we want to sort is
> still NULL (e.g. because there were no leases found, no paths for
> secdriver to lock or no cache banks). However, passing NULL to
> qsort() is undefined and even though gl
In a few occasions in tests we pass INT_MAX to
virFileReadLimFD(). This is not safe because virFileReadAll()
will call virFileReadLimFD() under the hood which takes the limit
and adds 1 to it. And since we use signed integer for all of this
an overflow will occur.
Signed-off-by: Michal Privoznik
In a few places it may happen that the array we want to sort is
still NULL (e.g. because there were no leases found, no paths for
secdriver to lock or no cache banks). However, passing NULL to
qsort() is undefined and even though glibc plays nicely we
shouldn't rely on undefined behaviour.
Signed-
In a few places we take 1 and shift it left repeatedly. So much
that it won't longer fit into signed integer. The problem is that
this is undefined behaviour. Switching to 1U makes us stay within
boundaries.
Signed-off-by: Michal Privoznik
---
src/conf/domain_capabilities.h | 2 +-
src/cpu/cpu_
I've noticed these while reviewing Tim's asan patches.
Michal Prívozník (3):
Don't call qsort() over NULL
tests: Don't pass INT_MAX to virFileReadAll()
src: Use 1U for bit shifting
src/conf/capabilities.c | 6 --
src/conf/domain_capabilities.h | 2 +-
src/cpu/cpu_x86.c
On 5/6/21 5:08 PM, Tim Wiederhake wrote:
> This series enables and adds AddressSanitizer and UndefinedBehaviorSanitizer
> builds to the CI.
>
> See:
> https://clang.llvm.org/docs/AddressSanitizer.html and
> https://clang.llvm.org/docs/UndefinedBehaviorSanitizer.html
>
> These sanitizers already f
126db34a81bc9f9f9710408f88cceaa1e34bbbd7 had previously switched various
flows over to this from VIR_ERR_OPERATION_FAILED.
This change simply does the same for qemuDomainDetachPrepDisk,
qemuDomainDetachPrepInput and qemuDomainDetachPrepVsock to allow
management apps to centralise their error handl
On Mon, Jun 14, 2021 at 11:54:56AM +0200, Pavel Hrdina wrote:
> On Mon, Jun 14, 2021 at 11:27:32AM +0200, Olaf Hering wrote:
> > Am Mon, 14 Jun 2021 11:13:54 +0200
> > schrieb Pavel Hrdina :
> >
> > > What OS that libvirt supports ships Xen < 4.9?
> >
> > I don't know if that matters.
> > A few l
Am Mon, 14 Jun 2021 11:54:56 +0200
schrieb Pavel Hrdina :
> It matters in a way that we can bump the minimal version to 4.9 and we
> can simplify the code a bit more.
I will leave this up to Jim if such thing can be justified.
It may not matter much for code in libxl.
Olaf
pgpVXP4K8mshY.pgp
De
On Mon, Jun 14, 2021 at 11:27:32AM +0200, Olaf Hering wrote:
> Am Mon, 14 Jun 2021 11:13:54 +0200
> schrieb Pavel Hrdina :
>
> > What OS that libvirt supports ships Xen < 4.9?
>
> I don't know if that matters.
> A few lines above in meson.build Xen 4.6 is the supported base.
It matters in a way
Am Mon, 14 Jun 2021 11:13:54 +0200
schrieb Pavel Hrdina :
> What OS that libvirt supports ships Xen < 4.9?
I don't know if that matters.
A few lines above in meson.build Xen 4.6 is the supported base.
Olaf
pgp7g1rZa_TUm.pgp
Description: Digitale Signatur von OpenPGP
On 6/11/21 2:27 PM, Pavel Hrdina wrote:
> When using firmware auto-selection and user enables AMD SEV-ES we need
> to pick correct firmware that actually supports it. This can be detected
> by having `amd-sev-es` in the firmware JSON description.
>
> Signed-off-by: Pavel Hrdina
> ---
> src/qemu/
On Mon, Jun 14, 2021 at 10:28:31AM +0200, Olaf Hering wrote:
> A xenstore.pc and xentoollog.pc exists only since Xen 4.9.
What OS that libvirt supports ships Xen < 4.9?
Pavel
> Fixes commit fe7c07adac30994dd042515e1076e195128e15cd
>
> Signed-off-by: Olaf Hering
> ---
> meson.build | 14 ++
I expect to find a link to the repositories when clicking on
"Contribute", this patch fixes this. The wording is directly inspired by
the one on the hacking page.
Signed-off-by: Simon Chopin
---
docs/contribute.html.in | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/do
A xenstore.pc and xentoollog.pc exists only since Xen 4.9.
Fixes commit fe7c07adac30994dd042515e1076e195128e15cd
Signed-off-by: Olaf Hering
---
meson.build | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/meson.build b/meson.build
index 04c229d7f4..f3ff57d336
58 matches
Mail list logo
