Re: [libvirt PATCH 5/5] qemu: Reject TPM 1.2 for ARM virt guests

It works. Thanks. Tested-by: liuyd.f...@fujitsu.com On 6/25/21 10:27 PM, Andrea Bolognani wrote: > We already reject TPM 1.2 in a number of scenarios; let's add > ARM virt guests to the list. > > https://bugzilla.redhat.com/show_bug.cgi?id=1970310 > > Signed-off-by: Andrea Bolognani > --- >

Re: [libvirt PATCH 3/5] qemu: Default to TPM 2.0 for ARM virt guests

That works for me. Thanks. Tested-by: liuyd.f...@fujitsu.com On 6/25/21 10:27 PM, Andrea Bolognani wrote: > The TPM 2.0 specification predates ARM virtualization, and so > implementing TPM 1.2 support on ARM was not considered a useful > endeavor. > > This is technically a breaking change, but

Re: [PATCH v2 1/3] test_driver: Implement virDomainGetMessages

On Mon, 2021-06-28 at 16:12 +0200, Martin Kletzander wrote: > On Mon, Jun 28, 2021 at 10:45:38AM +0800, Luke Yue wrote: > > On Thu, 2021-06-24 at 17:19 +0200, Martin Kletzander wrote: > > > On Thu, Jun 24, 2021 at 06:59:59PM +0800, Luke Yue wrote: > > > > Signed-off-by: Luke Yue > > > > --- > > >

Re: [PATCH v3 2/6] conf: modernize SEV XML parse and format methods

On 6/25/21 10:39 AM, Pavel Hrdina wrote: On Tue, Jun 22, 2021 at 03:10:45PM +0200, Boris Fiuczynski wrote: Make use of virDomainLaunchSecurity enum and automatic memory freeing. Signed-off-by: Boris Fiuczynski --- src/conf/domain_conf.c | 123 +

Re: [PATCH 2/2] virSetUIDGIDWithCaps: Assume PR_CAPBSET_DROP is always defined

On Fri, Jun 25, 2021 at 09:22:56AM +0200, Michal Privoznik wrote: Bounding set capabilities were introduced in kernel commit of v2.6.25-rc1~912. I guess it is safe to assume that all Linux hosts we ran on have at least that version or newer. Signed-off-by: Michal Privoznik ---

Re: [PATCH 1/2] virSetUIDGIDWithCaps: Don't drop CAP_SETPCAP right away

On Fri, Jun 25, 2021 at 09:22:55AM +0200, Michal Privoznik wrote: There are few cases where we execute a virCommand with all caps cleared (virCommandClearCaps()). For instance dnsmasqCapsRefreshInternal() does just that. This means, that after fork() and before exec() the virSetUIDGIDWithCaps()

Re: [PATCH] docs: formatdomain: Document disk serial truncation status quo

Hi, I have a few questions regarding this to get better understanding on how this should be handled by management apps. On Fri, Jun 04, 2021 at 02:08:40PM +0200, Peter Krempa wrote: > Disk serials are truncated arbitrarily and silently by qemu depending on > the device type and how they are

Re: [PATCH v2 1/3] test_driver: Implement virDomainGetMessages

On Mon, Jun 28, 2021 at 10:45:38AM +0800, Luke Yue wrote: On Thu, 2021-06-24 at 17:19 +0200, Martin Kletzander wrote: On Thu, Jun 24, 2021 at 06:59:59PM +0800, Luke Yue wrote: > Signed-off-by: Luke Yue > --- > src/test/test_driver.c | 53 > ++ > 1 file

Re: [PATCH] NEWS: Update for 7.5.0

On Mon, Jun 28, 2021 at 11:45:31AM +0200, Peter Krempa wrote: > * **Improvements** > > + * docs: Document disk serial truncation status quo One leading spaces too many. > +Disk is being truncated by qemu before passed to the guest. s/qemu/QEMU/ > * **Bug fixes** > > + * qemu:

[PATCH 2/4] qemu: interface: add virNetDevOpenvswitchInterfaceSetQos and virNetDevOpenvswitchInterfaceClearQos

From: zhangjl02 Introduce qos setting and cleaning method. Use ovs command to set qos parameters on specific interface of qemu virtual machine. When an ovs port is created, we add 'ifname' to external-ids. When setting qos on an ovs port, query its qos and queue. If found, change qos on queried

[PATCH 1/4] qemu: interface: add qemuDomainDefIsOvsport

From: zhangjl02 Tell whether a port definition is an ovs managed virtual port --- src/qemu/qemu_domain.c | 13 + src/qemu/qemu_domain.h | 3 +++ 2 files changed, 16 insertions(+) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index fc60e15eea..da5a226fc2 100644 ---

[PATCH 3/4] qemu: interface: remove setting noqueue for ovs port

From: zhangjl02 Return 0 directly if the port is ovs managed. When the ovs port is set noqueue, qos config on this port will not work. --- src/qemu/qemu_domain.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index da5a226fc2..2e8236ce7c

[PATCH 0/4] Add qemu support setting qos via ovs on ovs interface

Now libvirt use tc rules to manage interface's qos. But when a interface is created by ovs, there is no qos setting result in ovs database. Therefore, qos of ovs port should be set via ovs management command. We add a function to tell whether a port definition is an ovs managed virtual port.

[PATCH 4/4] qemu: interface: check and use ovs command to set qos of ovs managed port

From: zhangjl02 When qos is set or delete, we have to check if the port is an ovs managed port. If true, call the virNetDevOpenvswitchInterfaceSetQos function when qos is set, and call the virNetDevOpenvswitchInterfaceClearQos function when the interface is to be destroyed. ---

[PATCH] NEWS: Update for 7.5.0

Mention fixing of disk iothread validation and the disk serial truncation state. Signed-off-by: Peter Krempa --- NEWS.rst | 11 +++ 1 file changed, 11 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 2c7180cb95..3da2047d36 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -22,8 +22,19 @@