Re: Avoiding lockspace already exists error from virtlockd

2021-06-30 Thread Jim Fehlig
On 6/25/21 4:53 AM, Michal Prívozník wrote: On 5/28/21 8:30 PM, Jim Fehlig wrote: Hi All! I received a bug report about virtlockd emitting an error whenever libvirtd is (re)started May 25 15:44:31 virt81 virtlockd[7723]: Requested operation is not valid: Lockspace for path

[PATCH] virtlockd: Don't report error if lockspace exists

2021-06-30 Thread Jim Fehlig
When the qemu or libxl driver is configured to use lockd and file_lockspace_dir is set, virtlockd emits an error when libvirtd is retarted May 25 15:44:31 virt81 virtlockd[7723]: Requested operation is not valid: Lockspace for path /data/libvirtd/lockspace already exists There is really no need

[libvirt PATCH 4/4] tests.lavocado: adding a README and Makefile for convenience

2021-06-30 Thread Beraldo Leal
Signed-off-by: Beraldo Leal --- tests/lavocado/Makefile | 2 + tests/lavocado/README.md | 124 +++ 2 files changed, 126 insertions(+) create mode 100644 tests/lavocado/Makefile create mode 100644 tests/lavocado/README.md diff --git

[libvirt PATCH 3/4] tests.lavocado: adding a .gitignore

2021-06-30 Thread Beraldo Leal
This will prevent unnecessary Python object and temporary files to be tracked by git. Signed-off-by: Beraldo Leal --- tests/lavocado/.gitignore | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 tests/lavocado/.gitignore diff --git a/tests/lavocado/.gitignore

[libvirt PATCH 2/4] tests.lavocado: adding basic transient domain tests

2021-06-30 Thread Beraldo Leal
This basic test case validates the core lifecycle and operations on transient domains and came from libvirt-tck as an exercise in porting tests. Signed-off-by: Beraldo Leal --- tests/lavocado/tests/domain/transient.py | 102 +++ 1 file changed, 102 insertions(+) create mode

[libvirt PATCH 1/4] tests: introduce lavocado: initial code structure

2021-06-30 Thread Beraldo Leal
lavocado aims to be an alternative test framework for the libvirt project using Python, python-libvirt and Avocado. This can be used to write unit, functional and integration tests and it is inspired by the libvirt-tck framework. Documentation, helper classes and templates will be provided to

[libvirt PATCH 0/4] RFC: tests: introduce lavocado

2021-06-30 Thread Beraldo Leal
lavocado aims to be an alternative test framework for the libvirt project using Python, python-libvirt and Avocado. This can be used to write unit, functional and integration tests and it is inspired by the libvirt-tck framework. This series introduces the basic framework along with some basic

[PATCH] lib: Specify domain redefinition requirements

2021-06-30 Thread Roman Bolshakov
There might be misunderstanding [1] when libvirt permits domain redefinition and if it's a valid case at all. 1. https://github.com/ansible-collections/community.libvirt/blob/b973d7c4b405818b9fe77bbb0432c67acc12e82f/plugins/modules/virt.py#L533 Signed-off-by: Roman Bolshakov ---

Re: [PATCH libvirt v1] conf: verify for duplicate hostdevs

2021-06-30 Thread Michal Prívozník
On 6/18/21 12:46 PM, Shalini Chellathurai Saroja wrote: > It is possible to define/edit(in shut off state) a domain XML with > same hostdev device repeated more than once, as shown below. This > behavior is not expected. So, this patch fixes it. > > vser1: > > [...] > > [...] > >

Re: [libvirt PATCH] nodedev: handle mdevs from multiple parents

2021-06-30 Thread Michal Prívozník
On 6/10/21 8:15 PM, Jonathon Jongsma wrote: > Due to a rather unfortunate misunderstanding, we were parsing the list > of defined devices from mdevctl incorrectly. Since my primary > development machine only has a single device capable of mdevs, I > apparently neglected to test multiple parent

Re: [libvirt PATCH v2 0/5] mdev tweaks

2021-06-30 Thread Jonathon Jongsma
On Wed, Jun 30, 2021 at 3:18 AM Michal Prívozník wrote: > > On 6/22/21 9:53 PM, Jonathon Jongsma wrote: > > A few minor fixes to mdev support in the nodedev driver > > > > Changes in v2: > > - split out the error-reporting macro into a separate commit as > > recommended by Peter > > - Since

[libvirt PATCH v2] security: fix SELinux label generation logic

2021-06-30 Thread Daniel P . Berrangé
A process can access a file if the set of MCS categories for the file is equal-to *or* a subset-of, the set of MCS categories for the process. If there are two VMs: a) svirt_t:s0:c117 b) svirt_t:s0:c117,c720 Then VM (b) is able to access files labelled for VM (a). IOW, we must discard case

Re: [libvirt PATCH] security: fix SELinux label generation logic

2021-06-30 Thread Peter Krempa
On Wed, Jun 30, 2021 at 12:04:27 +0100, Daniel P. Berrangé wrote: > On Wed, Jun 30, 2021 at 12:50:29PM +0200, Peter Krempa wrote: > > On Wed, Jun 30, 2021 at 11:03:12 +0100, Daniel P. Berrangé wrote: > > > A process can access a file if the set of MCS categories > > > for the file is equal-to *or*

Re: [libvirt PATCH] security: fix SELinux label generation logic

2021-06-30 Thread Daniel P . Berrangé
On Wed, Jun 30, 2021 at 12:50:29PM +0200, Peter Krempa wrote: > On Wed, Jun 30, 2021 at 11:03:12 +0100, Daniel P. Berrangé wrote: > > A process can access a file if the set of MCS categories > > for the file is equal-to *or* a subset-of, the set of > > MCS categories for the process. > > > > If

Re: [libvirt PATCH] security: fix SELinux label generation logic

2021-06-30 Thread Peter Krempa
On Wed, Jun 30, 2021 at 11:03:12 +0100, Daniel P. Berrangé wrote: > A process can access a file if the set of MCS categories > for the file is equal-to *or* a subset-of, the set of > MCS categories for the process. > > If there are two VMs: > > a) svirt_t:s0:c117 > b) svirt_t:s0:c117,c720 >

Re: [PATCH] ui: Mark the '-no-quit' option as deprecated

2021-06-30 Thread Thomas Huth
On 30/06/2021 12.16, Thomas Huth wrote: On 30/06/2021 12.01, Peter Maydell wrote: On Wed, 30 Jun 2021 at 10:22, Thomas Huth wrote: It's just a cumbersome wrapper around the -display ...,window_close=off parameter, so we should rather tell our users to use that instead. This is an

Re: [PATCH] ui: Mark the '-no-quit' option as deprecated

2021-06-30 Thread Thomas Huth
On 30/06/2021 12.01, Peter Maydell wrote: On Wed, 30 Jun 2021 at 10:22, Thomas Huth wrote: It's just a cumbersome wrapper around the -display ...,window_close=off parameter, so we should rather tell our users to use that instead. This is an interesting definition of "cumbersome" --

Re: [PATCH] ui: Mark the '-no-quit' option as deprecated

2021-06-30 Thread Daniel P . Berrangé
On Wed, Jun 30, 2021 at 11:01:06AM +0100, Peter Maydell wrote: > On Wed, 30 Jun 2021 at 10:22, Thomas Huth wrote: > > > > It's just a cumbersome wrapper around the -display ...,window_close=off > > parameter, so we should rather tell our users to use that instead. > > This is an interesting

[libvirt PATCH] security: fix SELinux label generation logic

2021-06-30 Thread Daniel P . Berrangé
A process can access a file if the set of MCS categories for the file is equal-to *or* a subset-of, the set of MCS categories for the process. If there are two VMs: a) svirt_t:s0:c117 b) svirt_t:s0:c117,c720 Then VM (b) is able to access files labelled for VM (a). IOW, we must discard case

Re: [PATCH] ui: Mark the '-no-quit' option as deprecated

2021-06-30 Thread Peter Maydell
On Wed, 30 Jun 2021 at 10:22, Thomas Huth wrote: > > It's just a cumbersome wrapper around the -display ...,window_close=off > parameter, so we should rather tell our users to use that instead. This is an interesting definition of "cumbersome" -- personally I would say the long -display option

Re: [PATCH] ui: Mark the '-no-quit' option as deprecated

2021-06-30 Thread Daniel P . Berrangé
On Wed, Jun 30, 2021 at 11:21:27AM +0200, Thomas Huth wrote: > It's just a cumbersome wrapper around the -display ...,window_close=off > parameter, so we should rather tell our users to use that instead. > > Signed-off-by: Thomas Huth > --- > docs/system/deprecated.rst | 6 ++ >

[PATCH] ui: Mark the '-no-quit' option as deprecated

2021-06-30 Thread Thomas Huth
It's just a cumbersome wrapper around the -display ...,window_close=off parameter, so we should rather tell our users to use that instead. Signed-off-by: Thomas Huth --- docs/system/deprecated.rst | 6 ++ qemu-options.hx| 5 +++-- softmmu/vl.c | 2 ++ 3 files

Re: [libvirt PATCH v2 0/5] mdev tweaks

2021-06-30 Thread Michal Prívozník
On 6/22/21 9:53 PM, Jonathon Jongsma wrote: > A few minor fixes to mdev support in the nodedev driver > > Changes in v2: > - split out the error-reporting macro into a separate commit as recommended > by Peter > - Since virCommandRun() may report an error, ensure that the >

Re: [PATCH] docs: formatdomain: Document disk serial truncation status quo

2021-06-30 Thread Peter Krempa
On Tue, Jun 29, 2021 at 21:37:19 +0200, Tomáš Golembiovský wrote: > On Tue, Jun 29, 2021 at 03:33:26PM +0200, Peter Krempa wrote: > > On Mon, Jun 28, 2021 at 16:55:34 +0200, Tomáš Golembiovský wrote: [...] > > > If hypervisor start rejecting long serial numbers than this will become > > >

Re: [PATCH libvirt v1] conf: verify for duplicate hostdevs

2021-06-30 Thread Shalini Chellathurai Saroja
ping On 6/18/21 12:46 PM, Shalini Chellathurai Saroja wrote: It is possible to define/edit(in shut off state) a domain XML with same hostdev device repeated more than once, as shown below. This behavior is not expected. So, this patch fixes it. vser1: [...] [...]

Re: [libvirt PATCH 0/5] qemu: Fix defaults for TPM on ARM virt guests

2021-06-30 Thread Michal Prívozník
On 6/25/21 4:27 PM, Andrea Bolognani wrote: > The current default is unfortunately broken, and the user has to > manually step in and provide the version number explicitly for the > TPM device to work at all. > > https://bugzilla.redhat.com/show_bug.cgi?id=1970310 > > Andrea Bolognani (5): >