Re: [PATCHv2 3/4] qemu: interface: remove setting noqueue for ovs port

2021-07-02 Thread Michal Prívozník
On 7/1/21 10:42 AM, zhangjl02 wrote: > From: zhangjl02 > > Return 0 directly if the port is ovs managed. When the ovs port is set > noqueue, qos config on this port will not work. > --- > src/qemu/qemu_domain.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git

Re: [PATCHv2 4/4] qemu: interface: check and use ovs command to set qos of ovs managed port

2021-07-02 Thread Michal Prívozník
On 7/1/21 10:42 AM, zhangjl02 wrote: > From: zhangjl02 > > When qos is set or delete, we have to check if the port is an ovs managed > port. If true, call the virNetDevOpenvswitchInterfaceSetQos function when qos > is set, and call the virNetDevOpenvswitchInterfaceClearQos function when > the

Re: [PATCHv2 1/4] virDomain: interface: add virDomainNetDefIsOvsport

2021-07-02 Thread Michal Prívozník
On 7/1/21 10:42 AM, zhangjl02 wrote: > From: zhangjl02 > > Tell whether a port definition is an ovs managed virtual port > --- > src/conf/domain_conf.c | 8 > src/conf/domain_conf.h | 2 ++ > src/libvirt_private.syms | 1 + > 3 files changed, 11 insertions(+) > > diff --git

Re: [PATCHv2 2/4] virDomain: interface: add virNetDevOpenvswitchInterfaceSetQos and virNetDevOpenvswitchInterfaceClearQos

2021-07-02 Thread Michal Prívozník
On 7/1/21 10:42 AM, zhangjl02 wrote: > From: zhangjl02 > > Introduce qos setting and cleaning method. Use ovs command to set qos > parameters on specific interface of qemu virtual machine. > > When an ovs port is created, we add 'ifname' to external-ids. When setting > qos on an ovs port, query

Re: [PATCHv2 0/4] Add qemu support setting qos via ovs on ovs interface

2021-07-02 Thread Michal Prívozník
On 7/1/21 10:42 AM, zhangjl02 wrote: > --- > > diff to v1: > - move qemuDomainDefIsOvsport from src/qemu/qemu_domain.c to > src/conf/domain_conf.c You can also post a follow up patch that replaces check from the function with the function call :-) I mean, we have couple of places that do

Re: [libvirt PATCH 1/2] docs: point go imports to gitlab.com repos

2021-07-02 Thread Neal Gompa
On Fri, Jul 2, 2021 at 8:35 AM Andrea Bolognani wrote: > > On Fri, Jul 02, 2021 at 11:54:54AM +0100, Daniel P. Berrangé wrote: > > > > - https://libvirt.org/git/libvirt-go.git"/> > > + https://gitlab.com/libvirt/libvirt-go"/> > > > > > > -

Re: [PATCH v3 5/6] conf: add s390-pv as launch security type

2021-07-02 Thread Boris Fiuczynski
On 6/25/21 12:00 PM, Pavel Hrdina wrote: On Tue, Jun 22, 2021 at 03:10:48PM +0200, Boris Fiuczynski wrote: Add launch security type 's390-pv' as well as some tests. Signed-off-by: Boris Fiuczynski Reviewed-by: Daniel Henrique Barboza --- docs/schemas/domaincommon.rng | 1 +

Re: [libvirt PATCH 0/4] RFC: tests: introduce lavocado

2021-07-02 Thread Cleber Rosa
On Fri, Jul 2, 2021 at 7:48 AM Daniel P. Berrangé wrote: > > On Thu, Jul 01, 2021 at 06:09:47PM -0300, Beraldo Leal wrote: > > On Thu, Jul 01, 2021 at 07:04:32PM +0100, Daniel P. Berrangé wrote: > > > On Wed, Jun 30, 2021 at 01:36:30PM -0300, Beraldo Leal wrote: > > > > > > If I look at Avocado,

Re: [libvirt PATCH 0/4] RFC: tests: introduce lavocado

2021-07-02 Thread Cleber Rosa
On Fri, Jul 2, 2021 at 7:55 AM Daniel P. Berrangé wrote: > > On Fri, Jul 02, 2021 at 07:23:57AM -0400, Cleber Rosa wrote: > > Hi Daniel, > > > > On Thu, Jul 1, 2021 at 2:05 PM Daniel P. Berrangé > > wrote: > > > > > > On Wed, Jun 30, 2021 at 01:36:30PM -0300, Beraldo Leal wrote: > > > >

Re: [libvirt PATCH 0/4] RFC: tests: introduce lavocado

2021-07-02 Thread Cleber Rosa
On Fri, Jul 2, 2021 at 8:40 AM Cleber Rosa wrote: > > > There are a couple of ways. The simplest is hinting to Avocado that a > file is of kind "tap" with a hintfile. Suppose you have a > "test-suite" directory, and in it, you have "test.sh": > > #!/bin/sh -e > echo "1..2" > echo "ok 2

Re: [libvirt PATCH 2/2] docs: add go-import meta tags for new go modules

2021-07-02 Thread Andrea Bolognani
On Fri, Jul 02, 2021 at 11:54:55AM +0100, Daniel P. Berrangé wrote: > + > + https://gitlab.com/libvirt/libvirt-go-module"/> > + > + > + https://gitlab.com/libvirt/libvirt-go-xml-module"/> > + Double space before the git URL, plus of course the

Re: [libvirt PATCH 1/2] docs: point go imports to gitlab.com repos

2021-07-02 Thread Andrea Bolognani
On Fri, Jul 02, 2021 at 11:54:54AM +0100, Daniel P. Berrangé wrote: > > - https://libvirt.org/git/libvirt-go.git"/> > + https://gitlab.com/libvirt/libvirt-go"/> > > > - https://libvirt.org/git/libvirt-go-xml.git"/> > +

Re: [libvirt PATCH] docs: Add go-import directive for module-aware packages

2021-07-02 Thread Andrea Bolognani
On Fri, Jul 02, 2021 at 01:27:09PM +0100, Daniel P. Berrangé wrote: > On Fri, Jul 02, 2021 at 02:21:16PM +0200, Andrea Bolognani wrote: > > + > > + https://libvirt.org/git/libvirt-go-module.git"/> > > + > > + > > +

Re: [libvirt PATCH] docs: Add go-import directive for module-aware packages

2021-07-02 Thread Daniel P . Berrangé
On Fri, Jul 02, 2021 at 02:21:16PM +0200, Andrea Bolognani wrote: > This is how Go figures out the location of the git repository > containing the actual code for the package. > > Addresses the following error message: > > go: libvirt.org/go/libvirt@v1.7005.0: > unrecognized import path

[libvirt PATCH] docs: Add go-import directive for module-aware packages

2021-07-02 Thread Andrea Bolognani
This is how Go figures out the location of the git repository containing the actual code for the package. Addresses the following error message: go: libvirt.org/go/libvirt@v1.7005.0: unrecognized import path "libvirt.org/go/libvirt": parse https://libvirt.org/go/libvirt?go-get=1:

[PATCH 1/2] qemu: migration: Use correct flag constant for enabling storage migration

2021-07-02 Thread Peter Krempa
The 'storageMigration' flag is supposed to be true if storage migration is requested, which is based on VIR_MIGRATE_NON_SHARED_DISK or VIR_MIGRATE_NON_SHARED_INC flags. The assignment to the variable used QEMU_MONITOR_MIGRATE_NON_SHARED_INC (0x04) instead of VIR_MIGRATE_NON_SHARED_INC (0x80),

[PATCH 2/2] NEWS: Mention implications of the bug in migration code

2021-07-02 Thread Peter Krempa
Wrong flag use could have user-visible implications. Mention the fix. Signed-off-by: Peter Krempa --- NEWS.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 2536955a4a..2a97b5ece4 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -17,6 +17,13 @@ v7.6.0 (unreleased)

[PATCH 0/2] qemu: fix migration with non-shared storage (incremental)

2021-07-02 Thread Peter Krempa
See patch 1/2. Peter Krempa (2): qemu: migration: Use correct flag constant for enabling storage migration NEWS: Mention implications of the bug in migration code NEWS.rst | 7 +++ src/qemu/qemu_migration.c | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) --

Re: [libvirt PATCH 0/4] RFC: tests: introduce lavocado

2021-07-02 Thread Beraldo Leal
On Fri, Jul 02, 2021 at 12:43:57PM +0100, Daniel P. Berrangé wrote: > On Thu, Jul 01, 2021 at 06:09:47PM -0300, Beraldo Leal wrote: > > On Thu, Jul 01, 2021 at 07:04:32PM +0100, Daniel P. Berrangé wrote: > > > On Wed, Jun 30, 2021 at 01:36:30PM -0300, Beraldo Leal wrote: > > > > > > If I look at

Re: [libvirt PATCH 0/4] RFC: tests: introduce lavocado

2021-07-02 Thread Daniel P . Berrangé
On Fri, Jul 02, 2021 at 07:23:57AM -0400, Cleber Rosa wrote: > Hi Daniel, > > On Thu, Jul 1, 2021 at 2:05 PM Daniel P. Berrangé wrote: > > > > On Wed, Jun 30, 2021 at 01:36:30PM -0300, Beraldo Leal wrote: > > > lavocado aims to be an alternative test framework for the libvirt > > > project using

Re: [libvirt PATCH 0/4] RFC: tests: introduce lavocado

2021-07-02 Thread Daniel P . Berrangé
On Thu, Jul 01, 2021 at 06:09:47PM -0300, Beraldo Leal wrote: > On Thu, Jul 01, 2021 at 07:04:32PM +0100, Daniel P. Berrangé wrote: > > On Wed, Jun 30, 2021 at 01:36:30PM -0300, Beraldo Leal wrote: > > > > If I look at Avocado, I think (correct me if i'm wrong) > > > > 1. The harness is

Re: [libvirt PATCH 0/4] RFC: tests: introduce lavocado

2021-07-02 Thread Daniel P . Berrangé
On Fri, Jul 02, 2021 at 07:23:57AM -0400, Cleber Rosa wrote: > On Thu, Jul 1, 2021 at 2:05 PM Daniel P. Berrangé wrote: > > > > Overall, I'm more enthusiastic about writing tests in Python > > than Perl, for the long term, but would also potentially like > > to write tests in Go too. > > > > I'm

Re: [libvirt PATCH 0/4] RFC: tests: introduce lavocado

2021-07-02 Thread Cleber Rosa
Hi Daniel, On Thu, Jul 1, 2021 at 2:05 PM Daniel P. Berrangé wrote: > > On Wed, Jun 30, 2021 at 01:36:30PM -0300, Beraldo Leal wrote: > > lavocado aims to be an alternative test framework for the libvirt > > project using Python, python-libvirt and Avocado. This can be used to > > write unit,

Re: [PATCH] domstats:add haltpolling time statistic interface

2021-07-02 Thread Yang Fei
On 2021/7/2 15:45, Peter Krempa wrote: > On Fri, Jul 02, 2021 at 12:53:29 +0800, Yang Fei wrote: >> This patch add the ability to statistic the halt polling time when >> VM execute HLT(arm is WFI). >> >> In actual services, the execution of the HLT instruction by the >> guest is an important

[libvirt PATCH 1/2] docs: point go imports to gitlab.com repos

2021-07-02 Thread Daniel P . Berrangé
The gitlab.com repos are the primary source, with libvirt.org just a read-only mirror. Signed-off-by: Daniel P. Berrangé --- docs/page.xsl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/page.xsl b/docs/page.xsl index 5cb4322fdc..8c63454902 100644 ---

[libvirt PATCH 2/2] docs: add go-import meta tags for new go modules

2021-07-02 Thread Daniel P . Berrangé
Signed-off-by: Daniel P. Berrangé --- docs/page.xsl | 6 ++ 1 file changed, 6 insertions(+) diff --git a/docs/page.xsl b/docs/page.xsl index 8c63454902..2a25115171 100644 --- a/docs/page.xsl +++ b/docs/page.xsl @@ -105,6 +105,12 @@

[libvirt PATCH 0/2] docs: fix imports of new go modules

2021-07-02 Thread Daniel P . Berrangé
Daniel P. Berrangé (2): docs: point go imports to gitlab.com repos docs: add go-import meta tags for new go modules docs/page.xsl | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) -- 2.31.1

Re: [PATCH 0/3] Threshold event improvements

2021-07-02 Thread Michal Prívozník
On 7/1/21 4:03 PM, Peter Krempa wrote: > Peter Krempa (3): > storage_source: Add flag storing whether threshold event was > registered with index > qemu: Prevent two threshold events when it was registered with index > virDomainSetBlockThreshold: Document that two events are fired when >

[PATCH] virresctrl: Fix updating the mask for a cache resource

2021-07-02 Thread Vinayak Kale
In 'virResctrlAllocUpdateMask', mask is updated only if 'previous mask' is NULL. By default, the bitmask for a cache resource for a VM is initialized with 'default-resctrl-group' bitmask. So the 'previous mask' would not be NULL and mask won't get updated if cachetune is configured for a VM. This

Re: [PATCH libvirt v1] conf: verify for duplicate hostdevs

2021-07-02 Thread Shalini Chellathurai Saroja
On 7/1/21 4:40 PM, Michal Prívozník wrote: So let's do the following, I'll merge it tomorrow, after the release so that we give users the longest window possible to complain. Reviewed-by: Michal Privoznik ok, thank you Michal. Pushed now. Michal Thank you Michal. -- Kind regards Shalini

Re: [PATCH] domstats:add haltpolling time statistic interface

2021-07-02 Thread Peter Krempa
On Fri, Jul 02, 2021 at 12:53:29 +0800, Yang Fei wrote: > This patch add the ability to statistic the halt polling time when > VM execute HLT(arm is WFI). > > In actual services, the execution of the HLT instruction by the > guest is an important cause of virtualization overhead. The halt >