Re: [PATCH] qemu: save status xml after generating taint message

On Wed, Jul 21, 2021 at 10:54 PM Michal Prívozník wrote: > > > The bug quoted shows a few examples where we fail to save status. > > > > I'm very surprised we don't save status when hotplugging a NIC or a > > disk, as the BZ suggests. > > I'm not convinced that the steps there are 100% correct.

Re: [libvirt PATCH] nodedev: Handle inactive mdevs with the same UUID

On Thu, Jul 8, 2021 at 4:28 PM Jonathon Jongsma wrote: > > On Thu, Jul 8, 2021 at 3:47 PM Boris Fiuczynski wrote: > > > > On 7/6/21 9:05 PM, Jonathon Jongsma wrote: > > > Unfortunately, mdevctl supports defining more than one mdev with the > > > same UUID as long as they have different parent

Re: [libvirt PATCH 0/4] RFC: tests: introduce lavocado

On Thu, Jul 22, 2021 at 09:44:28AM +0100, Daniel P. Berrangé wrote: > On Wed, Jul 21, 2021 at 04:22:19PM -0300, Beraldo Leal wrote: > > On Wed, Jul 21, 2021 at 06:50:03PM +0100, Daniel P. Berrangé wrote: > > > On Thu, Jul 01, 2021 at 06:09:47PM -0300, Beraldo Leal wrote: > > > > On Thu, Jul 01,

Re: [libvirt PATCH 0/4] RFC: tests: introduce lavocado

Daniel P. Berrangé writes: > On Tue, Jul 20, 2021 at 02:19:25PM +0200, Erik Skultety wrote: >> On Thu, Jul 01, 2021 at 07:04:32PM +0100, Daniel P. Berrangé wrote: >> > Libvirt has consumers writing applications in a variety of >> > languages, and periodically reporting bugs. My general wish >>

Re: set custom loglevel for external libraries

Am Thu, 22 Jul 2021 17:17:11 +0200 schrieb Olaf Hering : > xc_private.h uses XTL_INFO, XTL_DETAIL, XTL_DEBUG and XTL_ERROR in the > wrappers. I wonder if the code should map VIR_LOG_INFO to XTL_DETAIL to enable DPRINTF. Olaf pgp3lN57hElrs.pgp Description: Digitale Signatur von OpenPGP

Re: [libvirt PATCH] ci: Adapt to lcitool command line changes

On Thu, Jul 22, 2021 at 04:01:13PM +0200, Andrea Bolognani wrote: > lcitool now uses the term "target" instead of "host" to refer to > the various operating systems it supports, and we need to adapt > our helper script so that it works with the new command line > interface. > > Signed-off-by:

Re: [PATCH v3] nodedev: fix internal error when no defined mdevs exist

On Wed, 21 Jul 2021 13:30:00 +0200 Boris Fiuczynski wrote: > Commit e9b534905f4 introduced an error when parsing an empty list > returned from mdevctl. > > This occurs e.g. if nodedev-undefine is used to undefine the last > defined mdev which causes the following error messages > >

[PATCH 2/2] virSetUIDGIDWithCaps: Set bounding capabilities only with CAP_SETPCAP

In one of my previous patches I've tried to postpone dropping CAP_SETPCAP until the very end because it's needed for capng_apply(). What I did not realize back then was that we might not have the capability to begin with. Because of unknown reasons capng_apply() pollutes logs only for

[PATCH 0/2] Another round of capng_apply() fixes

See 2/2 for explanation. Michal Prívozník (2): virSetUIDGIDWithCaps: Check for capng_apply() retval properly virSetUIDGIDWithCaps: Set bounding capabilities only with CAP_SETPCAP src/util/virutil.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- 2.31.1

[PATCH 1/2] virSetUIDGIDWithCaps: Check for capng_apply() retval properly

After all capabilities were set (except for CAP_SETGID, CAP_SETUID and CAP_SETPCAP) and after UID:GID was changed we drop the last aforementioned capabilities (we couldn't drop them before because we needed UID:GID and capabilities change). Therefore, there's final capng_apply() call. However,

Re: set custom loglevel for external libraries

Am Thu, 22 Jul 2021 16:07:15 +0100 schrieb Daniel P. Berrangé : > Do we actually need to care about every single level, as opposed to > just doing a sparse mapping where we squash several xen levels into > one libvirt level, as the code below shows ? xc_private.h uses XTL_INFO, XTL_DETAIL,

Re: set custom loglevel for external libraries

On Thu, Jul 22, 2021 at 04:39:24PM +0200, Olaf Hering wrote: > Thanks for your reply, I had no time to look at this until now. > > Am Wed, 16 Jun 2021 11:44:10 +0100 > schrieb Daniel P. Berrangé : > > > Anyway if you used a virLogSource object, then turning on debugging > > exclusively for libxl

Re: [PULL 36/40] vl: switch -M parsing to keyval

On Thu, Jul 22, 2021 at 16:39:26 +0200, Paolo Bonzini wrote: > On 22/07/21 10:19, Peter Krempa wrote: > > This patch breaks detection of certain machine options features in > > libvirt which were being detected from 'query-command-line-options'. > > > > I presume the change simply removed this

Re: set custom loglevel for external libraries

Thanks for your reply, I had no time to look at this until now. Am Wed, 16 Jun 2021 11:44:10 +0100 schrieb Daniel P. Berrangé : > Anyway if you used a virLogSource object, then turning on debugging > exclusively for libxl library messages would be as simple as > >

Re: [PULL 36/40] vl: switch -M parsing to keyval

On 22/07/21 10:19, Peter Krempa wrote: This patch breaks detection of certain machine options features in libvirt which were being detected from 'query-command-line-options'. I presume the change simply removed this from the output of query-command-line-options due to the historical cruft how

Re: [PULL 37/48] usb: build usb-host as module

adding libvirt-list On Thu, Jul 08, 2021 at 17:17:37 +0200, Paolo Bonzini wrote: > From: Gerd Hoffmann > > Drop one more shared library dependency (libusb) from core qemu. > > Signed-off-by: Gerd Hoffmann > Reviewed-by: Jose R. Ziviani > Message-Id:

[libvirt PATCH] ci: Adapt to lcitool command line changes

lcitool now uses the term "target" instead of "host" to refer to the various operating systems it supports, and we need to adapt our helper script so that it works with the new command line interface. Signed-off-by: Andrea Bolognani --- Getting this ready for when

Re: [PATCH] qemuxml2argvmock: Deduplicate some code

On a %A in %Y, Michal Privoznik wrote: > A stub implementation for virQEMUCapsGetKVMSupportsSecureGuest() > was added recently. However, the very same implementation was > added to domaincapsmock.c which is also loaded by > qemuxml2argvtest and thus one occurrence of the stub can be > dropped. >

Re: [libvirt PATCH] qemuxml2argvmock: drop virQEMUCapsGetKVMSupportsSecureGuest

On 7/22/21 3:17 PM, Pavel Hrdina wrote: > It is actually not needed because in qemuxml2argvtest we preload > domaincapsmock as well. > > Reported-by: Michal Privoznik > Signed-off-by: Pavel Hrdina > --- > tests/qemuxml2argvmock.c | 16 > 1 file changed, 16 deletions(-) >

[PATCH] qemuxml2argvmock: Deduplicate some code

A stub implementation for virQEMUCapsGetKVMSupportsSecureGuest() was added recently. However, the very same implementation was added to domaincapsmock.c which is also loaded by qemuxml2argvtest and thus one occurrence of the stub can be dropped. Signed-off-by: Michal Privoznik ---

[PATCH v2 2/3] remove sysconfig files

sysconfig files are owned by the admin of the host. They have the liberty to put anything they want into these files. This makes it difficult to provide different built-in defaults. Remove the sysconfig file and place the current desired default into the service file. Local customizations can

[PATCH v2 3/3] NEWS: mention removal of sysconfig

Signed-off-by: Olaf Hering --- NEWS.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index d95750e776..3e5b790e03 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -15,6 +15,16 @@ v7.6.0 (unreleased) * **Improvements** + * packaging: sysconfig files no longer

[PATCH v2 1/3] libvirt.spec: relocate pre script of daemon-driver-qemu

Reduce the delta in an upcoming change. No change in behavior intended. Signed-off-by: Olaf Hering --- libvirt.spec.in | 32 +++- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index cb48dd0be0..85e79883c5 100644 ---

[PATCH v2 0/3] remove sysconfig files

based on 94944e38d7. Olaf Hering (3): libvirt.spec: relocate pre script of daemon-driver-qemu remove sysconfig files NEWS: mention removal of sysconfig NEWS.rst| 10 +++ docs/daemons.rst| 20 + docs/remote.html.in

[libvirt PATCH] qemuxml2argvmock: drop virQEMUCapsGetKVMSupportsSecureGuest

It is actually not needed because in qemuxml2argvtest we preload domaincapsmock as well. Reported-by: Michal Privoznik Signed-off-by: Pavel Hrdina --- tests/qemuxml2argvmock.c | 16 1 file changed, 16 deletions(-) diff --git a/tests/qemuxml2argvmock.c

Re: [libvirt PATCH] tests: fix compiling tests with minGW

On Thu, Jul 22, 2021 at 02:54:57PM +0200, Michal Prívozník wrote: > On 7/22/21 12:24 PM, Pavel Hrdina wrote: > > We need to mock virQEMUCapsGetKVMSupportsSecureGuest only if compiling > > with QEMU otherwise compilation will fail with error: > > > >

Re: [libvirt PATCH] tests: fix compiling tests with minGW

On 7/22/21 12:24 PM, Pavel Hrdina wrote: > We need to mock virQEMUCapsGetKVMSupportsSecureGuest only if compiling > with QEMU otherwise compilation will fail with error: > > /usr/lib/gcc/i686-w64-mingw32/11.1.1/../../../../i686-w64-mingw32/bin/ld: >

Re: [libvirt PATCH 07/10] virNWFilterParseParamAttributes: Remove superfluous `goto`s

On a %A in %Y, Tim Wiederhake wrote: > Signed-off-by: Tim Wiederhake > --- > src/conf/nwfilter_params.c | 11 --- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/src/conf/nwfilter_params.c b/src/conf/nwfilter_params.c > index 63ab7e7150..35ea0256c3 100644 > ---

Re: [libvirt PATCH 00/10] virHashNew refactorings - part V

On a %A in %Y, Tim Wiederhake wrote: > "virHashNew" cannot return NULL, yet we check for NULL in various places. > > See https://listman.redhat.com/archives/libvir-list/2021-July/msg00074.html. > > Tim Wiederhake (10): > conf: Add AUTOPTR_CLEANUP_FUNC for virNWFilterVarValue >

Re: [PATCH v1] remove sysconfig files

Am Wed, 21 Jul 2021 12:36:40 +0100 schrieb Daniel P. Berrangé : > If we remove the sysconfig files, we're not expecting users to > modify the .service files. Instead they will be using the systemd > overrides in /etc/systemd/system/libvirtd.service.d/ to > customize. It seems docs/daemons.rst

Re: [PATCH v1] remove sysconfig files

Am Wed, 21 Jul 2021 06:00:12 -0700 schrieb Andrea Bolognani : > On Wed, Jul 21, 2021 at 01:23:56PM +0200, Olaf Hering wrote: > > There is no point in restarting libvirtd in the middle of the transaction. > > The spec file gives no ordering hints to rpm. > Note that the daemon restart always

Re: [PATCH] storage_driver: Unlock object on ACL fail in storagePoolLookupByTargetPath

On 7/21/21 11:27 AM, Peter Krempa wrote: > 'virStoragePoolObjListSearch' returns a locked and refed object, thus we > must release it on ACL permission failure. > > Fixes: 7aa0e8c0cb8 > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1984318 > Signed-off-by: Peter Krempa > --- >

[libvirt PATCH] tests: fix compiling tests with minGW

We need to mock virQEMUCapsGetKVMSupportsSecureGuest only if compiling with QEMU otherwise compilation will fail with error: /usr/lib/gcc/i686-w64-mingw32/11.1.1/../../../../i686-w64-mingw32/bin/ld: tests/libdomaincapsmock.dll.p/domaincapsmock.c.obj: in function

[PATCH] storage: create logical volume with --yes option

If lvcreate found an existing signature when trying to create a new logical volume (E.g. left after some deleted volume), the action failed due to inability to answer interactive question to wiping it (lvcreate assumed 'no' was the answer). With added option --yes to the command line, the answer

Re: [PATCH] storage_driver: Unlock object on ACL fail in storagePoolLookupByTargetPath

Hi Peter, I'm going to allocate a new (low impact) CVE for this bug. Thanks. On Wed, Jul 21, 2021 at 11:34 AM Peter Krempa wrote: > > Adding libvirt-security since I forgot when sending the patch. > > On Wed, Jul 21, 2021 at 11:27:41 +0200, Peter Krempa wrote: > > 'virStoragePoolObjListSearch'

Re: [PATCH] conf: remove unnecessary restore in virDomainSEVDefParseXML

On Thu, Jul 22, 2021 at 11:07:42AM +0200, Boris Fiuczynski wrote: > Since commit d399a728f4 placed the restore in the right scope the > restore can get removed in virDomainSEVDefParseXML. > > Signed-off-by: Boris Fiuczynski > --- > src/conf/domain_conf.c | 1 - > 1 file changed, 1 deletion(-)

[PATCH] conf: remove unnecessary restore in virDomainSEVDefParseXML

Since commit d399a728f4 placed the restore in the right scope the restore can get removed in virDomainSEVDefParseXML. Signed-off-by: Boris Fiuczynski --- src/conf/domain_conf.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index

Re: [libvirt PATCH v2 2/2] ci: Halt on sanitizer errors

On Thu, Jul 22, 2021 at 11:00:18AM +0200, Tim Wiederhake wrote: > The undefined behaviour sanitizer (UBSAN) defaults to merely printing an > error message if it detects undefined behaviour. These error messages often > end up in captured output and do not fail the tests, effectively hiding > the

Re: [libvirt PATCH v2 1/2] virFileReadLimFD: Cast maxlen to size_t before adding

On Thu, Jul 22, 2021 at 11:00:17AM +0200, Tim Wiederhake wrote: > If the function is called with maxlen equal to `INT_MAX`, adding > one will trigger a signed integer overflow. > > Signed-off-by: Tim Wiederhake > --- > src/util/virfile.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

[libvirt PATCH v2 2/2] ci: Halt on sanitizer errors

The undefined behaviour sanitizer (UBSAN) defaults to merely printing an error message if it detects undefined behaviour. These error messages often end up in captured output and do not fail the tests, effectively hiding the warning. Make the test cases fail to make the issues visible.

[libvirt PATCH v2 0/2] Fail tests on UBSAN findings

V1: https://listman.redhat.com/archives/libvir-list/2021-July/msg00592.html Changes since V1: Simplified series by using the approach mentioned in https://listman.redhat.com/archives/libvir-list/2021-June/msg00358.html Tim Wiederhake (2): virFileReadLimFD: Cast maxlen to size_t before adding

[libvirt PATCH v2 1/2] virFileReadLimFD: Cast maxlen to size_t before adding

If the function is called with maxlen equal to `INT_MAX`, adding one will trigger a signed integer overflow. Signed-off-by: Tim Wiederhake --- src/util/virfile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virfile.c b/src/util/virfile.c index

Re: [libvirt PATCH 0/4] RFC: tests: introduce lavocado

On Wed, Jul 21, 2021 at 04:22:19PM -0300, Beraldo Leal wrote: > On Wed, Jul 21, 2021 at 06:50:03PM +0100, Daniel P. Berrangé wrote: > > On Thu, Jul 01, 2021 at 06:09:47PM -0300, Beraldo Leal wrote: > > > On Thu, Jul 01, 2021 at 07:04:32PM +0100, Daniel P. Berrangé wrote: > > > > On Wed, Jun 30,

Re: [libvirt PATCH 0/4] RFC: tests: introduce lavocado

On Wed, Jul 21, 2021 at 06:01:34PM -0400, Cleber Rosa wrote: > > Daniel P. Berrangé writes: > > > On Thu, Jul 01, 2021 at 06:09:47PM -0300, Beraldo Leal wrote: > >> > >> This is supported already: > >> > >> $ avocado run --tap - --test-runner='nrunner' tests/domain/transient.py > >> 1..3 > >>

Re: [PULL 36/40] vl: switch -M parsing to keyval

CC libvir-list On Tue, Jul 06, 2021 at 12:01:37 +0200, Paolo Bonzini wrote: > Switch from QemuOpts to keyval. This enables the introduction > of non-scalar machine properties, and JSON syntax in the future. > > For JSON syntax to be supported right now, we would have to > consider what would

Re: [libvirt PATCH 4/4] ci: Halt on sanitizer errors

On Wed, 2021-07-21 at 06:56 -0700, Andrea Bolognani wrote: > On Wed, Jul 21, 2021 at 03:08:02PM +0200, Peter Krempa wrote: > > On Wed, Jul 21, 2021 at 14:46:43 +0200, Tim Wiederhake wrote: > > > +++ b/.gitlab-ci.yml > > > @@ -89,6 +89,8 @@ stages: > > > - meson build --werror -Ddocs=disabled

[PATCH v4 2/3] util: Add virHostCPUGetHaltPollTime

Add helper function virHostCPUGetHaltPollTime to obtain halt polling time. If the kernel support halt polling time statistic, and mount debugfs. This function will take effect on KVM VMs. Signed-off-by: Yang Fei --- src/libvirt_private.syms | 1 + src/util/virhostcpu.c| 39

[PATCH v4 0/3] domstats:add haltpolling time statistic interface

This series add the ability to statistic the halt polling time when VM execute HLT(arm is WFI). v1: https://listman.redhat.com/archives/libvir-list/2021-July/msg00029.html v2: https://listman.redhat.com/archives/libvir-list/2021-July/msg00339.html v3:

[PATCH v4 3/3] qemu: Introduce qemuDomainGetStatsCpuHaltPollTime

This function add halt polling time interface in domstats. So that we can use command 'virsh domstats VM' to get the data if system support. Signed-off-by: Yang Fei --- docs/manpages/virsh.rst | 4 src/libvirt-domain.c| 7 +++ src/qemu/qemu_driver.c | 20 3

[PATCH v4 1/3] util: Add virFileReadValueUllongQuiet

Use function virFileReadValueUllongQuiet to read unsigned long long value without error report. Signed-off-by: Yang Fei --- src/libvirt_private.syms | 1 + src/util/virfile.c | 24 src/util/virfile.h | 2 ++ 3 files changed, 27 insertions(+) diff --git

RE: [RFC PATCH v2 0/8] LIBVIRT: X86: TDX support

> -Original Message- > From: Pavel Hrdina > Sent: Wednesday, July 21, 2021 10:23 PM > To: Duan, Zhenzhong > Cc: libvir-list@redhat.com; pkre...@redhat.com; berra...@redhat.com; > Yamahata, Isaku ; Tian, Jun J > ; Qiang, Chenyi > Subject: Re: [RFC PATCH v2 0/8] LIBVIRT: X86: TDX

Re: [PATCH] conf: Restore ctxt's node in right scope

On Thu, Jul 22, 2021 at 03:44:18PM +0800, Zhenzhong Duan wrote: > We just found is ignored in our xml. Further debug > shows that ctxt's node pointer isn't restored in virDomainSecDefParseXML(), > which leads to parsing of remaining elements failed. > > Signed-off-by: Zhenzhong Duan > --- >

[libvirt PATCH 11/38] libxlLoggerNew: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/libxl/libxl_logger.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/libxl/libxl_logger.c b/src/libxl/libxl_logger.c index 0807383d39..f7b5c8ee16 100644 --- a/src/libxl/libxl_logger.c +++ b/src/libxl/libxl_logger.c @@ -149,9 +149,7

[libvirt PATCH 28/38] virLockSpaceNew: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/util/virlockspace.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/util/virlockspace.c b/src/util/virlockspace.c index 9986d8df41..edf2ec907f 100644 --- a/src/util/virlockspace.c +++ b/src/util/virlockspace.c @@ -247,8 +247,7 @@

[libvirt PATCH 30/38] virNetDaemonNew: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/rpc/virnetdaemon.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/rpc/virnetdaemon.c b/src/rpc/virnetdaemon.c index 1a17753f42..b6f3233f64 100644 --- a/src/rpc/virnetdaemon.c +++ b/src/rpc/virnetdaemon.c @@ -141,8 +141,7 @@

[libvirt PATCH 36/38] virSecuritySELinuxQEMUInitialize: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/security/security_selinux.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c index 0bff9b7bae..5f98d4d47a 100644 --- a/src/security/security_selinux.c +++

[libvirt PATCH 32/38] virNetworkObjNew: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/conf/virnetworkobj.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/conf/virnetworkobj.c b/src/conf/virnetworkobj.c index 66f916c749..ea021892c7 100644 --- a/src/conf/virnetworkobj.c +++ b/src/conf/virnetworkobj.c @@ -118,8 +118,7

[libvirt PATCH 09/38] hypervCreateEmbeddedParam: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/hyperv/hyperv_wmi.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/hyperv/hyperv_wmi.c b/src/hyperv/hyperv_wmi.c index b113283aeb..dc2c6471ab 100644 --- a/src/hyperv/hyperv_wmi.c +++ b/src/hyperv/hyperv_wmi.c @@ -275,7 +275,7 @@

[libvirt PATCH 37/38] virStoragePoolObjListNew: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/conf/virstorageobj.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/conf/virstorageobj.c b/src/conf/virstorageobj.c index 24957d6012..6c8a06e8bc 100644 --- a/src/conf/virstorageobj.c +++ b/src/conf/virstorageobj.c @@ -401,12

[libvirt PATCH 38/38] virStorageVolObjListNew: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/conf/virstorageobj.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/conf/virstorageobj.c b/src/conf/virstorageobj.c index 6c8a06e8bc..2b6932d7e5 100644 --- a/src/conf/virstorageobj.c +++ b/src/conf/virstorageobj.c @@ -170,12

[libvirt PATCH 35/38] virSecuritySELinuxLXCInitialize: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/security/security_selinux.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c index 0c2cf1d1c7..0bff9b7bae 100644 --- a/src/security/security_selinux.c +++

[libvirt PATCH 34/38] virQEMUCapsProbeQMPHostCPU: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_capabilities.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 6cea8c2eca..3804687080 100644 --- a/src/qemu/qemu_capabilities.c +++

[libvirt PATCH 33/38] virNodeDeviceObjListNew: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/conf/virnodedeviceobj.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/conf/virnodedeviceobj.c b/src/conf/virnodedeviceobj.c index b213592b56..e8f6792138 100644 --- a/src/conf/virnodedeviceobj.c +++ b/src/conf/virnodedeviceobj.c

[libvirt PATCH 29/38] virLockSpaceNewPostExecRestart: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/util/virlockspace.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/util/virlockspace.c b/src/util/virlockspace.c index edf2ec907f..0c4beaf9fe 100644 --- a/src/util/virlockspace.c +++ b/src/util/virlockspace.c @@ -293,8 +293,7 @@

[libvirt PATCH 31/38] virNetworkObjListNew: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/conf/virnetworkobj.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/conf/virnetworkobj.c b/src/conf/virnetworkobj.c index 341d6b4292..66f916c749 100644 --- a/src/conf/virnetworkobj.c +++ b/src/conf/virnetworkobj.c @@ -350,10

[libvirt PATCH 27/38] virLockDaemonNewPostExecRestart: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/locking/lock_daemon.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/locking/lock_daemon.c b/src/locking/lock_daemon.c index f5e5375e80..fa08acbc76 100644 --- a/src/locking/lock_daemon.c +++ b/src/locking/lock_daemon.c @@ -211,8

[libvirt PATCH 26/38] virLockDaemonNew: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/locking/lock_daemon.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/locking/lock_daemon.c b/src/locking/lock_daemon.c index 05fc68dc54..f5e5375e80 100644 --- a/src/locking/lock_daemon.c +++ b/src/locking/lock_daemon.c @@ -153,8

[libvirt PATCH 24/38] virHashAtomicNew: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/util/virhash.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/util/virhash.c b/src/util/virhash.c index d2b591c0b7..a9996c9fc0 100644 --- a/src/util/virhash.c +++ b/src/util/virhash.c @@ -102,10 +102,7 @@

[libvirt PATCH 25/38] virInterfaceObjListNew: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/conf/virinterfaceobj.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/conf/virinterfaceobj.c b/src/conf/virinterfaceobj.c index c8fda4990f..a73208f1fc 100644 --- a/src/conf/virinterfaceobj.c +++ b/src/conf/virinterfaceobj.c @@

[libvirt PATCH 23/38] virFileCacheNew: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/util/virfilecache.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/util/virfilecache.c b/src/util/virfilecache.c index 2f55deefb6..64348dc1e6 100644 --- a/src/util/virfilecache.c +++ b/src/util/virfilecache.c @@ -242,8 +242,7

[libvirt PATCH 21/38] virDomainMomentObjListNew: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/conf/virdomainmomentobjlist.c | 4 1 file changed, 4 deletions(-) diff --git a/src/conf/virdomainmomentobjlist.c b/src/conf/virdomainmomentobjlist.c index c0896685a9..17b9c16ae7 100644 --- a/src/conf/virdomainmomentobjlist.c +++

[libvirt PATCH 22/38] virDomainObjListNew: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/conf/virdomainobjlist.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/conf/virdomainobjlist.c b/src/conf/virdomainobjlist.c index 5f9fd9aabc..43d09692a9 100644 --- a/src/conf/virdomainobjlist.c +++

[libvirt PATCH 20/38] virDomainDefValidateAliases: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/conf/domain_validate.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index df2ab47361..aab377fbbd 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c @@

[libvirt PATCH 19/38] virDomainDefBootOrderPostParse: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/conf/domain_conf.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index e05ea9ba88..6937863db7 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -5924,10 +5924,7 @@

[libvirt PATCH 18/38] virDomainCCWAddressSetCreate: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/conf/domain_addr.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/conf/domain_addr.c b/src/conf/domain_addr.c index f011721beb..53b39923e8 100644 --- a/src/conf/domain_addr.c +++ b/src/conf/domain_addr.c @@ -1388,8 +1388,7 @@

[libvirt PATCH 17/38] virCloseCallbacksNew: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/hypervisor/virclosecallbacks.c | 4 1 file changed, 4 deletions(-) diff --git a/src/hypervisor/virclosecallbacks.c b/src/hypervisor/virclosecallbacks.c index b9d4940b60..2578a71f03 100644 --- a/src/hypervisor/virclosecallbacks.c +++

[libvirt PATCH 16/38] virChrdevAlloc: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/conf/virchrdev.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/conf/virchrdev.c b/src/conf/virchrdev.c index 91f2b5a233..5d6de68427 100644 --- a/src/conf/virchrdev.c +++ b/src/conf/virchrdev.c @@ -265,13 +265,9 @@ virChrdevs

[libvirt PATCH 14/38] qemuDomainObjPrivateAlloc: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_domain.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index ac1d8ef151..b919da6eab 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -1788,8 +1788,7 @@

[libvirt PATCH 15/38] qemuInteropFetchConfigs: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_interop_config.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/qemu/qemu_interop_config.c b/src/qemu/qemu_interop_config.c index ea2afcc070..848e8f7381 100644 --- a/src/qemu/qemu_interop_config.c +++

[libvirt PATCH 13/38] qemuBlockNodeNameGetBackingChain: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_block.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c index 2815eb54fa..8150241015 100644 --- a/src/qemu/qemu_block.c +++ b/src/qemu/qemu_block.c @@ -231,22 +231,16 @@

[libvirt PATCH 10/38] qemusecuritymock: init_hash: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- tests/qemusecuritymock.c | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/tests/qemusecuritymock.c b/tests/qemusecuritymock.c index 5daf27ccd7..87aadf564e 100644 --- a/tests/qemusecuritymock.c +++ b/tests/qemusecuritymock.c

[libvirt PATCH 12/38] qemuBlockNodeNamesDetect: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/qemu/qemu_block.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c index 6627d044cd..2815eb54fa 100644 --- a/src/qemu/qemu_block.c +++ b/src/qemu/qemu_block.c @@ -365,10 +365,7 @@

[libvirt PATCH 06/38] virNWFilterCreateVarsFrom: Remove superfluous `goto`s

Signed-off-by: Tim Wiederhake --- src/nwfilter/nwfilter_gentech_driver.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/nwfilter/nwfilter_gentech_driver.c b/src/nwfilter/nwfilter_gentech_driver.c index d17be401e6..a425285e8c 100644 ---

[libvirt PATCH 07/38] virNWFilterRuleDefToRuleInst: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/nwfilter/nwfilter_gentech_driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/nwfilter/nwfilter_gentech_driver.c b/src/nwfilter/nwfilter_gentech_driver.c index a425285e8c..f98af5d513 100644 ---

[libvirt PATCH 08/38] ebiptablesApplyNewRules: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/nwfilter/nwfilter_ebiptables_driver.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/nwfilter/nwfilter_ebiptables_driver.c b/src/nwfilter/nwfilter_ebiptables_driver.c index 345562bab6..ec17d43c4e 100644 ---

[libvirt PATCH 02/38] virSystemdActivationNew: Use automatic memory management

Signed-off-by: Tim Wiederhake --- src/util/virsystemd.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/util/virsystemd.c b/src/util/virsystemd.c index 6417dc6ea7..f90c17e767 100644 --- a/src/util/virsystemd.c +++ b/src/util/virsystemd.c @@ -958,11 +958,10 @@

[libvirt PATCH 05/38] virNWFilterCreateVarsFrom: Use automatic memory management

Signed-off-by: Tim Wiederhake --- src/nwfilter/nwfilter_gentech_driver.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/nwfilter/nwfilter_gentech_driver.c b/src/nwfilter/nwfilter_gentech_driver.c index dbb6b1f80e..d17be401e6 100644 ---

[libvirt PATCH 03/38] virSystemdActivationNew: Remove superfluous `goto`s

Signed-off-by: Tim Wiederhake --- src/util/virsystemd.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/util/virsystemd.c b/src/util/virsystemd.c index f90c17e767..99c92b6f52 100644 --- a/src/util/virsystemd.c +++ b/src/util/virsystemd.c @@ -968,17 +968,14 @@

[libvirt PATCH 04/38] virNWFilterCreateVarsFrom: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/nwfilter/nwfilter_gentech_driver.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/nwfilter/nwfilter_gentech_driver.c b/src/nwfilter/nwfilter_gentech_driver.c index da4f71daf1..dbb6b1f80e 100644 --- a/src/nwfilter/nwfilter_gentech_driver.c +++

[libvirt PATCH 00/38] virHashNew refactorings - part VII

"virHashNew" cannot return NULL, yet we check for NULL in various places. See https://listman.redhat.com/archives/libvir-list/2021-July/msg00074.html. Not split up further as per https://listman.redhat.com/archives/libvir-list/2021-July/msg00575.html Tim Wiederhake (38):

[libvirt PATCH 01/38] virSystemdActivationNew: `virHashNew` cannot return NULL

Signed-off-by: Tim Wiederhake --- src/util/virsystemd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/util/virsystemd.c b/src/util/virsystemd.c index 96f81cd3fa..6417dc6ea7 100644 --- a/src/util/virsystemd.c +++ b/src/util/virsystemd.c @@ -964,8 +964,7 @@

[PATCH] conf: Restore ctxt's node in right scope

We just found is ignored in our xml. Further debug shows that ctxt's node pointer isn't restored in virDomainSecDefParseXML(), which leads to parsing of remaining elements failed. Signed-off-by: Zhenzhong Duan --- src/conf/domain_conf.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 4/4] virshtest: add test for domjobinfo

Signed-off-by: Luke Yue --- tests/virshtest.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/tests/virshtest.c b/tests/virshtest.c index fe0c420958..88609af89c 100644 --- a/tests/virshtest.c +++ b/tests/virshtest.c @@ -257,6 +257,13 @@ static int

[PATCH 3/4] test_driver: Implement virDomainAbortJob

As the job should be running between 0-1 seconds, so if the API is triggered between 0-1 seconds, it will set time to 1, so that the job status will be completed. Otherwise, there is no job active and report error. Signed-off-by: Luke Yue --- src/test/test_driver.c | 29

[PATCH 2/4] test_driver: Implement virDomainGetJobStats

Signed-off-by: Luke Yue --- src/test/test_driver.c | 90 ++ 1 file changed, 90 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 29b19d80f0..4af8ce42f2 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@

[PATCH 0/4] Implement some job related APIs for test driver

Luke Yue (4): test_driver: Implement virDomainGetJobInfo test_driver: Implement virDomainGetJobStats test_driver: Implement virDomainAbortJob virshtest: add test for domjobinfo src/test/test_driver.c | 170 + tests/virshtest.c | 11 +++ 2

[PATCH 1/4] test_driver: Implement virDomainGetJobInfo

As in testDomainGetControlInfo, a background job should be running between 0-1 seconds, so make the testDomainGetJobInfo consistent with it. Signed-off-by: Luke Yue --- src/test/test_driver.c | 51 ++ 1 file changed, 51 insertions(+) diff --git

[PATCH v3 13/13] docs/deprecated: deprecate passing plugin args through `arg=`

Signed-off-by: Mahmoud Mandour --- docs/system/deprecated.rst | 7 +++ 1 file changed, 7 insertions(+) diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst index e2e0090878..7ae6f1f727 100644 --- a/docs/system/deprecated.rst +++ b/docs/system/deprecated.rst @@ -126,6 +126,13

[PATCH] conf: Add grabToggle to evdev input

Add support for customizable grabToggle key combinations with . Signed-off-by: Justin Gatzen --- docs/formatdomain.rst | 12 +++- docs/schemas/domaincommon.rng | 12 src/conf/domain_conf.c| 19