Release of libvirt-7.6.0

The 7.6.0 release of both libvirt and libvirt-python is tagged and signed tarballs and source RPMs are available at https://libvirt.org/sources/ https://libvirt.org/sources/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing any other

[PATCH] testutils: Don't leak @testBitmap and @failedTests

In virTestMain() the @failedTests bitmap is allocated and optionally @testBitmap too. But neither of them is freed. Signed-off-by: Michal Privoznik --- tests/testutils.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/testutils.c b/tests/testutils.c index 7d87e30a5c..58d3300998 1006

[PATCH] rpm: fix mingw obsoletes lines

The package is mistakenly obsoleting itself, when it should be obsoleting the -static packages we dropped. Signed-off-by: Daniel P. Berrangé --- mingw-libvirt.spec.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mingw-libvirt.spec.in b/mingw-libvirt.spec.in index bcc2b

Re: [PATCH v4 13/13] docs/deprecated: deprecate passing plugin args through `arg=`

Mahmoud Mandour writes: > Signed-off-by: Mahmoud Mandour > --- > docs/system/deprecated.rst | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst > index e2e0090878..7ae6f1f727 100644 > --- a/docs/system/deprecated.rst > +++ b/

Re: [libvirt PATCH 2/7] nodedev: fix xml output for mdev parents in test suite

On 7/23/21 6:40 PM, Jonathon Jongsma wrote: Commit 51fbbfdce8 attempted to get the proper nodedev name for the parent of an defined mdev by traversing the filesystem and looking for a device that had the appropriate sysfs path. This works, but it would be cleaner to to avoid mucking around in

Re: [PATCH] vmx: Parse vm.genid

On 7/30/21 2:02 PM, Richard W.M. Jones wrote: > On Thu, Jul 29, 2021 at 10:30:30AM +0200, Michal Privoznik wrote: >> The VMware metadata file contains genid but we are not parsing >> and thus reporting it in domain XML. However, it's not as >> straightforward as one might think. The UUID reported b

Re: [PATCH] vmx: Parse vm.genid

On Mon, Aug 02, 2021 at 01:00:15PM +0200, Michal Prívozník wrote: > On 7/30/21 2:02 PM, Richard W.M. Jones wrote: > > On Thu, Jul 29, 2021 at 10:30:30AM +0200, Michal Privoznik wrote: > >> The VMware metadata file contains genid but we are not parsing > >> and thus reporting it in domain XML. Howev

Re: [PATCH] vmx: Parse vm.genid

On Mon, Aug 02, 2021 at 01:00:15PM +0200, Michal Prívozník wrote: > On 7/30/21 2:02 PM, Richard W.M. Jones wrote: > > On Thu, Jul 29, 2021 at 10:30:30AM +0200, Michal Privoznik wrote: > >> The VMware metadata file contains genid but we are not parsing > >> and thus reporting it in domain XML. Howev

Re: [PATCH] vmx: Parse vm.genid

On Mon, Aug 02, 2021 at 12:04:49PM +0100, Richard W.M. Jones wrote: > On Mon, Aug 02, 2021 at 01:00:15PM +0200, Michal Prívozník wrote: > > On 7/30/21 2:02 PM, Richard W.M. Jones wrote: > > > On Thu, Jul 29, 2021 at 10:30:30AM +0200, Michal Privoznik wrote: > > >> The VMware metadata file contains

Re: [PATCH] vmx: Parse vm.genid

On 8/2/21 1:04 PM, Richard W.M. Jones wrote: > On Mon, Aug 02, 2021 at 01:00:15PM +0200, Michal Prívozník wrote: > > > Sure, I understand what it's used for. I was just wondering if there > are other consumers who want to pull the genID from VMware VMX files > using libvirt. Seems like something

[PATCH v3 1/3] libvirt.spec: relocate pre script of daemon-driver-qemu

Reduce the delta in an upcoming change. No change in behavior intended. Signed-off-by: Olaf Hering --- libvirt.spec.in | 32 +++- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 5c6494eefd..749f46c418 100644 ---

[PATCH v3 2/3] remove sysconfig files

sysconfig files are owned by the admin of the host. They have the liberty to put anything they want into these files. This makes it difficult to provide different built-in defaults. Remove the sysconfig file and place the current desired default into the service file. Local customizations can now

[PATCH v3 3/3] NEWS: mention removal of sysconfig

Signed-off-by: Olaf Hering --- NEWS.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 21df0e1602..ae30255492 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -19,6 +19,16 @@ v7.7.0 (unreleased) * **Improvements** + * packaging: sysconfig files no longer in

[PATCH v3 0/3] remove sysconfig files

rebased to 919f25d36ef0ea41c50bdb5afa0b83187ffb3c87 Olaf Hering (3): libvirt.spec: relocate pre script of daemon-driver-qemu remove sysconfig files NEWS: mention removal of sysconfig NEWS.rst| 10 +++ docs/daemons.rst| 20 + doc

Re: [PATCH] vmx: Parse vm.genid

On Mon, Aug 02, 2021 at 12:12:08PM +0100, Daniel P. Berrangé wrote: > On Mon, Aug 02, 2021 at 12:04:49PM +0100, Richard W.M. Jones wrote: > > On Mon, Aug 02, 2021 at 01:00:15PM +0200, Michal Prívozník wrote: > > > On 7/30/21 2:02 PM, Richard W.M. Jones wrote: > > > > On Thu, Jul 29, 2021 at 10:30:3

Re: [PATCH] testutils: Don't leak @testBitmap and @failedTests

On a %A in %Y, Michal Privoznik wrote: > In virTestMain() the @failedTests bitmap is allocated and > optionally @testBitmap too. But neither of them is freed. > > Signed-off-by: Michal Privoznik > --- > tests/testutils.c | 3 +++ > 1 file changed, 3 insertions(+) > Fixes: 0cd5a726e365e67690a81e

Re: [PATCH] vmx: Parse vm.genid

On Mon, Aug 02, 2021 at 12:26:56PM +0100, Richard W.M. Jones wrote: > On Mon, Aug 02, 2021 at 12:12:08PM +0100, Daniel P. Berrangé wrote: > > On Mon, Aug 02, 2021 at 12:04:49PM +0100, Richard W.M. Jones wrote: > > > On Mon, Aug 02, 2021 at 01:00:15PM +0200, Michal Prívozník wrote: > > > > On 7/30/2

Re: [PATCH] testutils: Don't leak @testBitmap and @failedTests

On 8/2/21 2:02 PM, Jano Tomko wrote: > On a %A in %Y, Michal Privoznik wrote: >> In virTestMain() the @failedTests bitmap is allocated and >> optionally @testBitmap too. But neither of them is freed. >>> Signed-off-by: Michal Privoznik >> --- >> tests/testutils.c | 3 +++ >> 1 file changed, 3 ins

Re: [PATCH] rpm: fix mingw obsoletes lines

On 8/2/21 12:53 PM, Daniel P. Berrangé wrote: > The package is mistakenly obsoleting itself, when it should be > obsoleting the -static packages we dropped. > > Signed-off-by: Daniel P. Berrangé > --- > mingw-libvirt.spec.in | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff -

Re: [PATCH] vmx: Parse vm.genid

On Mon, Aug 02, 2021 at 01:14:52PM +0100, Daniel P. Berrangé wrote: > On Mon, Aug 02, 2021 at 12:26:56PM +0100, Richard W.M. Jones wrote: > > On Mon, Aug 02, 2021 at 12:12:08PM +0100, Daniel P. Berrangé wrote: > > > On Mon, Aug 02, 2021 at 12:04:49PM +0100, Richard W.M. Jones wrote: > > > > On Mon,

[PATCH v5] docs/deprecated: deprecate passing plugin args through `arg=`

Signed-off-by: Mahmoud Mandour --- v4 -> v5: 1. Mentioned that short-form booleans are still usable but not preferable. docs/system/deprecated.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst index e2e0090878..43ae15

Re: [libvirt PATCH 6/7] nodedev: Handle inactive mdevs with the same UUID

On Fri, Jul 30, 2021 at 8:01 AM Boris Fiuczynski wrote: > > On 7/30/21 9:48 AM, Michal Prívozník wrote: > > On 7/29/21 9:27 PM, Jonathon Jongsma wrote: > >> On Thu, Jul 29, 2021 at 1:35 PM Boris Fiuczynski > >> wrote: > >>> > >>> On 7/27/21 4:09 PM, Jonathon Jongsma wrote: > On Tue, Jul 27,

[PATCH 2/8] block: add BlockParentClass class

Add a class that will unify block parents for blockdev-replace functionality we are going to add. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/block-parent.h | 32 + block/block-parent.c | 66 block/meson.build

[PATCH RFC 0/8] blockdev-replace

Hi all! As a continuation of "Qemu block filter insertion/removal API" discussion, here is my proposal of blockdev-replace. The realization allows: - replace children of different parents: BDS, block devices, block exports - automatically replace all parents of specific BDS, excluding creatin

[PATCH 1/8] block-backend: blk_root(): drop const specifier on return type

We'll need get non-const child pointer for graph modifications in further commits. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/sysemu/block-backend.h | 2 +- block/block-backend.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/sysemu/block-bac

[PATCH 6/8] qdev: realize BlockParentClass

Signed-off-by: Vladimir Sementsov-Ogievskiy --- softmmu/qdev-monitor.c | 42 ++ 1 file changed, 42 insertions(+) diff --git a/softmmu/qdev-monitor.c b/softmmu/qdev-monitor.c index 0117989009..2e149aa9b8 100644 --- a/softmmu/qdev-monitor.c +++ b/softmmu/qde

[PATCH 5/8] qdev: improve find_device_state() to distinguish simple not found case

We'll need this for realizing qdev_find_child() in the next commit. Signed-off-by: Vladimir Sementsov-Ogievskiy --- softmmu/qdev-monitor.c | 48 +- 1 file changed, 33 insertions(+), 15 deletions(-) diff --git a/softmmu/qdev-monitor.c b/softmmu/qdev-monito

[PATCH 8/8] qapi: add blockdev-replace command

Add command that can add and remove filters. Key points of functionality: What the command does is simply replace some BdrvChild.bs by some other nodes. The tricky thing is selecting there BdrvChild objects. To be able to select any kind of BdrvChild we use a generic parent_id, which may be a nod

[PATCH 3/8] block: realize BlockParentClass for BlockDriverState

Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 49 + 1 file changed, 49 insertions(+) diff --git a/block.c b/block.c index e97ce0b1c8..449f933661 100644 --- a/block.c +++ b/block.c @@ -26,6 +26,7 @@ #include "qemu/osdep.h" #include "bl

[PATCH 7/8] block: improve bdrv_replace_node_noperm()

Add optional block edge name filter and new mode: "exactly one", which we are going to use soon. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 27 --- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/block.c b/block.c index 449f933661..ae8c8c4032

[PATCH 4/8] block/export: realize BlockParentClass functionality

Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/export/export.c | 44 +++ 1 file changed, 44 insertions(+) diff --git a/block/export/export.c b/block/export/export.c index 6d3b9964c8..39b45feafe 100644 --- a/block/export/export.c +++ b/block/export/e

Re: lxc container startup error and RFC patch

On 7/29/21 3:28 PM, Cole Robinson wrote: Hi all, I'm seeing LXC container startup failures. This is with libvirt git, fedora 34 host with systemd-248.6-1.fc34.x86_64 (I didn't confirm with other versions). Reproducer: From my experience its more related to cgroups. Works with V2-only, doesn't

Re: lxc container startup error and RFC patch

On 8/2/21 10:20 PM, Jim Fehlig wrote: > On 7/29/21 3:28 PM, Cole Robinson wrote: >> Hi all, >> >> I'm seeing LXC container startup failures. This is with libvirt git, >> fedora 34 host with systemd-248.6-1.fc34.x86_64 (I didn't confirm with >> other versions). Reproducer: > > From my experience it