[PATCH] qemu: Label vhostuser net device

2021-08-13 Thread Jim Fehlig
Attaching a newly created vhostuser port to a VM fails due to an apparmor denial internal error: unable to execute QEMU command 'chardev-add': Failed to bind socket to /run/openvswitch/vhu838c4d29-c9: Permission denied In the case of a net device type VIR_DOMAIN_NET_TYPE_VHOSTUSER, the underlying

Re: [PATCH v2] libxl: remove conditionals from discard configuration

2021-08-13 Thread Jim Fehlig
On 8/13/21 8:03 AM, Olaf Hering wrote: LIBXL_HAVE_LIBXL_DEVICE_DISK_DISCARD_ENABLE exists since Xen 4.5.0 Signed-off-by: Olaf Hering --- src/libxl/libxl_conf.c | 21 + 1 file changed, 5 insertions(+), 16 deletions(-) Reviewed-by: Jim Fehlig

Re: [PATCH v1] libxl: remove conditionals from discard configuration

2021-08-13 Thread Jim Fehlig
On 8/13/21 8:00 AM, Olaf Hering wrote: Am Fri, 13 Aug 2021 07:52:31 -0600 schrieb Jim Fehlig : Why remove the cast? Because ->discard is of type virDomainDiskDiscard, the function can receive such type right away. Ah, I missed the change to the function signature. Jim

Re: [PATCH v1] libxl: remove conditionals from discard configuration

2021-08-13 Thread Jim Fehlig
On 8/13/21 5:22 AM, Olaf Hering wrote: LIBXL_HAVE_LIBXL_DEVICE_DISK_DISCARD_ENABLE exists since Xen 4.5.0 Signed-off-by: Olaf Hering --- src/libxl/libxl_conf.c | 21 + 1 file changed, 5 insertions(+), 16 deletions(-) This patch doesn't apply to libvirt.git master. dif

[PATCH v2] libxl: remove conditionals from discard configuration

2021-08-13 Thread Olaf Hering
LIBXL_HAVE_LIBXL_DEVICE_DISK_DISCARD_ENABLE exists since Xen 4.5.0 Signed-off-by: Olaf Hering --- src/libxl/libxl_conf.c | 21 + 1 file changed, 5 insertions(+), 16 deletions(-) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index 56cb9abd5d..9f0739e1fa 100644

Re: [PATCH v1] libxl: remove conditionals from discard configuration

2021-08-13 Thread Olaf Hering
Am Fri, 13 Aug 2021 07:52:31 -0600 schrieb Jim Fehlig : > Why remove the cast? Because ->discard is of type virDomainDiskDiscard, the function can receive such type right away. Olaf pgpM9pRwd1XCQ.pgp Description: Digitale Signatur von OpenPGP

[PATCH v1] libxl: remove conditionals from discard configuration

2021-08-13 Thread Olaf Hering
LIBXL_HAVE_LIBXL_DEVICE_DISK_DISCARD_ENABLE exists since Xen 4.5.0 Signed-off-by: Olaf Hering --- src/libxl/libxl_conf.c | 21 + 1 file changed, 5 insertions(+), 16 deletions(-) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index 3de2f9f57a..e275996cab 100644