Re: [PATCH 4/6] network_conf: add validation against schema in create

2021-09-02 Thread Daniel P . Berrangé
On Thu, Sep 02, 2021 at 05:11:03PM +0200, Ján Tomko wrote: > On a Thursday in 2021, Kristina Hanicova wrote: > > Signed-off-by: Kristina Hanicova > > --- > > src/conf/network_conf.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/src/conf/network_conf.c

Re: [PATCH 0/4] nwfilter-binding create: add support for validation against schema

2021-09-02 Thread Ján Tomko
On a Thursday in 2021, Kristina Hanicova wrote: Kristina Hanicova (4): api: add virNWFilterBindingCreateFlags conf: virnwfilterbindingdef: add validation against schema in create nwfilter_driver: allow VIR_NWFILTER_BINDING_CREATE_VALIDATE flag virsh: add support for '--validate' option in

Re: [PATCH 5/6] network: allow VIR_NETWORK_CREATE_VALIDATE flag

2021-09-02 Thread Ján Tomko
On a Thursday in 2021, Kristina Hanicova wrote: Signed-off-by: Kristina Hanicova --- src/network/bridge_driver.c | 4 ++-- src/test/test_driver.c | 4 ++-- src/vbox/vbox_network.c | 3 ++- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/vbox/vbox_network.c

Re: [PATCH 0/4] network port create: add support for validation against schema

2021-09-02 Thread Ján Tomko
On a Thursday in 2021, Kristina Hanicova wrote: Kristina Hanicova (4): api: add VIR_NETWORK_PORT_CREATE_VALIDATE flag conf: virnetworkportdef: add validation against schema in network port create bridge_driver: allow VIR_NETWORK_PORT_CREATE_VALIDATE flag virsh: add support for

Re: [PATCH 1/6] api: add public virNetworkCreateXMLFlags() and remote protocol

2021-09-02 Thread Ján Tomko
On a Thursday in 2021, Kristina Hanicova wrote: This new API creates network with given flags. Signed-off-by: Kristina Hanicova --- include/libvirt/libvirt-network.h | 3 +++ src/driver-network.h | 6 + src/libvirt-network.c | 41 +++

Re: [PATCH 3/6] api: add virNetworkCreateFlags

2021-09-02 Thread Ján Tomko
On a Thursday in 2021, Kristina Hanicova wrote: Signed-off-by: Kristina Hanicova --- include/libvirt/libvirt-network.h | 4 src/libvirt-network.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/include/libvirt/libvirt-network.h

Re: [PATCH 0/6] network create: add support for validation against schema

2021-09-02 Thread Ján Tomko
On a Thursday in 2021, Kristina Hanicova wrote: Kristina Hanicova (6): api: add public virNetworkCreateXMLFlags() and remote protocol src: add driver support for networkCreateXMLFlags() api: add virNetworkCreateFlags network_conf: add validation against schema in create network: allow

Re: [PATCH 4/6] network_conf: add validation against schema in create

2021-09-02 Thread Ján Tomko
On a Thursday in 2021, Kristina Hanicova wrote: Signed-off-by: Kristina Hanicova --- src/conf/network_conf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index f23599abac..5e24880f1f 100644 --- a/src/conf/network_conf.c

Re: [PATCH RFC 0/8] blockdev-replace

2021-09-02 Thread Vladimir Sementsov-Ogievskiy
ping 02.08.2021 21:54, Vladimir Sementsov-Ogievskiy wrote: Hi all! As a continuation of "Qemu block filter insertion/removal API" discussion, here is my proposal of blockdev-replace. The realization allows: - replace children of different parents: BDS, block devices, block exports -

Re: [PATCH v3 0/5] Implement some job related APIs for test driver

2021-09-02 Thread Luke Yue
On Wed, 2021-08-18 at 22:17 +0800, Luke Yue wrote: > v3: > - Fix virDomainGetJobStats when use completed flags > - Introduce testDomainSetDummyData > - Add and refine some tests > > Luke Yue (5): >   test_driver: Implement virDomainGetJobInfo >   test_driver: Implement virDomainGetJobStats >  

[PATCH 0/3] Add an option to use virDomainGetSecurityLabelList and test it

2021-09-02 Thread Luke Yue
Luke Yue (3): test_driver: Implement virDomainGetSecurityLabelList virsh: Add '--full-seclabels' option for dominfo tests: Add test for virDomainGetSecurityLabelList docs/manpages/virsh.rst | 5 +- src/test/test_driver.c | 42 + tests/virsh-undefine | 8

Re: RBD encryption support in libvirt

2021-09-02 Thread Daniel P . Berrangé
On Thu, Sep 02, 2021 at 05:55:20AM +, Or Ozeri wrote: > Hi, > > > I wanted to get your advice on a patch I'm preparing for libvirt. > It touches the code-path that allows using LUKS encryption on top of an RBD > image. > > > We recently added LUKS and LUKS2 encryption support in Ceph's

[PATCH 2/3] virsh: Add '--full-seclabels' option for dominfo

2021-09-02 Thread Luke Yue
There is no virsh command uses virDomainGetSecurityLabelList API, so add an option for dominfo to call it and print full list of security labels. Also realign some outputs as it's now "Security labels:" instead of "Security label:". Signed-off-by: Luke Yue --- docs/manpages/virsh.rst | 5

[PATCH 3/3] tests: Add test for virDomainGetSecurityLabelList

2021-09-02 Thread Luke Yue
Signed-off-by: Luke Yue --- tests/virshtest.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/virshtest.c b/tests/virshtest.c index 0d703f3765..4fb4799456 100644 --- a/tests/virshtest.c +++ b/tests/virshtest.c @@ -69,6 +69,7 @@ Managed save:no\n\ Security model:

[PATCH 1/3] test_driver: Implement virDomainGetSecurityLabelList

2021-09-02 Thread Luke Yue
Signed-off-by: Luke Yue --- src/test/test_driver.c | 42 ++ 1 file changed, 42 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 2f19b7c520..1b5914c890 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@

[libvirt PATCH v2 0/1] Add a PCI/PCIe device VPD Capability

2021-09-02 Thread Dmitrii Shcherbakov
Add support for deserializing the binary PCI/PCIe VPD format and exposing VPD resources as XML elements in a new nested capability of PCI/PCIe devices called 'vpd'. The VPD format is specified in "I.3. VPD Definitions" in PCI specs (2.2+) and "6.28.1 VPD Format" PCIe 4.0. As section 6.28 in PCIe

[libvirt PATCH v2 1/1] Add a PCI/PCIe device VPD Capability

2021-09-02 Thread Dmitrii Shcherbakov
Add support for deserializing the binary PCI/PCIe VPD format and exposing VPD resources as XML elements in a new nested capability of PCI/PCIe devices called 'vpd'. The VPD format is specified in "I.3. VPD Definitions" in PCI specs (2.2+) and "6.28.1 VPD Format" PCIe 4.0. As section 6.28 in PCIe

RBD encryption support in libvirt

2021-09-02 Thread Or Ozeri
Hi, I wanted to get your advice on a patch I'm preparing for libvirt. It touches the code-path that allows using LUKS encryption on top of an RBD image. We recently added LUKS and LUKS2 encryption support in Ceph's librbd. We exposed this in qemu in a recent patch by adding new optional