On Fri, Sep 10, 2021 at 4:35 PM Peter Krempa wrote:
>
> We don't support all startup policies with all source types so to
> correctly allow switching from a 'file' based cdrom with 'optional'
> startup policy to a 'block' based one which doesn't support optional we
> must update the startup
On 9/10/21 4:48 PM, Kristina Hanicova wrote:
> We don't need to propagate all public flags, only the information
> about the presence of the validation one, which can differ from
> function to function. This patch makes it easier and more
> readable in case of a future additions of validation
Signed-off-by: Andrea Bolognani
---
.../debian-11-cross-aarch64.Dockerfile| 126 +
.../debian-11-cross-armv6l.Dockerfile | 125 +
.../debian-11-cross-armv7l.Dockerfile | 126 +
ci/containers/debian-11-cross-i686.Dockerfile |
It's been out for a bit.
Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/368763275
Andrea Bolognani (2):
ci: Add Debian 11 builds
ci: Regenerate configuration from manifest
.../debian-11-cross-aarch64.Dockerfile| 126 +
The armv7l and ppc64le cross-builds as well as the Clang build
are adopted from Debian 10, while the mips64el build is adopted
from Debian sid. As always, the way jobs are distributed across
Debian versions is fairly arbitrary.
Signed-off-by: Andrea Bolognani
---
ci/manifest.yml | 42
On 9/10/21 3:30 AM, Peter Krempa wrote:
On Thu, Sep 09, 2021 at 13:46:41 -0400, Laine Stump wrote:
The ACPI index of a device in a running guest can't be modified, and
libvirt doesn't actually attempt to modify it, but it was possible for
a user to request such a modification, and libvirt
We don't need to propagate all public flags, only the information
about the presence of the validation one, which can differ from
function to function. This patch makes it easier and more
readable in case of a future additions of validation flags.
This change was suggested by Daniel.
Hi,
sorry for replying this late.
Thanks for looking into this. It's a fairly long list, so it's
understandable that it took a while. :)
5. Slot handling.
As already discussed, virtio-mem and virtio-pmem don't need slots. Yet,
the "slots" definition is required and libvirt reserves
On Thu, Sep 09, 2021 at 03:52:45PM +, Puscasu, Felix wrote:
> Hello Libvirt team,
>
> For the last couple of months, as an AWS intern I have been reading
> and learning how to use libvirt. I have been working on integrating
> https://github.com/firecracker-microvm/firecracker>,
> an open
On 9/10/21 3:35 PM, Peter Krempa wrote:
> We don't support all startup policies with all source types so to
> correctly allow switching from a 'file' based cdrom with 'optional'
> startup policy to a 'block' based one which doesn't support optional we
> must update the startup policy field first.
These were removed along with the outdated information on how
to regenerate the Dockerfiles contained in the repository, but
this part is still relevant.
Reverts: 30856d2865122f82ec25c258c7cd2cceb52aa7a5 (partially)
Signed-off-by: Andrea Bolognani
---
ci/README.rst | 22 ++
The value 3 is the length of the "ci-" prefix, which is present
in the items returned by get_registry_images() but not in those
returned by get_dockerfiles().
Signed-off-by: Andrea Bolognani
---
ci/util.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/ci/util.py
After recent changes.
Andrea Bolognani (2):
ci: Restore information about Coverity integration
ci: Avoid use of magic constants
ci/README.rst | 22 ++
ci/util.py| 3 ++-
2 files changed, 24 insertions(+), 1 deletion(-)
--
2.31.1
On 7/7/21 12:30 PM, David Hildenbrand wrote:
> On 23.06.21 12:12, Michal Privoznik wrote:
>> v4 of:
>>
>> https://listman.redhat.com/archives/libvir-list/2021-April/msg01138.html
>>
>> diff to v3:
>> - Rebased code on the top of master
>> - Tried to work in all Peter's review suggestions
>> -
On Fri, Sep 10, 2021 at 03:26:20PM +0200, Pavel Hrdina wrote:
> On Fri, Sep 10, 2021 at 12:57:30PM +0100, Daniel P. Berrangé wrote:
> > On Thu, Sep 09, 2021 at 06:13:16PM +0200, Pavel Hrdina wrote:
> > > Rebased on top of current master.
> > >
> > > I'm posting this as an RFC mainly because I'm
We don't support all startup policies with all source types so to
correctly allow switching from a 'file' based cdrom with 'optional'
startup policy to a 'block' based one which doesn't support optional we
must update the startup policy field first. Obviously we need to have
fallback if the update
On Fri, Sep 10, 2021 at 12:57:30PM +0100, Daniel P. Berrangé wrote:
> On Thu, Sep 09, 2021 at 06:13:16PM +0200, Pavel Hrdina wrote:
> > Rebased on top of current master.
> >
> > I'm posting this as an RFC mainly because I'm not sure how to model
> > the new API. This patches introduce a new naive
On Fri, Sep 10, 2021 at 01:49:27PM +0200, Michal Prívozník wrote:
> On 9/9/21 6:13 PM, Pavel Hrdina wrote:
> > Signed-off-by: Pavel Hrdina
> > ---
> > src/remote/remote_driver.c | 1 +
> > src/remote/remote_protocol.x | 14 +-
> > src/remote_protocol-structs | 6 ++
> > 3
On Fri, Sep 10, 2021 at 01:49:24PM +0200, Michal Prívozník wrote:
> On 9/9/21 6:13 PM, Pavel Hrdina wrote:
> > This will be needed by future patches adding appid API to allow changing
> > it for running VMs.
> >
> > Signed-off-by: Pavel Hrdina
> > ---
> > src/conf/domain_validate.c | 42
On Fri, Sep 10, 2021 at 01:49:22PM +0200, Michal Prívozník wrote:
> On 9/9/21 6:13 PM, Pavel Hrdina wrote:
> > With introduction of live changes of appid we should also support
> > removal of the appid from VM. This is done by writing empty appid part
> > to appid_store file.
> >
> >
On Fri, Sep 10, 2021 at 01:49:20PM +0200, Michal Prívozník wrote:
> On 9/9/21 6:13 PM, Pavel Hrdina wrote:
> > Signed-off-by: Pavel Hrdina
> > ---
> > include/libvirt/libvirt-domain.h | 4 +++
> > src/driver-hypervisor.h | 6 +
> > src/libvirt-domain.c | 44
On Fri, Sep 10, 2021 at 01:49:18PM +0200, Michal Prívozník wrote:
> On 9/9/21 6:13 PM, Pavel Hrdina wrote:
> > Signed-off-by: Pavel Hrdina
> > ---
> > docs/manpages/virsh.rst | 14 +
> > tools/virsh-domain.c| 65 +
> > 2 files changed, 79
When documenting our public API in some places we use '@' to
refer to the variable. For instance:
* This API tries to set guest time to the given value. The time
* to set (@seconds and @nseconds) should be in seconds relative
* to the Epoch of 1970-01-01 00:00:00 in UTC.
However, when
On a Friday in 2021, Peter Krempa wrote:
'-qmp' in this case behaves the same as '-chardev' so it should have
been converted the same way as others were in 43c9c0859f2d53321 since
short options are deprecated.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_process.c | 2 +-
1 file changed, 1
'-qmp' in this case behaves the same as '-chardev' so it should have
been converted the same way as others were in 43c9c0859f2d53321 since
short options are deprecated.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_process.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On a Friday in 2021, Tim Wiederhake wrote:
Signed-off-by: Tim Wiederhake
---
src/util/virxml.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/util/virxml.h b/src/util/virxml.h
index 06fb7aebd8..e69fd08ea6 100644
--- a/src/util/virxml.h
+++ b/src/util/virxml.h
@@
On a Friday in 2021, Tim Wiederhake wrote:
Workaround for a bug in clang. Clang emits an unused-variable warning
if the variable is only accessed on scope exit by a destructor function.
Note that gcc does not exhibit this behavior.
See https://bugs.llvm.org/show_bug.cgi?id=3888 and
On Fri, Sep 10, 2021 at 02:26:32PM +0200, Tim Wiederhake wrote:
> On Fri, 2021-09-10 at 11:53 +0100, Daniel P. Berrangé wrote:
> > On Fri, Sep 10, 2021 at 12:45:43PM +0200, Tim Wiederhake wrote:
> > > Workaround for a bug in clang. Clang emits an unused-variable
> > > warning
> > > if the variable
On Fri, 2021-09-10 at 11:53 +0100, Daniel P. Berrangé wrote:
> On Fri, Sep 10, 2021 at 12:45:43PM +0200, Tim Wiederhake wrote:
> > Workaround for a bug in clang. Clang emits an unused-variable
> > warning
> > if the variable is only accessed on scope exit by a destructor
> > function.
> > Note
On Thu, Sep 09, 2021 at 06:13:16PM +0200, Pavel Hrdina wrote:
> Rebased on top of current master.
>
> I'm posting this as an RFC mainly because I'm not sure how to model
> the new API. This patches introduce a new naive API that will change
> only the APPID and nothing else.
>
> Currently there
On 9/9/21 6:13 PM, Pavel Hrdina wrote:
> This will be needed by future patches adding appid API to allow changing
> it for running VMs.
>
> Signed-off-by: Pavel Hrdina
> ---
> src/conf/domain_validate.c | 42 +++---
> src/conf/domain_validate.h | 2 ++
>
On 9/9/21 6:13 PM, Pavel Hrdina wrote:
> Rebased on top of current master.
>
> I'm posting this as an RFC mainly because I'm not sure how to model
> the new API. This patches introduce a new naive API that will change
> only the APPID and nothing else.
>
> Currently there are no other known
On 9/9/21 6:13 PM, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> docs/manpages/virsh.rst | 14 +
> tools/virsh-domain.c| 65 +
> 2 files changed, 79 insertions(+)
>
> diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst
>
On 9/9/21 6:13 PM, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> src/remote/remote_driver.c | 1 +
> src/remote/remote_protocol.x | 14 +-
> src/remote_protocol-structs | 6 ++
> 3 files changed, 20 insertions(+), 1 deletion(-)
>
> diff --git
On 9/9/21 6:13 PM, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina
> ---
> include/libvirt/libvirt-domain.h | 4 +++
> src/driver-hypervisor.h | 6 +
> src/libvirt-domain.c | 44
> src/libvirt_public.syms | 1 +
> 4 files
On 9/9/21 6:13 PM, Pavel Hrdina wrote:
> With introduction of live changes of appid we should also support
> removal of the appid from VM. This is done by writing empty appid part
> to appid_store file.
>
> Signed-off-by: Pavel Hrdina
> ---
> src/util/vircgroup.c | 2 +-
> 1 file changed, 1
On Fri, Sep 10, 2021 at 12:45:43PM +0200, Tim Wiederhake wrote:
> Workaround for a bug in clang. Clang emits an unused-variable warning
> if the variable is only accessed on scope exit by a destructor function.
> Note that gcc does not exhibit this behavior.
>
> See
Signed-off-by: Tim Wiederhake
---
src/conf/virchrdev.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/conf/virchrdev.c b/src/conf/virchrdev.c
index fe11e10437..58e3c84aad 100644
--- a/src/conf/virchrdev.c
+++ b/src/conf/virchrdev.c
@@ -291,10 +291,10 @@ void
Signed-off-by: Tim Wiederhake
---
src/lxc/lxc_driver.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c
index e2720a6f89..528af5d164 100644
--- a/src/lxc/lxc_driver.c
+++ b/src/lxc/lxc_driver.c
@@ -4079,9 +4079,9 @@
Typical usage:
void foobar(virObjectLockable *obj)
{
g_autoptr(virLockGuard) lock = virObjectLockGuard(obj);
/* `obj` is locked, and released automatically on scope exit */
...
}
Signed-off-by: Tim Wiederhake
---
src/libvirt_private.syms | 1 +
Signed-off-by: Tim Wiederhake
---
src/util/virxml.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/util/virxml.h b/src/util/virxml.h
index 06fb7aebd8..e69fd08ea6 100644
--- a/src/util/virxml.h
+++ b/src/util/virxml.h
@@ -358,10 +358,8 @@
V1: https://listman.redhat.com/archives/libvir-list/2021-August/msg00823.html
Changes since V1:
* Replaced vir_g_auto* macros with redefinitions of g_auto* if compiled with
clang (patch 1).
* Split up VIR_XPATH_NODE_AUTORESTORE simplification differently (patches 2
and 3).
* Added
Signed-off-by: Tim Wiederhake
---
src/bhyve/bhyve_driver.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c
index 516490f6cd..cdd833f896 100644
--- a/src/bhyve/bhyve_driver.c
+++ b/src/bhyve/bhyve_driver.c
@@ -87,7 +87,8
Signed-off-by: Tim Wiederhake
---
src/conf/virchrdev.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/conf/virchrdev.c b/src/conf/virchrdev.c
index 5d6de68427..fe11e10437 100644
--- a/src/conf/virchrdev.c
+++ b/src/conf/virchrdev.c
@@ -237,12 +237,10 @@ static void
Using the two-step idiom to force resolution of other macros, e.g.:
#define bar BAR
CONCAT_(foo, bar) // foobar
CONCAT(foo, bar) // fooBAR
Signed-off-by: Tim Wiederhake
---
src/internal.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/internal.h b/src/internal.h
Use of semicolons after VIR_XPATH_NODE_AUTORESTORE was inconsistent.
Make it mandatory.
Signed-off-by: Tim Wiederhake
---
src/conf/backup_conf.c | 2 +-
src/conf/checkpoint_conf.c | 2 +-
src/conf/cpu_conf.c| 2 +-
src/conf/domain_conf.c |
Modeled after "WITH_QEMU_LOCK_GUARD" (see qemu's include/qemu/lockable.h).
Uses "__LINE__" instead of "__COUNTER__", as the latter is a GNU extension.
See comment for typical usage.
Signed-off-by: Tim Wiederhake
---
src/util/virobject.h | 20
1 file changed, 20
Modeled after "WITH_QEMU_LOCK_GUARD" (see qemu's include/qemu/lockable.h).
Uses "__LINE__" instead of "__COUNTER__", as the latter is a GNU extension.
See comment for typical usage.
Signed-off-by: Tim Wiederhake
---
src/util/virthread.h | 20
1 file changed, 20
Locks a virMutex on creation and unlocks it in its destructor.
Typical usage:
void function(virMutex *m)
{
g_autoptr(virLockGuard) lock = virLockGuardNew(m);
/* `m` is locked, and released automatically on scope exit */
...
while (expression) {
Workaround for a bug in clang. Clang emits an unused-variable warning
if the variable is only accessed on scope exit by a destructor function.
Note that gcc does not exhibit this behavior.
See https://bugs.llvm.org/show_bug.cgi?id=3888 and
https://bugs.llvm.org/show_bug.cgi?id=43482.
On Fri, Sep 10, 2021 at 09:56:19AM +0100, Daniel P. Berrangé wrote:
> This switches our CI rules to be largely auto-generated by the lcitool
> manifest command, so that they share a consistent design with all other
> projects and are simpler to modify in future.
>
> Daniel P. Berrangé (7):
>
In the documentation to virDomainAttachDevice() we refer to a
non-existent virDomainUpdateDeviceFlag() function. The correct
name is virDomainUpdateDeviceFlags().
Signed-off-by: Michal Privoznik
---
Pushed as trivial.
src/libvirt-domain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
On Fri, Sep 10, 2021 at 10:57:37 +0200, Michal Prívozník wrote:
> On 9/10/21 9:30 AM, Peter Krempa wrote:
> > On Thu, Sep 09, 2021 at 13:46:41 -0400, Laine Stump wrote:
> >> The ACPI index of a device in a running guest can't be modified, and
> >> libvirt doesn't actually attempt to modify it, but
The sanitizer jobs run in ubuntu 20.04 containers and thus overlap with
testing already done for the regular ubuntu 20.04 build job. Fold the
sanitizer run for GCC into the regular build job and add a second
ubuntu 20.04 build job for CLang sanitizers.
Signed-off-by: Daniel P. Berrangé
---
On 9/10/21 9:30 AM, Peter Krempa wrote:
> On Thu, Sep 09, 2021 at 13:46:41 -0400, Laine Stump wrote:
>> The ACPI index of a device in a running guest can't be modified, and
>> libvirt doesn't actually attempt to modify it, but it was possible for
>> a user to request such a modification, and
We now use lcitool's manifest feature to generate files. The logic
for checking for stale containers in the registry, however, is still
relevant so that is propagated to a standalone command.
Signed-off-by: Daniel P. Berrangé
---
ci/helper | 121
This uses the command "lcitool manifest ci/manifest.yml" to re-generate
all existing dockerfiles and gitlab CI config.
Signed-off-by: Daniel P. Berrangé
---
.gitlab-ci.yml| 512 +--
ci/cirrus/freebsd-12.vars | 2 +-
We now use lcitool's manifest feature to generate files.
Signed-off-by: Daniel P. Berrangé
---
ci/containers/README.rst | 36
1 file changed, 36 deletions(-)
delete mode 100644 ci/containers/README.rst
diff --git a/ci/containers/README.rst
Signed-off-by: Daniel P. Berrangé
---
ci/manifest.yml | 153
1 file changed, 153 insertions(+)
create mode 100644 ci/manifest.yml
diff --git a/ci/manifest.yml b/ci/manifest.yml
new file mode 100644
index 00..b25ab2dfcf
--- /dev/null
+++
Signed-off-by: Daniel P. Berrangé
---
ci/cirrus/freebsd-12.vars | 6 +++---
ci/cirrus/freebsd-13.vars | 6 +++---
ci/cirrus/freebsd-current.vars| 6 +++---
ci/cirrus/macos-11.vars | 2 +-
This switches our CI rules to be largely auto-generated by the lcitool
manifest command, so that they share a consistent design with all other
projects and are simpler to modify in future.
Daniel P. Berrangé (7):
gitlab: move codestyle job to the sanity_checks stage
gitlab: refresh containers
It was in the build stage previously to let it run in parallel with
other build jobs, but with the "needs" clause this is not required.
Signed-off-by: Daniel P. Berrangé
---
.gitlab-ci.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index
On Thu, Sep 09, 2021 at 13:46:41 -0400, Laine Stump wrote:
> The ACPI index of a device in a running guest can't be modified, and
> libvirt doesn't actually attempt to modify it, but it was possible for
> a user to request such a modification, and libvirt wouldn't complain,
> thus misleading the
63 matches
Mail list logo
