Signed-off-by: Kristina Hanicova
---
tools/virsh-util.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tools/virsh-util.c b/tools/virsh-util.c
index 19cd0bcb99..fb74514b3c 100644
--- a/tools/virsh-util.c
+++ b/tools/virsh-util.c
@@ -137,8 +137,7 @@
Signed-off-by: Kristina Hanicova
---
tools/virsh-host.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/tools/virsh-host.c b/tools/virsh-host.c
index b602696704..6f306fffe3 100644
--- a/tools/virsh-host.c
+++ b/tools/virsh-host.c
@@ -1350,7 +1350,6 @@
Signed-off-by: Kristina Hanicova
---
tools/virsh-host.c | 15 +
tools/virsh-interface.c | 50 ++---
tools/virsh-network.c | 30 -
tools/virsh-nodedev.c | 32 ++
tools/virsh-nwfilter.c | 15
Signed-off-by: Kristina Hanicova
---
tools/virsh-interface.c | 15 ++-
tools/virsh-network.c | 17 ++---
2 files changed, 12 insertions(+), 20 deletions(-)
diff --git a/tools/virsh-interface.c b/tools/virsh-interface.c
index 4bcc59b580..f402119b68 100644
---
This is partially v2 of:
https://listman.redhat.com/archives/libvir-list/2021-September/msg00731.html
Diff to v1:
* split changes into smaller patches
Kristina Hanicova (4):
virsh: remove variable 'ret' and use early return if possible
virsh: remove variable 'ret' in cmdVersion()
virsh:
This patch is partially v2 of:
https://listman.redhat.com/archives/libvir-list/2021-September/msg00728.html
Diff to v1:
* split from previous big patch
* split the fixing part and the refactoring part of the function into
different patches
Kristina Hanicova (2):
virsh: domain: fix mistake in
Signed-off-by: Kristina Hanicova
---
tools/virsh-domain.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 2730acfba5..cfa0016296 100644
--- a/tools/virsh-domain.c
+++ b/tools/virsh-domain.c
@@ -11006,25
Function returned false when everything ended successfully, there
was a missing check for a return value. This patch fixes that.
Signed-off-by: Kristina Hanicova
---
tools/virsh-domain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/virsh-domain.c
Signed-off-by: Kristina Hanicova
---
tools/virsh-volume.c | 52
1 file changed, 23 insertions(+), 29 deletions(-)
diff --git a/tools/virsh-volume.c b/tools/virsh-volume.c
index 152f5b0dbe..38bb62a48f 100644
--- a/tools/virsh-volume.c
+++
Signed-off-by: Kristina Hanicova
---
tools/virsh-host.c | 40
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/tools/virsh-host.c b/tools/virsh-host.c
index be9cbc2096..bcd44cefe1 100644
--- a/tools/virsh-host.c
+++ b/tools/virsh-host.c
@@
Signed-off-by: Kristina Hanicova
---
tools/virsh-domain.c | 99 +---
1 file changed, 47 insertions(+), 52 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index f876f30cc5..b64df640ba 100644
--- a/tools/virsh-domain.c
+++
Signed-off-by: Kristina Hanicova
---
tools/virsh-host.c | 99 +++---
1 file changed, 49 insertions(+), 50 deletions(-)
diff --git a/tools/virsh-host.c b/tools/virsh-host.c
index e6ed4a26ce..be9cbc2096 100644
--- a/tools/virsh-host.c
+++
This is v2 of patch:
https://listman.redhat.com/archives/libvir-list/2021-September/msg00730.html
Diff to v1:
* split the previous patch into more smaller ones to make the code
review easier
* small code quality alternations I did not notice were possible before
This series refactors a few
Signed-off-by: Kristina Hanicova
---
tools/virsh-domain.c | 49
1 file changed, 22 insertions(+), 27 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index b64df640ba..3dc5fb046e 100644
--- a/tools/virsh-domain.c
+++
Signed-off-by: Kristina Hanicova
---
tools/virsh-domain.c | 62
1 file changed, 28 insertions(+), 34 deletions(-)
diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
index 3dc5fb046e..6f2249ddde 100644
--- a/tools/virsh-domain.c
+++
On 9/11/21 11:26 PM, Ani Sinha wrote:
Hi all:
This patchset introduces libvirt xml support for the following two pm conf
options:
(before I get into a more radical discussion about different options -
since we aren't exactly duplicating the QEMU option name anyway, what if
we
On a Thursday in 2021, Peter Krempa wrote:
There are a few more capabilities we can easily assume and stop trying
to probe them and some more legacy code to delete.
This time it's mainly about VNC including a modernization of
qemuxml2argvtest cases for it.
Peter Krempa (14):
qemuxml2argvtest:
On a Thursday in 2021, Peter Krempa wrote:
All supported qemu versions now use the new commandine parser functions,
commandline
thus we can remove the old-style commandline generator.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 5 +
On a Thursday in 2021, Peter Krempa wrote:
The 'tls-creds-x509' object is always registered even when qemu is built
without gnutls for all supported qemu versions. This means we can assume
it's support and thus simplify the code using TLS.
s/can assume it's support/cannot probe for its
On a Thursday in 2021, Peter Krempa wrote:
Replace the fake caps invocation with invocation bidnig it to the oldest
*binding
supported qemu version.
Signed-off-by: Peter Krempa
---
...s-vnc-tls.args => graphics-vnc-tls.x86_64-2.11.0.args} | 8 +---
tests/qemuxml2argvtest.c
On a Thursday in 2021, Kristina Hanicova wrote:
This patch targets smaller functions and rewrites them into the
pattern using an early return without needing redundant 'ret'
variable (if possible).
Patch also includes removal of 'else' branch after 'return' and
other small alterations.
On a Thursday in 2021, Kristina Hanicova wrote:
This patch includes:
* fix of a mistake in cmdMigrateSetMaxDowntime() - function
returned false when it should have returned true
Ideally, refactors should not alter behavior, so fixes should be
separated.
Jano
* use of an early return in
On a Thursday in 2021, Kristina Hanicova wrote:
This patch includes small refactoring such as:
* early return in case of an error - helps with indentation
* removal of 'else' branch after return - unnecessary
* altering code to be more consistent with the rest of the file -
function calls
23.09.2021 13:09, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
Thanks a lot for reviewing!
20.09.2021 09:44, Markus Armbruster wrote:
Vladimir Sementsov-Ogievskiy writes:
Add command that can add and remove filters.
Key points of functionality:
What the command does is
As with previous test replace the fake caps versions with a combination
of DO_TEST_CAPS_VER(..., "2.11.0") and DO_TEST_CAPS_LATEST().
Signed-off-by: Peter Krempa
---
...phics-vnc-egl-headless.x86_64-2.11.0.args} | 5 ++-
...aphics-vnc-egl-headless.x86_64-latest.args | 37 +++
Now that the code is refactored add the DO_TEST_CAPS_LATEST versions as
promised in the commit adding the pinned versions.
Signed-off-by: Peter Krempa
---
...ics-vnc-auto-socket-cfg.x86_64-latest.args | 36 +++
...raphics-vnc-auto-socket.x86_64-latest.args | 33 +
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 3 +--
src/qemu/qemu_capabilities.h | 2 +-
tests/qemucapabilitiesdata/caps_2.11.0.x86_64.xml | 1 -
tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml | 1 -
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 3 +--
src/qemu/qemu_capabilities.h | 2 +-
tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml | 1 -
tests/qemucapabilitiesdata/caps_2.11.0.x86_64.xml | 1 -
QEMU added the capability to disable file transfers via spice in commit
5ad24e5f3b ("spice: Add -spice disable-agent-file-transfer cmdline
option (rhbz#961850)") released in qemu-v1.6.0 and the option can't be
disabled.
Remove the unnecessary validation.
Signed-off-by: Peter Krempa
---
Replace the 3 unix socket tests with real caps versions to demonstrate
that supported qemus no longer use the old syntax.
DO_TEST_CAPS_LATEST versions will be added later.
This also removes duplicate invocation of 'graphics-vnc-socket'.
Signed-off-by: Peter Krempa
---
...
All supported qemu versions now use the new commandine parser functions,
thus we can remove the old-style commandline generator.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 5 +
tests/qemuxml2argvdata/name-escape.args | 2 +-
tests/qemuxml2argvtest.c
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 3 +--
src/qemu/qemu_capabilities.h | 2 +-
tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml | 1 -
tests/qemucapabilitiesdata/caps_2.11.0.x86_64.xml | 1 -
The switch to QemuOpts parser which brought the long-form options
happened in qemu commit 4db14629c3 ("vnc: switch to QemuOpts, allow
multiple servers") released in v2.3.0.
We can always assume this capability and remove the old-style
generators.
Signed-off-by: Peter Krempa
---
'qemuDomainSecretGraphicsPrepare' always populates 'gfxPriv->tlsAlias'
when 'cfg->vncTLS' is enabled.
This means we can remove the fallback code setting up TLS for vnc via
the 'x509=' parameter.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 48
Signed-off-by: Peter Krempa
---
src/qemu/qemu_capabilities.c | 3 +--
src/qemu/qemu_capabilities.h | 2 +-
tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml | 1 -
tests/qemucapabilitiesdata/caps_2.11.0.x86_64.xml | 1 -
The 'tls-creds-x509' object is always registered even when qemu is built
without gnutls for all supported qemu versions. This means we can assume
it's support and thus simplify the code using TLS.
Signed-off-by: Peter Krempa
---
src/qemu/qemu_command.c | 8 +---
src/qemu/qemu_domain.c |
Replace the fake caps invocation with invocation bidnig it to the oldest
supported qemu version.
Signed-off-by: Peter Krempa
---
...s-vnc-tls.args => graphics-vnc-tls.x86_64-2.11.0.args} | 8 +---
tests/qemuxml2argvtest.c | 2 +-
2 files changed, 6
Signed-off-by: Peter Krempa
---
src/qemu/qemu_backup.c | 5 ++--
src/qemu/qemu_command.c | 39 +++-
src/qemu/qemu_command.h | 10 +++-
src/qemu/qemu_driver.c | 15
src/qemu/qemu_hotplug.c | 13
There are a few more capabilities we can easily assume and stop trying
to probe them and some more legacy code to delete.
This time it's mainly about VNC including a modernization of
qemuxml2argvtest cases for it.
Peter Krempa (14):
qemuxml2argvtest: Use real caps in "graphics-vnc-tls" case
On Thu, Sep 23, 2021 at 17:08:02 +0200, Kristina Hanicova wrote:
> This patch changes the way functions return bool value from
> pattern:
>
> if (functionCall() < 0)
> return false;
>
> return true;
>
> into a more readable and modern way of direct return:
>
> return
On Thu, Sep 23, 2021 at 17:08:00 +0200, Kristina Hanicova wrote:
> This patch includes small refactoring such as:
> * early return in case of an error - helps with indentation
> * removal of 'else' branch after return - unnecessary
> * altering code to be more consistent with the rest of the file
This patch includes:
* fix of a mistake in cmdMigrateSetMaxDowntime() - function
returned false when it should have returned true
* use of an early return in case of an error
* removal of unnecessary variables and extra labels
* returning value directly
Signed-off-by: Kristina Hanicova
---
This patch targets smaller functions and rewrites them into the
pattern using an early return without needing redundant 'ret'
variable (if possible).
Patch also includes removal of 'else' branch after 'return' and
other small alterations.
Signed-off-by: Kristina Hanicova
---
tools/virsh-host.c
This patch refactors a few bigger functions mainly trying to
remove too deep indentation and make them more readable and more
consistent with the rest of the file.
Signed-off-by: Kristina Hanicova
---
tools/virsh-domain.c | 203 ---
tools/virsh-host.c |
This patch changes the way functions return bool value from
pattern:
if (functionCall() < 0)
return false;
return true;
into a more readable and modern way of direct return:
return functionCall() == 0;
I know that not everybody will agree this is more readable so I
am open
This series targets some alterations to make the code more readable and
consistent.
Kristina Hanicova (5):
virsh: checkpoint & domain-monitor: small refactoring
virsh: domain: refactoring of small functions
virsh: domain: change the way functions return bool value
virsh: domain, host &
This patch includes small refactoring such as:
* early return in case of an error - helps with indentation
* removal of 'else' branch after return - unnecessary
* altering code to be more consistent with the rest of the file -
function calls inside of parentheses, etc.
* removal of unnecessary
On Thu, Sep 23, 2021 at 04:07:17PM +0200, Victor Toso wrote:
> Hi,
>
> On Thu, Sep 23, 2021 at 11:47:58AM +0100, Daniel P. Berrangé wrote:
> > In order to auto-generate more of the language binding code, it is
> > desirable to know what libvirt version an API was introduced in.
> > We can extract
Hi,
On Thu, Sep 23, 2021 at 11:47:58AM +0100, Daniel P. Berrangé wrote:
> In order to auto-generate more of the language binding code, it is
> desirable to know what libvirt version an API was introduced in.
> We can extract this information from the .syms files and expose
> it in the API
Commit a50c473ad6c988a2 removed last use of 'cfg' from
qemuDomainMemoryPeek and qemuDomainScreenshot triggering a compile time
warning.
Fixes: a50c473ad6c988a249bf79a30fb7c6dc19733347
Signed-off-by: Peter Krempa
---
Build-fix && trivial. Pushed.
src/qemu/qemu_driver.c | 4
1 file
On 9/15/21 5:30 PM, Luke Yue wrote:
> v4:
> - Rebase to current master branch
> - Add the forgotten virObjectUnlock(vm) in PATCH 09/11
> - Refine tests
>
> CI link: https://gitlab.com/lukedyue/libvirt/-/pipelines/371315349
>
> Luke Yue (11):
> domain_driver.c: Introduce and use
On 9/23/21 12:47 PM, Daniel P. Berrangé wrote:
> In order to auto-generate more of the language binding code, it is
> desirable to know what libvirt version an API was introduced in.
> We can extract this information from the .syms files and expose
> it in the API description
>
> eg instead of
>
In order to auto-generate more of the language binding code, it is
desirable to know what libvirt version an API was introduced in.
We can extract this information from the .syms files and expose
it in the API description
eg instead of
we now have
This will benefit this proposal:
On 9/13/21 4:23 PM, Peng Liang wrote:
> See path 2 for detail.
>
> v2 -> v3:
> - Change the directory to put the temp files of screenshot and
> memorypeek from autoDumpPath to per-domain directory [Daniel]
>
> v1 -> v2:
> - Add commit message for path1 [Peter]
>
> Peng Liang (2):
> qemu: move
Vladimir Sementsov-Ogievskiy writes:
> Thanks a lot for reviewing!
>
> 20.09.2021 09:44, Markus Armbruster wrote:
>> Vladimir Sementsov-Ogievskiy writes:
>>
>>> Add command that can add and remove filters.
>>>
>>> Key points of functionality:
>>>
>>> What the command does is simply replace
On Thu, 2021-09-23 at 11:23 +0200, Tim Wiederhake wrote:
> When building with "CC=clang", "-Db_sanitize=address,undefined", and
> "-Dbuildtype=debug", the following error occurs:
>
> ../src/conf/nwfilter_conf.c:2190:1: error: stack frame size of
> 10616
> bytes in function
When building with "CC=clang", "-Db_sanitize=address,undefined", and
"-Dbuildtype=debug", the following error occurs:
../src/conf/nwfilter_conf.c:2190:1: error: stack frame size of 10616
bytes in function 'virNWFilterRuleDefFixup' [-Werror,-Wframe-larger-than=]
On 9/20/21 3:49 PM, Peter Krempa wrote:
> This series is based on Markus' effort to add 'feature' flags to enum
> values so that e.g. they can be deprecated:
>
> https://listman.redhat.com/archives/libvir-list/2021-September/msg00453.html
>
> This series adapts both the schema query language to
On Mon, Sep 20, 2021 at 19:21:28 +0200, Tim Wiederhake wrote:
> Signed-off-by: Tim Wiederhake
> ---
> src/conf/nwfilter_conf.c | 284 ---
> 1 file changed, 143 insertions(+), 141 deletions(-)
>
> diff --git a/src/conf/nwfilter_conf.c
On Thu, Sep 23, 2021 at 09:56:01AM +0200, Michal Prívozník wrote:
> On 9/20/21 7:21 PM, Tim Wiederhake wrote:
> > This is an alternative to
> > https://listman.redhat.com/archives/libvir-list/2021-September/msg00522.html.
> >
> > When libvirt is build:
> > * with sanitizers enabled,
> > *
On 9/21/21 7:30 PM, Erik Skultety wrote:
> Commit b5e8db8f14d tuned the SPEC file so that libvirt daemons restart
> on package upgrade. In order to do that it added a bunch of
> parametrized macros using the %global directive. This caused a problem
> when running RPM builds on CentOS Stream 8
On 9/20/21 7:21 PM, Tim Wiederhake wrote:
> This is an alternative to
> https://listman.redhat.com/archives/libvir-list/2021-September/msg00522.html.
>
> When libvirt is build:
> * with sanitizers enabled,
> * buildtype explicitly set to "debug",
> * on clang,
>
> the build fails with:
>
>
62 matches
Mail list logo
