Re: [PATCH v3 2/5] qemu: capablities: detect presence of acpi-root-pci-hotplug for i440fx machines

2021-09-25 Thread Laine Stump
On 9/11/21 11:26 PM, Ani Sinha wrote: The following change in qemu added support for a global boolean flag specific to i440fx machines that would turn off or on acpi based hotplug for pci root bus: 3d7e78aaf ("Introduce a new flag for i440fx to disable PCI hotplug on the root bus") The

Re: [PATCH v3 1/5] qemu: capablities: detect presence of acpi-pci-hotplug-with-bridge-support

2021-09-25 Thread Laine Stump
On 9/11/21 11:26 PM, Ani Sinha wrote: qemu added support for i440fx specific global boolean flag PIIX4_PM.acpi-pci-hotplug-with-bridge-support around version 2.1. This flag is enabled by default. When disabled, it turns off acpi pci hotplug for cold plugged pci bridges in i440fx machine types.

Re: [PATCH v3 0/5] Add support for two i386 pm options which control acpi hotplug

2021-09-25 Thread Ani Sinha
Ok then let me do this. I will split up this patch set and send out a separate patch set just for acpi-hotplug-root with the conf change as suggested by danpb. It makes sense for me too to go down the path of his suggestion. Meanwhile let's figure out what we wanted to do for acpi-hotplug-bridge.

Re: [PATCH v3 0/5] Add support for two i386 pm options which control acpi hotplug

2021-09-25 Thread Laine Stump
On 9/23/21 4:46 PM, Laine Stump wrote: On 9/11/21 11:26 PM, Ani Sinha wrote: Hi all: This patchset introduces libvirt xml support for the following two pm conf options:       (before I get into a more radical discussion about different options - since we aren't exactly duplicating

Re: [libvirt PATCH 0/4] qemu: deprecate more capabilities

2021-09-25 Thread Michal Prívozník
On 9/24/21 5:30 PM, Ján Tomko wrote: > Applies on top of my seccomp sandbox series. > > Ján Tomko (4): > qemu: assume QEMU_CAPS_MACHINE_KERNEL_IRQCHIP > qemu: Deprecate QEMU_CAPS_MACHINE_KERNEL_IRQCHIP > qemu: assume QEMU_CAPS_FSDEV_CREATEMODE > qemu: deprecate QEMU_CAPS_FSDEV_CREATEMODE

Re: [libvirt PATCH 0/5] qemu: simplify seccomp sandbox

2021-09-25 Thread Michal Prívozník
On 9/24/21 4:28 PM, Ján Tomko wrote: > Inspired by Peter's q-c-l-o cleanups. > > Ján Tomko (5): > qemu: always assume QEMU_CAPS_SECCOMP_BLACKLIST > qemu: conf: simplify seccomp_sandbox comment > qemu: seccomp: remove dead code > qemu: capabilities: deprecate QEMU_CAPS_SECCOMP_BLACKLIST >

Re: [PATCH v2 0/2] virsh: domain: rework cmdMigrateSetMaxDowntime()

2021-09-25 Thread Michal Prívozník
On 9/24/21 1:30 AM, Kristina Hanicova wrote: > This patch is partially v2 of: > https://listman.redhat.com/archives/libvir-list/2021-September/msg00728.html > > Diff to v1: > * split from previous big patch > * split the fixing part and the refactoring part of the function into > different

Re: [PATCH v2 0/7] virsh: domain: small refactoring

2021-09-25 Thread Michal Prívozník
On 9/24/21 5:17 PM, Kristina Hanicova wrote: > This is partially v2 of: > https://listman.redhat.com/archives/libvir-list/2021-September/msg00728.html > > Diff to v1: > * split changes into smaller patches > > Kristina Hanicova (7): > virsh: domain: use early return in virshDomainDefine() >

Re: [PATCH v3 0/5] Add support for two i386 pm options which control acpi hotplug

2021-09-25 Thread Ani Sinha
DanPB, Could you please reiterate the suggestion regarding the placement of the pci root hotplug xml you made in the irc channel? On Fri, Sep 24, 2021 at 02:16 Laine Stump wrote: > On 9/11/21 11:26 PM, Ani Sinha wrote: > > Hi all: > > > > This patchset introduces libvirt xml support for the