Re: [PATCH v3 0/5] Add support for two i386 pm options which control acpi hotplug

On Tue, 28 Sep 2021, Daniel P. Berrangé wrote: > On Tue, Sep 28, 2021 at 06:14:12PM +0530, Ani Sinha wrote: > > On Tue, Sep 28, 2021 at 17:49 Daniel P. Berrangé > > wrote: > > > > > On Tue, Sep 28, 2021 at 05:31:43PM +0530, Ani Sinha wrote: > > > > > > > > > > > > On Tue, 28 Sep 2021, Daniel P.

Re: [PATCH v3 3/5] conf: introduce acpi-hotplug-bridge and acpi-root-hotplug pm options

On Tue, 28 Sep 2021, Laine Stump wrote: > On 9/28/21 12:54 PM, Ani Sinha wrote: > > > > > > On Tue, Sep 28, 2021 at 10:17 PM Laine Stump > > wrote: > > > > On 9/28/21 4:44 AM, Daniel P. Berrangé wrote: > > > On Sun, Sep 12, 2021 at 08:56:29AM +0530, Ani Sinha w

Re: [PATCH v3 3/5] conf: introduce acpi-hotplug-bridge and acpi-root-hotplug pm options

On 9/28/21 12:54 PM, Ani Sinha wrote: On Tue, Sep 28, 2021 at 10:17 PM Laine Stump > wrote: On 9/28/21 4:44 AM, Daniel P. Berrangé wrote: > On Sun, Sep 12, 2021 at 08:56:29AM +0530, Ani Sinha wrote: >> This change introduces libvirt xml support for the f

Re: [PATCH v3 0/5] Add support for two i386 pm options which control acpi hotplug

On Tue, Sep 28, 2021 at 10:21 PM Daniel P. Berrangé wrote: > On Tue, Sep 28, 2021 at 06:14:12PM +0530, Ani Sinha wrote: > > On Tue, Sep 28, 2021 at 17:49 Daniel P. Berrangé > > wrote: > > > > > On Tue, Sep 28, 2021 at 05:31:43PM +0530, Ani Sinha wrote: > > > > > > > > > > > > On Tue, 28 Sep 2021

Re: [PATCH v3 3/5] conf: introduce acpi-hotplug-bridge and acpi-root-hotplug pm options

On Tue, Sep 28, 2021 at 10:17 PM Laine Stump wrote: > On 9/28/21 4:44 AM, Daniel P. Berrangé wrote: > > On Sun, Sep 12, 2021 at 08:56:29AM +0530, Ani Sinha wrote: > >> This change introduces libvirt xml support for the following two pm > options: > >> > >> > >> > >> > >> > > > > > >> +`

Re: [PATCH v3 0/5] Add support for two i386 pm options which control acpi hotplug

On Tue, Sep 28, 2021 at 06:14:12PM +0530, Ani Sinha wrote: > On Tue, Sep 28, 2021 at 17:49 Daniel P. Berrangé > wrote: > > > On Tue, Sep 28, 2021 at 05:31:43PM +0530, Ani Sinha wrote: > > > > > > > > > On Tue, 28 Sep 2021, Daniel P. Berrangé wrote: > > > > > > > On Thu, Sep 23, 2021 at 04:46:38PM

Re: [PATCH v3 3/5] conf: introduce acpi-hotplug-bridge and acpi-root-hotplug pm options

On 9/28/21 4:44 AM, Daniel P. Berrangé wrote: On Sun, Sep 12, 2021 at 08:56:29AM +0530, Ani Sinha wrote: This change introduces libvirt xml support for the following two pm options: +``acpi-hotplug-bridge`` + :since:`Since 7.8.0` This option enables or disables BIOS ACPI based

Re: [libvirt][PATCH v7 5/5] Add get domaincaps unit test

On Wed, Sep 08, 2021 at 09:15:58AM +0800, Haibin Huang wrote: > Signed-off-by: Haibin Huang > --- > tests/domaincapsdata/bhyve_basic.x86_64.xml | 1 + > tests/domaincapsdata/bhyve_fbuf.x86_64.xml| 1 + > tests/domaincapsdata/bhyve_uefi.x86_64.xml| 1 + > tests/domaincapsdata

Re: [libvirt][PATCH v7 4/5] Support to query SGX capability

On Wed, Sep 08, 2021 at 09:15:57AM +0800, Haibin Huang wrote: > 1.Add SGX feature in domain capabilities > 2.Get sgx capabilities by query-sgx-capabilities I think we'd generally prefer it if the domain capabilities additions are separate from the QEMU Driver capabilities probe. So I think I'd

Re: [libvirt][PATCH v7 2/5] qemu: Add command-line to generate SGX EPC memory backend

On Wed, Sep 08, 2021 at 09:15:55AM +0800, Haibin Huang wrote: > From: Lin Yang > > According to the result parsing from xml, add the argument of > SGX EPC memory backend into QEMU command line: > > #qemu-system-x86_64 \ > .. \ > -object memory-backend-epc,id=mem1,size=64M

Re: [libvirt][PATCH v7 1/5] conf: Introduce SGX EPC element into device memory xml

On Wed, Sep 08, 2021 at 09:15:54AM +0800, Haibin Huang wrote: > From: Lin Yang > > > ... > > > 512 > > > ... > > --- > docs/schemas/domaincommon.rng| 1 + > src/conf/domain_conf.c | 5 + > src/conf/domain_conf.h | 1 + > src/conf/domain_val

Re: [libvirt][PATCH v7 1/5] conf: Introduce SGX EPC element into device memory xml

On Wed, Sep 08, 2021 at 09:15:54AM +0800, Haibin Huang wrote: > From: Lin Yang > > > ... > > > 512 > > > ... > > --- > docs/schemas/domaincommon.rng| 1 + > src/conf/domain_conf.c | 5 + > src/conf/domain_conf.h | 1 + > src/conf/domain_val

Re: [PATCH v3 0/5] Add support for two i386 pm options which control acpi hotplug

On Tue, Sep 28, 2021 at 17:49 Daniel P. Berrangé wrote: > On Tue, Sep 28, 2021 at 05:31:43PM +0530, Ani Sinha wrote: > > > > > > On Tue, 28 Sep 2021, Daniel P. Berrangé wrote: > > > > > On Thu, Sep 23, 2021 at 04:46:38PM -0400, Laine Stump wrote: > > > > On 9/11/21 11:26 PM, Ani Sinha wrote: > >

Re: [PATCH v3 0/5] Add support for two i386 pm options which control acpi hotplug

On Tue, Sep 28, 2021 at 05:31:43PM +0530, Ani Sinha wrote: > > > On Tue, 28 Sep 2021, Daniel P. Berrangé wrote: > > > On Thu, Sep 23, 2021 at 04:46:38PM -0400, Laine Stump wrote: > > > On 9/11/21 11:26 PM, Ani Sinha wrote: > > > > Hi all: > > > > > > > > This patchset introduces libvirt xml supp

Re: [PATCH v3 0/5] Add support for two i386 pm options which control acpi hotplug

On Tue, 28 Sep 2021, Daniel P. Berrangé wrote: > On Thu, Sep 23, 2021 at 04:46:38PM -0400, Laine Stump wrote: > > On 9/11/21 11:26 PM, Ani Sinha wrote: > > > Hi all: > > > > > > This patchset introduces libvirt xml support for the following two pm conf > > > options: > > > > > > > > > > > >

Re: [libvirt PATCH] scripts: include function versions in API definition

Hi, On Thu, Sep 23, 2021 at 03:24:22PM +0100, Daniel P. Berrangé wrote: > On Thu, Sep 23, 2021 at 04:07:17PM +0200, Victor Toso wrote: > > Hi, > > > > On Thu, Sep 23, 2021 at 11:47:58AM +0100, Daniel P. Berrangé wrote: > > > In order to auto-generate more of the language binding code, it is > > >

Re: [PATCH v3 0/5] Add support for two i386 pm options which control acpi hotplug

On Thu, Sep 23, 2021 at 04:46:38PM -0400, Laine Stump wrote: > On 9/11/21 11:26 PM, Ani Sinha wrote: > > Hi all: > > > > This patchset introduces libvirt xml support for the following two pm conf > > options: > > > > > > > > > > > > (before I get into a more radical discussion about di

Re: [PATCH v3 3/5] conf: introduce acpi-hotplug-bridge and acpi-root-hotplug pm options

On Tue, 28 Sep 2021, Daniel P. Berrangé wrote: > On Tue, Sep 28, 2021 at 03:28:04PM +0530, Ani Sinha wrote: > > > > > > On Tue, 28 Sep 2021, Daniel P. Berrangé wrote: > > > > > On Tue, Sep 28, 2021 at 02:35:47PM +0530, Ani Sinha wrote: > > > > > > > > > > > > On Tue, 28 Sep 2021, Daniel P. Berra

Re: [PATCH v3 3/5] conf: introduce acpi-hotplug-bridge and acpi-root-hotplug pm options

On Tue, Sep 28, 2021 at 11:47:26AM +0100, Daniel P. Berrangé wrote: > On Tue, Sep 28, 2021 at 03:28:04PM +0530, Ani Sinha wrote: > > > > > > On Tue, 28 Sep 2021, Daniel P. Berrangé wrote: > > > > > On Tue, Sep 28, 2021 at 02:35:47PM +0530, Ani Sinha wrote: > > > > > > > > > > > > On Tue, 28 Sep

Re: [PATCH v3 3/5] conf: introduce acpi-hotplug-bridge and acpi-root-hotplug pm options

On Tue, Sep 28, 2021 at 03:28:04PM +0530, Ani Sinha wrote: > > > On Tue, 28 Sep 2021, Daniel P. Berrangé wrote: > > > On Tue, Sep 28, 2021 at 02:35:47PM +0530, Ani Sinha wrote: > > > > > > > > > On Tue, 28 Sep 2021, Daniel P. Berrangé wrote: > > > > > > > On Sun, Sep 12, 2021 at 08:56:29AM +0530

Re: [PATCH v3 3/5] conf: introduce acpi-hotplug-bridge and acpi-root-hotplug pm options

On Tue, Sep 28, 2021 at 3:28 PM Ani Sinha wrote: > > > > On Tue, 28 Sep 2021, Daniel P. Berrangé wrote: > > > On Tue, Sep 28, 2021 at 02:35:47PM +0530, Ani Sinha wrote: > > > > > > > > > On Tue, 28 Sep 2021, Daniel P. Berrangé wrote: > > > > > > > On Sun, Sep 12, 2021 at 08:56:29AM +0530, Ani Sinh

Re: [PATCH v3 3/5] conf: introduce acpi-hotplug-bridge and acpi-root-hotplug pm options

On Tue, 28 Sep 2021, Daniel P. Berrangé wrote: > On Tue, Sep 28, 2021 at 02:35:47PM +0530, Ani Sinha wrote: > > > > > > On Tue, 28 Sep 2021, Daniel P. Berrangé wrote: > > > > > On Sun, Sep 12, 2021 at 08:56:29AM +0530, Ani Sinha wrote: > > > > This change introduces libvirt xml support for the f

Re: [PATCH v3 3/5] conf: introduce acpi-hotplug-bridge and acpi-root-hotplug pm options

On Tue, Sep 28, 2021 at 02:35:47PM +0530, Ani Sinha wrote: > > > On Tue, 28 Sep 2021, Daniel P. Berrangé wrote: > > > On Sun, Sep 12, 2021 at 08:56:29AM +0530, Ani Sinha wrote: > > > This change introduces libvirt xml support for the following two pm > > > options: > > > > > > > > > > > >

Re: [PATCH v3 3/5] conf: introduce acpi-hotplug-bridge and acpi-root-hotplug pm options

On Tue, 28 Sep 2021, Daniel P. Berrangé wrote: > On Sun, Sep 12, 2021 at 08:56:29AM +0530, Ani Sinha wrote: > > This change introduces libvirt xml support for the following two pm options: > > > > > > > > > > > > > > +``acpi-hotplug-bridge`` > > + :since:`Since 7.8.0` This option enabl

Re: [PATCH v3 3/5] conf: introduce acpi-hotplug-bridge and acpi-root-hotplug pm options

On Sun, Sep 12, 2021 at 08:56:29AM +0530, Ani Sinha wrote: > This change introduces libvirt xml support for the following two pm options: > > > > > > +``acpi-hotplug-bridge`` > + :since:`Since 7.8.0` This option enables or disables BIOS ACPI based > hotplug support > + for cold plug

Re: [PATCH v6 0/4] Add support to enable/disable hotplug on pci-root controller

On Tue, Sep 28, 2021 at 07:49:38AM +0530, Ani Sinha wrote: > changelog: > > v6: incorporated Jan's suggestions. > v5: incorporated suggestions from Laine for patches #2 and #3. The qemu > command line > is now added in a new function and called from > qemuBuildControllersByTypeCommandLine()