On Sun, 2021-10-03 at 15:52 -0400, Laine Stump wrote:
> On 10/3/21 3:43 PM, Laine Stump wrote:
> > cleanup:
> > + if (mon)
> > + virCHMonitorClose(mon);
>
> Oops, I also meant to point out that the "if (mon)" is unnecessary
> here,
> because (as with all similar functions in
On 10/3/21 3:43 PM, Laine Stump wrote:
cleanup:
+ if (mon)
+ virCHMonitorClose(mon);
Oops, I also meant to point out that the "if (mon)" is unnecessary here,
because (as with all similar functions in libvirt) virCHMonitorClose()
can be called with a null argument, and will just
On 10/1/21 2:12 PM, William Douglas wrote:
Signed-off-by: William Douglas
---
src/ch/ch_monitor.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/src/ch/ch_monitor.c b/src/ch/ch_monitor.c
index 800457af41..7326ac645b 100644
--- a/src/ch/ch_monitor.c
+++
On 10/1/21 2:12 PM, William Douglas wrote:
In virCHMontiorNew the monitor object is referenced an additional time
incorrectly preventing it from being disposed of. Because the disposal
wasn't being used, a bug in virCHMonitorClose that would incorrectly
unref the domain object wasn't being seen.
On 10/1/21 2:12 PM, William Douglas wrote:
In virCHMonitorBuildKernelRelatedJson there are two cases of json
value objects being lost after the pointer being redefined. This
change removes the needless redefinition.
Signed-off-by: William Douglas
Reviewed-by: Laine Stump
