Re: [PATCH 0/8] virsh: Use g_autoptr() for public types

2021-10-05 Thread Jonathon Jongsma
For the series: Acked-by: Jonathon Jongsma On Mon, Sep 27, 2021 at 12:11 AM Michal Privoznik wrote: > > In this patchset I'm switching from virXXXFree to g_autoptr(). There are > still some left, but very rare occurrence: > > libvirt.git $ git grep -o "vir[A-Z].*Free" -- tools/ | \ >

Re: [libvirt PATCH v3 2/9] virthread: Introduce virLockGuard

2021-10-05 Thread Jonathon Jongsma
On Thu, Sep 30, 2021 at 6:29 AM Tim Wiederhake wrote: > > Locks a virMutex on creation and unlocks it in its destructor. > > The VIR_LOCK_GUARD macro is used instead of "g_autoptr(virLockGuard)" to > work around a clang issue (see https://bugs.llvm.org/show_bug.cgi?id=3888 > and

Re: [PATCH 3/3] qemu: Add support for virtio device option paeg-per-vq

2021-10-05 Thread Jonathon Jongsma
On Fri, Sep 17, 2021 at 3:17 PM Jonathon Jongsma wrote: > > On Thu, Sep 9, 2021 at 6:51 AM Michal Prívozník wrote: > > > > On 9/6/21 4:06 PM, Han Han wrote: > > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1925363 > > > > > > Signed-off-by: Han Han > > > --- > > >

Re: [PATCH 09/11] qdev: Avoid QemuOpts in QMP device_add

2021-10-05 Thread Kevin Wolf
Am 05.10.2021 um 17:52 hat Damien Hedde geschrieben: > > > On 10/5/21 16:37, Kevin Wolf wrote: > > Am 27.09.2021 um 13:39 hat Kevin Wolf geschrieben: > > > Am 27.09.2021 um 13:06 hat Damien Hedde geschrieben: > > > > On 9/24/21 11:04, Kevin Wolf wrote: > > > > > Directly call

[libvirt PATCH 2/2] qemu: remove use of implicit boolean syntax for -cpu features

2021-10-05 Thread Daniel P . Berrangé
Some CPU features are still added using implicit syntax "feature" which is a deprecated shorthand for "feature=on". Signed-off-by: Daniel P. Berrangé --- src/qemu/qemu_command.c | 6 +++--- tests/qemuxml2argvdata/clock-timer-hyperv-rtc.args | 2 +-

[libvirt PATCH 1/2] qemu: remove use of (+|-)name syntax for -cpu featres

2021-10-05 Thread Daniel P . Berrangé
The -cpu arg gained support for feature=on|off syntax for the x86 emulator in 2.4.0 commit 38e5c119c2925812bd441450ab9e5e00fc79e662 Author: Eduardo Habkost Date: Mon Mar 23 17:29:32 2015 -0300 target-i386: Register QOM properties for feature flags Most other targets gained this

[libvirt PATCH 0/2] qemu: changes to use feature=on|off syntax for -cpu unconditionally

2021-10-05 Thread Daniel P . Berrangé
Given our min QEMU, it doesn't seem like we need to support either the old "-feature" / "+feature" syntax, nor the bare "feature" syntax. Daniel P. Berrangé (2): qemu: remove use of (+|-)name syntax for -cpu featres qemu: remove use of implicit boolean syntax for -cpu features

Re: [PATCH 09/11] qdev: Avoid QemuOpts in QMP device_add

2021-10-05 Thread Damien Hedde
On 10/5/21 16:37, Kevin Wolf wrote: Am 27.09.2021 um 13:39 hat Kevin Wolf geschrieben: Am 27.09.2021 um 13:06 hat Damien Hedde geschrieben: On 9/24/21 11:04, Kevin Wolf wrote: Directly call qdev_device_add_from_qdict() for QMP device_add instead of first going through QemuOpts and

[PATCH v2 0/5] Add support for librbd encryption

2021-10-05 Thread Or Ozeri
Changes from v1: addressed (hopefully) all of Peter's v1 comments (thanks Peter!) Or Ozeri (5): qemu: add disk post parse to qemublocktest qemu: add rbd encryption capability probing conf: add luks2 encryption format conf: add encryption engine property qemu: add librbd encryption

[PATCH v2 4/5] conf: add encryption engine property

2021-10-05 Thread Or Ozeri
This commit extends libvirt XML configuration to support a custom encryption engine. This means that becomes valid. The only engine for now is qemu. However, a new engine (librbd) will be added in an upcoming commit. If no engine is specified, qemu will be used (assuming qemu driver is used).

[PATCH v2 1/5] qemu: add disk post parse to qemublocktest

2021-10-05 Thread Or Ozeri
The post parse callback is part of the real (non-test) processing flow. This commit adds it (for disks) to the qemublocktest flow as well. Signed-off-by: Or Ozeri --- src/qemu/qemu_domain.c | 2 +- src/qemu/qemu_domain.h | 4 tests/qemublocktest.c | 3 +++ 3 files changed, 8

[PATCH v2 3/5] conf: add luks2 encryption format

2021-10-05 Thread Or Ozeri
This commit extends libvirt XML configuration to support luks2 encryption format. This means that becomes valid. Actual handler (other than returning "not supported") for this new format will be added in an upcoming commit. Signed-off-by: Or Ozeri --- docs/formatstorageencryption.html.in | 2

[PATCH v2 5/5] qemu: add librbd encryption engine

2021-10-05 Thread Or Ozeri
rbd encryption is new in qemu 6.1.0. This commit adds a new encryption engine property which allows the user to use this new encryption engine. Signed-off-by: Or Ozeri --- docs/formatstorageencryption.html.in | 2 +- docs/schemas/storagecommon.rng| 1 +

[PATCH v2 2/5] qemu: add rbd encryption capability probing

2021-10-05 Thread Or Ozeri
rbd encryption is new in qemu 6.1.0. This commit adds capability probing for it. Signed-off-by: Or Ozeri --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + tests/qemucapabilitiesdata/caps_6.1.0.x86_64.xml | 1 + 3 files changed,

Re: [PATCH 09/11] qdev: Avoid QemuOpts in QMP device_add

2021-10-05 Thread Kevin Wolf
Am 27.09.2021 um 13:39 hat Kevin Wolf geschrieben: > Am 27.09.2021 um 13:06 hat Damien Hedde geschrieben: > > On 9/24/21 11:04, Kevin Wolf wrote: > > > Directly call qdev_device_add_from_qdict() for QMP device_add instead of > > > first going through QemuOpts and converting back to QDict. > > > >

Cancellation of VM core dumps

2021-10-05 Thread Simon Rowe
I see that cancellation of core dump jobs that are memory-only are explicitly rejected >>> d.abortJob() libvirt: QEMU Driver error : Requested operation is not valid: cannot abort memory-only dump Traceback (most recent call last): File "", line 1, in File

Re: [PATCH] qemu: Check if unpriv_sgio is already set before trying to set it

2021-10-05 Thread Ján Tomko
On a Tuesday in 2021, Michal Privoznik wrote: In case when libvirt runs inside a restricted container it may not have enough permissions to modify unpriv_sgio. However, it may have been set beforehand by sysadmin or an orchestration tool. Therefore, let's check whether the currently set value is

[PATCH] qemu: Check if unpriv_sgio is already set before trying to set it

2021-10-05 Thread Michal Privoznik
In case when libvirt runs inside a restricted container it may not have enough permissions to modify unpriv_sgio. However, it may have been set beforehand by sysadmin or an orchestration tool. Therefore, let's check whether the currently set value is the one we want and if it is refrain from

Re: [PATCH 06/11] qdev: Add Error parameter to qdev_set_id()

2021-10-05 Thread Kevin Wolf
Am 27.09.2021 um 12:33 hat Damien Hedde geschrieben: > Hi Kevin, > > I proposed a very similar patch in our rfc series because we needed some of > the cleaning you do here. > https://lists.gnu.org/archive/html/qemu-devel/2021-09/msg05679.html > I've added a bit of doc for the function, feel free