Ups, a horse on fire... ? :-)
Sorry about it and thanks for saddling it.
On 10/6/21 11:16 AM, Andrea Bolognani wrote:
Signed-off-by: Andrea Bolognani
---
Pushed as trivial.
tools/virt-host-validate-common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
On Tue, Aug 10, 2021 at 05:02:54AM -0700, Andrea Bolognani wrote:
> On Tue, Aug 10, 2021 at 11:05:42AM +0100, Daniel P. Berrangé wrote:
> > On Mon, Aug 09, 2021 at 05:13:29PM +0200, Andrea Bolognani wrote:
> > > The version coming from the rst2html5 package instead of the
> > > docutils package is
With cgroup v1 I'm seeing LXC container startup failures:
$ sudo virt-install --connect lxc:/// --name test-container --memory 128
--boot init=/bin/sh
Starting install...
ERRORerror from service:
GDBus.Error:org.freedesktop.machine1.NoMachineForPID: PID 2145047 does
not belong to any known
On Thu, 30 Sep 2021 13:33:24 +0200
Peter Krempa wrote:
> On Tue, Sep 21, 2021 at 16:50:30 +0200, Michal Privoznik wrote:
> > Signed-off-by: Michal Privoznik
> > ---
> > src/qemu/qemu_command.c | 43 ++---
> > 1 file changed, 27 insertions(+), 16 deletions(-)
On Thu, 30 Sep 2021 14:08:34 +0200
Peter Krempa wrote:
> On Tue, Sep 21, 2021 at 16:50:31 +0200, Michal Privoznik wrote:
> > QEMU is trying to obsolete -numa node,cpus= because that uses
> > ambiguous vCPU id to [socket, die, core, thread] mapping. The new
> > form is:
> >
> > -numa
Kevin Wolf wrote:
> Am 05.10.2021 um 17:52 hat Damien Hedde geschrieben:
Hi
>> > Usage
>> > -
>> >
>> > The primary device can be hotplugged or be part of the startup
>> > configuration
>> >
>> > -device virtio-net-pci,netdev=hostnet1,id=net1,
>> >
On 06/10/2021 12:53, Kevin Wolf wrote:
Am 06.10.2021 um 11:20 hat Laurent Vivier geschrieben:
On 06/10/2021 10:21, Juan Quintela wrote:
Kevin Wolf wrote:
Am 05.10.2021 um 17:52 hat Damien Hedde geschrieben:
Hi
Usage
-
The primary device can be hotplugged or be part of the startup
Am 06.10.2021 um 11:20 hat Laurent Vivier geschrieben:
> On 06/10/2021 10:21, Juan Quintela wrote:
> > Kevin Wolf wrote:
> > > Am 05.10.2021 um 17:52 hat Damien Hedde geschrieben:
> >
> > Hi
> >
> > > > > Usage
> > > > > -
> > > > >
> > > > > The primary device can be hotplugged or be part
Signed-off-by: Ján Tomko
---
src/conf/domain_conf.c | 24 +++
src/conf/domain_conf.h | 2 +
src/libvirt_private.syms | 1 +
src/qemu/qemu_hotplug.c | 87 +++-
4 files changed, 112 insertions(+), 2 deletions(-)
diff --git
rbd encryption is new in qemu 6.1.0.
This commit adds a new encryption engine property which
allows the user to use this new encryption engine.
Signed-off-by: Or Ozeri
---
docs/formatstorageencryption.html.in | 2 +-
docs/schemas/storagecommon.rng| 1 +
This commit extends libvirt XML configuration to support luks2 encryption
format.
This means that becomes valid.
Actual handler (other than returning "not supported") for this new format will
be added in an upcoming commit.
Signed-off-by: Or Ozeri
---
docs/formatstorageencryption.html.in | 2
v3: rebased on master
v2: addressed (hopefully) all of Peter's v1 comments (thanks Peter!)
Or Ozeri (5):
qemu: add disk post parse to qemublocktest
qemu: add rbd encryption capability probing
conf: add luks2 encryption format
conf: add encryption engine property
qemu: add librbd
The post parse callback is part of the real (non-test) processing flow.
This commit adds it (for disks) to the qemublocktest flow as well.
Specifically, this will be needed for tests that use luks encryption,
so that the default encryption engine (which is added in an upcoming commit)
will be
This reverts commit b164eac5e1d4ebe17e673f0427b70f862a670f94
Signed-off-by: Ján Tomko
---
src/qemu/qemu_extdevice.c | 1 -
src/qemu/qemu_extdevice.h | 1 -
src/qemu/qemu_process.c | 4 +---
3 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/src/qemu/qemu_extdevice.c
https://bugzilla.redhat.com/show_bug.cgi?id=1897708
Signed-off-by: Ján Tomko
---
src/qemu/qemu_driver.c | 9 +++-
src/qemu/qemu_hotplug.c | 99 +
2 files changed, 107 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_driver.c
Do not depend on passing a logManager. Create a new connection.
Signed-off-by: Ján Tomko
---
src/qemu/qemu_extdevice.c | 4 ++--
src/qemu/qemu_virtiofs.c | 8 ++--
src/qemu/qemu_virtiofs.h | 3 +--
3 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/src/qemu/qemu_extdevice.c
rbd encryption is new in qemu 6.1.0.
This commit adds capability probing for it.
Signed-off-by: Or Ozeri
---
src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 1 +
tests/qemucapabilitiesdata/caps_6.1.0.x86_64.xml | 1 +
3 files changed,
Signed-off-by: Ján Tomko
---
src/logging/log_manager.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/logging/log_manager.h b/src/logging/log_manager.h
index 9a8f9b6af8..80f14934d7 100644
--- a/src/logging/log_manager.h
+++ b/src/logging/log_manager.h
@@ -27,6 +27,8 @@ typedef struct
diff to v1
* do not store logCtxt in private data
* qemuDomainGetVHostUserChrSourceDef inlined in the only function
that uses it
* a new connection to the logManager is opened when virtiofsd is started
* use VIR_APPEND_ELEMENT_COPY to reuse 'fs' on the successful audit
* qemuDomainRemoveFSDevice
This commit extends libvirt XML configuration to support a custom encryption
engine.
This means that becomes valid.
The only engine for now is qemu. However, a new engine (librbd) will be added
in an upcoming commit.
If no engine is specified, qemu will be used (assuming qemu driver is used).
On Wed, Oct 06, 2021 at 09:55:10 +, Or Ozeri wrote:
>My commit which adds the encryption engine configuration is default to
>"default".
>Only in the post-parse callback in the qemu driver, I switch it from
>"default" to "qemu".
>Thus, if you don't call the post-parse on
My commit which adds the encryption engine configuration is default to "default".Only in the post-parse callback in the qemu driver, I switch it from "default" to "qemu".Thus, if you don't call the post-parse on this test, then tests which use luks format
On 06/10/2021 10:21, Juan Quintela wrote:
Kevin Wolf wrote:
Am 05.10.2021 um 17:52 hat Damien Hedde geschrieben:
Hi
Usage
-
The primary device can be hotplugged or be part of the startup
configuration
-device virtio-net-pci,netdev=hostnet1,id=net1,
Signed-off-by: Andrea Bolognani
---
Pushed as trivial.
tools/virt-host-validate-common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/virt-host-validate-common.c
b/tools/virt-host-validate-common.c
index 556223242d..7a5cda4104 100644
---
On Wed, Oct 06, 2021 at 09:15:22 +0200, Ján Tomko wrote:
> Signed-off-by: Ján Tomko
> ---
> src/conf/domain_conf.c | 24
> src/conf/domain_conf.h | 2 +
> src/libvirt_private.syms | 1 +
> src/qemu/qemu_hotplug.c | 81 +++-
> 4 files
On Tue, Oct 05, 2021 at 10:41:47PM -0600, Jim Fehlig wrote:
> virt-host-validate checks if AMD SEV is enabled by verifying
> /sys/module/kvm_amd/parameters/sev is set to '1'. On a system
> running kernel 5.13, the parameter is reported as 'Y'. To be
> extra paranoid, add a check for 'y' along with
On Wed, Oct 06, 2021 at 09:15:21 +0200, Ján Tomko wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1897708
>
> Signed-off-by: Ján Tomko
> ---
> src/qemu/qemu_driver.c | 9 +++-
> src/qemu/qemu_hotplug.c | 96 +
> 2 files changed, 104 insertions(+),
On Wed, Oct 06, 2021 at 09:15:19 +0200, Ján Tomko wrote:
> We might need it later for device hotplug.
>
> Signed-off-by: Ján Tomko
> ---
> src/qemu/qemu_domain.h | 11 +++
> src/qemu/qemu_process.c | 5 -
> 2 files changed, 11 insertions(+), 5 deletions(-)
So from the code it
On Wed, Oct 06, 2021 at 09:15:20 +0200, Ján Tomko wrote:
> Remove the local variable in favor of the one stored in priv.
>
> Signed-off-by: Ján Tomko
> ---
> src/qemu/qemu_process.c | 20 +---
> 1 file changed, 9 insertions(+), 11 deletions(-)
>
> diff --git
virt-host-validate checks if AMD SEV is enabled by verifying
/sys/module/kvm_amd/parameters/sev is set to '1'. On a system
running kernel 5.13, the parameter is reported as 'Y'. To be
extra paranoid, add a check for 'y' along with 'Y' to complement
the existing check for '1'.
Fixes:
On Wed, Oct 06, 2021 at 09:15:20 +0200, Ján Tomko wrote:
> Remove the local variable in favor of the one stored in priv.
>
> Signed-off-by: Ján Tomko
> ---
> src/qemu/qemu_process.c | 20 +---
> 1 file changed, 9 insertions(+), 11 deletions(-)
>
> diff --git
On Wed, Oct 06, 2021 at 10:27:48 +0200, Ján Tomko wrote:
> On a Wednesday in 2021, Peter Krempa wrote:
> > On Wed, Oct 06, 2021 at 09:15:16 +0200, Ján Tomko wrote:
> > > Iterate through the array to find the first free index.
> > >
> > > Signed-off-by: Ján Tomko
> > > ---
> > >
On a Wednesday in 2021, Peter Krempa wrote:
On Wed, Oct 06, 2021 at 09:15:16 +0200, Ján Tomko wrote:
Iterate through the array to find the first free index.
Signed-off-by: Ján Tomko
---
src/qemu/qemu_alias.c | 18 ++
1 file changed, 14 insertions(+), 4 deletions(-)
diff
On Wed, Oct 06, 2021 at 09:15:18 +0200, Ján Tomko wrote:
> Prepare for hotplug support.
>
> Signed-off-by: Ján Tomko
> ---
> src/qemu/qemu_alias.c | 2 +-
> src/qemu/qemu_alias.h | 4
> src/qemu/qemu_command.c | 2 +-
> src/qemu/qemu_command.h | 6 ++
> src/qemu/qemu_hotplug.h | 4
On Wed, Oct 06, 2021 at 09:15:17 +0200, Ján Tomko wrote:
> Other devices (includes 9p-based fsdev) call this wrapper
> before formatting the device.
>
> Add it here too.
>
> Signed-off-by: Ján Tomko
> ---
> src/qemu/qemu_command.c | 3 +++
> 1 file changed, 3 insertions(+)
Reviewed-by: Peter
On Wed, Oct 06, 2021 at 09:15:16 +0200, Ján Tomko wrote:
> Iterate through the array to find the first free index.
>
> Signed-off-by: Ján Tomko
> ---
> src/qemu/qemu_alias.c | 18 ++
> 1 file changed, 14 insertions(+), 4 deletions(-)
>
> diff --git a/src/qemu/qemu_alias.c
On Wed, Oct 06, 2021 at 09:15:15 +0200, Ján Tomko wrote:
> This reverts commit 801e6da29c0202946d44b42136cc4ee229932a29
>
> They are not needed anymore.
>
> Signed-off-by: Ján Tomko
> ---
> src/qemu/qemu_domain.c | 41 -
> src/qemu/qemu_domain.h | 11
On Wed, Oct 06, 2021 at 09:15:13 +0200, Ján Tomko wrote:
> Signed-off-by: Ján Tomko
> ---
> src/qemu/qemu_command.c | 55 ++---
> 1 file changed, 35 insertions(+), 20 deletions(-)
Reviewed-by: Peter Krempa
On Wed, Oct 06, 2021 at 09:15:14 +0200, Ján Tomko wrote:
> Reconstruct the socket path from priv->libDir in every user.
>
> Signed-off-by: Ján Tomko
> ---
> src/qemu/qemu_command.c | 8 +---
> src/qemu/qemu_extdevice.c | 6 ++
> src/qemu/qemu_virtiofs.c | 14 +++---
>
On Wed, Oct 06, 2021 at 09:15:12 +0200, Ján Tomko wrote:
> Signed-off-by: Ján Tomko
> ---
> src/qemu/qemu_command.c | 22 +-
> 1 file changed, 17 insertions(+), 5 deletions(-)
Reviewed-by: Peter Krempa
On Wed, Oct 06, 2021 at 09:15:11 +0200, Ján Tomko wrote:
> The mocked path in the test suite is not in sync with what libvirtd
> generates.
>
> Signed-off-by: Ján Tomko
> ---
> .../qemuxml2argvdata/vhost-user-fs-fd-memory.x86_64-latest.args | 2 +-
>
On Wed, Oct 06, 2021 at 09:36:46 +0200, Peter Krempa wrote:
> On Wed, Oct 06, 2021 at 09:15:21 +0200, Ján Tomko wrote:
> > https://bugzilla.redhat.com/show_bug.cgi?id=1897708
> >
> > Signed-off-by: Ján Tomko
> > ---
> > src/qemu/qemu_driver.c | 9 +++-
> > src/qemu/qemu_hotplug.c | 96
On Wed, Oct 06, 2021 at 09:15:10 +0200, Ján Tomko wrote:
> A function that creates a chardev source with the appropriate
> socket path set.
>
> Signed-off-by: Ján Tomko
> ---
> src/qemu/qemu_domain.c | 13 +
> src/qemu/qemu_domain.h | 4
> 2 files changed, 17 insertions(+)
On Wed, Oct 06, 2021 at 09:15:21 +0200, Ján Tomko wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1897708
>
> Signed-off-by: Ján Tomko
> ---
> src/qemu/qemu_driver.c | 9 +++-
> src/qemu/qemu_hotplug.c | 96 +
> 2 files changed, 104 insertions(+),
On Wed, Oct 06, 2021 at 09:15:09 +0200, Ján Tomko wrote:
> Intended as a replacement for qemuVirtioFSCreateSocketFilename,
> to be used outside of qemu_virtiofs.c
>
> Signed-off-by: Ján Tomko
> ---
> src/qemu/qemu_domain.c | 10 ++
> src/qemu/qemu_domain.h | 4
> 2 files changed,
On Wed, Oct 06, 2021 at 09:15:08 +0200, Ján Tomko wrote:
It's defined also for 'virDomainChrDef'
> Signed-off-by: Ján Tomko
> ---
> src/conf/domain_conf.h | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Peter Krempa
On Wed, Oct 06, 2021 at 09:15:07 +0200, Ján Tomko wrote:
> The commit adding the vhost-user-fs device forgot to format
> the device's alias on the command line.
>
> Thankfully it was not needed yet because virtiofs migration
> is not yet supported, but it will be needed in the future
> to allow
Signed-off-by: Ján Tomko
---
src/conf/domain_conf.c | 24
src/conf/domain_conf.h | 2 +
src/libvirt_private.syms | 1 +
src/qemu/qemu_hotplug.c | 81 +++-
4 files changed, 106 insertions(+), 2 deletions(-)
diff --git
Remove the local variable in favor of the one stored in priv.
Signed-off-by: Ján Tomko
---
src/qemu/qemu_process.c | 20 +---
1 file changed, 9 insertions(+), 11 deletions(-)
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 4a1fd753ee..17435c0ee9 100644
---
Prepare for hotplug support.
Signed-off-by: Ján Tomko
---
src/qemu/qemu_alias.c | 2 +-
src/qemu/qemu_alias.h | 4
src/qemu/qemu_command.c | 2 +-
src/qemu/qemu_command.h | 6 ++
src/qemu/qemu_hotplug.h | 4
5 files changed, 16 insertions(+), 2 deletions(-)
diff --git
Other devices (includes 9p-based fsdev) call this wrapper
before formatting the device.
Add it here too.
Signed-off-by: Ján Tomko
---
src/qemu/qemu_command.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index dc4f91ce25..8c8aafb13d
This reverts commit 801e6da29c0202946d44b42136cc4ee229932a29
They are not needed anymore.
Signed-off-by: Ján Tomko
---
src/qemu/qemu_domain.c | 41 -
src/qemu/qemu_domain.h | 11 ---
2 files changed, 52 deletions(-)
diff --git
Reconstruct the socket path from priv->libDir in every user.
Signed-off-by: Ján Tomko
---
src/qemu/qemu_command.c | 8 +---
src/qemu/qemu_extdevice.c | 6 ++
src/qemu/qemu_virtiofs.c | 14 +++---
tests/qemuxml2argvtest.c | 12
4 files changed, 14
Signed-off-by: Ján Tomko
---
src/qemu/qemu_command.c | 55 ++---
1 file changed, 35 insertions(+), 20 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 7e76e188c1..d0f961b8ea 100644
--- a/src/qemu/qemu_command.c
+++
https://bugzilla.redhat.com/show_bug.cgi?id=1897708
Signed-off-by: Ján Tomko
---
src/qemu/qemu_driver.c | 9 +++-
src/qemu/qemu_hotplug.c | 96 +
2 files changed, 104 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_driver.c
Signed-off-by: Ján Tomko
---
src/qemu/qemu_command.c | 22 +-
1 file changed, 17 insertions(+), 5 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 90c8022b07..7e76e188c1 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@
The mocked path in the test suite is not in sync with what libvirtd
generates.
Signed-off-by: Ján Tomko
---
.../qemuxml2argvdata/vhost-user-fs-fd-memory.x86_64-latest.args | 2 +-
.../qemuxml2argvdata/vhost-user-fs-hugepages.x86_64-latest.args | 2 +-
tests/qemuxml2argvtest.c
We might need it later for device hotplug.
Signed-off-by: Ján Tomko
---
src/qemu/qemu_domain.h | 11 +++
src/qemu/qemu_process.c | 5 -
2 files changed, 11 insertions(+), 5 deletions(-)
diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h
index 7e717cf2ad..fef6a2f39f
Iterate through the array to find the first free index.
Signed-off-by: Ján Tomko
---
src/qemu/qemu_alias.c | 18 ++
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/src/qemu/qemu_alias.c b/src/qemu/qemu_alias.c
index 81a1e7eeed..4153050bec 100644
---
Intended as a replacement for qemuVirtioFSCreateSocketFilename,
to be used outside of qemu_virtiofs.c
Signed-off-by: Ján Tomko
---
src/qemu/qemu_domain.c | 10 ++
src/qemu/qemu_domain.h | 4
2 files changed, 14 insertions(+)
diff --git a/src/qemu/qemu_domain.c
A function that creates a chardev source with the appropriate
socket path set.
Signed-off-by: Ján Tomko
---
src/qemu/qemu_domain.c | 13 +
src/qemu/qemu_domain.h | 4
2 files changed, 17 insertions(+)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index
https://bugzilla.redhat.com/show_bug.cgi?id=1897708
Ján Tomko (16):
qemu: vhost-user-fs: format alias on the command line
conf: define cleanup func for virDomainChrSourceDef
qemu: domain: introduce qemuDomainGetVHostUserFSSocketPath
qemu: domain: introduce
The commit adding the vhost-user-fs device forgot to format
the device's alias on the command line.
Thankfully it was not needed yet because virtiofs migration
is not yet supported, but it will be needed in the future
to allow hot(un)plug.
Signed-off-by: Ján Tomko
---
src/qemu/qemu_command.c
Signed-off-by: Ján Tomko
---
src/conf/domain_conf.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index e054c1508e..c23c233184 100644
--- a/src/conf/domain_conf.h
+++ b/src/conf/domain_conf.h
@@ -1284,6 +1284,7 @@ struct
On Wed, Oct 06, 2021 at 08:37:16 +0200, Peter Krempa wrote:
> On Tue, Oct 05, 2021 at 09:41:12 -0500, Or Ozeri wrote:
> > The post parse callback is part of the real (non-test) processing flow.
> > This commit adds it (for disks) to the qemublocktest flow as well.
>
> Could you please elaborate
On Tue, Oct 05, 2021 at 09:41:13 -0500, Or Ozeri wrote:
> rbd encryption is new in qemu 6.1.0.
> This commit adds capability probing for it.
>
> Signed-off-by: Or Ozeri
> ---
> src/qemu/qemu_capabilities.c | 2 ++
> src/qemu/qemu_capabilities.h | 1 +
>
On Tue, Oct 05, 2021 at 09:41:12 -0500, Or Ozeri wrote:
> The post parse callback is part of the real (non-test) processing flow.
> This commit adds it (for disks) to the qemublocktest flow as well.
Could you please elaborate why this is needed? Specifically
qemublocktest takes a few liberties
On Tue, Oct 05, 2021 at 18:07:04 +0100, Daniel P. Berrangé wrote:
> Some CPU features are still added using implicit syntax "feature"
> which is a deprecated shorthand for "feature=on".
>
> Signed-off-by: Daniel P. Berrangé
> ---
> src/qemu/qemu_command.c | 6
On Tue, Oct 05, 2021 at 18:07:03 +0100, Daniel P. Berrangé wrote:
> The -cpu arg gained support for feature=on|off syntax for the x86
> emulator in 2.4.0
>
> commit 38e5c119c2925812bd441450ab9e5e00fc79e662
> Author: Eduardo Habkost
> Date: Mon Mar 23 17:29:32 2015 -0300
>
>
69 matches
Mail list logo
