Re: Module/Tool/SO to convert from KVM-xml => QEMU-native?

2021-10-09 Thread Ajay Garg
For converting kvm-xml to qemu-native, qemu needs to be installed/updated in entirety. Doing a complete "sudo make install" for qemu, will take care of the conversion (without touching virt-manager / kvm /libvirt). "sudo make install" (for qemu) safely updates the older qemu-files (if any),

[PATCH v2 4/5] qapi: Implement deprecated-input={reject, crash} for enum values

2021-10-09 Thread Markus Armbruster
This copies the code implementing the policy from qapi/qmp-dispatch.c to qapi/qobject-input-visitor.c. Tolerable, but if we acquire more copes, we should look into factoring them out. Signed-off-by: Markus Armbruster --- docs/devel/qapi-code-gen.rst | 6 -- qapi/compat.json |

[PATCH RFC v2 5/5] block: Deprecate transaction type drive-backup

2021-10-09 Thread Markus Armbruster
Several moons ago, Vladimir posted Subject: [PATCH v2 3/3] qapi: deprecate drive-backup Date: Wed, 5 May 2021 16:58:03 +0300 Message-Id: <20210505135803.67896-4-vsement...@virtuozzo.com> https://lists.gnu.org/archive/html/qemu-devel/2021-05/msg01394.html with this TODO: We

[PATCH v2 2/5] qapi: Add feature flags to enum members

2021-10-09 Thread Markus Armbruster
This is quite similar to commit 84ab008687 "qapi: Add feature flags to struct members", only for enums instead of structs. Special feature flag 'deprecated' is silently ignored there. This is okay only because it will be implemented shortly. Signed-off-by: Markus Armbruster Reviewed-by: Eric

[PATCH v2 0/5] qapi: Add feature flags to enum members

2021-10-09 Thread Markus Armbruster
PATCH 1+2 add feature flags to enum members. Awkward due to an introspection design mistake; see PATCH 1 for details. PATCH 3+4 implement policy deprecated-input={reject,crash} for enum values. Policy deprecated-output=hide is not implemented, because we can't hide a value without hiding the

[PATCH v2 3/5] qapi: Move compat policy from QObject to generic visitor

2021-10-09 Thread Markus Armbruster
The next commit needs to access compat policy from the generic visitor core. Move it there from qobject input and output visitor. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- include/qapi/qobject-input-visitor.h | 4 include/qapi/qobject-output-visitor.h | 4

[PATCH v2 1/5] qapi: Enable enum member introspection to show more than name

2021-10-09 Thread Markus Armbruster
The next commit will add feature flags to enum members. There's a problem, though: query-qmp-schema shows an enum type's members as an array of member names (SchemaInfoEnum member @values). If it showed an array of objects with a name member, we could simply add more members to these objects.

Re: [PATCH 3/3] qemu: Add support for virtio device option paeg-per-vq

2021-10-09 Thread Han Han
On Thu, Sep 9, 2021 at 7:43 PM Michal Prívozník wrote: > On 9/6/21 4:06 PM, Han Han wrote: > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1925363 > > > > Signed-off-by: Han Han > > --- > > src/qemu/qemu_command.c | 4 ++ > > src/qemu/qemu_hotplug.c

Re: [PATCH 3/3] qemu: Add support for virtio device option paeg-per-vq

2021-10-09 Thread Han Han
On Wed, Oct 6, 2021 at 3:27 AM Jonathon Jongsma wrote: > On Fri, Sep 17, 2021 at 3:17 PM Jonathon Jongsma > wrote: > > > > On Thu, Sep 9, 2021 at 6:51 AM Michal Prívozník > wrote: > > > > > > On 9/6/21 4:06 PM, Han Han wrote: > > > > Resolves:

[PATCH v2 3/3] qemu: Add support for virtio device option page-per-vq

2021-10-09 Thread Han Han
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1925363 Signed-off-by: Han Han --- src/qemu/qemu_command.c | 4 ++ src/qemu/qemu_hotplug.c | 3 +- src/qemu/qemu_validate.c | 7

[PATCH v2 2/3] conf: Add page_per_vq for driver element

2021-10-09 Thread Han Han
Signed-off-by: Han Han --- docs/formatdomain.rst | 9 + docs/schemas/domaincommon.rng | 5 + src/conf/domain_conf.c| 16 src/conf/domain_conf.h| 1 + src/conf/domain_validate.c| 6 ++ 5 files changed, 37 insertions(+) diff --git

[PATCH v2 1/3] qemu_capabilities: Add flag QEMU_CAPS_VIRTIO_PAGE_PER_VQ

2021-10-09 Thread Han Han
The qemu capability will be used for the page_per_vq option of virtio devices. Signed-off-by: Han Han --- src/qemu/qemu_capabilities.c | 6 ++ src/qemu/qemu_capabilities.h | 1 + tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml | 1 +

[PATCH v2 0/3] Implement paeg-per-vq to virtio devices

2021-10-09 Thread Han Han
Diff from v1: - Remove some duplicated test cases - Merge some err msgs of 2 lines into one line - Rebase to latest upstream v1: https://listman.redhat.com/archives/libvir-list/2021-September/msg00087.html Han Han (3): qemu_capabilities: Add flag QEMU_CAPS_VIRTIO_PAGE_PER_VQ conf: Add

Re: [PATCH RFC 1/5] qapi: Enable enum member introspection to show more than name

2021-10-09 Thread Markus Armbruster
Peter Krempa writes: > On Mon, Sep 20, 2021 at 11:08:59 +0200, Markus Armbruster wrote: >> Peter Krempa writes: >> >> > On Wed, Sep 15, 2021 at 21:24:21 +0200, Markus Armbruster wrote: >> >> The next commit will add feature flags to enum members. There's a >> >> problem, though:

[PATCH] libvirt qemu add rbd mirror dest in qemuDomainBlockCopyCommon

2021-10-09 Thread dingli...@cmss.chinamobile.com
From: dinglimin The BlockCopy command is designed to copy a chain of disk backup images to dest. For RBD external destination, before the modification, only the '--XML' parameter is supported by 'blockdev-mirror'. After the modification, the '--dest' parameter(--dest