Re: [PATCH v1] tools: add virt-host-validate-ch for ch driver

On 10/12/2021 10:32 AM, Michal Prívozník wrote: On 10/7/21 11:49 PM, Praveen K Paladugu wrote: Signed-off-by: Wei-Chen Chen Signed-off-by: Praveen K Paladugu --- po/POTFILES.in| 1 + tools/meson.build | 5 +++ tools/virt-host-validate-ch.c | 85

Re: [PATCH v1] tools: add virt-host-validate-ch for ch driver

On 10/7/21 11:49 PM, Praveen K Paladugu wrote: > Signed-off-by: Wei-Chen Chen > Signed-off-by: Praveen K Paladugu > --- > po/POTFILES.in| 1 + > tools/meson.build | 5 +++ > tools/virt-host-validate-ch.c | 85 +++ >

Re: [PATCH] spec: change the ownership of cache directory

On 10/11/21 1:47 PM, Peng Liang wrote: > In a50c473ad6c9 ("qemu: move temp file of screenshot and memorypeek to > per-domain dir") and c4f3c955d578 ("qemu: don't change ownership of > cache directory"), I move the temporary files of screenshot and > memorypeek from the cache directory to

Re: [libvirt PATCH] NEWS: document virtiofs hotplug

On 10/12/21 2:45 PM, Ján Tomko wrote: > Signed-off-by: Ján Tomko > --- > NEWS.rst | 4 > 1 file changed, 4 insertions(+) > Reviewed-by: Michal Privoznik Michal

Re: [PATCH] gitdm: Add other email into Red Hat company list

On 10/12/21 12:39 AM, Julio Faracco wrote: > Some people from Red Hat does not use 'redhat.com' domain emails. > They use personal or other domains. > > Signed-off-by: Julio Faracco > --- > docs/gitdm/companies/ibm| 1 - > docs/gitdm/companies/redhat | 1 + > 2 files changed, 1

Re: [PATCH 00/14] qemu: Type-aware generation of properties for -device (part 2)

On a Tuesday in 2021, Peter Krempa wrote: This series finishes the refactor to generate '-device' via JSON. This will be needed later on when qemu will consider only the JSON format to be long term stable. Next part will deal with the testing and finishing touches. Peter Krempa (14):

Re: [PATCH 13/14] qemuBuildFloppyCommandLineControllerOptions: Extract formatting of implicit/explicit fdc

On a Tuesday in 2021, Peter Krempa wrote: qemuBuildFloppyCommandLineControllerOptions was generating config for both the implicit and explicit fdc. The explicit FDC is using '-device' and thus will need to be converted to JSON. Split up the lookup of the floppy drive configs from the actuall

[libvirt PATCH] qemu: correctly pass qemuBuildVHostUserFsDevProps

../../work/libvirt/src/qemu/qemu_hotplug.c: In function ‘qemuDomainAttachFSDevice’: ../../work/libvirt/src/qemu/qemu_hotplug.c:3458:68: error: ordered comparison of pointer with integer zero [-Werror=extra] 3458 | if (qemuBuildVHostUserFsDevProps(fs, vm->def, charAlias, priv) < 0) |

[libvirt PATCH] NEWS: document virtiofs hotplug

Signed-off-by: Ján Tomko --- NEWS.rst | 4 1 file changed, 4 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index ae678bffc4..61edc53439 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -40,6 +40,10 @@ v7.9.0 (unreleased) domain definition when the guest was first started).This setting is only

[PATCH] rpc: Temporarily stop accept()-ing new clients on EMFILE

This commit is related to 5de203f879 which I pushed a few days ago. While that commit prioritized closing clients socket over the rest of I/O process, this one goes one step further and temporarily suspends processing new connection requests. A brief recapitulation of the problem: 1) assume that

Re: [PATCH v2 0/5] qapi: Add feature flags to enum members

On Sat, Oct 09, 2021 at 14:09:39 +0200, Markus Armbruster wrote: I've tested this with my libvirt patches which make use of the new way enum members are returned as well as code which validates whether libvirt uses deprecated values and everything works as expected, thus Series: Tested-by:

Re: [libvirt PATCHv3 0/2] qemu: virtiofs hot(un)plug (virtiofs epopee)

On Tue, Oct 12, 2021 at 14:14:42 +0200, Ján Tomko wrote: > Now with more JSON. > > Ján Tomko (2): > qemu: implement virtiofs hotplug > qemu: implement virtiofs hotunplug Reviewed-by: Peter Krempa

[libvirt PATCHv3 2/2] qemu: implement virtiofs hotunplug

Signed-off-by: Ján Tomko --- src/conf/domain_conf.c | 24 src/conf/domain_conf.h | 2 + src/libvirt_private.syms | 1 + src/qemu/qemu_hotplug.c | 83 +++- 4 files changed, 108 insertions(+), 2 deletions(-) diff --git

[libvirt PATCHv3 0/2] qemu: virtiofs hot(un)plug (virtiofs epopee)

Now with more JSON. Ján Tomko (2): qemu: implement virtiofs hotplug qemu: implement virtiofs hotunplug src/conf/domain_conf.c | 24 ++ src/conf/domain_conf.h | 2 + src/libvirt_private.syms | 1 + src/qemu/qemu_driver.c | 9 +- src/qemu/qemu_hotplug.c | 182

[libvirt PATCHv3 1/2] qemu: implement virtiofs hotplug

https://bugzilla.redhat.com/show_bug.cgi?id=1897708 Signed-off-by: Ján Tomko --- src/qemu/qemu_driver.c | 9 +++- src/qemu/qemu_hotplug.c | 99 + 2 files changed, 107 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c

Re: [PATCH 0/5] trace: inroduce qmp: trace namespace

Vladimir Sementsov-Ogievskiy writes: > Hi all! > > We have handle_qmp_command and qmp_command_repond trace points to trace > qmp commands. They are very useful to debug problems involving > management tools like libvirt. > > But tracing all qmp commands is too much. > > Here I suggest a kind of

[PATCH 13/14] qemuBuildFloppyCommandLineControllerOptions: Extract formatting of implicit/explicit fdc

qemuBuildFloppyCommandLineControllerOptions was generating config for both the implicit and explicit fdc. The explicit FDC is using '-device' and thus will need to be converted to JSON. Split up the lookup of the floppy drive configs from the actuall command generation. Signed-off-by: Peter

[PATCH 14/14] qemuBuildFloppyCommandLineControllerOptionsExplicit: Generate via JSON

QEMU declares the bootindex types as: bootindexA= bootindexB= The driveA/driveB parameters were deprecated and removed in qemu-6.0. We'll keep them for compatibility, but they are not used with -blockdev. Signed-off-by: Peter Krempa --- src/qemu/qemu_command.c | 45

[PATCH 12/14] qemuBuildSmartcardCommandLine: Generate via JSON

QEMU declares the props we control as: 'ccid-card-emulated' backend= cert1= cert2= cert3= db= 'ccid-card-passthru' chardev= - ID of a chardev to use as a backend Signed-off-by: Peter Krempa --- src/qemu/qemu_command.c | 88 + 1 file

[PATCH 11/14] qemuBuildIOMMUCommandLine: Generate via JSON

QEMU declares the following types for fields we control: intremap= - on/off/auto (default: "auto") caching-mode=- (default: false) eim=- on/off/auto (default: "auto") device-iotlb=- (default: false) aw-bits=- (default: 39) Signed-off-by: Peter Krempa ---

[PATCH 10/14] qemuBuildVMCoreInfoCommandLine: Generate via JSON

While this device doesn't have any properties it must be converted to use qemuBuildDeviceCommandlineFromJSON so that we can validate it in the future. Signed-off-by: Peter Krempa --- src/qemu/qemu_command.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git

[PATCH 09/14] qemuBuildTPMProxyCommandLine: Generate via JSON

All properties are strings according to QEMU. Signed-off-by: Peter Krempa --- src/qemu/qemu_command.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index bf15a4801a..86affcdf6f 100644 ---

[PATCH 08/14] qemuBuildVMGenIDCommandLine: Generate via JSON

QEMU declares the 'guid' property as: guid= - UUID (aka GUID) or "auto" for random value (default) (default: "auto") Signed-off-by: Peter Krempa --- src/qemu/qemu_command.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff --git

[PATCH 07/14] qemuValidateDomainSmartcardDef: Move validation of smartcard count

Move it into the validator. Note that the placement into the device validation part is intentional so that it also covers hotplug code paths. Signed-off-by: Peter Krempa --- src/qemu/qemu_command.c | 12 src/qemu/qemu_validate.c | 20 +++- 2 files changed, 15

[PATCH 06/14] qemuBuildSmartcardCommandLine: Replace qemuBuildSmartcardFindCCIDController

We have a commonly used helper virDomainControllerAliasFind, which does the same thing and also reports errors internally. Signed-off-by: Peter Krempa --- src/qemu/qemu_command.c | 35 +++ 1 file changed, 3 insertions(+), 32 deletions(-) diff --git

[PATCH 05/14] virDomainSmartcardDef: Declare 'type' as virDomainSmartcardType

Use 'virXMLPropEnum' to parse it and fix all switch statements which didn't include the VIR_DOMAIN_SMARTCARD_TYPE_LAST case. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 23 +++ src/conf/domain_conf.h | 2 +- src/qemu/qemu_command.c |

[PATCH 02/14] qemuBuildDeviceCommandlineFromJSON: Remove unused keyword

Now that the code was converted to use this helper we can remove it. Signed-off-by: Peter Krempa --- src/qemu/qemu_command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index ade82eef22..fae2d1569c 100644 ---

[PATCH 04/14] qemuValidateDomainSmartcardDef: Move chardev validation under VIR_DOMAIN_SMARTCARD_TYPE_PASSTHROUGH

Don't check the type twice, move the chardev validation into the switch. Signed-off-by: Peter Krempa --- src/qemu/qemu_validate.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 5973f019d2..9865e29637 100644

[PATCH 03/14] qemuValidateDomainSmartcardDef: Unbreak error messages

https://www.libvirt.org/coding-style.html#error-message-format Signed-off-by: Peter Krempa --- src/qemu/qemu_validate.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 0e7684973e..5973f019d2 100644 ---

[PATCH 01/14] qemuBuildStorageSourceAttachPrepareDrive: Fix function comment

Remove mention of argument which no longer exists. Signed-off-by: Peter Krempa --- src/qemu/qemu_command.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index cc8fd68680..ade82eef22 100644 --- a/src/qemu/qemu_command.c +++

[PATCH 00/14] qemu: Type-aware generation of properties for -device (part 2)

This series finishes the refactor to generate '-device' via JSON. This will be needed later on when qemu will consider only the JSON format to be long term stable. Next part will deal with the testing and finishing touches. Peter Krempa (14): qemuBuildStorageSourceAttachPrepareDrive: Fix

Re: [PATCH RFC v2 5/5] block: Deprecate transaction type drive-backup

Am 11.10.2021 um 20:58 hat Eric Blake geschrieben: > On Sat, Oct 09, 2021 at 02:09:44PM +0200, Markus Armbruster wrote: > > Several moons ago, Vladimir posted > > > > Subject: [PATCH v2 3/3] qapi: deprecate drive-backup > > Date: Wed, 5 May 2021 16:58:03 +0300 > > Message-Id:

Re: [PATCH v2 2/5] qapi: Add feature flags to enum members

Am 09.10.2021 um 14:09 hat Markus Armbruster geschrieben: > This is quite similar to commit 84ab008687 "qapi: Add feature flags to > struct members", only for enums instead of structs. > > Special feature flag 'deprecated' is silently ignored there. This is > okay only because it will be

Re: [PATCH v2 1/5] qapi: Enable enum member introspection to show more than name

Am 09.10.2021 um 14:09 hat Markus Armbruster geschrieben: > The next commit will add feature flags to enum members. There's a > problem, though: query-qmp-schema shows an enum type's members as an > array of member names (SchemaInfoEnum member @values). If it showed > an array of objects with a

Re: [PATCH 3/3] qemu: Add support for virtio device option paeg-per-vq

On 10/9/21 11:47 AM, Han Han wrote: > On Thu, Sep 9, 2021 at 7:43 PM Michal Prívozník wrote: > >> On 9/6/21 4:06 PM, Han Han wrote: >>> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1925363 >>> >>> Signed-off-by: Han Han >>> --- > > BTW, is there any way to add Gavi(g...@nvidia.com)

Re: [PATCH v2 4/7] qemuxml2argvtest: Use real-caps testing for 'acpi-hotplug-bridge-disable'

On Mon, Oct 11, 2021 at 09:27:44 -0700, Andrea Bolognani wrote: > On Mon, Oct 11, 2021 at 04:51:40PM +0200, Ján Tomko wrote: > > On a Monday in 2021, Peter Krempa wrote: > > > +++ > > > b/tests/qemuxml2argvdata/aarch64-acpi-hotplug-bridge-disable.aarch64-latest.err > > > @@ -0,0 +1 @@ > > > +XML