Re: [PATCH v2 03/15] net/vhost-vdpa: Fix device compatibility check

2021-10-13 Thread Jason Wang
在 2021/10/8 下午9:34, Kevin Wolf 写道: vhost-vdpa works only with specific devices. At startup, it second guesses what the command line option handling will do and error out if it thinks a non-virtio device will attach to them. This second guessing is not only ugly, it can lead to wrong error mess

Re: [PATCH v2 02/15] net/vhost-user: Fix device compatibility check

2021-10-13 Thread Jason Wang
在 2021/10/8 下午9:34, Kevin Wolf 写道: vhost-user works only with specific devices. At startup, it second guesses what the command line option handling will do and error out if it thinks a non-virtio device will attach to them. This second guessing is not only ugly, it can lead to wrong error mess

Re: [PATCH v2 01/15] net: Introduce NetClientInfo.check_peer_type()

2021-10-13 Thread Jason Wang
在 2021/10/8 下午9:34, Kevin Wolf 写道: Some network backends (vhost-user and vhost-vdpa) work only with specific devices. At startup, they second guess what the command line option handling will do and error out if they think a non-virtio device will attach to them. This second guessing is not onl

Re: [PATCH v2 09/15] softmmu/qdev-monitor: add error handling in qdev_set_id

2021-10-13 Thread Eric Blake
On Wed, Oct 13, 2021 at 03:10:38PM +0200, Damien Hedde wrote: > > > @@ -691,7 +703,13 @@ DeviceState *qdev_device_add(QemuOpts *opts, Error > > > **errp) > > > } > > > } > > > -qdev_set_id(dev, g_strdup(qemu_opts_id(opts))); > > > +/* > > > + * set dev's parent and regi

Re: [PATCH v2 00/15] qdev: Add JSON -device

2021-10-13 Thread Kevin Wolf
Am 13.10.2021 um 17:30 hat Michael S. Tsirkin geschrieben: > On Fri, Oct 08, 2021 at 03:34:27PM +0200, Kevin Wolf wrote: > > It's still a long way until we'll have QAPIfied devices, but there are > > some improvements that we can already make now to make the future switch > > easier. > > > > One i

Re: [PATCH v2 00/15] qdev: Add JSON -device

2021-10-13 Thread Michael S. Tsirkin
On Fri, Oct 08, 2021 at 03:34:27PM +0200, Kevin Wolf wrote: > It's still a long way until we'll have QAPIfied devices, but there are > some improvements that we can already make now to make the future switch > easier. > > One important part of this is having code paths without QemuOpts, which > we

Re: [PATCH v4] qemu: tpm: Run swtpm_setup --create-config-files in session mode

2021-10-13 Thread Marc-André Lureau
Hi On Wed, Oct 13, 2021 at 4:57 PM Stefan Berger wrote: > Using swtpm v0.7.0 we can run swtpm_setup to create default config files > for swtpm_setup and swtpm-localca in session mode. Now a user can start > a VM with an attached TPM without having to run this program on the > command line before

Re: [PATCH v2 08/15] qdev: Make DeviceState.id independent of QemuOpts

2021-10-13 Thread Damien Hedde
On 10/8/21 15:34, Kevin Wolf wrote: DeviceState.id is a pointer to a string that is stored in the QemuOpts object DeviceState.opts and freed together with it. We want to create devices without going through QemuOpts in the future, so make this a separately allocated string. Signed-off-by: Kev

Re: [PATCH v2 03/15] net/vhost-vdpa: Fix device compatibility check

2021-10-13 Thread Damien Hedde
On 10/8/21 15:34, Kevin Wolf wrote: vhost-vdpa works only with specific devices. At startup, it second guesses what the command line option handling will do and error out if it thinks a non-virtio device will attach to them. This second guessing is not only ugly, it can lead to wrong error me

Re: [PATCH v2 02/15] net/vhost-user: Fix device compatibility check

2021-10-13 Thread Damien Hedde
On 10/8/21 15:34, Kevin Wolf wrote: vhost-user works only with specific devices. At startup, it second guesses what the command line option handling will do and error out if it thinks a non-virtio device will attach to them. This second guessing is not only ugly, it can lead to wrong error me

Re: [PATCH v2 01/15] net: Introduce NetClientInfo.check_peer_type()

2021-10-13 Thread Damien Hedde
On 10/8/21 15:34, Kevin Wolf wrote: Some network backends (vhost-user and vhost-vdpa) work only with specific devices. At startup, they second guess what the command line option handling will do and error out if they think a non-virtio device will attach to them. This second guessing is not o

Re: [PATCH v2 09/15] softmmu/qdev-monitor: add error handling in qdev_set_id

2021-10-13 Thread Damien Hedde
On 10/11/21 23:00, Eric Blake wrote: On Fri, Oct 08, 2021 at 03:34:36PM +0200, Kevin Wolf wrote: From: Damien Hedde qdev_set_id() is mostly used when the user adds a device (using -device cli option or device_add qmp command). This commit adds an error parameter to handle the case where the

[PATCH v4] qemu: tpm: Run swtpm_setup --create-config-files in session mode

2021-10-13 Thread Stefan Berger
Using swtpm v0.7.0 we can run swtpm_setup to create default config files for swtpm_setup and swtpm-localca in session mode. Now a user can start a VM with an attached TPM without having to run this program on the command line before. This program needs to run once. This patch addresses the issue r

Re: VM paused during multipath iSCSI reservation

2021-10-13 Thread Vojtech Juranek
I'm sorry, I send it here by mistake. Wanted to send it to libvirt-user list. Sorry for that. Vojta On Wednesday, 13 October 2021 14:21:02 CEST you wrote: > Hi, > I'm trying to find the root cause for BZ #1898049 [1]. When setting up > Windows HA cluster on Windows Server VMs run on top of oVirt,

Re: [PATCH] apparmor: ceph config file names

2021-10-13 Thread Jamie Strandboge
On Thu, 07 Oct 2021, christian.ehrha...@canonical.com wrote: > From: Christian Ehrhardt > > If running multiple [1] clusters (uncommon) the ceph config file will be > derived from the cluster name. Therefore the rule to allow to read ceph > config files need to be opened up slightly to allow for

VM paused during multipath iSCSI reservation

2021-10-13 Thread Vojtech Juranek
Hi, I'm trying to find the root cause for BZ #1898049 [1]. When setting up Windows HA cluster on Windows Server VMs run on top of oVirt, Windows cluster validator runs couple of tests and fails during test "Validate SCSI-3 Persistent Reservation" and one of the VMs of the cluster is paused wi

Re: [libvirt PATCH 6/7] nodedev: Handle inactive mdevs with the same UUID

2021-10-13 Thread Boris Fiuczynski
On 7/26/21 4:47 PM, Michal Prívozník wrote: On 7/23/21 6:40 PM, Jonathon Jongsma wrote: Unfortunately, mdevctl supports defining more than one mdev with the same UUID as long as they have different parent devices. (Only one of these devices can be active at any given time). This means that we c

Re: [RFC PATCH] qemu: Do not report eof when processing monitor IO

2021-10-13 Thread Michal Prívozník
On 10/8/21 11:37 PM, Jim Fehlig wrote: > There have been countless reports from users concerned about the following > error reported by libvirtd when qemu domains are shutdown > > internal error: End of file from qemu monitor > > While the error is harmless, users often mistaken it for real probl

Re: [PATCH 0/2] qemu_migration: set priv->migMaxBandwidth during migration

2021-10-13 Thread Michal Prívozník
On 10/8/21 10:19 AM, Kristina Hanicova wrote: > > Kristina Hanicova (2): > qemu_migration: set bandwidth in priv during migration > qemu_migration: drop unnecessary 'migrate_speed' variable > > src/qemu/qemu_migration.c | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-) >

Re: [PATCH v2] virsh: Add QMP command wrapping for 'qemu-monitor-command'

2021-10-13 Thread Peter Krempa
On Fri, Sep 17, 2021 at 15:34:56 +0200, Peter Krempa wrote: > Issuing simple QMP commands is pain as they need to be wrapped by the > JSON wrapper: > > { "execute": "COMMAND" } > > and optionally also: > > { "execute": "COMMAND", "arguments":...} > > For simple commands without arguments we c