[PATCH] qemu: Do not report eof when processing monitor IO

2021-10-14 Thread Jim Fehlig
There have been countless reports from users concerned about the following error reported by libvirtd when qemu domains are shutdown internal error: End of file from qemu monitor While the error is harmless, users often mistaken it for real problem with their deployments. EOF from the monitor

Re: [PATCH 0/5] trace: inroduce qmp: trace namespace

2021-10-14 Thread Vladimir Sementsov-Ogievskiy
12.10.2021 14:49, Markus Armbruster wrote: Vladimir Sementsov-Ogievskiy writes: Hi all! We have handle_qmp_command and qmp_command_repond trace points to trace qmp commands. They are very useful to debug problems involving management tools like libvirt. But tracing all qmp commands is too

Re: Please explain to me this commit

2021-10-14 Thread Ani Sinha
On Thu, Oct 14, 2021 at 16:54 Michal Prívozník wrote: > On 10/14/21 12:16 PM, Ani Sinha wrote: > > > https://gitlab.com/libvirt/libvirt/-/commit/bdc3e8f47be108fa552b72a6d913528869e61097 > > < > https://gitlab.com/libvirt/libvirt/-/commit/bdc3e8f47be108fa552b72a6d913528869e61097 > > > > > > I

Re: Please explain to me this commit

2021-10-14 Thread Michal Prívozník
On 10/14/21 12:16 PM, Ani Sinha wrote: > https://gitlab.com/libvirt/libvirt/-/commit/bdc3e8f47be108fa552b72a6d913528869e61097 > > > I think you completely missed the logic here and you are rewriting a > patch

Re: Please explain to me this commit

2021-10-14 Thread Peter Krempa
On Thu, Oct 14, 2021 at 15:46:10 +0530, Ani Sinha wrote: > https://gitlab.com/libvirt/libvirt/-/commit/bdc3e8f47be108fa552b72a6d913528869e61097 > > I think you completely missed the logic here Okay so let me explain my thoughtst first. I've noticed that the QEMU_CAPS_PIIX4_ACPI_HOTPLUG_BRIDGE

Re: [PATCH 1/2] qemu: Move pid file of pr-helper to stateDir

2021-10-14 Thread Peng Liang
On 10/14/2021 6:10 PM, Michal Prívozník wrote: > On 10/11/21 2:11 PM, Peng Liang wrote: >> Libvirt will put the pid file of pr-helper to per-domain directory. >> However, the ownership of the per-domain directory is the user to run >> the QEMU process and the user has the write permission of the

Please explain to me this commit

2021-10-14 Thread Ani Sinha
https://gitlab.com/libvirt/libvirt/-/commit/bdc3e8f47be108fa552b72a6d913528869e61097 I think you completely missed the logic here and you are rewriting a patch without cc'ing the original author. I'm sorry but this is rude. Ani

Re: [PATCH 1/2] qemu: Move pid file of pr-helper to stateDir

2021-10-14 Thread Michal Prívozník
On 10/11/21 2:11 PM, Peng Liang wrote: > Libvirt will put the pid file of pr-helper to per-domain directory. > However, the ownership of the per-domain directory is the user to run > the QEMU process and the user has the write permission of the directory. > If VM escape occurs, the attacker can >

Re: [PATCH v2 1/3] qemu_capabilities: Add flag QEMU_CAPS_VIRTIO_PAGE_PER_VQ

2021-10-14 Thread Michal Prívozník
On 10/11/21 2:54 AM, Han Han wrote: > > > On Mon, Oct 11, 2021 at 3:50 AM Peter Krempa > wrote: > > On Sat, Oct 09, 2021 at 17:37:42 +0800, Han Han wrote: > > The qemu capability will be used for the page_per_vq option of virtio > > devices. > > >

Re: [PATCH v2] virsh: Add QMP command wrapping for 'qemu-monitor-command'

2021-10-14 Thread Michal Prívozník
On 9/17/21 3:34 PM, Peter Krempa wrote: > Issuing simple QMP commands is pain as they need to be wrapped by the > JSON wrapper: > > { "execute": "COMMAND" } > > and optionally also: > > { "execute": "COMMAND", "arguments":...} > > For simple commands without arguments we can add syntax sugar