Re: [libvirt PATCH 00/10] Revert

2021-10-21 Thread Ani Sinha
On Thu, 21 Oct 2021, Laine Stump wrote: > Starting with commit 58ba0f6a3d7342fba29edbbf2bb9cb5497c870e5, support > > for overriding the default hotplug method for a guest using the > > subelement of / was added to > > libvirt. This uses the QEMU global commandline switch: > > > > ICH9-LPC.ac

Re: [libvirt PATCH 00/10] Revert

2021-10-21 Thread Ani Sinha
On Thu, 21 Oct 2021, Ján Tomko wrote: > On a Thursday in 2021, Laine Stump wrote: > > [...] > > > Laine Stump (10): > > Revert "qemu: capabilities: Remove > >QEMU_CAPS_PIIX4_ACPI_HOTPLUG_BRIDGE" > > Revert "qemuxml2xmltest: Convert all acpi-hotplug control related > >tests to DO_TEST_C

Re: [libvirt PATCH 00/10] Revert

2021-10-21 Thread Ján Tomko
On a Thursday in 2021, Laine Stump wrote: [...] Laine Stump (10): Revert "qemu: capabilities: Remove QEMU_CAPS_PIIX4_ACPI_HOTPLUG_BRIDGE" Revert "qemuxml2xmltest: Convert all acpi-hotplug control related tests to DO_TEST_CAPS_LATEST" Revert "qemuxml2argvtest: Add '-enable' variants for

Re: [libvirt PATCH 02/10] Revert "qemuxml2xmltest: Convert all acpi-hotplug control related tests to DO_TEST_CAPS_LATEST"

2021-10-21 Thread Ján Tomko
On a Thursday in 2021, Laine Stump wrote: This reverts commit da896d440c7267e0b4575e4a3f2780bebf3fbfca. Signed-off-by: Laine Stump --- ...i-hotplug-bridge-disable.x86_64-latest.xml | 36 - .../pc-i440fx-acpi-hotplug-bridge-disable.xml | 1 + ...pi-hotplug-bridge-enable.x86_64-latest.

Re: [PATCH 4/4] virt-aa-helper: test: add test for new option -P

2021-10-21 Thread Andrea Bolognani
On Mon, Oct 11, 2021 at 07:59:47AM +0200, Christian Ehrhardt wrote: > On Thu, Oct 7, 2021 at 7:25 PM Ioanna Alifieraki > > +# For the next test to run apparmor needs to be installed and enabled. > > +# In some environments (e.g. containers) even though apparmor is > > +# installed, it is not enable

[libvirt PATCH 10/10] Revert "qemu: capablities: detect acpi-pci-hotplug-with-bridge-support"

2021-10-21 Thread Laine Stump
This reverts commit 58ba0f6a3d7342fba29edbbf2bb9cb5497c870e5. Conflict: * src/qemu/qemu_capabilities.[ch] Because other new cap flags had been added since the original commit, reformatting was necessary to follow the "groups of five" pattern. * tests.qemucapabilitiesdata/caps_6.2

[libvirt PATCH 08/10] Revert "qemu: command: add support for acpi-bridge-hotplug feature"

2021-10-21 Thread Laine Stump
This reverts commit bef0f0d8be6baa1d9359be208b53d6b8a37ddc95. Conflicts: tests/qemuxml2argvdata/q35-acpi-hotplug-bridge-disable.args * this file had been renamed from its original, then renamed back, which understandably confused git. It's being completely removed here anyway, so the c

[libvirt PATCH 09/10] Revert "conf: introduce support for acpi-bridge-hotplug feature"

2021-10-21 Thread Laine Stump
This reverts commit 7300ccc9b3eddb38306868534e7fc2d505a0a13c. Signed-off-by: Laine Stump --- docs/formatdomain.rst | 29 -- docs/schemas/domaincommon.rng | 15 src/conf/domain_conf.c| 89 +-- src/conf/domain

[libvirt PATCH 06/10] Revert "qemuValidateDomainDefPCIFeature: un-break error messages"

2021-10-21 Thread Laine Stump
This reverts commit 7d074c56830c5d435f87667299cc102650dbbb4f. Signed-off-by: Laine Stump --- src/qemu/qemu_validate.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index d3b9691db5..0cb4542efd 100644 --- a/src/qemu/q

[libvirt PATCH 07/10] Revert "NEWS: document new acpi pci hotplug config option"

2021-10-21 Thread Laine Stump
This reverts commit 5ee4f3e1d4f173f7e1b64b745ab9ef5dc8c8f393. Signed-off-by: Laine Stump --- NEWS.rst | 8 1 file changed, 8 deletions(-) diff --git a/NEWS.rst b/NEWS.rst index f3b9e5f0cb..bbed7a8228 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -32,14 +32,6 @@ v7.9.0 (unreleased) contr

[libvirt PATCH 03/10] Revert "qemuxml2argvtest: Add '-enable' variants for ACPI-hotplug related cases"

2021-10-21 Thread Laine Stump
This reverts commit 64146031058906804b3c5f519570fadc9ff4df48. Conflicts: tests/qemuxml2argvdata/pc-i440fx-acpi-hotplug-bridge-enable.x86_64-latest.args tests/qemuxml2argvdata/pc-i440fx-acpi-root-hotplug-enable.x86_64-latest.args tests/qemuxml2argvdata/q35-acpi-hotplug-bridge-enable.x86_64-lates

[libvirt PATCH 04/10] Revert "qemuxml2argvtest: Use real-caps testing for 'acpi-hotplug-bridge-disable'"

2021-10-21 Thread Laine Stump
This reverts commit 2d20f0bb05175d18513220bccd1dbaa207cc4c6a. Conflicts: tests/qemuxml2argvdata/pc-i440fx-acpi-hotplug-bridge-disable.args tests/qemuxml2argvdata/q35-acpi-hotplug-bridge-disable.args the test output of these files was regenerated because the tests were changed upstream to us

[libvirt PATCH 02/10] Revert "qemuxml2xmltest: Convert all acpi-hotplug control related tests to DO_TEST_CAPS_LATEST"

2021-10-21 Thread Laine Stump
This reverts commit da896d440c7267e0b4575e4a3f2780bebf3fbfca. Signed-off-by: Laine Stump --- ...i-hotplug-bridge-disable.x86_64-latest.xml | 36 - .../pc-i440fx-acpi-hotplug-bridge-disable.xml | 1 + ...pi-hotplug-bridge-enable.x86_64-latest.xml | 36 - .../pc-i440fx-acp

[libvirt PATCH 05/10] Revert "qemuValidateDomainDefPCIFeature: Fix validation logic"

2021-10-21 Thread Laine Stump
This reverts commit bdc3e8f47be108fa552b72a6d913528869e61097. Signed-off-by: Laine Stump --- src/qemu/qemu_validate.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 1ffc261c58..d3b9691db5 100644 --- a/src/qem

[libvirt PATCH 00/10] Revert

2021-10-21 Thread Laine Stump
Starting with commit 58ba0f6a3d7342fba29edbbf2bb9cb5497c870e5, support for overriding the default hotplug method for a guest using the subelement of / was added to libvirt. This uses the QEMU global commandline switch: ICH9-LPC.acpi-pci-hotplug-with-bridge-support= that was added to QEMU in qe

[libvirt PATCH 01/10] Revert "qemu: capabilities: Remove QEMU_CAPS_PIIX4_ACPI_HOTPLUG_BRIDGE"

2021-10-21 Thread Laine Stump
This reverts commit 618e8665db2e4c1a8e9a227045b99b48f6110c06. This is the first in a series of 10 commits that revert (in reverse order) the changes to add the switch to libvirt domain XML, which unfortunately needs to be removed due to QEMU developers discovering a flaw with the design of the QE

Re: [libvirt PATCH v7 1/5] Add a PCI/PCIe device VPD Parser

2021-10-21 Thread Daniel P . Berrangé
On Wed, Oct 20, 2021 at 11:30:31AM +0300, Dmitrii Shcherbakov wrote: > Add support for deserializing the binary PCI/PCIe VPD format and storing > results in memory. > > The VPD format is specified in "I.3. VPD Definitions" in PCI specs > (2.2+) and "6.28.1 VPD Format" PCIe 4.0. As section 6.28 in

Re: [PATCH v2 0/6] qemu_monitor_json: Assume existence of some commands

2021-10-21 Thread Ján Tomko
On a Thursday in 2021, Michal Privoznik wrote: Technically a v2 of: https://listman.redhat.com/archives/libvir-list/2021-October/msg00825.html but I've cancelled sending in the middle of v1. Anyway, patch 1/6 is new (yeah, I've noticed a test failing so I've cancelled sending v1). Michal Prívo

Re: [PATCH 3/4] virt-aa-helper: Purge profile if corrupted

2021-10-21 Thread Ján Tomko
On a Wednesday in 2021, Ioanna Alifieraki wrote: On Thu, Oct 7, 2021 at 10:41 PM Ján Tomko wrote: On a Thursday in 2021, Ioanna Alifieraki wrote: >This commit aims to address the bug reported in [1] and [2]. >If the profile is corrupted (0-size) the VM cannot be launched. >To overcome this ch

Re: [PATCH v4 4/5] qemu: add librbd encryption engine

2021-10-21 Thread Peter Krempa
On Thu, Oct 21, 2021 at 11:40:20 +, Or Ozeri wrote: >Thanks for reviewing all of my patches! >I'm fine with you making any of the changes you suggested. >So the only change I need to make is "specify what's happening in the >storage driver"? >Can you elaborate what do you me

RE: [PATCH v4 4/5] qemu: add librbd encryption engine

2021-10-21 Thread Or Ozeri
Thanks for reviewing all of my patches!I'm fine with you making any of the changes you suggested.So the only change I need to make is "specify what's happening in the storage driver"?Can you elaborate what do you mean by that?I can add something like:For librbd engine, the encryption happens inside

Re: [PATCH v4 5/5] conf: add luks2 encryption format

2021-10-21 Thread Peter Krempa
On Thu, Oct 07, 2021 at 14:21:21 -0500, Or Ozeri wrote: > This commit extends libvirt XML configuration to support luks2 encryption > format. > This means that becomes valid. > Currently librbd is the only engine that supports this new format. > > Signed-off-by: Or Ozeri > --- > docs/formatsto

Re: [PATCH v4 4/5] qemu: add librbd encryption engine

2021-10-21 Thread Peter Krempa
On Thu, Oct 07, 2021 at 14:21:20 -0500, Or Ozeri wrote: > rbd encryption is new in qemu 6.1.0. > This commit adds a new encryption engine property which > allows the user to use this new encryption engine. > > Signed-off-by: Or Ozeri > --- > docs/formatstorageencryption.html.in | 7 +-

Re: [PATCH v4 3/5] conf: add encryption engine property

2021-10-21 Thread Peter Krempa
On Thu, Oct 07, 2021 at 14:21:19 -0500, Or Ozeri wrote: > This commit extends libvirt XML configuration to support a custom encryption > engine. > This means that becomes valid. > The only engine for now is qemu. However, a new engine (librbd) will be added > in an upcoming commit. > If no engi

[PATCH v2 6/6] qemuMonitorJSONGetMigrationCapabilities: Don't return early on CommandNotFound

2021-10-21 Thread Michal Privoznik
The qemuMonitorJSONGetMigrationCapabilities() command executes 'query-migrate-capabilities' command and returns early if QEMU doesn't know the command. Well, the command was introduced in QEMU release 1.2 (specifically in commit v1.2.0-rc0~29^2~11) and since the minimum required version is 2.11.0 w

[PATCH v2 5/6] qemuMonitorJSONGetMemoryDeviceInfo: Don't return early on CommandNotFound

2021-10-21 Thread Michal Privoznik
The qemuMonitorJSONGetMemoryDeviceInfo() command executes 'query-memory-devices' command and returns early if QEMU doesn't know the command. Well, the command was introduced in QEMU release 2.1 (specifically in commit v2.1.0-rc0~41^2~9) and since the minimum required version is 2.11.0 we can be sur

[PATCH v2 4/6] qemuMonitorJSONGetKVMState: Don't return early on CommandNotFound

2021-10-21 Thread Michal Privoznik
The qemuMonitorJSONGetKVMState() command executes 'query-kvm' command and returns early if QEMU doesn't know the command. Well, the command was introduced in QEMU release 0.14 and since the minimum required version is 2.11.0 we can be sure that command will always exist. Signed-off-by: Michal Priv

[PATCH v2 3/6] qemuMonitorJSONGetDumpGuestMemoryCapability: Don't return early on CommandNotFound

2021-10-21 Thread Michal Privoznik
The qemuMonitorJSONGetDumpGuestMemoryCapability() command executes 'query-dump-guest-memory-capability' command and returns early if QEMU doesn't know the command. Well, the command was introduced in QEMU release 2.0 (specifically in commit v2.0.0-rc0~43^2~16) and since the minimum required version

[PATCH v2 1/6] qemumigparamstest: Drop "unsupported" test case

2021-10-21 Thread Michal Privoznik
The aim of "unsupported" test case is to check whether our code handles 'CommandNotFound' error returned for 'query-migrate-parameters' monitor command. Well, the command is pretty old and every QEMU that we are dealing with supports it. Thus this test case is useless. Drop it. Signed-off-by: Mich

[PATCH v2 2/6] qemuMonitorJSONGetMigrationParams: Don't return early on CommandNotFound

2021-10-21 Thread Michal Privoznik
The qemuMonitorJSONGetMigrationParams() function executes 'query-migrate-parameters' command and returns early if QEMU doesn't know the command. Well, the command was introduced in QEMU release 2.4 (specifically in commit v2.4.0-rc0~147^2~3) and since the minimum required version is 2.11.0 we can b

[PATCH v2 0/6] qemu_monitor_json: Assume existence of some commands

2021-10-21 Thread Michal Privoznik
Technically a v2 of: https://listman.redhat.com/archives/libvir-list/2021-October/msg00825.html but I've cancelled sending in the middle of v1. Anyway, patch 1/6 is new (yeah, I've noticed a test failing so I've cancelled sending v1). Michal Prívozník (6): qemumigparamstest: Drop "unsupported"

Re: [PATCH 0/5] qemu_monitor_json: Assume existence of some commands

2021-10-21 Thread Michal Prívozník
On 10/21/21 10:56 AM, Michal Privoznik wrote: > Just like with QEMU capabilities, we can safely assume existence of some > monitor commands because they were introduced in older than minimal > required version and do not depend on QEMU build arguments. > > Michal Prívozník (5): > qemuMonitorJSON

[PATCH v3 3/5] qapi: Move compat policy from QObject to generic visitor

2021-10-21 Thread Markus Armbruster
The next commit needs to access compat policy from the generic visitor core. Move it there from qobject input and output visitor. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- include/qapi/qobject-input-visitor.h | 4 include/qapi/qobject-output-visitor.h | 4 inclu

[PATCH v3 4/5] qapi: Implement deprecated-input={reject, crash} for enum values

2021-10-21 Thread Markus Armbruster
This copies the code implementing the policy from qapi/qmp-dispatch.c to qapi/qobject-input-visitor.c. Tolerable, but if we acquire more copies, we should look into factoring them out. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Tested-by: Peter Krempa Acked-by: Peter Krempa ---

[PATCH v3 0/5] qapi: Add feature flags to enum members

2021-10-21 Thread Markus Armbruster
PATCH 1+2 add feature flags to enum members. Awkward due to an introspection design mistake; see PATCH 1 for details. PATCH 3+4 implement policy deprecated-input={reject,crash} for enum values. Policy deprecated-output=hide is not implemented, because we can't hide a value without hiding the ent

[PATCH v3 2/5] qapi: Add feature flags to enum members

2021-10-21 Thread Markus Armbruster
This is quite similar to commit 84ab008687 "qapi: Add feature flags to struct members", only for enums instead of structs. Special feature flag 'deprecated' is silently ignored there. This is okay only because it will be implemented shortly. Signed-off-by: Markus Armbruster Reviewed-by: Eric Bl

[PATCH RFC v3 5/5] block: Deprecate transaction type drive-backup

2021-10-21 Thread Markus Armbruster
Several moons ago, Vladimir posted Subject: [PATCH v2 3/3] qapi: deprecate drive-backup Date: Wed, 5 May 2021 16:58:03 +0300 Message-Id: <20210505135803.67896-4-vsement...@virtuozzo.com> https://lists.gnu.org/archive/html/qemu-devel/2021-05/msg01394.html with this TODO: We a

[PATCH v3 1/5] qapi: Enable enum member introspection to show more than name

2021-10-21 Thread Markus Armbruster
The next commit will add feature flags to enum members. There's a problem, though: query-qmp-schema shows an enum type's members as an array of member names (SchemaInfoEnum member @values). If it showed an array of objects with a name member, we could simply add more members to these objects. Si

Re: [PATCH v4 2/5] qemu: capablities: Detect presence of 'rbd-encryption' as QEMU_CAPS_RBD_ENCRYPTION

2021-10-21 Thread Peter Krempa
On Thu, Oct 07, 2021 at 14:21:18 -0500, Or Ozeri wrote: > rbd encryption is new in qemu 6.1.0. > This commit adds capability probing for it. > > Signed-off-by: Or Ozeri > --- > src/qemu/qemu_capabilities.c | 2 ++ > src/qemu/qemu_capabilities.h | 1 + > te

Re: [PATCH v4 1/5] qemu: add disk post parse to qemublocktest

2021-10-21 Thread Peter Krempa
On Thu, Oct 07, 2021 at 14:21:17 -0500, Or Ozeri wrote: > The post parse callback is part of the real (non-test) processing flow. > This commit adds it (for disks) to the qemublocktest flow as well. > Specifically, this will be needed for tests that use luks encryption, > so that the default encryp

Re: [PATCH RFC v2 5/5] block: Deprecate transaction type drive-backup

2021-10-21 Thread Markus Armbruster
Kevin Wolf writes: > Am 11.10.2021 um 20:58 hat Eric Blake geschrieben: >> On Sat, Oct 09, 2021 at 02:09:44PM +0200, Markus Armbruster wrote: >> > Several moons ago, Vladimir posted >> > >> > Subject: [PATCH v2 3/3] qapi: deprecate drive-backup >> > Date: Wed, 5 May 2021 16:58:03 +0300

Re: [PATCH v2 4/5] qapi: Implement deprecated-input={reject,crash} for enum values

2021-10-21 Thread Markus Armbruster
Eric Blake writes: > On Sat, Oct 09, 2021 at 02:09:43PM +0200, Markus Armbruster wrote: >> This copies the code implementing the policy from qapi/qmp-dispatch.c >> to qapi/qobject-input-visitor.c. Tolerable, but if we acquire more >> copes, we should look into factoring them out. > > copies Fix

Re: [RFC PATCH 00/10] VirtioNet RSS support

2021-10-21 Thread Nikolay Shirokovskiy
чт, 21 окт. 2021 г. в 01:28, Andrew Melnichenko : > Hi, > Yes, the work is in progress. Now. I'm working with a proper solution for > the eBPF RSS helper. > Ok. Thank you! > > On Wed, Oct 20, 2021 at 3:23 PM Nikolay Shirokovskiy < > nshirokovs...@virtuozzo.com> wrote: > >> Hi, Andrew. >> >> We

[PATCH 0/5] qemu_monitor_json: Assume existence of some commands

2021-10-21 Thread Michal Privoznik
Just like with QEMU capabilities, we can safely assume existence of some monitor commands because they were introduced in older than minimal required version and do not depend on QEMU build arguments. Michal Prívozník (5): qemuMonitorJSONGetMigrationParams: Don't return early on CommandNotFo

Re: [PATCH v2 2/5] qapi: Add feature flags to enum members

2021-10-21 Thread Markus Armbruster
Kevin Wolf writes: > Am 09.10.2021 um 14:09 hat Markus Armbruster geschrieben: >> This is quite similar to commit 84ab008687 "qapi: Add feature flags to >> struct members", only for enums instead of structs. >> >> Special feature flag 'deprecated' is silently ignored there. This is >> okay only

Re: [PATCH v2 1/5] qapi: Enable enum member introspection to show more than name

2021-10-21 Thread Markus Armbruster
Kevin Wolf writes: > Am 09.10.2021 um 14:09 hat Markus Armbruster geschrieben: >> The next commit will add feature flags to enum members. There's a >> problem, though: query-qmp-schema shows an enum type's members as an >> array of member names (SchemaInfoEnum member @values). If it showed >> a

Re: [PATCH 5/5] qemu: Prefer -numa cpu over -numa node,cpus=

2021-10-21 Thread Igor Mammedov
On Wed, 20 Oct 2021 16:15:29 +0200 Michal Prívozník wrote: > On 10/20/21 1:18 PM, Peter Krempa wrote: > > On Wed, Oct 20, 2021 at 13:07:59 +0200, Michal Prívozník wrote: > >> On 10/6/21 3:32 PM, Igor Mammedov wrote: > >>> On Thu, 30 Sep 2021 14:08:34 +0200 > >>> Peter Krempa wrote: > > >

Re: [PATCH 5/5] qemu: Prefer -numa cpu over -numa node,cpus=

2021-10-21 Thread Igor Mammedov
On Wed, 20 Oct 2021 13:07:59 +0200 Michal Prívozník wrote: > On 10/6/21 3:32 PM, Igor Mammedov wrote: > > On Thu, 30 Sep 2021 14:08:34 +0200 > > Peter Krempa wrote: > > > >> On Tue, Sep 21, 2021 at 16:50:31 +0200, Michal Privoznik wrote: > >>> QEMU is trying to obsolete -numa node,cpus= bec