Re: [PATCH v5 0/5] Add support for librbd encryption

2021-10-27 Thread Han Han
Hi Or, I have a question about this feature. For rbd encryption in ceph, is it introduced from ceph-v16.2.0? Does it require the ceph cluster side >= this version? On Sun, Oct 24, 2021 at 5:54 PM Or Ozeri wrote: > v5: rebased + nit fixes suggested by Peter > v4: > - added disk post parse to

RE: [libvirt][PATCH v7 4/5] Support to query SGX capability

2021-10-27 Thread Huang, Haibin
Modified the comments and merged the latest community patch > -Original Message- > From: Daniel P. Berrangé > Sent: Tuesday, September 28, 2021 10:12 PM > To: Huang, Haibin > Cc: libvir-list@redhat.com; Ding, Jian-feng ; Yang, > Lin A ; Lu, Lianhao ; > pbonz...@redhat.com;

Re: [PATCH v2 4/4] MAINTAINERS: Agree to maintain nanoMIPS TCG frontend

2021-10-27 Thread Richard Henderson
On 10/26/21 9:14 PM, Philippe Mathieu-Daudé wrote: As of this commit, the nanoMIPS toolchains haven't been merged in mainstream projects. However MediaTek provides a toolchain: https://github.com/MediaTek-Labs/nanomips-gnu-toolchain/releases/tag/nanoMIPS-2021.02-01 QEMU deprecation policy

Re: [PATCH v2 3/4] MAINTAINERS: Split MIPS TCG frontend vs MIPS machines/hardware

2021-10-27 Thread Richard Henderson
On 10/26/21 9:14 PM, Philippe Mathieu-Daudé wrote: Hardware emulated models don't belong to the TCG MAINTAINERS section. Move them to a new 'Overall MIPS Machines' section in the 'MIPS Machines' group. Reviewed-by: Jiaxun Yang Signed-off-by: Philippe Mathieu-Daudé

Re: [PATCH v2 2/4] MAINTAINERS: Add entries to cover MIPS CPS / GIC hardware

2021-10-27 Thread Richard Henderson
On 10/26/21 9:14 PM, Philippe Mathieu-Daudé wrote: MIPS CPS and GIC models are unrelated to the TCG frontend. Move them as new sections under the 'Devices' group. Cc: Paul Burton Reviewed-by: Jiaxun Yang Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 20 ++-- 1 file

Re: [PATCH v2 1/4] MAINTAINERS: Add MIPS general architecture support entry

2021-10-27 Thread Richard Henderson
On 10/26/21 9:14 PM, Philippe Mathieu-Daudé wrote: The architecture is covered in TCG (frontend and backend) and hardware models. Add a generic section matching the 'mips' word in patch subjects. Reviewed-by: Jiaxun Yang Signed-off-by: Philippe Mathieu-Daudé

Re: [PATCH] qemu: Extend qemu.conf with PCR banks to activate during 'TPM manufacturing'

2021-10-27 Thread Stefan Berger
On 10/27/21 14:17, Marc-André Lureau wrote: Hi On Wed, Oct 27, 2021 at 9:00 PM Stefan Berger wrote: Extend qemu.conf with a configration option swtpm_active_pcr_banks that allows a user to set a comma-separated list of PCR banks to activate during 'TPM manufacturing'. Valid PCR banks are

Re: [PATCH] qemu: Extend qemu.conf with PCR banks to activate during 'TPM manufacturing'

2021-10-27 Thread Marc-André Lureau
Hi On Wed, Oct 27, 2021 at 9:00 PM Stefan Berger wrote: > > Extend qemu.conf with a configration option swtpm_active_pcr_banks that > allows a user to set a comma-separated list of PCR banks to activate > during 'TPM manufacturing'. Valid PCR banks are sha1,sha256,sha384 and > sha512. > Why not

[PATCH] qemu: Extend qemu.conf with PCR banks to activate during 'TPM manufacturing'

2021-10-27 Thread Stefan Berger
Extend qemu.conf with a configration option swtpm_active_pcr_banks that allows a user to set a comma-separated list of PCR banks to activate during 'TPM manufacturing'. Valid PCR banks are sha1,sha256,sha384 and sha512. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2016599 Signed-off-by:

Re: [libvirt PATCH 1/4] PCI VPD: handle additional edge cases

2021-10-27 Thread Dmitrii Shcherbakov
Daniel, > The issue I have is that 'lspci -vvv' will happily report the VPD > data on my machine: > > ... > > while libvirt refuses to report it. Even if the BIOS is not perfectly > following the spec, it is clearly still possible to extract the data > and display it to the user. So I don't think

Re: [libvirt PATCH 1/4] PCI VPD: handle additional edge cases

2021-10-27 Thread Daniel P . Berrangé
On Tue, Oct 26, 2021 at 08:28:20PM +0300, Dmitrii Shcherbakov wrote: > Hi Daniel, > > > Something is still not right with the logic here as this error report > is triggering on my machines. If I comment out this check, then I can > get data reported by libvirt > > The VPD example you shared

Re: [RFC] Allowing SEV attestation

2021-10-27 Thread Daniel P . Berrangé
On Tue, Oct 26, 2021 at 05:29:00PM -0600, Jim Fehlig wrote: > On 5/6/21 04:22, Michal Prívozník wrote: > > Dear list, > > Hi Michal, > > This thread has been quiet for a long time, but I wanted to check if any > work has been done to provide an sev-inject-launch-secret equivalent for > libvirt.

Re: [PATCH 1/3] virthreadpool: Allow setting identity for workers

2021-10-27 Thread Michal Prívozník
On 10/26/21 5:06 PM, Daniel P. Berrangé wrote: > On Tue, Oct 26, 2021 at 04:49:55PM +0200, Michal Prívozník wrote: >> On 10/26/21 4:39 PM, Daniel P. Berrangé wrote: >>> On Tue, Oct 26, 2021 at 12:17:06PM +0200, Michal Privoznik wrote: In some cases the worker func running inside the pool may

Re: [RFC] Allowing SEV attestation

2021-10-27 Thread Michal Prívozník
On 10/27/21 1:29 AM, Jim Fehlig wrote: > On 5/6/21 04:22, Michal Prívozník wrote: >> Dear list, > > Hi Michal, > > This thread has been quiet for a long time, but I wanted to check if any > work has been done to provide an sev-inject-launch-secret equivalent for > libvirt. AFAICT, there was

Re: [libvirt PATCH] spec: Depend on qemu-kvm-block-driver-curl in RHEL-9

2021-10-27 Thread Daniel P . Berrangé
On Wed, Oct 27, 2021 at 03:58:29PM +0200, Jiri Denemark wrote: > The curl block driver is no longer a requirement for qemu-kvm package in > RHEL-9, which breaks support for https network disks. Let's depend on it > explicitly (in libvirt-daemon-kvm meta package) until we possibly > reimplement the

Re: [libvirt PATCH] spec: Depend on qemu-kvm-block-driver-curl in RHEL-9

2021-10-27 Thread Ján Tomko
On a Wednesday in 2021, Jiri Denemark wrote: The curl block driver is no longer a requirement for qemu-kvm package in RHEL-9, which breaks support for https network disks. Let's depend on it explicitly (in libvirt-daemon-kvm meta package) until we possibly reimplement the https disk support

[libvirt PATCH] spec: Depend on qemu-kvm-block-driver-curl in RHEL-9

2021-10-27 Thread Jiri Denemark
The curl block driver is no longer a requirement for qemu-kvm package in RHEL-9, which breaks support for https network disks. Let's depend on it explicitly (in libvirt-daemon-kvm meta package) until we possibly reimplement the https disk support using nbdkit (tracked in bug 2016527).

[PATCH v2] qemu_agent: remove unused code

2021-10-27 Thread Kristina Hanicova
This is v2 of: https://listman.redhat.com/archives/libvir-list/2021-October/msg01064.html Diff to v1: * I forgot to delete another part of the unused code which belonged together (noticed by Jano) This section of code was left unused ever since it was introduced ten years ago. I think we can

Re: [PATCH v3 0/4] Add qemu support setting qos via ovs on ovs interface

2021-10-27 Thread Yalan Zhang
Hi Jinsheng, Thank you for the explanation. From the statistics above, the tc outputs for outbound matches. But I'm confused about the inbound statistics: # virsh domiftune rhel vnet5 inbound.average: *100* inbound.peak : *200* inbound.burst : 256 ... # tc -d class show dev vnet5

Re: [PATCH] qemu_agent: remove unused code

2021-10-27 Thread Ján Tomko
On a Wednesday in 2021, Kristina Hanicova wrote: Missing commit message. Signed-off-by: Kristina Hanicova --- src/qemu/qemu_agent.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c index 5f421be6f6..f7feadd5eb 100644 ---

[PATCH] virsh: Fix ambiguous output in metadata-change event

2021-10-27 Thread Han Han
When you set metadata with type element like the following: dom.setMetadata(libvirt.VIR_DOMAIN_METADATA_ELEMENT, "", 'abc', "HAHAH", 0) Then for `virsh event --all`, then it will output this message: event 'metadata-change' for domain 'rhel9': element HAHAH The message is ambiguous since it

[PATCH] qemu_agent: remove unused code

2021-10-27 Thread Kristina Hanicova
Signed-off-by: Kristina Hanicova --- src/qemu/qemu_agent.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c index 5f421be6f6..f7feadd5eb 100644 --- a/src/qemu/qemu_agent.c +++ b/src/qemu/qemu_agent.c @@ -237,17 +237,6 @@

[PATCH] qemu: support kvm-pv-ipi off

2021-10-27 Thread zhenwei pi
QEMU version 3.1 introduced PV_SEND_IPI CPUID feature bit under commit 7f710c32bb8 (target-i386: adds PV_SEND_IPI CPUID feature bit). This patch adds a new KVM feature 'pv-ipi' to disable this feature (enabled by default). Newer CPU platform (Ex, AMD Zen2) supports hardware accelation for IPI in

Re: [PATCH 5/9] qapi: Generalize struct member policy checking

2021-10-27 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 10/25/21 07:25, Markus Armbruster wrote: >> The generated visitor functions call visit_deprecated_accept() and >> visit_deprecated() when visiting a struct member with special feature >> flag 'deprecated'. This makes the feature flag visible to the actual >>