On 11/15/21 1:59 PM, Dmitrii Shcherbakov wrote:
[...]
diff --git a/tests/virnetdevtest.c b/tests/virnetdevtest.c
index aadbeb1ef4..bdaa94e83c 100644
--- a/tests/virnetdevtest.c
+++ b/tests/virnetdevtest.c
Maybe I'm just looking at it too superficially, but it seems like these
test cases are
Commit 65b0b746b516 changed spice tests to use latest caps. Before this
change, "FLAG_REAL_CAPS" wasn't being set in testQemuInfoInitArgs(). The
absence of this flag triggered the code path inside
testCompareXMLToArgv() that executed testUpdateQEMUCaps(). This function
will update the host CPU via
Hi Daniel,
Thanks a lot for the review, I'll send a v4 with the requested changes included.
On Tue, Nov 16, 2021 at 9:55 PM Daniel P. Berrangé wrote:
> > +int
> > +virNetDevSendVfSetLinkRequest(const char *ifname, int vfInfoType,
> > + const void *payload, const
On Mon, Nov 15, 2021 at 09:59:23PM +0300, Dmitrii Shcherbakov wrote:
> SmartNIC DPUs may not expose some privileged eswitch operations
> to the hypervisor hosts. For example, this happens with Bluefield
> devices running in the ECPF (default) mode for security reasons. While
> VF MAC address
We've been using the new repositories for a few months now,
but the downloads page still points to the obsolete Go packages.
Fixes: 1832c0a02b3c9ceb518a4338cb3609fd7d1233a2
Signed-off-by: Andrea Bolognani
---
docs/downloads.html.in | 24
1 file changed, 12
Originally the default encryption engine is populated in the disk
post-parse callback code. This works for disks but for any additional
images introduced either via the block copy API or via the backup API we
don't populate the default.
In case when the backup or block copy is requested on an
The directory is already created by the build system, so we
don't need to create it explicitly in the spec file; moreover,
the path was incorrect, because it used datadir instead of
localstatedir.
Fixes: 4e041189f85bc1b0f8d5278c0cafdd4aba55beaf
Signed-off-by: Andrea Bolognani
---
On 10/24/2021 9:59 PM, Yan Fu wrote:
Hi,
Could you give a reference link for ch driver please?
Thanks,
Yan Fu
Sorry about the delay with my response. What do you mean by a
reference link?
On Fri, Oct 22, 2021 at 11:43 PM Praveen K Paladugu
mailto:pra...@linux.microsoft.com>> wrote:
On Mon, Nov 15, 2021 at 17:22:52 +0100, Pavel Hrdina wrote:
> Now that we always emulate restarting the VM process events are emitted
> differently so we need to update the code and the comment as well.
>
> Signed-off-by: Pavel Hrdina
> ---
> src/test/test_driver.c | 42
On Tue, Nov 16, 2021 at 16:15:54 +0100, Peter Krempa wrote:
> On Mon, Nov 15, 2021 at 17:22:50 +0100, Pavel Hrdina wrote:
> > Reflect the same change in test driver as in QEMU driver because the
> > compatibility check code isn't perfect.
> >
> > Signed-off-by: Pavel Hrdina
> > ---
> >
On Mon, Nov 15, 2021 at 17:22:53 +0100, Pavel Hrdina wrote:
> This will always happen so there is no need to error out and require
> usage of FORCE flag.
>
> Signed-off-by: Pavel Hrdina
> ---
> src/test/test_driver.c | 12
> 1 file changed, 12 deletions(-)
Reviewed-by: Peter
On Mon, Nov 15, 2021 at 17:22:51 +0100, Pavel Hrdina wrote:
> Now that we always emulate VM process stop we can drop the unused code
> and simply the logic.
>
> Signed-off-by: Pavel Hrdina
> ---
> src/test/test_driver.c | 33 -
> 1 file changed, 8 insertions(+),
On Mon, Nov 15, 2021 at 17:22:50 +0100, Pavel Hrdina wrote:
> Reflect the same change in test driver as in QEMU driver because the
> compatibility check code isn't perfect.
>
> Signed-off-by: Pavel Hrdina
> ---
> src/test/test_driver.c | 29 +++--
> 1 file changed, 7
On Mon, Nov 15, 2021 at 17:22:49 +0100, Pavel Hrdina wrote:
> We should have this check even if FORCE flag is used because later we
> unconditionally copy the `snap->def->dom` and error out if there is no
> copy created. The test driver will always save the VM XML when creating
> new snapshot.
>
On Mon, Nov 15, 2021 at 17:22:54 +0100, Pavel Hrdina wrote:
> We've changed the behavior of this API that from now on it will always
> restart the VM process and we are no longer able to revert to snapshots
> created by libvirt older then 0.9.5.
>
> Signed-off-by: Pavel Hrdina
> ---
>
On Mon, Nov 15, 2021 at 17:22:48 +0100, Pavel Hrdina wrote:
> This will always happen so there is no need to error out and require
> usage of FORCE flag.
>
> Signed-off-by: Pavel Hrdina
> ---
> src/qemu/qemu_snapshot.c | 9 -
> 1 file changed, 9 deletions(-)
Reviewed-by: Peter Krempa
On Mon, Nov 15, 2021 at 17:22:47 +0100, Pavel Hrdina wrote:
> Now that we always restart the QEMU process events are emitted
> differently so we need to update the code and the comment as well.
>
> Signed-off-by: Pavel Hrdina
> ---
> src/qemu/qemu_snapshot.c | 37
On Tue, Nov 16, 2021 at 15:30:02 +0100, Peter Krempa wrote:
> On Mon, Nov 15, 2021 at 17:22:46 +0100, Pavel Hrdina wrote:
> > Now that we always restart QEMU process the loadvm code is unused and
> > can be dropped.
> >
> > Signed-off-by: Pavel Hrdina
> > ---
> > src/qemu/qemu_snapshot.c | 96
On Mon, Nov 15, 2021 at 17:22:46 +0100, Pavel Hrdina wrote:
> Now that we always restart QEMU process the loadvm code is unused and
> can be dropped.
>
> Signed-off-by: Pavel Hrdina
> ---
> src/qemu/qemu_snapshot.c | 96 +++-
> 1 file changed, 26
On Mon, Nov 15, 2021 at 17:22:45 +0100, Pavel Hrdina wrote:
> Our compatibility check code isn't complete and there are cases where it
> fails to detect incompatible configuration and the revert fails. In
> addition future support for external snapshot will always require
> restarting the QEMU
On Mon, Nov 15, 2021 at 17:22:44 +0100, Pavel Hrdina wrote:
> The support to revert snapshots was introduced in libvirt 0.8.0 but
> saving the whole VM XML was implemented later in libvirt 0.9.5.
>
> That is more then 10 years ago so we can safely assume that nobody will
> try reverting to
On Tue, Nov 16, 2021 at 14:52:06 +0100, Ján Tomko wrote:
> Commit 3210c8b04 introduced a separate field 'diskbus' for
> internal use by the commandline formatter.
>
> Adjust the check for address equality to compare the relevant
> fields separately instead of the whole struct.
>
> This means
Commit 3210c8b04 introduced a separate field 'diskbus' for
internal use by the commandline formatter.
Adjust the check for address equality to compare the relevant
fields separately instead of the whole struct.
This means that the changes of the 'diskbus' field added
in commit 03ed14d2d4 no
On Tue, Nov 16, 2021 at 09:18:43 +0100, christian.ehrha...@canonical.com wrote:
> From: Christian Ehrhardt
>
> Since purged is a bool variable it should be initialized by false
> instead of 0.
>
> Suggested-by: Sergio Durigan Junior
> Signed-off-by: Christian Ehrhardt
> ---
>
From: Christian Ehrhardt
Since purged is a bool variable it should be initialized by false
instead of 0.
Suggested-by: Sergio Durigan Junior
Signed-off-by: Christian Ehrhardt
---
src/security/virt-aa-helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
25 matches
Mail list logo
