Re: [libvirt PATCH 3/9] qemu: add -display dbus capability check (to update to 6.3)

2021-11-29 Thread Peter Krempa
On Fri, Nov 05, 2021 at 14:51:13 +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > --- > src/qemu/qemu_capabilities.c | 2 ++ > src/qemu/qemu_capabilities.h | 1 + >

Re: [libvirt PATCH] vz: fix vzCapsAddGuestDomain

2021-11-29 Thread Michal Prívozník
On 11/29/21 17:16, Ján Tomko wrote: > There is a stray 'return -1' executed on all code paths. > > Fixes: c18d9e23fafabcfbb80481e0705931036b8e7331 > Signed-off-by: Ján Tomko > --- > src/vz/vz_driver.c | 2 -- > 1 file changed, 2 deletions(-) > Ooops. Reviewed-by: Michal Privoznik Michal

Re: [libvirt PATCH 4/9] qemu: add -display dbus support

2021-11-29 Thread Michal Prívozník
On 11/5/21 11:51, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Without any extra option, libvirt will start and tell QEMU to connect to > the private VM bus. > > Instead, a D-Bus "address" to connect to can be specified. Or the p2p > mode enabled. > > D-Bus display best

Re: [libvirt PATCH 1/9] qemu: start the D-Bus daemon as needed

2021-11-29 Thread Michal Prívozník
On 11/5/21 11:51, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > The daemon is started on daemon in external devices and hotplug code. > Add a mechanism to start it before qemu, if qemu itself needs it. (it is > already stopped in qemuProcessStop) > > Signed-off-by: Marc-André

Re: [PATCH 2/3] virsh: Add '--full-seclabels' option for dominfo

2021-11-29 Thread Martin Kletzander
On Thu, Sep 02, 2021 at 08:29:35PM +0800, Luke Yue wrote: There is no virsh command uses virDomainGetSecurityLabelList API, so add an option for dominfo to call it and print full list of security labels. Also realign some outputs as it's now "Security labels:" instead of "Security label:".

Re: [PATCH v7 0/2] Dirty Ring support (Libvirt)

2021-11-29 Thread Hyman
Ping Any corrections and suggetions are welcome. Please review, thanks! 在 2021/11/23 22:36, huang...@chinatelecom.cn 写道: From: "Hyman Huang(黄勇)" v7 - rebase on master - modify the following points according to the advice given by Peter 1. skip the -accel switch and reuse the existing

[libvirt PATCH] vz: fix vzCapsAddGuestDomain

2021-11-29 Thread Ján Tomko
There is a stray 'return -1' executed on all code paths. Fixes: c18d9e23fafabcfbb80481e0705931036b8e7331 Signed-off-by: Ján Tomko --- src/vz/vz_driver.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c index b47266290c..23b7795035 100644 ---

Re: [PATCH 1/3] test_driver: Implement virDomainGetSecurityLabelList

2021-11-29 Thread Martin Kletzander
On Thu, Sep 02, 2021 at 08:29:34PM +0800, Luke Yue wrote: Signed-off-by: Luke Yue --- src/test/test_driver.c | 42 ++ 1 file changed, 42 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 2f19b7c520..1b5914c890 100644 ---

Re: [libvirt PATCH 00/10] Enable hyperv-passthrough

2021-11-29 Thread Ján Tomko
On a Friday in 2021, Tim Wiederhake wrote: This series enables "hv-passthrough" in libvirt. See https://bugzilla.redhat.com/show_bug.cgi?id=1851249. Example usage in VM definition: Tim Wiederhake (10): schema: Wrap hyperv element in choice and group schema: Add optional "mode"

Re: [libvirt PATCH 06/10] docs: domain: Add documentation for "hyperv"'s new "mode" attribute

2021-11-29 Thread Ján Tomko
On a Friday in 2021, Tim Wiederhake wrote: Signed-off-by: Tim Wiederhake --- docs/formatdomain.rst | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index eb8c973cf1..95ef2e0d05 100644 --- a/docs/formatdomain.rst +++

Re: [PATCH v2] tools: fix iterating over argv when recovering xattr

2021-11-29 Thread Martin Kletzander
On Fri, Nov 26, 2021 at 03:46:56PM +, Daniel P. Berrangé wrote: The libvirt_recover_xattrs.sh tool hangs when run. When not flags s/not/no/ are provided OPTIND is 1, so the loop expands to 'shift 0' which has not effect. Rewrite to just loop over $@ instead which involves less

Re: [PATCH v3 12/12] tests: Test detach-device and detach-device-alias for test driver

2021-11-29 Thread Luke Yue
On Mon, 2021-11-29 at 15:50 +0100, Martin Kletzander wrote: > On Mon, Nov 29, 2021 at 10:41:51PM +0800, Luke Yue wrote: > > On Fri, 2021-11-26 at 16:44 +0100, Martin Kletzander wrote: > > > On Wed, Nov 10, 2021 at 10:24:31PM +0800, Luke Yue wrote: > > > > Signed-off-by: Luke Yue > > > > --- > > >

Re: [PATCH v3 02/12] domain_driver: extract DetachXXXDeviceConfig related functions and use them

2021-11-29 Thread Luke Yue
On Mon, 2021-11-29 at 15:33 +0100, Martin Kletzander wrote: > On Mon, Nov 29, 2021 at 09:06:57PM +0800, Luke Yue wrote: > > On Fri, 2021-11-26 at 16:43 +0100, Martin Kletzander wrote: > > > On Wed, Nov 10, 2021 at 10:24:21PM +0800, Luke Yue wrote: > > > > libxl / lxc / qemu drivers share some

Re: [PATCH v3 12/12] tests: Test detach-device and detach-device-alias for test driver

2021-11-29 Thread Martin Kletzander
On Mon, Nov 29, 2021 at 10:41:51PM +0800, Luke Yue wrote: On Fri, 2021-11-26 at 16:44 +0100, Martin Kletzander wrote: On Wed, Nov 10, 2021 at 10:24:31PM +0800, Luke Yue wrote: > Signed-off-by: Luke Yue > --- > tests/virshtest.c | 96 > +++ > 1 file

Re: [PATCH 2/2] virStorageSourceIsSameLocation: Special-case storage sources of type 'volume'

2021-11-29 Thread Martin Kletzander
On Mon, Nov 29, 2021 at 02:31:55PM +0100, Peter Krempa wrote: On Fri, Nov 26, 2021 at 14:50:37 +0100, Martin Kletzander wrote: On Fri, Nov 26, 2021 at 02:07:54PM +0100, Peter Krempa wrote: > The function is used also to compare virStorageSource which may not be > resolved to the image at that

Re: [PATCH v3 12/12] tests: Test detach-device and detach-device-alias for test driver

2021-11-29 Thread Luke Yue
On Fri, 2021-11-26 at 16:44 +0100, Martin Kletzander wrote: > On Wed, Nov 10, 2021 at 10:24:31PM +0800, Luke Yue wrote: > > Signed-off-by: Luke Yue > > --- > > tests/virshtest.c | 96 > > +++ > > 1 file changed, 96 insertions(+) > > > > This makes the

Re: [PATCH v3 02/12] domain_driver: extract DetachXXXDeviceConfig related functions and use them

2021-11-29 Thread Martin Kletzander
On Mon, Nov 29, 2021 at 09:06:57PM +0800, Luke Yue wrote: On Fri, 2021-11-26 at 16:43 +0100, Martin Kletzander wrote: On Wed, Nov 10, 2021 at 10:24:21PM +0800, Luke Yue wrote: > libxl / lxc / qemu drivers share some common codes in their > DomainDetachDeviceConfig functions, so extract them to

Re: [PATCH v3 08/12] conf: Add a memballoon helper for future use

2021-11-29 Thread Luke Yue
On Fri, 2021-11-26 at 16:44 +0100, Martin Kletzander wrote: > On Wed, Nov 10, 2021 at 10:24:27PM +0800, Luke Yue wrote: > > Currently it will only be used in test driver. > > > > Signed-off-by: Luke Yue > > --- > > src/conf/domain_conf.c   | 24 > > src/conf/domain_conf.h 

Re: [PATCH v3 06/12] conf: Add tpm helpers for future use

2021-11-29 Thread Luke Yue
On Fri, 2021-11-26 at 16:43 +0100, Martin Kletzander wrote: > On Wed, Nov 10, 2021 at 10:24:25PM +0800, Luke Yue wrote: > > Currently it will only be used in the test driver. > > > > Signed-off-by: Luke Yue > > --- > > src/conf/domain_conf.c   | 67 > > >

Re: [PATCH 2/2] virStorageSourceIsSameLocation: Special-case storage sources of type 'volume'

2021-11-29 Thread Peter Krempa
On Fri, Nov 26, 2021 at 14:50:37 +0100, Martin Kletzander wrote: > On Fri, Nov 26, 2021 at 02:07:54PM +0100, Peter Krempa wrote: > > The function is used also to compare virStorageSource which may not be > > resolved to the image at that point in which case the 'path' is not yet > > populated and

Re: [PATCH v3 03/12] test_driver: Implement virDomainDetachDeviceFlags

2021-11-29 Thread Luke Yue
On Fri, 2021-11-26 at 16:43 +0100, Martin Kletzander wrote: > On Wed, Nov 10, 2021 at 10:24:22PM +0800, Luke Yue wrote: > > Introduce testDomainChgDevice for further development (just like > > what we > > did for IOThread). And introduce > > testDomainDetachDeviceLiveAndConfig for > > detaching

Re: [PATCH v3 02/12] domain_driver: extract DetachXXXDeviceConfig related functions and use them

2021-11-29 Thread Luke Yue
On Fri, 2021-11-26 at 16:43 +0100, Martin Kletzander wrote: > On Wed, Nov 10, 2021 at 10:24:21PM +0800, Luke Yue wrote: > > libxl / lxc / qemu drivers share some common codes in their > > DomainDetachDeviceConfig functions, so extract them to > > domain_driver and > > reuse them. > > > > I would

Re: [libvirt PATCH 0/9] WIP/RFC: add QEMU "-display dbus" support

2021-11-29 Thread Marc-André Lureau
Hi On Fri, Nov 5, 2021 at 2:51 PM wrote: > > From: Marc-André Lureau > > Hi, > > This series implements supports for the upcoming QEMU "-display dbus" support. > Development is still in progress, but I hope to land the QEMU support early in > 6.3 (last version posted: >

Re: [PATCH 0/2] wireshark: Fix build with newer wireshark

2021-11-29 Thread Jiri Denemark
On Mon, Nov 29, 2021 at 11:35:48 +0100, Michal Privoznik wrote: > I've started seeing a build failure on rawhide because of new wireshark > (3.6.0). The problem is that wmem_alloc() function which we use was > removed from public symbols starting with the 3.6.0 release in favor of > wmem_new().

[PATCH 1/2] wireshark: Switch to tvb_bytes_to_str()

2021-11-29 Thread Michal Privoznik
When the dissector sees a byte sequence that is either an opaque data (xdr_opaque) or a byte sequence (xdr_bytes) it formats the bytes as a hex numbers using our own implementation. But wireshark already provides a function for it: tvb_bytes_to_str(). NB, the reason why it returns a const string

[PATCH 2/2] wireshark: Drop needless comment in dissect_xdr_bytes()

2021-11-29 Thread Michal Privoznik
In the dissect_xdr_bytes() there's a comment that the string allocated by xdr_bytes() can't be freed using xdr_free(). Well, that is expected because xdr_bytes() used plain calloc() AND the string is not an XDR struct but plain 'char *' type. Passing it to xdr_free() must result in weird things

[PATCH 0/2] wireshark: Fix build with newer wireshark

2021-11-29 Thread Michal Privoznik
I've started seeing a build failure on rawhide because of new wireshark (3.6.0). The problem is that wmem_alloc() function which we use was removed from public symbols starting with the 3.6.0 release in favor of wmem_new(). However, as I was looking at the code I realized that wireshark already

libvirt-7.10.0 release candidate 2

2021-11-29 Thread Jiri Denemark
I have just tagged v7.10.0-rc2 in the repository and pushed signed tarballs and source RPMs to https://libvirt.org/sources/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to