After previous commit, it's no longer possible to change nodeset
for strict numatune. Therefore, we can start generating
host-nodes onto command line again.
This partially reverts d73265af6ec41104c20633b5c0a23688a62105e6.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_command.c
The whole idea of VIR_DOMAIN_NUMATUNE_MEM_RESTRICTIVE is that the
memory location is restricted only via CGroups and thus can be
changed on the fly (which is exactly what
qemuDomainSetNumaParamsLive() does. Allow this mode there then.
Signed-off-by: Michal Privoznik
---
src/qemu/qemu_driver.c |
See 2/3 for explanation.
Michal Prívozník (3):
qemu: Allow VIR_DOMAIN_NUMATUNE_MEM_RESTRICTIVE in
qemuDomainSetNumaParamsLive()
qemu: Explicitly forbid changing nodeset for strict numatune
qemu_command: do use host-nodes for system memory
src/qemu/qemu_command.c
Let's imagine a guest that's configured with strict numatune:
For guests with NUMA:
Depending on machine type used (see commit v6.4.0-rc1~75) we
generate either:
1) -object '{"qom-type":"memory-backend-ram","id":"ram-node0",\
On Wed, Dec 15, 2021 at 18:37:21 +0530, Ani Sinha wrote:
> Commit 52521de8332c2323bd ("qemu: Use qemuDomainSaveStatus") replaced a call
> to virDomainObjSave() with qemuDomainSaveStatus() as a part of cleanup. Since
> qemuDomainSaveStatus() does not indicate any failure through its return code,
>
Over time, the code using them got split into other files.
(Mostly qemu_interface.c and qemu_process.c)
Signed-off-by: Ján Tomko
---
src/qemu/qemu_command.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index
On Tue, Dec 14, 2021 at 9:52 PM Jiri Denemark wrote:
>
> It is a nice wrapper around virDomainObjSave which logs a warning, but
> otherwise ignores the error. Let's use it where appropriate.
>
> Signed-off-by: Jiri Denemark
> ---
> src/qemu/qemu_domain.c| 11 ++---
>
Commit 52521de8332c2323bd ("qemu: Use qemuDomainSaveStatus") replaced a call
to virDomainObjSave() with qemuDomainSaveStatus() as a part of cleanup. Since
qemuDomainSaveStatus() does not indicate any failure through its return code,
the error handling cleanup code got eliminated in the process.
On a Wednesday in 2021, Peter Krempa wrote:
qemu-6.2 is out, update the caps dump for the final time.
Notable changes:
- 'unstable' feature flag for various QMP schema entries
- 'aio-max-batch' iothread property
- 'kernel-hashes' knob for the 'sev-guest' object
- 'native-hotplug' of
On a Wednesday in 2021, Michal Privoznik wrote:
It's not much that's left when no XDR library is found, but some users
might want just stateless drivers.
BTW: there is still one pending issue - if no XDR library is found then
remote driver is turned off which in turn means libvirtd is turned
On 15/12/2021 10.11, Markus Armbruster wrote:
Thomas Huth writes:
This option was just a wrapper around the -display ...,window-close=off
parameter, and the name "no-quit" is rather confusing compared to
"window-close" (since there are still other means to quit the emulator),
so let's remove
Thomas Huth writes:
> This option was just a wrapper around the -display ...,window-close=off
> parameter, and the name "no-quit" is rather confusing compared to
> "window-close" (since there are still other means to quit the emulator),
> so let's remove this now.
>
> Signed-off-by: Thomas Huth
On 12/14/21 17:53, Tim Wiederhake wrote:
> Signed-off-by: Tim Wiederhake
> ---
> docs/formatdomain.rst | 9 -
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
Reviewed-by: Michal Privoznik
Michal
On 12/15/21 09:24, Thomas Huth wrote:
> This option was just a wrapper around the -display ...,window-close=off
> parameter, and the name "no-quit" is rather confusing compared to
> "window-close" (since there are still other means to quit the emulator),
> so let's remove this now.
>
>
On 12/14/21 21:06, Laine Stump wrote:
> On 12/14/21 2:09 PM, Ján Tomko wrote:
>> This bumps the minimum dnsmasq version to the point where we do not need
>> capability probing, reducing it to a version check (which I will be
>> happy to remove on request).
>>
>> Unless I missed something, this
This option was just a wrapper around the -display ...,window-close=off
parameter, and the name "no-quit" is rather confusing compared to
"window-close" (since there are still other means to quit the emulator),
so let's remove this now.
Signed-off-by: Thomas Huth
---
docs/about/deprecated.rst
On 12/14/21 17:53, Tim Wiederhake wrote:
> Previous patch neglected the possibility of different modes for hyperv
> (e.g. "custom" and "passthrough").
>
> Fixes: 6e83fafe331dd0b4fb19aa384c3dd36b3af62933
> Signed-off-by: Tim Wiederhake
> ---
> src/conf/domain_conf.c | 9 +
> 1 file
On 12/14/21 16:01, Tim Wiederhake wrote:
> Signed-off-by: Tim Wiederhake
> ---
> docs/manpages/virsh.rst | 2 +-
> src/qemu/qemu_domain.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Michal Privoznik
Michal
On 12/14/21 17:22, Jiri Denemark wrote:
> Jiri Denemark (2):
> qemu: Use qemuDomainSaveStatus
> qemu: Drop driver parameter from qemuDomainSetFakeReboot
>
> src/qemu/qemu_domain.c| 12 ++---
> src/qemu/qemu_domain.h| 3 +-
> src/qemu/qemu_driver.c| 14 +++---
>
19 matches
Mail list logo
