[PATCH] virNetDevOpenvswitchUpdateVlan: fix vlan tag update error

From: tuqiang We try to update vlan tag by running virsh update-device command, libvirtd will report ovs-vsctl arguments error. Vlan tag update funtion does't consider the xml with no vlan configured circumstances. The steps to reproduce the problem: 1 define and start domain with its vlan

Re: [PATCH] cpu_conf: unbreak XPath in virCPUDefParseXML()

On a Tuesday in 2022, Michal Privoznik wrote: In one of my previous commits, I've changed an XPath in virCPUDefParseXML() from "boolean(./counter...)" to "./counter...)". Notice the dangling closing bracket? Well, I didn't back then. Fixes: 0fe2d8dd335054fae38b46bbbac58a4662e1a1d0

Re: [PATCH] libxl: Release auto-allocated spice ports

On a Monday in 2022, Jim Fehlig wrote: While VNC ports auto-allocated by the libxl driver are released in libxlDomainCleanup, spice ports are overlooked. Rework the existing logic to release any auto-allocated graphics ports, not just the VNC port of the first graphics device. Signed-off-by:

[PATCH] cpu_conf: unbreak XPath in virCPUDefParseXML()

In one of my previous commits, I've changed an XPath in virCPUDefParseXML() from "boolean(./counter...)" to "./counter...)". Notice the dangling closing bracket? Well, I didn't back then. Fixes: 0fe2d8dd335054fae38b46bbbac58a4662e1a1d0 Signed-off-by: Michal Privoznik --- src/conf/cpu_conf.c | 2

[libvirt][PATCH RESEND v10 5/5] qemu: Add command-line to generate SGX EPC memory backend

From: Lin Yang According to the result parsing from xml, add the argument of SGX EPC memory backend into QEMU command line: #qemu-system-x86_64 \ .. \ -object memory-backend-epc,id=mem1,size=64M,prealloc=on \ -object memory-backend-epc,id=mem2,size=28M \

[libvirt][PATCH RESEND v10 3/5] Add unit test for domaincapsdata sgx

Signed-off-by: Haibin Huang --- src/conf/domain_capabilities.c| 2 -- tests/domaincapsdata/bhyve_basic.x86_64.xml | 1 + tests/domaincapsdata/bhyve_fbuf.x86_64.xml| 1 + tests/domaincapsdata/bhyve_uefi.x86_64.xml| 1 + tests/domaincapsdata/empty.xml

[libvirt][PATCH RESEND v10 2/5] conf: expose SGX feature in domain capabilities

Extend hypervisor capabilities to include sgx feature. When available, the hypervisor supports launching an VM with SGX on Intel platfrom. The SGX feature tag privides additional details like section size and sgx1 or sgx2. Signed-off-by: Haibin Huang --- docs/formatdomaincaps.html.in | 26

RE: [libvirt][PATCH v10 5/5] Update default CPU location in qemu QOM tree

Please ignore just this patchset, which should be re-worked to be compatible with older QEME version as you pointed out and submitted after corresponding QEMU patch get merged. > -Original Message- > From: Ani Sinha > Sent: Saturday, February 5, 2022 10:02 PM > To: Huang, Haibin > Cc:

Re: [PATCH 0/2] lib: Use g_clear_pointer() more

On a Monday in 2022, Michal Privoznik wrote: *** BLURB HERE *** Michal Prívozník (2): vbox_common: Drop needless set to NULL lib: Use g_clear_pointer() more src/ch/ch_driver.c | 6 +- src/ch/ch_process.c| 3 +- src/conf/capabilities.c

[libvirt][PATCH RESEND v10 4/5] conf: Introduce SGX EPC element into device memory xml

From: Lin Yang ... 512 ... Signed-off-by: Lin Yang --- docs/formatdomain.rst | 9 +++- docs/schemas/domaincommon.rng | 1 + src/conf/domain_conf.c| 6 +++ src/conf/domain_conf.h

[libvirt][PATCH RESEND v10 1/5] qemu: provide support to query the SGX capability

QEMU version >= 6.2.0 provides support for creating enclave on SGX x86 platform using Software Guard Extensions (SGX) feature. This patch adds support to query the SGX capability from the qemu. Signed-off-by: Haibin Huang --- src/conf/domain_capabilities.c| 10 ++

[libvirt][PATCH RESEND v10 0/5] Support query and use SGX

Because the 5th patch was sent by mistake, so replace the 5th patch and send it again. This patch series provides support for enabling Intel's Software Guard Extensions (SGX) feature in guest VM. Giving the SGX support in QEMU had been merged. Intel SGX is a set of instructions that increases

Re: [PATCH 0/7] qemu: Don't use hardcoded QOM path for vcpu

On a Monday in 2022, Peter Krempa wrote: Peter Krempa (7): qemuMonitorJSONGetCPUx86Data: Unexport qemuProcessUpdateAndVerifyCPU: Refactor cleanup qemu: monitor: Don't hardcode QOM path of first CPU qemu: domain: Store 'qomPath' in qemuDomainVcpuPrivate qemu: process: Move cpu flag querying

Re: [PATCH 4/7] qemu: domain: Store 'qomPath' in qemuDomainVcpuPrivate

On a Monday in 2022, Peter Krempa wrote: The QOM path will be needed by code which is querying the cpu flags via 'qom-get' and thus needs a valid QOM path to the vCPU. Add it into the private data and transfer from the queried data. Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 3

Re: [PATCH 3/3] nodedev: add parent_addr to mdev nodedev dumpxml

On 2/4/22 6:10 PM, Jonathon Jongsma wrote: On 2/4/22 9:32 AM, Boris Fiuczynski wrote: As the parent address is part of the mdev nodedev name lets expose the internally available parent address in the XML. What is the issue that you're trying to solve here? The mdev xml already has a

Re: [libvirt PATCH 0/4] qemu: make nvram creation more robust and enable recovery

On a Monday in 2022, Daniel P. Berrangé wrote: Daniel P. Berrangé (4): qemu: do crash safe creation of NVRAM file include: define constants for resetting NVRAM state qemu: wire up support for resetting NVRAM tools: add --reset-nvram arg to several virsh commands docs/manpages/virsh.rst

Re: [PATCH 4/7] qemu: domain: Store 'qomPath' in qemuDomainVcpuPrivate

On Mon, Feb 07, 2022 at 17:35:29 +0100, Ján Tomko wrote: > On a Monday in 2022, Peter Krempa wrote: > > The QOM path will be needed by code which is querying the cpu flags via > > 'qom-get' and thus needs a valid QOM path to the vCPU. > > > > Add it into the private data and transfer from the

[PATCH 0/2] lib: Use g_clear_pointer() more

*** BLURB HERE *** Michal Prívozník (2): vbox_common: Drop needless set to NULL lib: Use g_clear_pointer() more src/ch/ch_driver.c | 6 +- src/ch/ch_process.c| 3 +- src/conf/capabilities.c| 9 +-- src/conf/domain_conf.c

Re: [PATCH] qemu: fix formatting of pflash readonly attribute

On a Monday in 2022, Daniel P. Berrangé wrote: When the had an explicit readonly='no' attribute we accidentally still marked the plfash as readonly due to the bad conversion from virTristateBool to bool. Signed-off-by: Daniel P. Berrangé --- src/qemu/qemu_domain.c| 3

[libvirt PATCH 11/11] node_device: Use automatic mutex management

Signed-off-by: Tim Wiederhake --- src/node_device/node_device_driver.c | 23 +++- src/node_device/node_device_udev.c | 52 2 files changed, 26 insertions(+), 49 deletions(-) diff --git a/src/node_device/node_device_driver.c

[PATCH 1/2] vbox_common: Drop needless set to NULL

There are two places where a variable passed to VBOX_RELEASE() macro is set to NULL explicitly. There is no need for that because the macro sets the variable to NULL already. Signed-off-by: Michal Privoznik --- src/vbox/vbox_common.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[libvirt PATCH 08/11] ch: Remove solitary virMutexUnlock

Signed-off-by: Tim Wiederhake --- src/ch/ch_driver.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/ch/ch_driver.c b/src/ch/ch_driver.c index 945a1aa225..4c1a9bae77 100644 --- a/src/ch/ch_driver.c +++ b/src/ch/ch_driver.c @@ -242,7 +242,6 @@ chDomainCreateXML(virConnectPtr conn,

[libvirt PATCH 02/11] virthreadpool: Cleanup

Signed-off-by: Tim Wiederhake --- src/util/virthreadpool.c | 51 ++-- 1 file changed, 13 insertions(+), 38 deletions(-) diff --git a/src/util/virthreadpool.c b/src/util/virthreadpool.c index b6d154802a..2f1d49d665 100644 --- a/src/util/virthreadpool.c +++

Re: [libvirt PATCH 0/4] [RFC] Functional CI - GitLab enablement

On Mon, Jan 31, 2022 at 07:00:57PM +0100, Erik Skultety wrote: > I'd like to propose a PoC of a GitLab-driven functional CI based on GitLab's > custom executor runner feature. ping? I'd like to get more comments on whether this proposal is heading the right direction. Also, patches 1-2/4 were

[PATCH 2/2] lib: Use g_clear_pointer() more

This change was generated using the following spatch: @ rule1 @ expression a; identifier f; @@ <... - f(*a); ... when != a; - *a = NULL; + g_clear_pointer(a, f); ...> @ rule2 @ expression a; identifier f; @@ <... - f(a); ... when != a; - a = NULL;

[libvirt PATCH 00/11] Automatic mutex management

Use the recently implemented VIR_LOCK_GUARD and VIR_WITH_MUTEX_LOCK_GUARD to simplify mutex management. This made a solitary "virMutexUnlock()" call without previous call to "virMutexLock()" in ch_driver.c obvious, which is removed in patch #8. Tim Wiederhake (11): virthreadpool: Use automatic

Re: [PATCH v4 2/4] hw/i386: Attach CPUs to machine

On Mon, 7 Feb 2022 at 11:56, Daniel P. Berrangé wrote: > AFAIK, we've never defined anything about QOM paths wrt ABI one way > or the other ? In the absence of guidelines then it comes down to > what are reasonable expectations of the mgmt app. These expectations > will be influenced by what it

Re: [PATCH] libxl: Set auto-allocated graphics ports to used on reconnect

On a Friday in 2022, Jim Fehlig wrote: The libxl driver reconnects to all running VMs when libvirtd is restarted, but it failed to mark auto-allocated graphics ports as set in the port allocator. If many VMs are running that use port auto-allocation and libvirtd is restarted, the port allocator

Re: [PATCH v4 2/4] hw/i386: Attach CPUs to machine

On Mon, 7 Feb 2022 11:48:27 + Daniel P. Berrangé wrote: > On Mon, Feb 07, 2022 at 12:22:22PM +0100, Igor Mammedov wrote: > > On Mon, 7 Feb 2022 10:36:42 +0100 > > Peter Krempa wrote: > > > > > On Mon, Feb 07, 2022 at 10:18:43 +0100, Igor Mammedov wrote: > > > > On Mon, 7 Feb 2022

[libvirt PATCH 10/11] bhyve_driver: Use automatic mutex management

Signed-off-by: Tim Wiederhake --- src/bhyve/bhyve_conf.c | 7 ++- src/bhyve/bhyve_driver.c | 12 src/bhyve/bhyve_utils.h | 3 --- 3 files changed, 2 insertions(+), 20 deletions(-) diff --git a/src/bhyve/bhyve_conf.c b/src/bhyve/bhyve_conf.c index 5eca0855f0..28981c90b7

[libvirt PATCH 03/11] libxl: Use automatic memory management

Signed-off-by: Tim Wiederhake --- src/libxl/libxl_conf.c | 8 ++-- src/libxl/libxl_conf.h | 12 src/libxl/libxl_logger.c | 20 +--- 3 files changed, 11 insertions(+), 29 deletions(-) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index

[libvirt PATCH 09/11] network: Use automatic mutex management

Signed-off-by: Tim Wiederhake --- src/network/bridge_driver.c | 41 + 1 file changed, 10 insertions(+), 31 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 23d9ed4226..3750da7962 100644 ---

[libvirt PATCH 07/11] ch: Use automatic mutex management

This leaves a bogus `virMutexUnlock` in `chDomainCreateXML`. Signed-off-by: Tim Wiederhake --- src/ch/ch_conf.c | 20 src/ch/ch_conf.h | 10 -- src/ch/ch_driver.c | 30 +++--- 3 files changed, 23 insertions(+), 37 deletions(-) diff --git

[libvirt PATCH 06/11] ch: Prepare virCHDriverGetCapabilities for automatic mutex management

No functional change intended. This change makes the refactoring to automatic mutex management easier to follow. Signed-off-by: Tim Wiederhake --- src/ch/ch_conf.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/src/ch/ch_conf.c b/src/ch/ch_conf.c index

[libvirt PATCH 05/11] lxc: Use automatic mutex management

Signed-off-by: Tim Wiederhake --- src/lxc/lxc_conf.c | 31 ++- src/lxc/lxc_conf.h | 9 - src/lxc/lxc_controller.c | 25 ++--- src/lxc/lxc_fuse.c | 12 ++-- 4 files changed, 30 insertions(+), 47 deletions(-) diff

[libvirt PATCH 04/11] lxc: Prepare virLXCDriverGetCapabilities for automatic mutex management

No functional change intended. This change makes the recfatoring to automatic mutex management easier to follow. Signed-off-by: Tim Wiederhake --- src/lxc/lxc_conf.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/src/lxc/lxc_conf.c

[libvirt PATCH 01/11] virthreadpool: Use automatic memory management

Signed-off-by: Tim Wiederhake --- src/util/virthreadpool.c | 39 +-- 1 file changed, 13 insertions(+), 26 deletions(-) diff --git a/src/util/virthreadpool.c b/src/util/virthreadpool.c index 426840e435..b6d154802a 100644 --- a/src/util/virthreadpool.c +++

[libvirt PATCH 4/4] tools: add --reset-nvram arg to several virsh commands

This wires up support for resetting NVRAM for all APIs that allow this feature. Signed-off-by: Daniel P. Berrangé --- docs/manpages/virsh.rst | 21 + tools/virsh-domain.c| 18 ++ tools/virsh-snapshot.c | 6 ++ 3 files changed, 41 insertions(+), 4

[libvirt PATCH 2/4] include: define constants for resetting NVRAM state

When starting a guest with pflash based firmware, we will initialize NVRAM from a template if it does not already exist. In theory if the firmware code file is updated, the existing NVRAM variables should continue to work correctly. It is inevitable that this could break accidentally one day. Or a

[PATCH] qemu: fix formatting of pflash readonly attribute

When the had an explicit readonly='no' attribute we accidentally still marked the plfash as readonly due to the bad conversion from virTristateBool to bool. Signed-off-by: Daniel P. Berrangé --- src/qemu/qemu_domain.c| 3 +-

[PATCH 5/7] qemu: process: Move cpu flag querying after code probing cpus

Upcoming changes will require that we have a proper QOM path for cpus when querying the flags as qemu is going to change it. By moving the flag probing code later we'll already probe the QOM paths so no re-query will be needed. Signed-off-by: Peter Krempa --- src/qemu/qemu_process.c | 8

[libvirt PATCH 1/4] qemu: do crash safe creation of NVRAM file

If we crash part way through writing the NVRAM file we end up with an unusable NVRAM on file. To avoid this we need to write to a temporary file and fsync(2) at the end, then rename to the real NVRAM file path. Signed-off-by: Daniel P. Berrangé --- src/qemu/qemu_process.c | 24

[PATCH 6/7] qemu: process: Move call to qemuProcessRefreshCPU after cpu probe

Similarly to previous commit we need to probe the vcpus first. Signed-off-by: Peter Krempa --- src/qemu/qemu_process.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index f99b14b846..bd9c6ed747 100644 ---

[PATCH 4/7] qemu: domain: Store 'qomPath' in qemuDomainVcpuPrivate

The QOM path will be needed by code which is querying the cpu flags via 'qom-get' and thus needs a valid QOM path to the vCPU. Add it into the private data and transfer from the queried data. Signed-off-by: Peter Krempa --- src/qemu/qemu_domain.c | 3 +++ src/qemu/qemu_domain.h | 2 ++ 2 files

[libvirt PATCH 0/4] qemu: make nvram creation more robust and enable recovery

Daniel P. Berrangé (4): qemu: do crash safe creation of NVRAM file include: define constants for resetting NVRAM state qemu: wire up support for resetting NVRAM tools: add --reset-nvram arg to several virsh commands docs/manpages/virsh.rst | 21 ---

[PATCH 7/7] qemu: process: Don't use hardcoded QOM path for cpu for probing flags

Modify 'qemuProcessGetVCPUQOMPath' to take the detected QOM path of the first vCPU which is always present as the QOM path used our code probing CPU flags via 'qom-get'. This is needed as upcoming qemu will change it. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/272 Resolves:

[PATCH 2/7] qemuProcessUpdateAndVerifyCPU: Refactor cleanup

Use automatic memory clearing and remove the 'ret' variable. Signed-off-by: Peter Krempa --- src/qemu/qemu_process.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index ea586e54c1..d080ab1c49 100644 ---

[PATCH 3/7] qemu: monitor: Don't hardcode QOM path of first CPU

Convert all code using the 'QOM_CPU_PATH' macro to accept the QOM path as an argument. For now the new helper for fetching the path 'qemuProcessGetVCPUQOMPath' will always return the same hard-coded value. Signed-off-by: Peter Krempa --- src/qemu/qemu_monitor.c | 17 ++--

Re: [PATCH v4 2/4] hw/i386: Attach CPUs to machine

On Mon, Feb 07, 2022 at 12:22:22PM +0100, Igor Mammedov wrote: > On Mon, 7 Feb 2022 10:36:42 +0100 > Peter Krempa wrote: > > > On Mon, Feb 07, 2022 at 10:18:43 +0100, Igor Mammedov wrote: > > > On Mon, 7 Feb 2022 09:14:37 +0100 > > > Igor Mammedov wrote: > > > > > > > On Sat, 5 Feb 2022

[PATCH 0/7] qemu: Don't use hardcoded QOM path for vcpu

Peter Krempa (7): qemuMonitorJSONGetCPUx86Data: Unexport qemuProcessUpdateAndVerifyCPU: Refactor cleanup qemu: monitor: Don't hardcode QOM path of first CPU qemu: domain: Store 'qomPath' in qemuDomainVcpuPrivate qemu: process: Move cpu flag querying after code probing cpus qemu:

Re: [PATCH v4 2/4] hw/i386: Attach CPUs to machine

On Mon, Feb 07, 2022 at 16:50:28 +0530, Ani Sinha wrote: > On Mon, Feb 7, 2022 at 3:12 PM Peter Krempa wrote: > > > > On Mon, Feb 07, 2022 at 10:36:42 +0100, Peter Krempa wrote: > > > On Mon, Feb 07, 2022 at 10:18:43 +0100, Igor Mammedov wrote: > > > > On Mon, 7 Feb 2022 09:14:37 +0100 > > > >

Re: [PATCH v4 2/4] hw/i386: Attach CPUs to machine

On Mon, Feb 7, 2022 at 4:58 PM Peter Krempa wrote: > > On Mon, Feb 07, 2022 at 16:50:28 +0530, Ani Sinha wrote: > > On Mon, Feb 7, 2022 at 3:12 PM Peter Krempa wrote: > > > > > > On Mon, Feb 07, 2022 at 10:36:42 +0100, Peter Krempa wrote: > > > > On Mon, Feb 07, 2022 at 10:18:43 +0100, Igor

Re: [PATCH v4 2/4] hw/i386: Attach CPUs to machine

On Mon, 7 Feb 2022 10:36:42 +0100 Peter Krempa wrote: > On Mon, Feb 07, 2022 at 10:18:43 +0100, Igor Mammedov wrote: > > On Mon, 7 Feb 2022 09:14:37 +0100 > > Igor Mammedov wrote: > > > > > On Sat, 5 Feb 2022 13:45:24 +0100 > > > Philippe Mathieu-Daudé wrote: > > > > > > > Previously

[libvirt PATCH 3/4] qemu: wire up support for resetting NVRAM

We can now replace the existing NVRAM file on startup when the API requests this. Signed-off-by: Daniel P. Berrangé --- src/qemu/qemu_driver.c| 24 ++-- src/qemu/qemu_process.c | 8 +--- src/qemu/qemu_process.h | 1 + src/qemu/qemu_saveimage.c | 9 +++--

[PATCH 1/7] qemuMonitorJSONGetCPUx86Data: Unexport

The function is used only as a helper in src/qemu/qemu_monitor_json.c Signed-off-by: Peter Krempa --- src/qemu/qemu_monitor_json.c | 2 +- src/qemu/qemu_monitor_json.h | 5 - 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c

Re: [PATCH v4 2/4] hw/i386: Attach CPUs to machine

On Mon, Feb 7, 2022 at 3:12 PM Peter Krempa wrote: > > On Mon, Feb 07, 2022 at 10:36:42 +0100, Peter Krempa wrote: > > On Mon, Feb 07, 2022 at 10:18:43 +0100, Igor Mammedov wrote: > > > On Mon, 7 Feb 2022 09:14:37 +0100 > > > Igor Mammedov wrote: > > [...] > > > Even if we change it in libvirt

Re: [libvirt PATCH] docs: remove twitter from the website

On Fri, Feb 04, 2022 at 05:01:54PM +0100, Ján Tomko wrote: > Regardless of the platform being mostly advertising, trolling > and promoting stupidity [0][1], the link points to the 'libvirt' > hashtag which never gained traction or contained useful information. Ok, I get it, you don't like

Re: [PULL 31/31] linux-user: Remove the deprecated ppc64abi32 target

Thomas Huth writes: > On 12/01/2022 12.27, Alex Bennée wrote: >> From: Thomas Huth >> It's likely broken, and nobody cared for picking it up again >> during the deprecation phase, so let's remove this now. >> Since this is the last entry in deprecated_targets_list, remove >> the related code

Re: removing VMs logs

On 2/7/22 09:22, Nikolay Shirokovskiy wrote: > Hi, all. > > Libvirt QEMU driver writes QEMU process log to > /var/log/libvirt/qemu/.log file. This file is owned by libvirt > that is no API client knows about it and no client will remove it. Thus > this file stays forever. I guess it does not

Re: [PATCH v4 2/4] hw/i386: Attach CPUs to machine

On Mon, Feb 07, 2022 at 10:36:42AM +0100, Peter Krempa wrote: > On Mon, Feb 07, 2022 at 10:18:43 +0100, Igor Mammedov wrote: > > On Mon, 7 Feb 2022 09:14:37 +0100 > > Igor Mammedov wrote: > > > > > On Sat, 5 Feb 2022 13:45:24 +0100 > > > Philippe Mathieu-Daudé wrote: > > > > > > > Previously

[PATCH] virhostcpu: fix getting CPU freq for Apple Silicon

The current implementation of virHostCPUGetInfo for macOS (__APPLE__) reads "hw.cpufrequency" from sysctl, which is available only on x86_64 architecture. On Apple Silicon ARM Macs, it's not available: $ sysctl hw.cpufrequency # No output $ arch -x86_64 sysctl hw.cpufrequency #

[PATCH] virhostcpu: fix getting CPU freq for Apple Silicon

The current implementation of virHostCPUGetInfo for macOS (__APPLE__) reads "hw.cpufrequency" from sysctl, which is available only on x86_64 architecture. On Apple Silicon ARM Macs, it's not available: $ sysctl hw.cpufrequency # No output $ arch -x86_64 sysctl hw.cpufrequency #