On a Wednesday in 2022, Daniel P. Berrangé wrote:
The systemd version in RHEL-7 lacked support for the LISTEN_FDNAMES env
variable with socket activation. Since we stopped targetting RHEL-7 we
can drop some considerable amount of compatibility code.
Signed-off-by: Daniel P. Berrangé
---
s/feature/features/
On a Wednesday in 2022, Andrea Bolognani wrote:
All these features are supposed to be handled by the call to
virDriverFeatureIsGlobal() placed right above the switch
statement, so group them together and add a comment. If any of
these features is actually encountered as part
The systemd version in RHEL-7 lacked support for the LISTEN_FDNAMES env
variable with socket activation. Since we stopped targetting RHEL-7 we
can drop some considerable amount of compatibility code.
Signed-off-by: Daniel P. Berrangé
---
docs/daemons.rst| 26 ---
On Wed, Feb 16, 2022 at 05:38:43PM +, Daniel P. Berrangé wrote:
> On Wed, Feb 16, 2022 at 05:56:33PM +0100, Ján Tomko wrote:
> > On a Wednesday in 2022, Daniel P. Berrangé wrote:
> > > The systemd version in RHEL-7 lacked support for the LISTEN_FDNAMES env
> > > variable with socket
On Wed, Feb 16, 2022 at 04:41:04PM +0100, Peter Krempa wrote:
> In a review of code using FD passing I was asked to add the check, so I
> wanted to see how it works and found a few issues.
>
> Peter Krempa (8):
> driver: Introduce global driver feature flag handling function
>
All these features are supposed to be handled by the call to
virDriverFeatureIsGlobal() placed right above the switch
statement, so group them together and add a comment. If any of
these features is actually encountered as part of the switch
statements, that means there's a bug in the driver and
On Wed, Feb 16, 2022 at 05:56:33PM +0100, Ján Tomko wrote:
> On a Wednesday in 2022, Daniel P. Berrangé wrote:
> > The systemd version in RHEL-7 lacked support for the LISTEN_FDNAMES env
> > variable with socket activation. Since we stopped targetting RHEL-7 we
> > can drop some considerable
On a Wednesday in 2022, Daniel P. Berrangé wrote:
The systemd version in RHEL-7 lacked support for the LISTEN_FDNAMES env
variable with socket activation. Since we stopped targetting RHEL-7 we
can drop some considerable amount of compatibility code.
Signed-off-by: Daniel P. Berrangé
---
On a Wednesday in 2022, Peter Krempa wrote:
In a review of code using FD passing I was asked to add the check, so I
wanted to see how it works and found a few issues.
Peter Krempa (8):
driver: Introduce global driver feature flag handling function
virDriverFeatureIsGlobal: Handle
All APIs using FD passing have this check to prevent sending a
'VIR_NET_CALL_WITH_FDS' to an older daemon but
virDomainCreateXMLWithFiles was missing it.
Now the LXC driver was historically not exposing
VIR_DRV_FEATURE_FD_PASSING, but that is not a problem as LXC always goes
through the remote
This was a lockout to make strings in typed parameters compatible with
versions which didn't have them. Now all drivers need to expose this
capability.
This namely enables it for 'esx' and 'vz' drivers, while they don't seem
to be implementing any parameters for now, they might later.
keepalive is a RPC feature, drivers must say that it's not supported.
Signed-off-by: Peter Krempa
---
src/driver.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/driver.c b/src/driver.c
index b450400084..6bebfeba58 100644
--- a/src/driver.c
+++ b/src/driver.c
@@
VIR_DRV_FEATURE_REMOTE is a special flag which is asserted only when the
connection is remote. All drivers implementing it must return 0 for it
to work. Handle it in the global handler and add a comment why.
Signed-off-by: Peter Krempa
---
src/driver.c | 11 +--
1 file changed, 9
The 'virDrvFeature' has a combination of features which are asserted by
the specific driver and features which are actually global.
In many cases the implementation was cargo-culted into newer drivers
without re-assesing whether it makes sense.
This patch introduces a global function which will
The feature implies that fd passing works with RPC. Non-remote impls
thus should always report support.
Signed-off-by: Peter Krempa
---
src/driver.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/driver.c b/src/driver.c
index 54b4ad5b43..758ee3e320 100644
---
They are features of the RPC; drivers must say that it's not supported.
Signed-off-by: Peter Krempa
---
src/driver.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/driver.c b/src/driver.c
index 6bebfeba58..9852a1cb17 100644
--- a/src/driver.c
+++ b/src/driver.c
The fix was on RPC level so everything should advertise it.
Signed-off-by: Peter Krempa
---
src/driver.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/driver.c b/src/driver.c
index d070861cfd..54b4ad5b43 100644
--- a/src/driver.c
+++ b/src/driver.c
@@ -357,10
In a review of code using FD passing I was asked to add the check, so I
wanted to see how it works and found a few issues.
Peter Krempa (8):
driver: Introduce global driver feature flag handling function
virDriverFeatureIsGlobal: Handle VIR_DRV_FEATURE_REMOTE
virDriverFeatureIsGlobal:
The systemd version in RHEL-7 lacked support for the LISTEN_FDNAMES env
variable with socket activation. Since we stopped targetting RHEL-7 we
can drop some considerable amount of compatibility code.
Signed-off-by: Daniel P. Berrangé
---
src/locking/lock_daemon.c | 8 +--
On 2/15/22 19:54, Daniel P. Berrangé wrote:
> There are a mind bending number of possible ways to configure the
> firmware with/without NVRAM. Only a small portion are tested and
> many error scenarios are silently ignored.
>
> This series attempts to get coverage of every possible XML config
>
On 2/15/22 19:54, Daniel P. Berrangé wrote:
> This demonstrates that
>
>
> /usr/share/OVMF/OVMF_CODE.fd
>
>
>
> gets expanded to give a per-VM NVRAM path.
>
> Signed-off-by: Daniel P. Berrangé
> ---
> .../bios-nvram-template.x86_64-latest.args| 37 +++
>
On 2/15/22 19:54, Daniel P. Berrangé wrote:
> The QEMU driver will populate the template to the nvram file any time it
> sees both the template and nvram paths present. It will auto-generate a
> nvram path per-VM if not provided by the user, but only if the loader
> is marked R/O.
>
> So with a
On 2/15/22 19:54, Daniel P. Berrangé wrote:
> When using we still parse the path,
> but completely ignore it, replacing any user provided content with
> a custom generated path. This makes sense since when undefining the
> guest, the code to cleanup NVRAM also uses the same generated path.
>
>
On Wed, Feb 16, 2022 at 15:33:57 +0300, Nikolay Shirokovskiy wrote:
> ср, 16 февр. 2022 г. в 11:58, Peter Krempa :
>
> > On Wed, Feb 16, 2022 at 11:38:01 +0300, Nikolay Shirokovskiy wrote:
> > > Currently taking an internal inactive snapshot with a disk excluded from
> > > snapshot using
On Wed, Feb 16, 2022 at 11:25:40AM +0100, Michal Prívozník wrote:
> On 2/8/22 06:21, Haibin Huang wrote:
> > From: Lin Yang
> >
> > According to the result parsing from xml, add the argument of
> > SGX EPC memory backend into QEMU command line:
> >
> > #qemu-system-x86_64 \
> >
On 2/8/22 06:21, Haibin Huang wrote:
> From: Lin Yang
>
> According to the result parsing from xml, add the argument of
> SGX EPC memory backend into QEMU command line:
>
> #qemu-system-x86_64 \
> .. \
> -object memory-backend-epc,id=mem1,size=64M,prealloc=on \
>
On 2/8/22 06:21, Haibin Huang wrote:
> Extend hypervisor capabilities to include sgx feature. When available,
> the hypervisor supports launching an VM with SGX on Intel platfrom.
> The SGX feature tag privides additional details like section size and
> sgx1 or sgx2.
>
> Signed-off-by: Haibin
On 2/8/22 06:21, Haibin Huang wrote:
> QEMU version >= 6.2.0 provides support for creating enclave on
> SGX x86 platform using Software Guard Extensions (SGX) feature.
> This patch adds support to query the SGX capability from the qemu.
>
> Signed-off-by: Haibin Huang
> ---
>
On 2/8/22 06:21, Haibin Huang wrote:
> Because the 5th patch was sent by mistake, so replace the 5th patch and
> send it again.
>
> This patch series provides support for enabling Intel's Software
> Guard Extensions (SGX) feature in guest VM.
> Giving the SGX support in QEMU had been merged.
On 2/8/22 06:21, Haibin Huang wrote:
> From: Lin Yang
>
>
> ...
>
>
> 512
>
>
> ...
>
>
> Signed-off-by: Lin Yang
> ---
> docs/formatdomain.rst | 9 +++-
> docs/schemas/domaincommon.rng | 1 +
> src/conf/domain_conf.c
On Wed, Feb 16, 2022 at 11:38:01 +0300, Nikolay Shirokovskiy wrote:
> Currently taking an internal inactive snapshot with a disk excluded from
> snapshot using snapshot="no" will fail with error "Disk device '%s' does
> not support snapshotting".
The idea for internal snapshots since we wanted
31 matches
Mail list logo
