I accept all comments. But I didn't your point for this comment .
> > +static void
> > +virQEMUCapsFormatSGXInfo(virQEMUCaps *qemuCaps, virBuffer *buf) {
> > +virSGXCapabilityPtr sgx =
> > +virQEMUCapsGetSGXCapabilities(qemuCaps);
> > +
> > +virBufferAddLit(buf, "\n");
> > +
On 2/21/22 10:21, Ján Tomko wrote:
On a Tuesday in 2022, Daniel Henrique Barboza wrote:
We're going to use the 'targetIndex' element for PowerNV PHBs. Clarify
that the same attribute will have a different meaning in this context.
Signed-off-by: Daniel Henrique Barboza
---
On Tue, Feb 22, 2022 at 03:19:58PM +0100, Erik Skultety wrote:
> > Note that I have adjusted the value of log_filters to match what is
> > recommended in
> >
> > https://libvirt.org/kbase/debuglogs.html#less-verbose-logging-for-qemu-vms
> >
> > but maybe there's a reason you had picked a
On a Tuesday in 2022, Peter Krempa wrote:
In case when a user starts a block copy operation with
VIR_DOMAIN_BLOCK_COPY_SHALLOW and VIR_DOMAIN_BLOCK_COPY_REUSE_EXT and
both the reused image and the original disk have a backing image libvirt
specifically does not insert the backing image until
Instead of using XPath, parse the using the XML node and
property helpers so the code is consistent with the parsing of
.
Reviewed-by: Michal Privoznik
Signed-off-by: Daniel P. Berrangé
---
src/conf/domain_conf.c | 17 +
1 file changed, 13 insertions(+), 4 deletions(-)
diff
The virDomainLoaderDef struct contains fields for both and
elements, so it makes sense to parse them in the same method,
just like we'll format them in the same method.
Reviewed-by: Michal Privoznik
Signed-off-by: Daniel P. Berrangé
---
src/conf/domain_conf.c | 92
There are a mind bending number of possible ways to configure the
firmware with/without NVRAM. Only a small portion are tested and
many error scenarios are silently ignored.
This series attempts to get coverage of every possible XML config
scenario and report explicit errors in all invalid
Currently if the firmware attribute is set then we silently
ignore most of the and element configs. This
changes the code so that we always fully parse the and
but then use a post-parse method to explicitly reject
invalid combinations.
Reviewed-by: Michal Privoznik
Signed-off-by: Daniel P.
When using we still parse the path,
but completely ignore it, replacing any user provided content with
a custom generated path. This makes sense since when undefining the
guest, the code to cleanup NVRAM also uses the same generated path.
Instead of silently ignoring user config, we should
The QEMU driver will populate the template to the nvram file any time it
sees both the template and nvram paths present. It will auto-generate a
nvram path per-VM if not provided by the user, but only if the loader
is marked R/O.
So with a R/O loader we have these possible scenarios
- No NVRAM
In case when a user starts a block copy operation with
VIR_DOMAIN_BLOCK_COPY_SHALLOW and VIR_DOMAIN_BLOCK_COPY_REUSE_EXT and
both the reused image and the original disk have a backing image libvirt
specifically does not insert the backing image until after the job is
asked to be completed via
On 2/21/22 10:36, Ján Tomko wrote:
On a Tuesday in 2022, Daniel Henrique Barboza wrote:
Hiding the empty (:00:0.0) PCI address in the case of devices that
will connect to slot 0x0 can be counterintuitive to the user, which will
see something like this:
Even if
On 2/22/22 17:21, Ján Tomko wrote:
> On a Tuesday in 2022, Michal Privoznik wrote:
>> When building the default memory backend (which has id='pc.ram')
>> and no guest NUMA is configured then
>> qemuBuildMemCommandLineMemoryDefaultBackend() is called. However,
>> its return value is ignored which
On a Tuesday in 2022, Michal Privoznik wrote:
When building the default memory backend (which has id='pc.ram')
and no guest NUMA is configured then
qemuBuildMemCommandLineMemoryDefaultBackend() is called. However,
its return value is ignored which means that on invalid
configuration (e.g. when
On a Tuesday in 2022, Peter Krempa wrote:
Signed-off-by: Peter Krempa
---
NEWS.rst | 19 +++
1 file changed, 19 insertions(+)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
So, we're offloading as much CI configuration/workflow stuff to lcitool
as possible. We can generate config files, install/update machines
(local or remote), dump Dockerfiles...we can't build and run those containers
locally. Instead, we have a CI helper script in libvirt repo which essentially
On 2/2/22 4:09 AM, Michal Prívozník wrote:
> On 2/1/22 15:33, Lubomir Rintel wrote:
>> My day started like this:
>>
>> # virt-install --connect qemu:///system --arch mips --machine malta
>> --memory 256 --disk none --import
>> Using default --name vm-mips
>>
>> Starting install...
>>
Signed-off-by: Peter Krempa
---
NEWS.rst | 19 +++
1 file changed, 19 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst
index b684416909..169ac9b740 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -64,6 +64,25 @@ v8.1.0 (unreleased)
* **Bug fixes**
+ * Remove unix sockets from
On Thu, Feb 17, 2022 at 09:54:12AM -0800, Andrea Bolognani wrote:
> On Mon, Jan 31, 2022 at 07:01:01PM +0100, Erik Skultety wrote:
> > +++ b/.gitlab-ci-integration.yml
> > @@ -0,0 +1,116 @@
> > +.tests:
> > + stage: integration
> > + before_script:
> > +- mkdir "$SCRATCH_DIR"
> > +- sudo
On Tue, Feb 22, 2022 at 03:10:52PM +0100, Tim Wiederhake wrote:
> On Thu, 2022-02-17 at 13:15 +, Daniel P. Berrangé wrote:
> > On Thu, Feb 17, 2022 at 02:01:01PM +0100, Tim Wiederhake wrote:
> >
> > Really should be giving an explanation of why this change
> > is required.
> >
> Added
...
>
> > +- for daemon in $DAEMONS;
> > + do
> > +sudo sed -Ei
> > "s/^(#)?(log_outputs=).*/\2'1:file:\/var\/log\/libvirt\/${daemon}.log'/"
> > /etc/libvirt/${daemon}.conf;
> > +sudo sed -Ei "s/^(#)?(log_filters=).*/\2'4:*object* 4:*json*
> > 4:*event* 4:*rpc*
Signed-off-by: Tim Wiederhake
---
NEWS.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/NEWS.rst b/NEWS.rst
index b684416909..cc5666fa91 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -32,7 +32,7 @@ v8.1.0 (unreleased)
either of the following 3 options:
``page-sampling,
On Thu, 2022-02-17 at 13:15 +, Daniel P. Berrangé wrote:
> On Thu, Feb 17, 2022 at 02:01:01PM +0100, Tim Wiederhake wrote:
>
> Really should be giving an explanation of why this change
> is required.
>
Added locally to commit message:
Making the mutex static and independent of the
On Tue, Feb 22, 2022 at 08:38:10AM +0100, Michal Prívozník wrote:
> On 2/21/22 17:17, Andrea Bolognani wrote:
> > On Mon, Feb 21, 2022 at 04:10:25PM +0100, Michal Privoznik wrote:
> >> +VIR_ENUM_IMPL(qemuMonitorDirtyRateCalcMode,
> >> + QEMU_MONITOR_DIRTYRATE_CALC_MODE_LAST,
> >> +
On 2/15/22 15:52, Martin Kletzander wrote:
> Since libvirt-guests script/service can operate on various URIs and we do
> support both socket activation and traditional services, the ordering should
> be
> specified for all the possible sockets and services.
>
> Also remove the Wants= dependency
On 2/16/22 11:25, Michal Prívozník wrote:
>> diff --git a/tests/qemuxml2argvdata/sgx-epc.x86_64-6.2.0.args
>> b/tests/qemuxml2argvdata/sgx-epc.x86_64-6.2.0.args
>> new file mode 100644
>> index 00..e1aa274054
>> --- /dev/null
>> +++ b/tests/qemuxml2argvdata/sgx-epc.x86_64-6.2.0.args
>>
When building the default memory backend (which has id='pc.ram')
and no guest NUMA is configured then
qemuBuildMemCommandLineMemoryDefaultBackend() is called. However,
its return value is ignored which means that on invalid
configuration (e.g. when non-existent hugepage size was
requested) an
27 matches
Mail list logo
