Re: [libvirt PATCH 0/3] docs: downloads: mark GitLab as the primary source

On 3/10/22 20:14, Ján Tomko wrote: > Also remove links to gitweb interface on libvirt.org which > is no longer available. > > Ján Tomko (3): > docs: downloads: remove links to libvirt.org mirrors > docs: downloads: remove reference to git:// > docs: downloads: mark GitLab as the primary

Re: [libvirt] [PATCH RESEND v2 0/4] re-introduce

On Wed, Mar 09, 2022 at 12:47:26PM +0530, Ani Sinha wrote: > > > On Tue, 8 Mar 2022, Michael S. Tsirkin wrote: > > > On Tue, Mar 08, 2022 at 10:23:20PM +0530, Ani Sinha wrote: > > > On Tue, Mar 8, 2022 at 10:17 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Tue, Mar 08, 2022 at

[PATCH RFC 1/1] qemu: capabilities: disable csske for host cpu

CPU models past gen16a will no longer support the csske feature. In order to secure migration of guests running on machines that still support this feature to machines that do not, let's disable csske in the host-model. Signed-off-by: Collin Walling --- src/qemu/qemu_capabilities.c

[PATCH RFC 0/1] s390x CPU Model Feature Deprecation

The s390x architecture has a growing list of features that will no longer be supported on future hardware releases. This introduces an issue with migration such that guests, running on models with these features enabled, will be rejected outright by machines that do not support these features. A

[libvirt PATCH 2/3] docs: downloads: remove reference to git://

With the introduction of smart HTTP protocol in git 1.6.6, the only advantage of plain git:// over https:// is not having the encryption overhead. Remove the reference to git://, assuming the overhead is neligible compared to the value of screen space on the downloads page. Signed-off-by: Ján

[libvirt PATCH 3/3] docs: downloads: mark GitLab as the primary source

Document our usage of GitLab and the read-only mirrors. Signed-off-by: Ján Tomko --- docs/downloads.rst | 27 +-- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/docs/downloads.rst b/docs/downloads.rst index 3b36f668d7..d438166b78 100644 ---

[libvirt PATCH 1/3] docs: downloads: remove links to libvirt.org mirrors

While the mirrors themselves are still available, the gitweb interface on libvirt.org has been disabled. The mirrors can still be accessible via, e.g.: git clone https://libvirt.org/git/libvirt-python.git But such link gives a 404 error. Remove the links from the website to avoid confusion.

[libvirt PATCH 0/3] docs: downloads: mark GitLab as the primary source

Also remove links to gitweb interface on libvirt.org which is no longer available. Ján Tomko (3): docs: downloads: remove links to libvirt.org mirrors docs: downloads: remove reference to git:// docs: downloads: mark GitLab as the primary source docs/downloads.rst | 106

Re: [PATCH 1/8] docs: Convert 'downloads' page to rST

On Thu, Mar 10, 2022 at 17:07:54 +0100, Ján Tomko wrote: > On a Thursday in 2022, Peter Krempa wrote: > > The table was manually converted to a set of 'list-table'-s for better > > experience of viewing the text. > > > > Signed-off-by: Peter Krempa > > --- > > docs/downloads.html.in | 661

Re: [PATCH 0/8] docs: Convert some pages to rST and clean up (part 2)

On a Thursday in 2022, Peter Krempa wrote: Jano asked me to expedite the conversion of the 'downloads' page so he can do some modifications. Peter Krempa (8): docs: Convert 'downloads' page to rST https://pipo.sk.gitlab.io/-/libvirt/-/jobs/2188545131/artifacts/website/downloads.html docs:

Re: [PATCH 1/8] docs: Convert 'downloads' page to rST

On a Thursday in 2022, Peter Krempa wrote: The table was manually converted to a set of 'list-table'-s for better experience of viewing the text. Signed-off-by: Peter Krempa --- docs/downloads.html.in | 661 - docs/downloads.rst | 417

[PATCH 8/8] docs: Convert 'testsuites' page to rST

Signed-off-by: Peter Krempa --- docs/meson.build| 2 +- docs/testsuites.html.in | 41 - docs/testsuites.rst | 37 + 3 files changed, 38 insertions(+), 42 deletions(-) delete mode 100644

[PATCH 7/8] docs: Convert 'testtck' page to rST

Signed-off-by: Peter Krempa --- docs/meson.build | 2 +- docs/testtck.html.in | 40 docs/testtck.rst | 37 + 3 files changed, 38 insertions(+), 41 deletions(-) delete mode 100644 docs/testtck.html.in create

[PATCH 6/8] docs: Convert 'pci-hotplug' page to rST

One internal reference was modified to work properly. Signed-off-by: Peter Krempa --- docs/meson.build | 2 +- docs/pci-hotplug.html.in | 185 --- docs/pci-hotplug.rst | 146 ++ 3 files changed, 147 insertions(+), 186

[PATCH 1/8] docs: Convert 'downloads' page to rST

The table was manually converted to a set of 'list-table'-s for better experience of viewing the text. Signed-off-by: Peter Krempa --- docs/downloads.html.in | 661 - docs/downloads.rst | 417 ++ docs/meson.build | 2 +-

[PATCH 5/8] docs: Convert 'nss' page to rST

Signed-off-by: Peter Krempa --- docs/meson.build | 2 +- docs/nss.html.in | 189 --- docs/nss.rst | 154 ++ 3 files changed, 155 insertions(+), 190 deletions(-) delete mode 100644 docs/nss.html.in create mode

[PATCH 4/8] syntax-check: Don't check for non-reentrant functions in '.rst' files

Signed-off-by: Peter Krempa --- build-aux/syntax-check.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index a8c9153b20..d1db1d0267 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -1620,7

[PATCH 3/8] docs: Convert 'testapi' page to rST

Signed-off-by: Peter Krempa --- docs/meson.build | 2 +- docs/testapi.html.in | 35 --- docs/testapi.rst | 34 ++ 3 files changed, 35 insertions(+), 36 deletions(-) delete mode 100644 docs/testapi.html.in create mode

[PATCH 2/8] docs: Convert 'contact' page to rST

Preserve the 'irc' and 'email' anchors. Signed-off-by: Peter Krempa --- docs/contact.html.in | 116 --- docs/contact.rst | 94 +++ docs/meson.build | 2 +- 3 files changed, 95 insertions(+), 117 deletions(-)

[PATCH 0/8] docs: Convert some pages to rST and clean up (part 2)

Jano asked me to expedite the conversion of the 'downloads' page so he can do some modifications. Peter Krempa (8): docs: Convert 'downloads' page to rST https://pipo.sk.gitlab.io/-/libvirt/-/jobs/2188545131/artifacts/website/downloads.html docs: Convert 'contact' page to rST

[PATCH RESEND] virsh: Provide completer for vol-wipe algorithms

Related issue: https://gitlab.com/libvirt/libvirt/-/issues/9 Signed-off-by: Haonan Wang --- tools/virsh-completer-volume.c | 19 +++ tools/virsh-completer-volume.h | 6 ++ tools/virsh-volume.c | 3 +-- tools/virsh-volume.h | 3 +++ 4 files changed, 29

[PATCH] virsh: Provide completer for vol-wipe algorithms

Related issue: https://gitlab.com/libvirt/libvirt/-/issues/9 Signed-off-by: Haonan Wang --- tools/virsh-completer-volume.c | 20 tools/virsh-completer-volume.h | 6 ++ tools/virsh-volume.c | 3 +-- tools/virsh-volume.h | 3 +++ 4 files changed, 30

Re: [PATCH 00/14] Snapshot definition cleanups

On a Thursday in 2022, Peter Krempa wrote: Cleanup patches extracted from my upcoming series for handling snapshots with outsourced storage. Peter Krempa (14): virDomainDiskDefFormat: Refactor to virXMLFormatElement qemuSnapshotDiskPrepareActiveExternal: Handle only external snapshots

Re: [PATCH 00/10] qemu: Update capabilities and use 'tls-hostname' field for NBD

On a Thursday in 2022, Peter Krempa wrote: Technically patch 7/10 is more of a RFC for now as my migration setup doesn't work properly so I could not test it. I have not tested it either. Peter Krempa (10): tests: qemucapabilities: Update caps_7.0.0.x86_64 qemu: capabilities: Introduce

[PATCH 12/14] virDomainSnapshotDefParse: Decouple parsing of memory snapshot config

Separate the steps of parsing the memory snapshot config from the post-processing and validation code. The upcoming patch refactoring the parsing will be simpler. Signed-off-by: Peter Krempa --- src/conf/snapshot_conf.c | 50 1 file changed, 30

[PATCH 14/14] qemuSnapshotCreateActiveExternal: Remove duplicit assignment

The block of code pausing the VM assigns 'resume' to true but it's already true because of the previous condition. The code is deliberately kept in two blocks as upcoming changes will modify both conditions. Signed-off-by: Peter Krempa --- src/qemu/qemu_snapshot.c | 2 -- 1 file changed, 2

[PATCH 13/14] conf: snapshot: Use proper types for snapshot location

Refactor the code to use proper types for the memory and disk snapshot location and fix the parsing code to be compatible with an unsigned type. Signed-off-by: Peter Krempa --- src/conf/snapshot_conf.c | 39 +-- src/conf/snapshot_conf.h | 4 ++-- 2 files

Re: [PATCH 03/10] qemuMigrationSrcRun: Fix misleading comment about NBD with TLS support

On a Thursday in 2022, Peter Krempa wrote: We do support non-shared storage migration with TLS now. Fix the comment claiming otherwise. Fixes: a8dc146a4d14b6f169f27b6d238452beb254a637 Signed-off-by: Peter Krempa --- src/qemu/qemu_migration.c | 5 + 1 file changed, 1 insertion(+), 4

[PATCH 11/14] virDomainSnapshotDefParse: Avoid 'memoryfile' temporary variable

Assign directly into the definition. The cleanup code can deal with that. Signed-off-by: Peter Krempa --- src/conf/snapshot_conf.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/src/conf/snapshot_conf.c b/src/conf/snapshot_conf.c index f3b264d2e1..7f98ae6aec

[PATCH 08/14] qemuDomainSnapshotForEachQcow2Raw: Act only on internal snapshots

Similarly to the external snapshot code the internal inactive snapshot creation helper should act only when an internal snapshot of the disk is required. For now the callers ensure that it's either _INTERNAL or _NO when control reaches this function. Signed-off-by: Peter Krempa ---

[PATCH 10/14] virDomainSnapshotDefParse: Refactor cleanup

Use automatic memory cleanup, decrease scope of variables and remove the 'cleanup' label. Signed-off-by: Peter Krempa --- src/conf/snapshot_conf.c | 74 +--- 1 file changed, 32 insertions(+), 42 deletions(-) diff --git a/src/conf/snapshot_conf.c

[PATCH 09/14] conf: snapshot: Remove VIR_DOMAIN_SNAPSHOT_PARSE_DISKS flag

All callers except the one in the 'esx' driver pass the flag. The 'esx' driver has a check that 'def->ndisks' is zero after parsing the definition. This means that we can simply always parse the disks. Signed-off-by: Peter Krempa --- src/conf/snapshot_conf.c | 22

[PATCH 07/14] Rename VIR_DOMAIN_SNAPSHOT_LOCATION_NONE to VIR_DOMAIN_SNAPSHOT_LOCATION_NO

The string value associated to the enum is "no". Rename the enum accordingly. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 6 +++--- src/conf/domain_conf.h | 2 +- src/conf/domain_validate.c | 2 +- src/conf/snapshot_conf.c | 12 ++-- src/qemu/qemu_domain.c

[PATCH 06/14] conf: Move definition of 'virDomainSnapshotLocation'

The snapshot location enum is also needed for the disk definition so if we house it inside domain_conf we can use the proper type for it. Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 10 +- src/conf/domain_conf.h | 14 +- src/conf/snapshot_conf.c | 8

[PATCH 05/14] virStorageSource: Convert 'type' to proper enum

Use 'virStorageType' as type for the 'type' member and convert the code to work properly. Signed-off-by: Peter Krempa --- src/ch/ch_monitor.c| 1 + src/conf/domain_conf.c | 27 ++- src/conf/snapshot_conf.c | 24 +---

[PATCH 04/14] virDomainSnapshotDiskDefParseXML: Automatically free temporary variables and remove cleanup

Refactor the function to avoid the cleanup section used to just free memory associated with the parsed object. Signed-off-by: Peter Krempa --- src/conf/snapshot_conf.c | 58 ++-- 1 file changed, 26 insertions(+), 32 deletions(-) diff --git

[PATCH 03/14] qemuSnapshotCreateAlignDisks: Rewrite logic for selecting default memory snapshot mode

Use an if/else branch rather than a expression with a ternary operator. Signed-off-by: Peter Krempa --- src/qemu/qemu_snapshot.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c index f92b571b06..355a2fd782 100644 ---

[PATCH 01/14] virDomainDiskDefFormat: Refactor to virXMLFormatElement

Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 79 -- 1 file changed, 38 insertions(+), 41 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 34fec887a3..69f61aadc1 100644 --- a/src/conf/domain_conf.c +++

[PATCH 00/14] Snapshot definition cleanups

Cleanup patches extracted from my upcoming series for handling snapshots with outsourced storage. Peter Krempa (14): virDomainDiskDefFormat: Refactor to virXMLFormatElement qemuSnapshotDiskPrepareActiveExternal: Handle only external snapshots qemuSnapshotCreateAlignDisks: Rewrite logic for

[PATCH 02/14] qemuSnapshotDiskPrepareActiveExternal: Handle only external snapshots

Preparation steps ensure that the 'snapshot' field can only be 'VIR_DOMAIN_SNAPSHOT_LOCATION_NONE' or VIR_DOMAIN_SNAPSHOT_LOCATION_EXTERNAL' at this point, but upcoming patches will change that. Handle only external snapshots. Signed-off-by: Peter Krempa --- src/qemu/qemu_snapshot.c | 2 +- 1

[PATCH 08/10] NEWS: Mention that VIR_MIGRATE_PARAM_TLS_DESTINATION works now for non-shared storage migration

Signed-off-by: Peter Krempa --- NEWS.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index f0270b9bb1..b9b9807625 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -19,6 +19,12 @@ v8.2.0 (unreleased) * **Improvements** + * qemu: ``VIR_MIGRATE_PARAM_TLS_DESTINATION``

[PATCH 07/10] qemu: migration: Use 'VIR_MIGRATE_PARAM_TLS_DESTINATION' for the NBD connection

The NBD connection for non-shared storage migration can have the same issue regarding TLS certificate name match as the migration connection itself. Propagate the configured name also for the NBD connections. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1901448 Signed-off-by: Peter

[PATCH 10/10] qemuBlockJobDiskNew: Remove misleading return value description

Signed-off-by: Peter Krempa --- src/qemu/qemu_blockjob.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/qemu/qemu_blockjob.c b/src/qemu/qemu_blockjob.c index 2442865b9b..7032814d21 100644 --- a/src/qemu/qemu_blockjob.c +++ b/src/qemu/qemu_blockjob.c @@ -227,8 +227,6 @@

[PATCH 09/10] qemuMigrationSrcNBDStorageCopyOne: Refactor cleanup

Autofree the temporary string and shuffle around the success path to avoid the 'cleanup' label. Signed-off-by: Peter Krempa --- src/qemu/qemu_migration.c | 20 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/src/qemu/qemu_migration.c

[PATCH 06/10] conf: Add support for setting expected TLS hostname for NBD disks

In cases when the hostname of the NBD server doesn't match the hostname in the TLS certificate the new attribute 'tlsHostname' can be used to override it. Add the XML infrastructure and tests. Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 4 +-

[PATCH 04/10] storage_source: Add 'tlsHostname' field to virStorageSource

The value will be used to override the hostname used for validation of TLS certificates. Signed-off-by: Peter Krempa --- src/conf/storage_source_conf.c | 2 ++ src/conf/storage_source_conf.h | 3 +++ 2 files changed, 5 insertions(+) diff --git a/src/conf/storage_source_conf.c

[PATCH 05/10] qemu: Add support for 'tlsHostname' setting of virStorageSource

Add validation and formatting of the blockdev props. Signed-off-by: Peter Krempa --- src/qemu/qemu_block.c | 6 +- src/qemu/qemu_domain.c | 15 +++ 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c index

[PATCH 03/10] qemuMigrationSrcRun: Fix misleading comment about NBD with TLS support

We do support non-shared storage migration with TLS now. Fix the comment claiming otherwise. Signed-off-by: Peter Krempa --- src/qemu/qemu_migration.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index

[PATCH 02/10] qemu: capabilities: Introduce QEMU_CAPS_BLOCKDEV_NBD_TLS_HOSTNAME

Detect that qemu can override TLS hostname setting for NBD clients. Signed-off-by: Peter Krempa --- src/qemu/qemu_capabilities.c | 4 src/qemu/qemu_capabilities.h | 3 +++ tests/qemucapabilitiesdata/caps_7.0.0.x86_64.xml | 1 + 3 files changed, 8

[PATCH 00/10] qemu: Update capabilities and use 'tls-hostname' field for NBD

Technically patch 7/10 is more of a RFC for now as my migration setup doesn't work properly so I could not test it. Peter Krempa (10): tests: qemucapabilities: Update caps_7.0.0.x86_64 qemu: capabilities: Introduce QEMU_CAPS_BLOCKDEV_NBD_TLS_HOSTNAME qemuMigrationSrcRun: Fix misleading

Re: [libvirt PATCH 2/2] conf: use a hash table for storing nwfilter object list

On a Thursday in 2022, Daniel P. Berrangé wrote: The current use of an array for nwfilter objects requires the caller to iterate over all elements to find a filter, and also requires locking each filter. Switching to a pair of hash tables enables O(1) lookups both by name and uuid, with no

Re: [libvirt PATCH 1/2] nwfilter: update comment about locking filter updates

On a Thursday in 2022, Daniel P. Berrangé wrote: The comment against the 'updateMutex' refers to a problem with lock ordering when looking up filters in the virNWFilterObjList which uses an array. That problem does indeed exist. Unfortunately it claims that switching to a hash table would solve

[libvirt PATCH 2/2] conf: use a hash table for storing nwfilter object list

The current use of an array for nwfilter objects requires the caller to iterate over all elements to find a filter, and also requires locking each filter. Switching to a pair of hash tables enables O(1) lookups both by name and uuid, with no locking required. Signed-off-by: Daniel P. Berrangé

[libvirt PATCH 0/2] nwfilter: switch nwfilter list from array to hash

Currently the virNWFilterObjList has O(N) complexity for object lookup and requires taking locks on every object examined. This switches to as hash table which O(1) complexity and lockless lookup. Daniel P. Berrangé (2): nwfilter: update comment about locking filter updates conf: use a hash

[libvirt PATCH 1/2] nwfilter: update comment about locking filter updates

The comment against the 'updateMutex' refers to a problem with lock ordering when looking up filters in the virNWFilterObjList which uses an array. That problem does indeed exist. Unfortunately it claims that switching to a hash table would solve the lock ordering problems during instantiation.