[RFC PATCH v1 0/5] Add virDomainGetSevAttestationReport API

2022-03-23 Thread Tyler Fanelli
This an RFC discussing a new API, virDomainGetSevAttestationReport (along with a virsh command "domgetsevreport"), with initial QEMU support via the "query-sev-attestation-report" QAPI mechanism. "query-sev-attestation-report" is supplied a base64-encoded 16 byte "mnonce" string as input, with a

[PATCH 2/5] remote: add RPC support for the virDomainGetSevAttestationReport API

2022-03-23 Thread Tyler Fanelli
Signed-off-by: Tyler Fanelli --- src/remote/remote_daemon_dispatch.c | 44 +++ src/remote/remote_driver.c | 55 + src/remote/remote_protocol.x| 21 ++- src/remote_protocol-structs | 12 +++ 4 files changed, 131

[PATCH 5/5] tools: add domgetsevreport virsh command

2022-03-23 Thread Tyler Fanelli
After domlaunchsecinfo is used to attest a VM, domgetsevreport can be used to get a full SEV attestation report from the guest. Signed-off-by: Tyler Fanelli --- docs/manpages/virsh.rst | 18 +++ tools/virsh-domain.c| 68 + 2 files changed, 86

[PATCH 4/5] qemu: Implement the virDomainGetSevAttestationReport API

2022-03-23 Thread Tyler Fanelli
Get a SEV attestation report using the query-sev-attestation-report QMP API. Signed-off-by: Tyler Fanelli --- include/libvirt/libvirt-domain.h | 8 +++ src/driver-hypervisor.h | 4 +- src/qemu/qemu_driver.c | 86 src/qemu/qemu_monitor.c

[PATCH 3/5] qemu_capabilities: Introduce QEMU_CAPS_SEV_GET_ATTESTATION_REPORT

2022-03-23 Thread Tyler Fanelli
The 'query-sev-attestation-report' qmp command is only available with qemu >= 6.1.0. Introduce a capability for query-sev-attestation-report. Signed-off-by: Tyler Fanelli --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 +

[PATCH 1/5] libvirt: Introduce virDomainGetSevAttestationReport public API

2022-03-23 Thread Tyler Fanelli
This API allows getting an attestation report from a SEV-enabled guest. The API uses virTypedParameter for input. The details of an attestation report buffer are described in the SEV API spec in section "6.8.2 Parameters, Table 60".

[RFC 0/1] virxml: Accept 'default' for virTristate* properties

2022-03-23 Thread Andrea Bolognani
Sending this as an RFC because it's incomplete. After virXMLPropTristate*() had been introduced, existing code was gradually converted to use the new helpers; however, if you look for example at 593140dabd66 you'll see that the original implementation considered encountering 'default' to be an

[RFC 1/1] virxml: Accept 'default' for virTristate* properties

2022-03-23 Thread Andrea Bolognani
The _ABSENT value of each enumeration has 'default' as string representation, and when that's been formatted to XML we should parse it back successfully, so we can't just treat encountering it as an error. Callers of virXMLPropTristate*() can of course still pass VIR_XML_PROP_NONZERO explicitly

Re: [libvirt PATCH 2/3] conf: add qemu-vdagent channel

2022-03-23 Thread Jonathon Jongsma
On 3/22/22 3:47 PM, Jonathon Jongsma wrote: Add the ability to configure a qemu-vdagent in guest domains. This device is similar to the spice vdagent channel except that qemu handles the spice-vdagent protocol messages itself rather than routing them over a spice protocol channel. The

Re: [libvirt PATCH 0/3] Enable copy/paste for vnc displays

2022-03-23 Thread Daniel P . Berrangé
On Tue, Mar 22, 2022 at 03:47:03PM -0500, Jonathon Jongsma wrote: > This patch series enables support for the qemu-vdagent character device which > enables copy/paste support between guest and client when using vnc graphics. > > The guest must be configured with something like the following: > >

Re: [libvirt PATCH 0/3] Enable copy/paste for vnc displays

2022-03-23 Thread Daniel P . Berrangé
On Wed, Mar 23, 2022 at 09:44:53AM -0500, Jonathon Jongsma wrote: > On 3/23/22 4:17 AM, Daniel P. Berrangé wrote: > > On Wed, Mar 23, 2022 at 12:01:19PM +0400, Marc-André Lureau wrote: > > > Hi > > > > > > On Wed, Mar 23, 2022 at 12:47 AM Jonathon Jongsma > > > wrote: > > > > > > > > This

Re: [libvirt PATCH 0/3] Enable copy/paste for vnc displays

2022-03-23 Thread Marc-André Lureau
Hi On Wed, Mar 23, 2022 at 6:44 PM Jonathon Jongsma wrote: > > On 3/23/22 4:17 AM, Daniel P. Berrangé wrote: > > On Wed, Mar 23, 2022 at 12:01:19PM +0400, Marc-André Lureau wrote: > >> Hi > >> > >> On Wed, Mar 23, 2022 at 12:47 AM Jonathon Jongsma > >> wrote: > >>> > >>> This patch series

Re: [libvirt PATCH 0/3] Enable copy/paste for vnc displays

2022-03-23 Thread Jonathon Jongsma
On 3/23/22 4:17 AM, Daniel P. Berrangé wrote: On Wed, Mar 23, 2022 at 12:01:19PM +0400, Marc-André Lureau wrote: Hi On Wed, Mar 23, 2022 at 12:47 AM Jonathon Jongsma wrote: This patch series enables support for the qemu-vdagent character device which enables copy/paste support between guest

Re: [PATCH v2 2/7] vircommand: Document virCommandSetSendBuffer() behaviour wrt daemonize

2022-03-23 Thread Michal Prívozník
On 3/23/22 08:48, Marc-André Lureau wrote: > Hi > > On Tue, Mar 22, 2022 at 8:02 PM Michal Privoznik > wrote: > > When virCommandSetSendBuffer() is used over a virCommand that is > (or will be) daemonized, then VIR_EXEC_ASYNC_IO the command must > have

Re: [libvirt PATCH 0/3] Enable copy/paste for vnc displays

2022-03-23 Thread Daniel P . Berrangé
On Wed, Mar 23, 2022 at 12:01:19PM +0400, Marc-André Lureau wrote: > Hi > > On Wed, Mar 23, 2022 at 12:47 AM Jonathon Jongsma wrote: > > > > This patch series enables support for the qemu-vdagent character device > > which > > enables copy/paste support between guest and client when using vnc

Re: [libvirt PATCH 0/3] Enable copy/paste for vnc displays

2022-03-23 Thread Marc-André Lureau
Hi On Wed, Mar 23, 2022 at 12:47 AM Jonathon Jongsma wrote: > > This patch series enables support for the qemu-vdagent character device which > enables copy/paste support between guest and client when using vnc graphics. > > The guest must be configured with something like the following: > >

Re: [PATCH v2 2/7] vircommand: Document virCommandSetSendBuffer() behaviour wrt daemonize

2022-03-23 Thread Marc-André Lureau
Hi On Tue, Mar 22, 2022 at 8:02 PM Michal Privoznik wrote: > When virCommandSetSendBuffer() is used over a virCommand that is > (or will be) daemonized, then VIR_EXEC_ASYNC_IO the command must > have VIR_EXEC_ASYNC_IO flag set no later than at > virCommandRunAsync() phase so that the thread

Re: [PATCH 1/4] conf: Introduce memory allocation threads

2022-03-23 Thread Michal Prívozník
On 3/22/22 16:05, Michal Privoznik wrote: > Since its commit v5.0.0-rc0~75^2~1^2~3 QEMU is capable of > specifying number of threads used to allocate memory. While it > defaults to the number of vCPUs, users might want to use a > different value (especially for humongous guests with gigantic >