Related: https://gitlab.com/libvirt/libvirt/-/issues/9
Signed-off-by: natto1784
---
.gitignore | 4
tools/virsh-completer-host.c | 12
tools/virsh-completer-host.h | 5 +
tools/virsh-host.c | 3 +++
4 files changed, 24 insertions(+)
diff
On 3/25/22 16:35, Michal Prívozník wrote:
I'm fixing all the small issues I've raised in review and pushing these.
Reviewed-by: Michal Privoznik
No, please don't! The property is not yet part of QEMU, this should
have been tagged RFC.
Sorry about the confusion.
Paolo
On Thu, Mar 24, 2022 at 07:16:28PM +0100, Michal Prívozník wrote:
> On 3/24/22 18:02, Andrea Bolognani wrote:
> > but I can't help
> > wondering if there are other cases where switching to
> > virXPathString() in the way seen here might have introduced undesired
> > changes in behavior.
> >
> >
The callback ID can be zero, not necessarily positive; correct the
comment to reflect this.
Signed-off-by: John Levon
---
src/libvirt-domain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
index a197618673..53efb60406 100644
---
The property is parsed using virTristateBoolTypeFromString() but
formatted as if it was a regular bool, which results in the
following incorrect conversion:
BOOL_ABSENT -> managed='no'
BOOL_YES-> managed='yes'
BOOL_NO -> managed='yes'
Use the virTristateBoolTypeToString() helper to
The check that ensures that at least one property among accel3d,
accel2d and rendernode has been provided by the user had been
lost during the conversion to virXMLPropTristateBool().
Fixes: 0fe2d8dd335054fae38b46bbbac58a4662e1a1d0
Signed-off-by: Andrea Bolognani
---
src/conf/domain_conf.c | 24
Signed-off-by: Andrea Bolognani
---
src/conf/domain_conf.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 1186ec8417..68191f42bd 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -6856,7
The function may fail and report an error, in which case we
should not just continue as if nothing happened.
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_domain.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index
We need it for a single scenario in which prop='default' has to
be treated as valid input.
Signed-off-by: Andrea Bolognani
---
src/libvirt_private.syms | 1 +
src/util/virxml.c| 18 ++
src/util/virxml.h| 7 +++
3 files changed, 26 insertions(+)
diff --git
If the value is VIR_TRISTATE_BOOL_ABSENT we should just omit
the element entirely.
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_domain.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index a587ebe86d..5fe05cc09a
Up until a few commits ago, libvirt produced this XML and so
we need to be able to read it back to prevent a bunch of
error : virXMLPropEnumInternal:516 : XML error: Invalid value
for attribute 'value' in element 'allowReboot': 'default'
messages from being logged on daemon upgrade when
virNetworkForwardDef.managed is a bool but
virNetworkPortDef.hostdevpci.managed is a virTristateBool, which
means that the current code performs the following incorrect
conversion:
false -> BOOL_ABSENT
true -> BOOL_YES
Using the virTristateBoolFromBool() helper solves the issue.
Fixes:
It's the default behavior.
Signed-off-by: Andrea Bolognani
---
src/conf/domain_conf.c| 6 +++---
src/conf/interface_conf.c | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 731139f80f..1186ec8417 100644
---
I have manually audited all commits that have converted existing
code to use the new helpers (full list below) and have convinced
myself that allowReboot is indeed the only one that requires
special handling.
Changes from [RFC]:
* introduce a separate helper for the one scenario where we need
On 3/25/22 16:35, Michal Prívozník wrote:
>> @@ -12080,6 +12088,15 @@ virDomainTimerDefParseXML(xmlNodePtr node,
>> }
>> }
>>
>> +reboot = virXMLPropString(node, "on_reboot");
>> +if (reboot != NULL) {
>> +if ((def->reboot =
On 3/24/22 10:48, Paolo Bonzini wrote:
> Some versions of Windows hang on reboot if their TSC value is greater
> than 2^54. The workaround is to reset the TSC to a small value. Add
> to the domain configuration an attribute for this. It can be used
> by QEMU and in principle also by ESXi, which
On 3/24/22 10:48, Paolo Bonzini wrote:
> QEMU 7.0.0 adds a new property tsc-clear-on-reset to x86 CPU, corresponding
> to Libvirt's element. Plumb it in the validation,
> command line handling and tests.
>
> Signed-off-by: Paolo Bonzini
> ---
> src/qemu/qemu_capabilities.c |
On 3/24/22 10:48, Paolo Bonzini wrote:
> Some versions of Windows hang on reboot if their TSC value is greater
> than 2^54. The workaround is to reset the TSC to a small value, and
> is implemented by QEMU and ESXi. This series adds a domain attribute
> for this, and implements it in QEMU.
>
>
currently the only user of virFileWrapperFdNew is the qemu driver;
virsh save is very slow with a default pipe size.
This change improves throughput by ~400% on fast nvme or ramdisk.
Best value currently measured is 1MB, which happens to be also
the kernel default for the pipe-max-size.
Signed-off-by: Tim Wiederhake
---
src/qemu/qemu_agent.c | 25 +++--
1 file changed, 11 insertions(+), 14 deletions(-)
diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c
index 4909fb336f..4156cb0dca 100644
--- a/src/qemu/qemu_agent.c
+++ b/src/qemu/qemu_agent.c
@@
Signed-off-by: Tim Wiederhake
---
src/ch/ch_monitor.c | 55 -
1 file changed, 24 insertions(+), 31 deletions(-)
diff --git a/src/ch/ch_monitor.c b/src/ch/ch_monitor.c
index 84085b7991..2c6b83a1b5 100644
--- a/src/ch/ch_monitor.c
+++
Signed-off-by: Tim Wiederhake
---
src/util/virportallocator.c | 93 -
1 file changed, 40 insertions(+), 53 deletions(-)
diff --git a/src/util/virportallocator.c b/src/util/virportallocator.c
index 5e63470848..44edd8f99a 100644
---
Signed-off-by: Tim Wiederhake
---
src/datatypes.c | 63 +++--
1 file changed, 19 insertions(+), 44 deletions(-)
diff --git a/src/datatypes.c b/src/datatypes.c
index aa614612f9..da8a9970f1 100644
--- a/src/datatypes.c
+++ b/src/datatypes.c
@@ -217,71
Signed-off-by: Tim Wiederhake
---
src/node_device/node_device_udev.c | 76 ++
1 file changed, 35 insertions(+), 41 deletions(-)
diff --git a/src/node_device/node_device_udev.c
b/src/node_device/node_device_udev.c
index b3e8103dae..b68dc12158 100644
---
Signed-off-by: Tim Wiederhake
---
src/vbox/vbox_common.c | 31 +--
1 file changed, 13 insertions(+), 18 deletions(-)
diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c
index acd18494d3..03f55f2f1e 100644
--- a/src/vbox/vbox_common.c
+++
Signed-off-by: Tim Wiederhake
---
src/node_device/node_device_driver.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/src/node_device/node_device_driver.c
b/src/node_device/node_device_driver.c
index 130c1d4023..1eb452b989 100644
---
Signed-off-by: Tim Wiederhake
---
src/network/bridge_driver.c | 59 +--
src/network/bridge_driver_linux.c | 4 +--
2 files changed, 25 insertions(+), 38 deletions(-)
diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c
index
Signed-off-by: Tim Wiederhake
---
src/rpc/virnetdaemon.c | 144 +
1 file changed, 45 insertions(+), 99 deletions(-)
diff --git a/src/rpc/virnetdaemon.c b/src/rpc/virnetdaemon.c
index c946e4a92a..1f32bae35f 100644
--- a/src/rpc/virnetdaemon.c
+++
Signed-off-by: Tim Wiederhake
---
src/interface/interface_backend_netcf.c | 192 +++-
1 file changed, 86 insertions(+), 106 deletions(-)
diff --git a/src/interface/interface_backend_netcf.c
b/src/interface/interface_backend_netcf.c
index 92698ee769..d625964421 100644
---
Use the recently implemented VIR_LOCK_GUARD and VIR_WITH_MUTEX_LOCK_GUARD
to simplify mutex management.
Tim Wiederhake (10):
virnetdaemon: Use automatic mutex management
bridge_driver: Use automatic mutex management
node_device_driver: Use automatic mutex management
On 3/25/22 15:43, Paolo Bonzini wrote:
> libparted_dep is not used if -Dstorage_disk=disabled. Do
> not bother looking for it if the disk storage backend was not
> requested.
>
> Signed-off-by: Paolo Bonzini
> ---
> meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff
libparted_dep is not used if -Dstorage_disk=disabled. Do
not bother looking for it if the disk storage backend was not
requested.
Signed-off-by: Paolo Bonzini
---
meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index
On 3/24/22 11:53, Paolo Bonzini wrote:
> rbd_dep is not used if -Dstorage_rbd=disabled. Do not bother looking for
> the libraries that compose it if the rbd storage backend was not requested.
>
> Signed-off-by: Paolo Bonzini
> ---
> meson.build | 4 ++--
> 1 file changed, 2 insertions(+), 2
On 3/24/22 11:53, Paolo Bonzini wrote:
> devmapper_dep and libparted_dep are not used if -Dstorage_disk=disabled. Do
> not bother looking for these libraries if the disk storage backend was not
> requested.
>
> Signed-off-by: Paolo Bonzini
> ---
> meson.build | 4 ++--
> 1 file changed, 2
On 3/24/22 10:36, Paolo Bonzini wrote:
> Make sure that all tests are run after the helpers and mocks are
> (re)built. This enables for example using "meson test" as the
> command line passed to "git bisect run".
>
> Signed-off-by: Paolo Bonzini
> ---
> tests/meson.build | 9 +
> 1
On Fri, Mar 25, 2022 at 02:57:14PM +0100, Claudio Fontana wrote:
> On 3/25/22 2:54 PM, Daniel P. Berrangé wrote:
> > On Fri, Mar 25, 2022 at 02:52:05PM +0100, Claudio Fontana wrote:
> >> On 3/25/22 2:13 PM, Daniel P. Berrangé wrote:
> >>> On Fri, Mar 25, 2022 at 01:54:51PM +0100, Claudio Fontana
On 3/25/22 2:54 PM, Daniel P. Berrangé wrote:
> On Fri, Mar 25, 2022 at 02:52:05PM +0100, Claudio Fontana wrote:
>> On 3/25/22 2:13 PM, Daniel P. Berrangé wrote:
>>> On Fri, Mar 25, 2022 at 01:54:51PM +0100, Claudio Fontana wrote:
currently the only user of virFileWrapperFdNew is the qemu
On Fri, Mar 25, 2022 at 02:52:05PM +0100, Claudio Fontana wrote:
> On 3/25/22 2:13 PM, Daniel P. Berrangé wrote:
> > On Fri, Mar 25, 2022 at 01:54:51PM +0100, Claudio Fontana wrote:
> >> currently the only user of virFileWrapperFdNew is the qemu driver;
> >> virsh save is very slow with a default
On 3/24/22 16:32, Kristina Hanicova wrote:
> These enums are essentially the same and always sorted in the
> same order in every hypervisor with jobs. They can be generalized
> by using the qemu enums as the main ones as they are the most
> extensive.
>
> Signed-off-by: Kristina Hanicova
> ---
>
On 3/24/22 16:32, Kristina Hanicova wrote:
>
> Kristina Hanicova (5):
> move jobs enums QEMU_X into hypervisor as VIR_X
> qemu: move macros QEMU_X into hypervisor as VIR_X
> lxc: use virDomainJob enum instead of virLXCDomainJob
> libxl: use virDomainJob enum instead of libxlDomainJob
>
On Tue, Mar 22, 2022 at 12:27:19 +0100, Peter Krempa wrote:
> v2:
> - patch 1/7 from last time was pushed
> - XML changes:
> - top level element renamed to "qemu:override" to accomodate
> possible extension in the future
> - wrapped 'qemu:props' meant to override the frontend under
On 3/25/22 2:13 PM, Daniel P. Berrangé wrote:
> On Fri, Mar 25, 2022 at 01:54:51PM +0100, Claudio Fontana wrote:
>> currently the only user of virFileWrapperFdNew is the qemu driver;
>> virsh save is very slow with a default pipe size.
>> This change improves throughput by ~400% on fast nvme or
Hi,
On Thu, Mar 24, 2022 at 11:26 PM Jonathon Jongsma wrote:
>
> Implement the qemu-vdagent channel introduced in the previous commit.
>
> Signed-off-by: Jonathon Jongsma
lgtm,
Reviewed-by: Marc-André Lureau
> ---
> src/qemu/qemu_command.c | 21 ++-
>
On Fri, Mar 25, 2022 at 01:54:51PM +0100, Claudio Fontana wrote:
> currently the only user of virFileWrapperFdNew is the qemu driver;
> virsh save is very slow with a default pipe size.
> This change improves throughput by ~400% on fast nvme or ramdisk.
>
> Best value currently measured is 1MB,
Hi
On Thu, Mar 24, 2022 at 11:26 PM Jonathon Jongsma wrote:
>
> Add the ability to configure a qemu-vdagent in guest domains. This
> device is similar to the spice vdagent channel except that qemu handles
> the spice-vdagent protocol messages itself rather than routing them over
> a spice
currently the only user of virFileWrapperFdNew is the qemu driver;
virsh save is very slow with a default pipe size.
This change improves throughput by ~400% on fast nvme or ramdisk.
Best value currently measured is 1MB, which happens to be also
the kernel default for the pipe-max-size.
On Fri, Mar 18, 2022 at 02:34:29PM +0100, Claudio Fontana wrote:
> On 3/17/22 4:03 PM, Dr. David Alan Gilbert wrote:
> > * Claudio Fontana (cfont...@suse.de) wrote:
> >> On 3/17/22 2:41 PM, Claudio Fontana wrote:
> >>> On 3/17/22 11:25 AM, Daniel P. Berrangé wrote:
> On Thu, Mar 17, 2022 at
On 3/25/22 12:14 PM, Daniel P. Berrangé wrote:
> On Fri, Mar 25, 2022 at 11:56:44AM +0100, Claudio Fontana wrote:
>> Thanks Daniel,
>>
>> On 3/25/22 11:33 AM, Daniel P. Berrangé wrote:
>>> On Fri, Mar 18, 2022 at 02:34:29PM +0100, Claudio Fontana wrote:
On 3/17/22 4:03 PM, Dr. David Alan
On Fri, Mar 25, 2022 at 11:56:44AM +0100, Claudio Fontana wrote:
> Thanks Daniel,
>
> On 3/25/22 11:33 AM, Daniel P. Berrangé wrote:
> > On Fri, Mar 18, 2022 at 02:34:29PM +0100, Claudio Fontana wrote:
> >> On 3/17/22 4:03 PM, Dr. David Alan Gilbert wrote:
> >>> * Claudio Fontana
On 3/25/22 11:41 AM, Daniel P. Berrangé wrote:
> On Mon, Mar 21, 2022 at 09:13:20AM +0100, Claudio Fontana wrote:
>> virsh save is very slow with a default pipe size, so set a larger one.
>>
>> This change improves throughput by ~400% on fast nvme or ramdisk,
>> for the current only user of
Thanks Daniel,
On 3/25/22 11:33 AM, Daniel P. Berrangé wrote:
> On Fri, Mar 18, 2022 at 02:34:29PM +0100, Claudio Fontana wrote:
>> On 3/17/22 4:03 PM, Dr. David Alan Gilbert wrote:
>>> * Claudio Fontana (cfont...@suse.de) wrote:
On 3/17/22 2:41 PM, Claudio Fontana wrote:
> On 3/17/22
On Mon, Mar 21, 2022 at 09:13:20AM +0100, Claudio Fontana wrote:
> virsh save is very slow with a default pipe size, so set a larger one.
>
> This change improves throughput by ~400% on fast nvme or ramdisk,
> for the current only user of virFileWrapperFdNew: the qemu driver.
>
> Best value
On Fri, Mar 18, 2022 at 02:34:29PM +0100, Claudio Fontana wrote:
> On 3/17/22 4:03 PM, Dr. David Alan Gilbert wrote:
> > * Claudio Fontana (cfont...@suse.de) wrote:
> >> On 3/17/22 2:41 PM, Claudio Fontana wrote:
> >>> On 3/17/22 11:25 AM, Daniel P. Berrangé wrote:
> On Thu, Mar 17, 2022 at
Hi,
a bit of an early ping on this, just wondering if the general direction of the
changes seems ok.
Thanks,
Claudio
On 3/21/22 9:13 AM, Claudio Fontana wrote:
> virsh save is very slow with a default pipe size, so set a larger one.
>
> This change improves throughput by ~400% on fast nvme
On 3/21/22 8:55 AM, Andrea Righi wrote:
> On Fri, Mar 18, 2022 at 02:34:29PM +0100, Claudio Fontana wrote:
> ...
>> I have lots of questions here, and I tried to involve Jiri and Andrea Righi
>> here, who a long time ago proposed a POSIX_FADV_NOREUSE implementation.
>>
>> 1) What is the reason
On Thu, Mar 24, 2022 at 11:26 PM Jonathon Jongsma wrote:
>
> This enumeration will be useful for vnc with the upcoming qemu-vdagent
> device so make the name more generic.
>
> Signed-off-by: Jonathon Jongsma
Reviewed-by: Marc-André Lureau
> ---
> src/conf/domain_conf.c | 8
>
On Thu, Mar 24, 2022 at 11:26 PM Jonathon Jongsma wrote:
>
> Detect whether qemu supports the qemu-vdagent character device. This
> enables support for copy/paste with VNC graphics.
>
> Signed-off-by: Jonathon Jongsma
Reviewed-by: Marc-André Lureau
> ---
> src/qemu/qemu_capabilities.c
On Thu, Mar 24, 2022 at 21:39:56 +0530, Jamm02 wrote:
> From: Moteen Shah
>
> domain_conf.c: all the option collision total and... error messages in
> virDomainDiskDefIotuneParse shifted to new function virDomainDefPostParseCheck
I don't quite understand what you mean by this commit message. Is
On a Thursday in 2022, Kristina Hanicova wrote:
Signed-off-by: Kristina Hanicova
---
src/qemu/qemu_migration.c | 46 +++
1 file changed, 22 insertions(+), 24 deletions(-)
diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index
On a Thursday in 2022, Kristina Hanicova wrote:
I think the code looks cleaner without else branches.
Signed-off-by: Kristina Hanicova
---
src/qemu/qemu_domainjob.c | 3 +--
src/qemu/qemu_migration.c | 13 +++--
src/qemu/qemu_process.c | 4 ++--
src/qemu/qemu_snapshot.c | 13
On a Friday in 2022, Han Han wrote:
Signed-off-by: Han Han
---
docs/kbase/index.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Ján Tomko
Jano
signature.asc
Description: PGP signature
Signed-off-by: Han Han
---
docs/kbase/index.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/kbase/index.rst b/docs/kbase/index.rst
index 77b23e96a8..860bfde71f 100644
--- a/docs/kbase/index.rst
+++ b/docs/kbase/index.rst
@@ -55,7 +55,7 @@ Usage
`Memory devices `__
62 matches
Mail list logo
