Re: [PATCH] Introduce network-backed NVRAM

Thanks a lot for taking the time to review it ! On 28/03/22 6:35 pm, Peter Krempa wrote: On Sun, Mar 20, 2022 at 21:28:13 -0700, Rohit Kumar wrote: Libvirt domain XML allows only local filepaths to specify a NVRAM element. Since VMs can move across different hosts, it should be possibe to

[libvirt PATCH] util: Improve macOS workaround

Since the workaround is specific to macOS, only disable compiler warnings when building on that platform. While at it, update the comment to reflect the fact that the workaround is needed for all versions of the OS, including the modern ones that we currently target. Signed-off-by: Andrea

[libvirt PATCH] qemu: Use real defaults for user and group in qemu.conf

The default values used by the library are determined at configure time based on a number of factors, and we should reflect them in the installed configuration file to make the comments it contains more useful. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/263 Signed-off-by: Andrea

Re: [PATCH] virConnectDomainEventRegisterAny: correct docs

On Mon, Mar 28, 2022 at 04:21:15PM +0200, Michal Prívozník wrote: > On 3/25/22 17:03, John Levon wrote: > > The callback ID can be zero, not necessarily positive; correct the > > comment to reflect this. > > > > Signed-off-by: John Levon > > --- > > src/libvirt-domain.c | 2 +- > > 1 file

[PATCH 2/3] virDomainLoaderDefFormat: Use modern XML formatting approach

Signed-off-by: Peter Krempa --- src/conf/domain_conf.c | 40 ++-- 1 file changed, 18 insertions(+), 22 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index ba8dd7d7d0..98da3f2460 100644 --- a/src/conf/domain_conf.c +++

[PATCH 1/3] virXMLFormatElement: Introduce virXMLFormatElementInternal

The new function aggregates the internal working of virXMLFormatElement and virXMLFormatElementEmpty and also allows skipping the newline after the opening tag to allow using this helper also in cases where we don't format any child elements but directly a value. Signed-off-by: Peter Krempa ---

[PATCH 3/3] vboxSetBootDeviceOrder: Remove whitespace alignment in VIR_DEBUG statements

Don't try to align the output, it's not future-proof and it's for debugging only. Signed-off-by: Peter Krempa --- src/vbox/vbox_common.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c

[PATCH 0/3] Cleanups based on 'nvram' refactor patch

Few cleanups that I've suggested in the review for adding remote store of nvram. Peter Krempa (3): virXMLFormatElement: Introduce virXMLFormatElementInternal virDomainLoaderDefFormat: Use modern XML formatting approach vboxSetBootDeviceOrder: Remove whitespace alignment in VIR_DEBUG

Re: [PATCH] virConnectDomainEventRegisterAny: correct docs

On 3/25/22 17:03, John Levon wrote: > The callback ID can be zero, not necessarily positive; correct the > comment to reflect this. > > Signed-off-by: John Levon > --- > src/libvirt-domain.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/libvirt-domain.c

Re: [libvirt RFC] virFile: new VIR_FILE_WRAPPER_BIG_PIPE to improve performance

On 3/28/22 12:47 PM, Claudio Fontana wrote: > On 3/26/22 4:49 PM, Claudio Fontana wrote: >> On 3/25/22 12:29 PM, Daniel P. Berrangé wrote: >>> On Fri, Mar 18, 2022 at 02:34:29PM +0100, Claudio Fontana wrote: On 3/17/22 4:03 PM, Dr. David Alan Gilbert wrote: > * Claudio Fontana

Re: [PATCH] virfile: Report error when changing pipe size fails

On 3/28/22 2:24 PM, Claudio Fontana wrote: > On 3/28/22 2:22 PM, Daniel P. Berrangé wrote: >> On Mon, Mar 28, 2022 at 01:46:08PM +0200, Michal Privoznik wrote: >>> When changing the size of pipe that virFileWrapperFdNew() creates >>> we start at 1MiB and if that fails because it's above the system

Re: Request to move my GitLab custom executor repo under the libvirt umbrella

On Mon, Mar 28, 2022 at 02:49:25PM +0200, Erik Skultety wrote: > On Thu, Mar 24, 2022 at 03:10:51PM +, Daniel P. Berrangé wrote: > > On Thu, Mar 24, 2022 at 04:07:36PM +0100, Erik Skultety wrote: > > > So, we successfully enabled functional testing utilizing GitLab's custom > > > executor

Re: [PATCH] Introduce network-backed NVRAM

On Sun, Mar 20, 2022 at 21:28:13 -0700, Rohit Kumar wrote: > Libvirt domain XML allows only local filepaths to specify a NVRAM > element. Since VMs can move across different hosts, it should be > possibe to allocate NVRAM disks on network storage for uninturrupted > access. > > This Patch extends

Re: Request to move my GitLab custom executor repo under the libvirt umbrella

On Thu, Mar 24, 2022 at 03:10:51PM +, Daniel P. Berrangé wrote: > On Thu, Mar 24, 2022 at 04:07:36PM +0100, Erik Skultety wrote: > > So, we successfully enabled functional testing utilizing GitLab's custom > > executor feature. The code responsible for creating template images and > >

Re: [PATCH] virfile: Report error when changing pipe size fails

On 3/28/22 2:22 PM, Daniel P. Berrangé wrote: > On Mon, Mar 28, 2022 at 01:46:08PM +0200, Michal Privoznik wrote: >> When changing the size of pipe that virFileWrapperFdNew() creates >> we start at 1MiB and if that fails because it's above the system >> wide limit we get EPERM and continue with

Re: [PATCH] virfile: Report error when changing pipe size fails

On Mon, Mar 28, 2022 at 01:46:08PM +0200, Michal Privoznik wrote: > When changing the size of pipe that virFileWrapperFdNew() creates > we start at 1MiB and if that fails because it's above the system > wide limit we get EPERM and continue with half of the size. > > However, we might get another

[PATCH 13/29] docs: Convert 'drvvmware' page to rST

Signed-off-by: Peter Krempa --- docs/drvvmware.html.in | 89 -- docs/drvvmware.rst | 72 ++ docs/meson.build | 2 +- 3 files changed, 73 insertions(+), 90 deletions(-) delete mode 100644 docs/drvvmware.html.in

[PATCH 21/29] docs: Convert 'formatstoragecaps' page to rST

Note that if we want to preserve the link from the code block hilighting 'virConnectGetStoragePoolCapabilities' we'd need to re-stylize it as rST doesn't support nesting of links into preformatted code blocks. Signed-off-by: Peter Krempa --- docs/formatstoragecaps.html.in | 95

[PATCH 27/29] docs: Convert 'logging' page to rST

binv5PV5eGPTA.bin Description: Binary data

[PATCH 28/29] docs: logging: Replace example by link to kbase/debuglogs.html

The 'debuglogs' knowledge base page has way more info and examples on how to set logging use it instead of the ad-hoc examples. Signed-off-by: Peter Krempa --- docs/logging.rst | 34 +++--- 1 file changed, 3 insertions(+), 31 deletions(-) diff --git

[PATCH 29/29] docs: Convert 'php' page to rST

bine9wbOqI_1h.bin Description: Binary data

[PATCH 17/29] docs: Convert 'formatcaps' page to rST

Signed-off-by: Peter Krempa --- docs/formatcaps.html.in | 219 docs/formatcaps.rst | 196 +++ docs/meson.build| 2 +- 3 files changed, 197 insertions(+), 220 deletions(-) delete mode 100644

[PATCH 14/29] docs: Convert 'drvxen' page to rST

Fix the referenced anchor in 'formatdomain.rst' right away. Signed-off-by: Peter Krempa --- docs/drvxen.html.in | 358 -- docs/drvxen.rst | 338 +++ docs/formatdomain.rst | 2 +- docs/meson.build | 2 +-

[PATCH 15/29] docs: Convert 'firewall' page to rST

binxFW1x30V5R.bin Description: Binary data

[PATCH 23/29] docs: formatstorageencryption: Drop empty 'default' paragraph

Signed-off-by: Peter Krempa --- docs/formatstorageencryption.rst | 3 --- 1 file changed, 3 deletions(-) diff --git a/docs/formatstorageencryption.rst b/docs/formatstorageencryption.rst index 7b5cccaf5e..1c7227040e 100644 --- a/docs/formatstorageencryption.rst +++

[PATCH 16/29] docs: Convert 'format' page to rST

Signed-off-by: Peter Krempa --- docs/format.html.in | 48 - docs/format.rst | 35 + docs/meson.build| 2 +- 3 files changed, 36 insertions(+), 49 deletions(-) delete mode 100644 docs/format.html.in create mode

[PATCH 22/29] docs: Convert 'formatstorageencryption' page to rST

Signed-off-by: Peter Krempa --- docs/formatstorageencryption.html.in | 181 --- docs/formatstorageencryption.rst | 142 + docs/meson.build | 2 +- 3 files changed, 143 insertions(+), 182 deletions(-) delete mode 100644

[PATCH 20/29] docs: Fix heading of 'formatnetworkport' page

The top level heading didn't contain the word 'port'. Signed-off-by: Peter Krempa --- docs/formatnetworkport.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/formatnetworkport.rst b/docs/formatnetworkport.rst index a85888907d..86a1bdb60b 100644 ---

[PATCH 09/29] docs: Convert 'drvsecret' page to rST

Signed-off-by: Peter Krempa --- docs/drvsecret.html.in | 82 -- docs/drvsecret.rst | 65 + docs/meson.build | 2 +- 3 files changed, 66 insertions(+), 83 deletions(-) delete mode 100644 docs/drvsecret.html.in

[PATCH 26/29] docs: Convert 'java' page to rST

Signed-off-by: Peter Krempa --- docs/java.html.in | 121 --- docs/java.rst | 128 ++ docs/meson.build | 2 +- 3 files changed, 129 insertions(+), 122 deletions(-) delete mode 100644 docs/java.html.in

[PATCH 24/29] docs: formatstorageencryption: Re-style encryption type headers

Use backticks to force monospace font instead of double quotes. Signed-off-by: Peter Krempa --- docs/formatstorageencryption.rst | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/docs/formatstorageencryption.rst b/docs/formatstorageencryption.rst index

[PATCH 25/29] docs: Convert 'hooks' page to rST

binMgIvGrc8Zx.bin Description: Binary data

[PATCH 18/29] docs: Convert 'formatdomaincaps' to rST

Signed-off-by: Peter Krempa --- docs/formatdomain.rst | 20 +- docs/formatdomaincaps.html.in | 693 -- docs/formatdomaincaps.rst | 602 + docs/kbase/backing_chains.rst | 2 +- docs/meson.build | 2 +- 5

[PATCH 19/29] docs: Convert 'formatnetworkport' to rST

Signed-off-by: Peter Krempa --- docs/formatnetworkport.html.in | 223 - docs/formatnetworkport.rst | 175 ++ docs/meson.build | 2 +- 3 files changed, 176 insertions(+), 224 deletions(-) delete mode 100644

[PATCH 11/29] docs: Convert 'drvvbox' page to rST

Signed-off-by: Peter Krempa --- docs/drvvbox.html.in | 172 --- docs/drvvbox.rst | 161 docs/meson.build | 2 +- 3 files changed, 162 insertions(+), 173 deletions(-) delete mode 100644

[PATCH 06/29] docs: Convert 'drvlxc' page to rST

Signed-off-by: Peter Krempa --- docs/drvlxc.html.in | 822 docs/drvlxc.rst | 670 docs/meson.build| 2 +- 3 files changed, 671 insertions(+), 823 deletions(-) delete mode 100644 docs/drvlxc.html.in

[PATCH 12/29] docs: Convert 'drvvirtuozzo' page to rST

Signed-off-by: Peter Krempa --- docs/drvvirtuozzo.html.in | 70 --- docs/drvvirtuozzo.rst | 60 + docs/meson.build | 2 +- 3 files changed, 61 insertions(+), 71 deletions(-) delete mode 100644

[PATCH 10/29] docs: Convert 'drvtest' page to rST

binOeX6ZG7Nnj.bin Description: Binary data

[PATCH 07/29] docs: Convert 'drvnodedev' page to rST

Fix one cross link anchor along with the conversion. Signed-off-by: Peter Krempa --- docs/drvnodedev.html.in | 383 docs/drvnodedev.rst | 348 docs/formatdomain.rst | 3 +- docs/meson.build| 2 +- 4

[PATCH 08/29] docs: Convert 'drvopenvz' page to rST

Signed-off-by: Peter Krempa --- docs/drvopenvz.html.in | 123 - docs/drvopenvz.rst | 97 docs/meson.build | 2 +- 3 files changed, 98 insertions(+), 124 deletions(-) delete mode 100644 docs/drvopenvz.html.in

[PATCH 04/29] docs: Convert 'drvesx' page to rST

Signed-off-by: Peter Krempa --- docs/drvesx.html.in | 838 docs/drvesx.rst | 681 +++ docs/meson.build| 2 +- 3 files changed, 682 insertions(+), 839 deletions(-) delete mode 100644 docs/drvesx.html.in

[PATCH 05/29] docs: Convert 'drvhyperv' page to rST

Signed-off-by: Peter Krempa --- docs/drvhyperv.html.in | 150 - docs/drvhyperv.rst | 121 + docs/meson.build | 2 +- 3 files changed, 122 insertions(+), 151 deletions(-) delete mode 100644 docs/drvhyperv.html.in

[PATCH 02/29] docs: Convert 'cgroups' page to rST

Signed-off-by: Peter Krempa --- docs/cgroups.html.in | 424 --- docs/cgroups.rst | 364 + docs/meson.build | 2 +- 3 files changed, 365 insertions(+), 425 deletions(-) delete mode 100644 docs/cgroups.html.in

[PATCH 03/29] docs: Convert 'drvbhyve' page to rST

Signed-off-by: Peter Krempa --- docs/drvbhyve.html.in | 583 -- docs/drvbhyve.rst | 582 + docs/meson.build | 2 +- 3 files changed, 583 insertions(+), 584 deletions(-) delete mode 100644

[PATCH 01/29] docs: Remove empty unreferenced 'drvremote' page

binXCpM1zbQmX.bin Description: Binary data

[PATCH 00/29] docs: Convert some pages to rST and clean up (part 2)

Peter Krempa (29): docs: Remove empty unreferenced 'drvremote' page docs: Convert 'cgroups' page to rST docs: Convert 'drvbhyve' page to rST docs: Convert 'drvesx' page to rST docs: Convert 'drvhyperv' page to rST docs: Convert 'drvlxc' page to rST docs: Convert 'drvnodedev' page to

Entering freeze for libvirt-8.2.0

I have just tagged v8.2.0-rc1 in the repository and pushed signed tarballs and source RPMs to https://libvirt.org/sources/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make

[PATCH] virfile: Report error when changing pipe size fails

When changing the size of pipe that virFileWrapperFdNew() creates we start at 1MiB and if that fails because it's above the system wide limit we get EPERM and continue with half of the size. However, we might get another error in which case we should report proper system error and return failure

Re: [libvirt RFCv4] virfile: set pipe size in virFileWrapperFdNew to improve throughput

On 3/28/22 13:10, Daniel P. Berrangé wrote: > On Mon, Mar 28, 2022 at 01:06:03PM +0200, Michal Prívozník wrote: >> On 3/25/22 16:10, Claudio Fontana wrote: >>> currently the only user of virFileWrapperFdNew is the qemu driver; >>> virsh save is very slow with a default pipe size. >>> This change

[build-fix PATCH] util: virfile: Fix indentation of preprocessor directives

stderr: cppi: /home/pipo/libvirt/src/util/virfile.c: line 205: not properly indented cppi: /home/pipo/libvirt/src/util/virfile.c: line 243: not properly indented cppi: /home/pipo/libvirt/src/util/virfile.c: line 249: not properly indented build-aux/syntax-check.mk: incorrect preprocessor

Re: [libvirt RFCv4] virfile: set pipe size in virFileWrapperFdNew to improve throughput

On Mon, Mar 28, 2022 at 01:06:03PM +0200, Michal Prívozník wrote: > On 3/25/22 16:10, Claudio Fontana wrote: > > currently the only user of virFileWrapperFdNew is the qemu driver; > > virsh save is very slow with a default pipe size. > > This change improves throughput by ~400% on fast nvme or

Re: [libvirt RFCv4] virfile: set pipe size in virFileWrapperFdNew to improve throughput

On 3/28/22 1:06 PM, Michal Prívozník wrote: > On 3/25/22 16:10, Claudio Fontana wrote: >> currently the only user of virFileWrapperFdNew is the qemu driver; >> virsh save is very slow with a default pipe size. >> This change improves throughput by ~400% on fast nvme or ramdisk. >> >> Best value

Re: [libvirt RFCv4] virfile: set pipe size in virFileWrapperFdNew to improve throughput

On 3/25/22 16:10, Claudio Fontana wrote: > currently the only user of virFileWrapperFdNew is the qemu driver; > virsh save is very slow with a default pipe size. > This change improves throughput by ~400% on fast nvme or ramdisk. > > Best value currently measured is 1MB, which happens to be also

Re: [libvirt RFC] virFile: new VIR_FILE_WRAPPER_BIG_PIPE to improve performance

On 3/26/22 4:49 PM, Claudio Fontana wrote: > On 3/25/22 12:29 PM, Daniel P. Berrangé wrote: >> On Fri, Mar 18, 2022 at 02:34:29PM +0100, Claudio Fontana wrote: >>> On 3/17/22 4:03 PM, Dr. David Alan Gilbert wrote: * Claudio Fontana (cfont...@suse.de) wrote: > On 3/17/22 2:41 PM, Claudio

Re: [PATCH v2 0/6] qemu: Add qemu-namespace XML to override device properties (-set replacement)

On 3/22/22 12:27, Peter Krempa wrote: > v2: > - patch 1/7 from last time was pushed > - XML changes: > - top level element renamed to "qemu:override" to accomodate > possible extension in the future > - wrapped 'qemu:props' meant to override the frontend under a >

Re: [libvirt RFC] virFile: new VIR_FILE_WRAPPER_BIG_PIPE to improve performance

On 3/28/22 11:19 AM, Claudio Fontana wrote: > On 3/28/22 10:31 AM, Daniel P. Berrangé wrote: >> On Sat, Mar 26, 2022 at 04:49:46PM +0100, Claudio Fontana wrote: >>> On 3/25/22 12:29 PM, Daniel P. Berrangé wrote: On Fri, Mar 18, 2022 at 02:34:29PM +0100, Claudio Fontana wrote: > On 3/17/22

Re: [libvirt RFC] virFile: new VIR_FILE_WRAPPER_BIG_PIPE to improve performance

On 3/28/22 10:31 AM, Daniel P. Berrangé wrote: > On Sat, Mar 26, 2022 at 04:49:46PM +0100, Claudio Fontana wrote: >> On 3/25/22 12:29 PM, Daniel P. Berrangé wrote: >>> On Fri, Mar 18, 2022 at 02:34:29PM +0100, Claudio Fontana wrote: On 3/17/22 4:03 PM, Dr. David Alan Gilbert wrote: > *

Re: [libvirt RFC] virFile: new VIR_FILE_WRAPPER_BIG_PIPE to improve performance

On 3/28/22 10:31 AM, Daniel P. Berrangé wrote: > On Sat, Mar 26, 2022 at 04:49:46PM +0100, Claudio Fontana wrote: >> On 3/25/22 12:29 PM, Daniel P. Berrangé wrote: >>> On Fri, Mar 18, 2022 at 02:34:29PM +0100, Claudio Fontana wrote: On 3/17/22 4:03 PM, Dr. David Alan Gilbert wrote: > *

Re: [PATCH] Introduce network-backed NVRAM

Ping. Hi, please review this patch. Thanks ! On 21/03/22 9:58 am, Rohit Kumar wrote: Libvirt domain XML allows only local filepaths to specify a NVRAM element. Since VMs can move across different hosts, it should be possibe to allocate NVRAM disks on network storage for uninturrupted access.

Re: [libvirt RFC] virFile: new VIR_FILE_WRAPPER_BIG_PIPE to improve performance

On Sat, Mar 26, 2022 at 04:49:46PM +0100, Claudio Fontana wrote: > On 3/25/22 12:29 PM, Daniel P. Berrangé wrote: > > On Fri, Mar 18, 2022 at 02:34:29PM +0100, Claudio Fontana wrote: > >> On 3/17/22 4:03 PM, Dr. David Alan Gilbert wrote: > >>> * Claudio Fontana (cfont...@suse.de) wrote: > On

Re: [PATCH 0/2] Revert two patches I've pushed mistakenly

On Mon, Mar 28, 2022 at 09:31:46 +0200, Michal Privoznik wrote: > Firstly, QEMU part is not merged which alone should have prevented me > from pushing these patches. > > Secondly, in the end QEMU is fixing the bug in a different manner that > does not require any libvirt work. > >

Re: [PATCH v2 1/7] qemu_tpm: Do async IO when starting swtpm emulator

On Tue, Mar 22, 2022 at 17:02:00 +0100, Michal Privoznik wrote: > When vTPM is secured via virSecret libvirt passes the secret > value via an FD when swtpm is started (arguments --key and > --migration-key). The writing of the secret into the FDs is > handled via virCommand, specifically qemu_tpm

Re: [PATCH 0/2] domain, qemu: add support for clearing TSC on reset

On 3/25/22 17:49, Paolo Bonzini wrote: > On 3/25/22 16:35, Michal Prívozník wrote: >> I'm fixing all the small issues I've raised in review and pushing these. >> >> Reviewed-by: Michal Privoznik > > No, please don't!  The property is not yet part of QEMU, this should > have been tagged RFC. > >

[PATCH 2/2] Revert "qemu: add support for tsc.on_reboot element"

This reverts commit 06c960e477de4561c7ba956f82994fa120226397. Turns out, this feature is not needed and QEMU will fix TSC without any intervention from outside. Signed-off-by: Michal Privoznik --- src/qemu/qemu_capabilities.c | 2 - src/qemu/qemu_capabilities.h

[PATCH 0/2] Revert two patches I've pushed mistakenly

Firstly, QEMU part is not merged which alone should have prevented me from pushing these patches. Secondly, in the end QEMU is fixing the bug in a different manner that does not require any libvirt work. https://lists.gnu.org/archive/html/qemu-devel/2022-03/msg06077.html

[PATCH 1/2] Revert "domain: add tsc.on_reboot element"

This reverts commit 150540394ddaa515f6857616a2bcf792748f162c. Turns out, this feature is not needed and QEMU will fix TSC without any intervention from outside. Signed-off-by: Michal Privoznik --- docs/formatdomain.rst | 4 src/conf/domain_conf.c| 17

Re: libvirt: introduce VIR_DOMAIN_DESTROY_REMOVE_LOGS flag

пн, 28 февр. 2022 г. в 14:13, Nikolay Shirokovskiy : > > Hi, all! > > What do you think? Hi, please take a look at this series. Nikolay > > пн, 14 февр. 2022 г. в 15:19, Nikolay Shirokovskiy > : >> >> The patch series based on discussion in RFC [1]. >> >> I wonder if we'd better add some