Re: [libvirt PATCH 00/10] Cleanup and test more firmware handling scenarios

2022-04-04 Thread Cole Robinson
On 2/16/22 8:17 AM, Michal Prívozník wrote: > On 2/15/22 19:54, Daniel P. Berrangé wrote: >> There are a mind bending number of possible ways to configure the >> firmware with/without NVRAM. Only a small portion are tested and >> many error scenarios are silently ignored. >> >> This series

[PATCH] tests: Fixing compiler warning in cputest

2022-04-04 Thread Boris Fiuczynski
Found when building on Fedora 36 on s390x. C compiler for the host machine: gcc (gcc 12.0.1 "gcc (GCC) 12.0.1 20220308 (Red Hat 12.0.1-0)") C linker for the host machine: gcc ld.bfd 2.37-24 In function ‘cpuTestUpdateLiveCompare’, inlined from ‘cpuTestUpdateLive’ at

Re: [PATCH 08/17] qemu: Formally deprecate support for qemu < 3.1

2022-04-04 Thread Andrea Bolognani
On Mon, Apr 04, 2022 at 10:35:25AM +0200, Peter Krempa wrote: > As of April 23 2022, Ubuntu 20.04 will be out for two years, which means > we no longer have to support Ubuntu 18.04 along with qemu-2.11 shipped > with it. > > This then brings the minimum qemu version we have to support to >

[PATCH 7/7] docs: convert 'csharp' page to rst

2022-04-04 Thread Peter Krempa
Signed-off-by: Peter Krempa --- docs/csharp.html.in | 52 - docs/csharp.rst | 38 + docs/meson.build| 2 +- 3 files changed, 39 insertions(+), 53 deletions(-) delete mode 100644 docs/csharp.html.in create mode

[PATCH 6/7] docs: csharp: Remove project-specific information

2022-04-04 Thread Peter Krempa
The enumeration of functions and types supported by the bindings was moved to the 'README.rst' file in the 'libvirt-csharp' repo: https://gitlab.com/libvirt/libvirt-csharp/-/merge_requests/8 Remove the corresponding bits from the main repository. Signed-off-by: Peter Krempa ---

[PATCH 4/7] docs: Move 'tlscerts' page to 'kbase/'

2022-04-04 Thread Peter Krempa
Signed-off-by: Peter Krempa --- docs/daemons.rst | 2 +- docs/docs.html.in | 3 --- docs/kbase/index.rst | 3 +++ docs/kbase/meson.build| 1 + docs/{ => kbase}/tlscerts.rst | 0 docs/meson.build | 1 - docs/remote.html.in | 2 +- 7

[PATCH 5/7] docs: convert 'windows' page to rst

2022-04-04 Thread Peter Krempa
binhNOpweyhQL.bin Description: Binary data

[PATCH 2/7] docs: convert 'python' page to rst

2022-04-04 Thread Peter Krempa
binypo8aNEZOm.bin Description: Binary data

[PATCH 3/7] docs: convert 'tlscerts' page to rst

2022-04-04 Thread Peter Krempa
binduh9D69oc0.bin Description: Binary data

[PATCH 1/7] docs: convert 'dbus' page to rst

2022-04-04 Thread Peter Krempa
binWwbpRSLpTr.bin Description: Binary data

[PATCH 0/7] docs: Convert some pages to rST and clean up (part 3)

2022-04-04 Thread Peter Krempa
This iteration has some patches from Pavel who also converted the pages to RST but didn't send it out yet. Included are those that didn't diverge yet. Additionally since I've moved the descriptions of types used in the C# bindings to the libvirt-csharp repo this series also cleans out the

Re: [RFC PATCH v1 0/5] Add virDomainGetSevAttestationReport API

2022-04-04 Thread Tyler Fanelli
Just a quick ping so this patchset doesn't get lost in the list -- may I receive a review on this? On 3/23/22 3:36 PM, Tyler Fanelli wrote: This an RFC discussing a new API, virDomainGetSevAttestationReport (along with a virsh command "domgetsevreport"), with initial QEMU support via the

[PATCH] lib: Use virReportSystemError() more

2022-04-04 Thread Michal Privoznik
Instead of reporting virReportError(..., g_strerror(), ...) let's use proper virReportSystemError(). Generated with help of cocci: @@ expression c; @@ <... - virReportError(c, + virReportSystemError(errno, ..., -

Re: [PATCH 0/3] virsh: Add some completers

2022-04-04 Thread Michal Prívozník
On 4/2/22 12:31, Amneesh Singh wrote: > Add some basic completers > > Amneesh Singh (3): > virsh: Provide completer for virtualization types > virsh: Provide completer for CPU architectures > virsh: Provide completer for PCI backend drivers > > src/util/virarch.c | 2 +- >

Re: [PATCH 1/3] virsh: Provide completer for virtualization types

2022-04-04 Thread Michal Prívozník
On 4/2/22 12:31, Amneesh Singh wrote: > Related: https://gitlab.com/libvirt/libvirt/-/issues/9 > Signed-off-by: Amneesh Singh > --- > tools/virsh-completer-host.c | 12 > tools/virsh-completer-host.h | 5 + > tools/virsh-host.c | 4 > 3 files changed, 21

Re: [PATCH 2/3] virsh: Provide completer for CPU architectures

2022-04-04 Thread Michal Prívozník
On 4/2/22 12:31, Amneesh Singh wrote: > Related: https://gitlab.com/libvirt/libvirt/-/issues/9 > Signed-off-by: Amneesh Singh > --- > src/util/virarch.c | 2 +- > src/util/virarch.h | 2 +- > tools/virsh-completer-host.c | 12 > tools/virsh-completer-host.h |

Re: [PATCH 3/3] virsh: Provide completer for PCI backend drivers

2022-04-04 Thread Michal Prívozník
On 4/2/22 12:31, Amneesh Singh wrote: > Related: https://gitlab.com/libvirt/libvirt/-/issues/9 > Signed-off-by: Amneesh Singh > --- > tools/virsh-completer-nodedev.c | 11 +++ > tools/virsh-completer-nodedev.h | 4 > tools/virsh-nodedev.c | 2 ++ > 3 files changed, 17

Re: [PATCH 00/17] qemu: Stop supporting Ubuntu 1804-ancient qemus

2022-04-04 Thread Ján Tomko
On a Monday in 2022, Peter Krempa wrote: (this is a rebase of the previous posting since there were conflicts in some of new capability tests as this series is removing some capability flags) As of April 23 2022, (thus during this release cycle) Ubuntu 20.04 will be out for two years, which per

Re: [libvirt PATCH 1/4] tools: snapshot: remove pointless checks

2022-04-04 Thread Andrea Bolognani
On Fri, Apr 01, 2022 at 03:27:33PM +0200, Ján Tomko wrote: > There's no need to check whether a flag is not set just to set it > in that case. > > Signed-off-by: Ján Tomko > --- > tools/virsh-snapshot.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) For this patch and this patch

[PATCH 00/17] qemu: Stop supporting Ubuntu 1804-ancient qemus

2022-04-04 Thread Peter Krempa
(this is a rebase of the previous posting since there were conflicts in some of new capability tests as this series is removing some capability flags) As of April 23 2022, (thus during this release cycle) Ubuntu 20.04 will be out for two years, which per our platform support policy means we no

[PATCH 12/17] qemu: capabilities: Retire QEMU_CAPS_CHARDEV_FD_PASS_COMMANDLINE

2022-04-04 Thread Peter Krempa
Signed-off-by: Peter Krempa --- src/qemu/qemu_capabilities.c | 3 +-- src/qemu/qemu_capabilities.h | 2 +- tests/qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 1 - tests/qemucapabilitiesdata/caps_3.1.0.x86_64.xml | 1 -

[PATCH 16/17] qemu: Always assume QEMU_CAPS_STORAGE_WERROR

2022-04-04 Thread Peter Krempa
All supported QEMUs now accept werror/rerror as argument for the frontend disk device, so we can remove the old code. Signed-off-by: Peter Krempa --- src/qemu/qemu_command.c | 34 +++--- src/qemu/qemu_command.h | 3 +-- src/qemu/qemu_hotplug.c | 3 +-- 3 files

[PATCH 17/17] qemu: capabilities: Retire QEMU_CAPS_STORAGE_WERROR and QEMU_CAPS_USB_STORAGE_WERROR

2022-04-04 Thread Peter Krempa
Signed-off-by: Peter Krempa --- src/qemu/qemu_capabilities.c | 12 ++-- src/qemu/qemu_capabilities.h | 4 ++-- tests/qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 2 -- tests/qemucapabilitiesdata/caps_3.1.0.x86_64.xml | 2 --

[PATCH 15/17] qemu: capabilities: Retire QEMU_CAPS_OVERCOMMIT

2022-04-04 Thread Peter Krempa
Signed-off-by: Peter Krempa --- src/qemu/qemu_capabilities.c | 3 +-- src/qemu/qemu_capabilities.h | 2 +- tests/qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 1 - tests/qemucapabilitiesdata/caps_3.1.0.x86_64.xml | 1 -

[PATCH 13/17] qemu: capabilities: Retire QEMU_CAPS_QUERY_CPU_MODEL_EXPANSION_MIGRATABLE

2022-04-04 Thread Peter Krempa
The flag was based on a version check which no longer made sense. Remove the flag by replacing it's only use by an arch-check which is equivalent at this point. Signed-off-by: Peter Krempa --- src/qemu/qemu_capabilities.c | 10 ++ src/qemu/qemu_capabilities.h

[PATCH 09/17] qemu: capabilities: Remove tautological version checks

2022-04-04 Thread Peter Krempa
Some version checks no longer make sense as the minimum supported qemu is now qemu-3.1. Signed-off-by: Peter Krempa --- src/qemu/qemu_capabilities.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index

[PATCH 08/17] qemu: Formally deprecate support for qemu < 3.1

2022-04-04 Thread Peter Krempa
As of April 23 2022, Ubuntu 20.04 will be out for two years, which means we no longer have to support Ubuntu 18.04 along with qemu-2.11 shipped with it. This then brings the minimum qemu version we have to support to qemu-3.1: Debian 10/Stable: 3.1 OpenSUSE Leap 15.3: 5.2 Ubuntu

[PATCH 10/17] qemu: capabilities: Remove probing of QEMU_CAPS_NUMA via 'query-command-line-options'

2022-04-04 Thread Peter Krempa
For modern qemu versions we use the presence of 'set-numa-node' qmp command. Signed-off-by: Peter Krempa --- src/qemu/qemu_capabilities.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 44f3205693..3750d27d3c 100644 ---

[PATCH 07/17] tests: qemucapabilities: Remove qemu-3.0 test data

2022-04-04 Thread Peter Krempa
Upcoming patches will raise the minimum required qemu version to 3.1. Signed-off-by: Peter Krempa --- .../caps_3.0.0.ppc64.replies | 23945 .../qemucapabilitiesdata/caps_3.0.0.ppc64.xml | 1073 - .../caps_3.0.0.riscv32.replies| 14919 --

[PATCH 06/17] tests: qemucapabilities: Remove qemu-2.12 test data

2022-04-04 Thread Peter Krempa
Upcoming patches will raise the minimum required qemu version to 3.1. Signed-off-by: Peter Krempa --- .../caps_2.12.0.aarch64.replies | 19577 - .../caps_2.12.0.aarch64.xml | 329 - .../caps_2.12.0.ppc64.replies | 23072

[PATCH 05/17] tests: qemucapabilities: Remove qemu-2.11 test data

2022-04-04 Thread Peter Krempa
Upcoming patches will raise the minimum required qemu version to 3.1. Signed-off-by: Peter Krempa --- .../caps_2.11.0.s390x.replies | 18237 --- .../caps_2.11.0.s390x.xml | 2593 -- .../caps_2.11.0.x86_64.replies| 19525

[PATCH 04/17] qemuxml2agvtest: Retire tests based on qemu-3.0

2022-04-04 Thread Peter Krempa
Upcoming patches will raise the minimum required qemu version to 3.1. Signed-off-by: Peter Krempa --- .../cpu-host-model.x86_64-3.0.0.args | 36 --- .../mlock-off.x86_64-3.0.0.args | 31 .../mlock-on.x86_64-3.0.0.args| 31

[PATCH 03/17] qemuxml2agvtest: Retire tests based on qemu-2.12

2022-04-04 Thread Peter Krempa
Upcoming patches will raise the minimum required qemu version to 3.1. Signed-off-by: Peter Krempa --- .../cpu-host-model.x86_64-2.12.0.args | 36 -- .../disk-error-policy-s390x.s390x-2.12.0.args | 35 -- .../disk-error-policy.x86_64-2.12.0.args | 37

[PATCH 02/17] qemuxml2agvtest: Retire tests based on qemu-2.11

2022-04-04 Thread Peter Krempa
Upcoming patches will raise the minimum required qemu version to 3.1. Signed-off-by: Peter Krempa --- .../cpu-host-model.x86_64-2.11.0.args | 36 -- ...ics-vnc-auto-socket-cfg.x86_64-2.11.0.args | 34 - ...raphics-vnc-auto-socket.x86_64-2.11.0.args | 32

[PATCH 01/17] ci: Drop Ubuntu 1804

2022-04-04 Thread Peter Krempa
As of April 23 2022, Ubuntu 20.04 will be out for two years, which per our platform support policy means we no longer have to support Ubuntu 18.04. Signed-off-by: Peter Krempa --- ci/containers/ubuntu-1804.Dockerfile | 108 --- ci/gitlab.yml| 16

Re: [libvirt PATCH v4 14/16] qemu: Generate command line for virtio-iommu

2022-04-04 Thread Ján Tomko
On a Friday in 2022, Andrea Bolognani wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1653327 Signed-off-by: Andrea Bolognani --- src/qemu/qemu_command.c | 12 .../virtio-iommu-aarch64.aarch64-latest.args | 1 +

Re: [PATCH] qemu: capabilities: Remove check for /usr/libexec/qemu-kvm

2022-04-04 Thread Andrea Bolognani
On Fri, Apr 01, 2022 at 03:52:34PM -0600, Jim Fehlig wrote: > On 3/30/22 10:59, Andrea Bolognani wrote: > > I agree that the message being logged is not very useful, but I don't > > think the approach you take here is the correct one: we want upstream > > libvirt to work out of the box when built