Re: [PATCH v1 4/4] scripts: apibuild: add 'version' to variables

2022-04-05 Thread Victor Toso
Hi, On Tue, Apr 05, 2022 at 04:33:27PM +, Andrea Bolognani wrote: > On Tue, Apr 05, 2022 at 01:43:23PM +0200, Victor Toso wrote: > > Differently from the previous patches, we don't parse nor export > > comments associated with variables. This isn't a big deal because we > > only export a

Re: [PATCH v1 0/4] Add 'version' to other exported types

2022-04-05 Thread Victor Toso
Hi, On Tue, Apr 05, 2022 at 05:01:54PM +, Andrea Bolognani wrote: > On Tue, Apr 05, 2022 at 04:52:10PM +0200, Michal Prívozník wrote: > > On 4/5/22 13:43, Victor Toso wrote: > > > As headers are already a great source of documentation for developers, > > > I'm suggesting to add a specific

Re: [PATCH v1 0/4] Add 'version' to other exported types

2022-04-05 Thread Andrea Bolognani
On Tue, Apr 05, 2022 at 04:52:10PM +0200, Michal Prívozník wrote: > On 4/5/22 13:43, Victor Toso wrote: > > As headers are already a great source of documentation for developers, > > I'm suggesting to add a specific comment to each of this exported types: > > > > /* ... Since */ > > > > For

Re: [PATCH v1 4/4] scripts: apibuild: add 'version' to variables

2022-04-05 Thread Andrea Bolognani
On Tue, Apr 05, 2022 at 01:43:23PM +0200, Victor Toso wrote: > Differently from the previous patches, we don't parse nor export > comments associated with variables. This isn't a big deal because we > only export a single variable: virConnectAuthPtrDefault > > Nonetheless, add version field to the

Re: [PATCH v1 2/4] scripts: apibuild: parse 'Since' for typedefs

2022-04-05 Thread Andrea Bolognani
On Tue, Apr 05, 2022 at 05:36:51PM +0200, Victor Toso wrote: > On Tue, Apr 05, 2022 at 04:52:09PM +0200, Michal Prívozník wrote: > > On 4/5/22 13:43, Victor Toso wrote: > > > This patch adds 'version' parameter to the generated XML API for > > > typedefs > > > > > > It'll require, for new

Re: [PATCH] virsh: Remove any reference of KVM device assignment

2022-04-05 Thread Andrea Bolognani
On Tue, Apr 05, 2022 at 10:42:03AM +0200, Michal Privoznik wrote: > The KVM device assignment was removed in v5.7.0-rc1~103 but virsh > and its manpage still mention it. Don't do that. > > Signed-off-by: Michal Privoznik > --- > docs/manpages/virsh.rst | 7 +++ > tools/virsh-nodedev.c | 2

Re: [PATCH v1 2/4] scripts: apibuild: parse 'Since' for typedefs

2022-04-05 Thread Victor Toso
Hi, On Tue, Apr 05, 2022 at 04:52:09PM +0200, Michal Prívozník wrote: > On 4/5/22 13:43, Victor Toso wrote: > > This patch adds 'version' parameter to the generated XML API for > > typedefs > > > > It'll require, for new additions, to add a comment with the version > > that the typedef value was

Re: [PATCH v1 0/4] Add 'version' to other exported types

2022-04-05 Thread Victor Toso
Hi, On Tue, Apr 05, 2022 at 04:52:10PM +0200, Michal Prívozník wrote: > On 4/5/22 13:43, Victor Toso wrote: > > Hi, > > > > This series is an extension of what Daniel did in e0e0bf6628 "scripts: > > include function versions in API definition". > > > > The main motivation behind this is to help

Re: [PATCH v1 2/4] scripts: apibuild: parse 'Since' for typedefs

2022-04-05 Thread Michal Prívozník
On 4/5/22 13:43, Victor Toso wrote: > This patch adds 'version' parameter to the generated XML API for > typedefs > > It'll require, for new additions, to add a comment with the version > that the typedef value was added. An example bellow of code diff and > the change in the generated XML. > >

Re: [PATCH v1 0/4] Add 'version' to other exported types

2022-04-05 Thread Michal Prívozník
On 4/5/22 13:43, Victor Toso wrote: > Hi, > > This series is an extension of what Daniel did in e0e0bf6628 "scripts: > include function versions in API definition". > > The main motivation behind this is to help code generators to consider > if a given symbol is present in a given version of

Re: [PATCH v2 1/4] domain_conf: Added configs for RSS and Hash report.

2022-04-05 Thread Michal Prívozník
On 1/9/22 22:07, Andrew Melnychenko wrote: > Added "rss" and "rss_hash_report" configuration that should be used with > qemu virtio RSS. > Both options are triswitches. Used as "driver" options and affects only NIC > with model type "virtio". > In other patches - options should turn on virtio-net

Re: [PATCH v2 4/4] test: Added xml2argv and xml2xml tests.

2022-04-05 Thread Michal Prívozník
On 1/9/22 22:07, Andrew Melnychenko wrote: > Added rss, hash and rss+hash xml2argv tests. > virtio-options tests was used for xml2xml test. > > Signed-off-by: Andrew Melnychenko > --- > .../net-virtio-rss.x86_64-latest.args | 43 +++ >

Re: [PATCH v2 0/4] VirtioNet RSS support.

2022-04-05 Thread Michal Prívozník
On 1/9/22 22:07, Andrew Melnychenko wrote: > This series of patches add RSS property support for virtio-net-pci. > > Virtio RSS effectively works with TAP devices, it requires additional > vectors for VirtioNet, queues for TAP device, and vCPU cores. > Example of device configuration: > ``` > >

[PATCH RESEND] qemu: disarm fake reboot flag on reset

2022-04-05 Thread Nikolay Shirokovskiy
From: Maxim Nestratov This is a quite an old (created at 2016) patch fixing an issue for at that time contemporary Fedora 23. virsh reboot returns success (yet after hanging for a while), VM is rebooted sucessfully too but then shutdown from inside guest causes reboot and not shutdown. VM has

[PATCH] qemu: disarm fake reboot flag on reset

2022-04-05 Thread Nikolay Shirokovskiy
binA9h7J9RSaP.bin Description: Binary data

[PATCH v1 2/4] scripts: apibuild: parse 'Since' for typedefs

2022-04-05 Thread Victor Toso
This patch adds 'version' parameter to the generated XML API for typedefs It'll require, for new additions, to add a comment with the version that the typedef value was added. An example bellow of code diff and the change in the generated XML. Note that the Since tag is removed from the comment

[PATCH v1 4/4] scripts: apibuild: add 'version' to variables

2022-04-05 Thread Victor Toso
Differently from the previous patches, we don't parse nor export comments associated with variables. This isn't a big deal because we only export a single variable: virConnectAuthPtrDefault Nonetheless, add version field to the exported XML by checking the allowlist file. This way, if we add

[PATCH v1 3/4] scripts: apibuild: parse 'Since' for macros

2022-04-05 Thread Victor Toso
This patch adds 'version' parameter to the generated XML API for macros It'll require, for new additions, to add a comment with the version that the macro was added. An example bellow of code diff and the change in the generated XML. Note that the Since tag is removed from the comment as there

[PATCH v1 0/4] Add 'version' to other exported types

2022-04-05 Thread Victor Toso
Hi, This series is an extension of what Daniel did in e0e0bf6628 "scripts: include function versions in API definition". The main motivation behind this is to help code generators to consider if a given symbol is present in a given version of libvirt that they are either running/building

[PATCH v1 1/4] scripts: apibuild: parse 'Since' version for enums

2022-04-05 Thread Victor Toso
This patch adds 'version' parameter to the generated XML API for enums. It'll require, for new additions, to add a comment with the version that the enum value was added. An example bellow of code diff and the change in the generated XML. Note that the Since tag is removed from the comment as

Re: libvirt: introduce VIR_DOMAIN_DESTROY_REMOVE_LOGS flag

2022-04-05 Thread Michal Prívozník
On 2/14/22 13:19, Nikolay Shirokovskiy wrote: > The patch series based on discussion in RFC [1]. > > I wonder if we'd better add some property like "transient logs" instead > of adding a flag to destoy API. > > Yes libguestfs uses virDomainDestroyFlags to terminate a VM and it is > intended

Re: [PATCH 01/17] ci: Drop Ubuntu 1804

2022-04-05 Thread Michal Prívozník
On 3/2/22 10:48, Daniel P. Berrangé wrote: > On Wed, Mar 02, 2022 at 09:12:55AM +0100, Peter Krempa wrote: >> On Tue, Mar 01, 2022 at 17:46:44 +0100, Erik Skultety wrote: >>> On Tue, Feb 15, 2022 at 02:47:44PM +0100, Peter Krempa wrote: As of April 23 2022, Ubuntu 20.04 will be out for two

Re: [libvirt RFC] virFile: new VIR_FILE_WRAPPER_BIG_PIPE to improve performance

2022-04-05 Thread Claudio Fontana
On 4/5/22 10:35 AM, Dr. David Alan Gilbert wrote: > * Claudio Fontana (cfont...@suse.de) wrote: >> On 3/28/22 10:31 AM, Daniel P. Berrangé wrote: >>> On Sat, Mar 26, 2022 at 04:49:46PM +0100, Claudio Fontana wrote: On 3/25/22 12:29 PM, Daniel P. Berrangé wrote: > On Fri, Mar 18, 2022 at

Re: [PATCH 0/9] Fixes and improvements around virXMLPropTristate*()

2022-04-05 Thread Michal Prívozník
On 3/25/22 17:26, Andrea Bolognani wrote: > I have manually audited all commits that have converted existing > code to use the new helpers (full list below) and have convinced > myself that allowReboot is indeed the only one that requires > special handling. > > Changes from [RFC]: > > *

Re: [libvirt PATCH 00/10] Automatic mutex management - part 5

2022-04-05 Thread Michal Prívozník
On 3/25/22 16:02, Tim Wiederhake wrote: > Use the recently implemented VIR_LOCK_GUARD and VIR_WITH_MUTEX_LOCK_GUARD > to simplify mutex management. > > Tim Wiederhake (10): > virnetdaemon: Use automatic mutex management > bridge_driver: Use automatic mutex management > node_device_driver:

Re: [libvirt PATCH 08/10] datatypes: Use automatic mutex management

2022-04-05 Thread Michal Prívozník
On 3/25/22 16:02, Tim Wiederhake wrote: > Signed-off-by: Tim Wiederhake > --- > src/datatypes.c | 63 +++-- > 1 file changed, 19 insertions(+), 44 deletions(-) > > diff --git a/src/datatypes.c b/src/datatypes.c > index aa614612f9..da8a9970f1 100644 >

[PATCH] virsh: Remove any reference of KVM device assignment

2022-04-05 Thread Michal Privoznik
The KVM device assignment was removed in v5.7.0-rc1~103 but virsh and its manpage still mention it. Don't do that. Signed-off-by: Michal Privoznik --- docs/manpages/virsh.rst | 7 +++ tools/virsh-nodedev.c | 2 +- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git

Re: [libvirt RFC] virFile: new VIR_FILE_WRAPPER_BIG_PIPE to improve performance

2022-04-05 Thread Dr. David Alan Gilbert
* Claudio Fontana (cfont...@suse.de) wrote: > On 3/28/22 10:31 AM, Daniel P. Berrangé wrote: > > On Sat, Mar 26, 2022 at 04:49:46PM +0100, Claudio Fontana wrote: > >> On 3/25/22 12:29 PM, Daniel P. Berrangé wrote: > >>> On Fri, Mar 18, 2022 at 02:34:29PM +0100, Claudio Fontana wrote: > On

Re: [PATCH] tests: Fixing compiler warning in cputest

2022-04-05 Thread Michal Prívozník
On 4/4/22 20:22, Boris Fiuczynski wrote: > Found when building on Fedora 36 on s390x. > > C compiler for the host machine: gcc (gcc 12.0.1 "gcc (GCC) 12.0.1 20220308 > (Red Hat 12.0.1-0)") > C linker for the host machine: gcc ld.bfd 2.37-24 > > In function ‘cpuTestUpdateLiveCompare’, >

Re: [PATCH 08/17] qemu: Formally deprecate support for qemu < 3.1

2022-04-05 Thread Peter Krempa
On Mon, Apr 04, 2022 at 08:35:55 -0700, Andrea Bolognani wrote: > On Mon, Apr 04, 2022 at 10:35:25AM +0200, Peter Krempa wrote: > > As of April 23 2022, Ubuntu 20.04 will be out for two years, which means > > we no longer have to support Ubuntu 18.04 along with qemu-2.11 shipped > > with it. > > >